- 28 Nov, 2019 40 commits
-
-
Sebastien Marchand authored
This CL removes the |SiteCharacteristicsDataReader| object from the SessionRestorePolicy::TabData struct. The goal is to make it easier to switch to the Graph owned local DB once it's ready. The |used_in_bg| bit is still set asynchronously and we need a way to cancel the initialization callback when it goes out of scope. It used to be done indirectly by releasing the SiteCharacteristicsDataReader but it now has to be explicit, this is achieved by a adding a CancelableOnceClosure member to SessionRestore::TabData. This callback will also be useful once we have the PM based version of the LocalDB. Bug: 961336 Change-Id: I443277dc711f2c22558fd76ec328b3623777b0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927168 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#720049}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4a8d66b9713e..3188d6f8a991 Created with: gclient setdep -r src-internal@3188d6f8a991 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:none Tbr: jbudorick@google.com Change-Id: I7ae1ebc821a31cbbd2d24a773033b24804d450e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942717Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720048}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4cea2aef55dc..389749ae554d git log 4cea2aef55dc..389749ae554d --date=short --first-parent --format='%ad %ae %s' 2019-11-28 jmadill@chromium.org Fix ICD generation (again). Created with: gclient setdep -r src/third_party/swiftshader@389749ae554d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I7ca43ba10f96bd9220311640c5f188497030d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720047}
-
kylechar authored
1. Fix class header ordering violations. 2. Use empty callbacks instead of optional callbacks. 3. Pass callbacks by value when transferring ownership. 4. Fix NOTIMPLEMENTED() for SkiaOutputSurfaceImplOngpu swap buffers and presentation feedback. This is handled elsewhere already. Bug: none Change-Id: Iedd18969fb674d48713ef406029e942b7afd947c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942969Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#720046}
-
David Bokan authored
This test no longer exists in the codebase so removing its expectations. TBR=nzolghadr@chromium.org Bug: 940829 Change-Id: I255cb97f630641f739c6f7a86ba21ca877f2abb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943051Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720045}
-
Sahel Sharify authored
This cl enables reading shipping and contact info delegation for JIT installation of payment apps on Android. Bug: 984694 Change-Id: I722ca93c462acc623f0f3e9fb8d2f787f8b69c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941193Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720044}
-
Armando Miraglia authored
Since onion souping, the event logs generated for peer connection were translated from std::string to WTF::String. However, the data being stored is binary and WTF::String attempts to appropriately format the string, resulting in corrupted binary data. This CL changes back WTF::String to std::string where possible and converts the binary data into a vector<uint8> to be sent via Mojo. This way the data is correctly stored in the output file. This is the first of 3 steps that will convert the data from string to vector<uint8>, which is more suitable for representing binary data. The next step will be to convert the data representation to vectors in the renderer code and the last in the browser code. Fixed: 1028536 Change-Id: If470069c45da24e298e9a4ceab926b8d7c08d05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942652Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#720043}
-
Kevin Ellis authored
Play controls recently broke for composited animations due to timing differences on when variables are changes. Per spec, the start time is not cleared when pausing an animation until after the animation is ready. This discrepancy lead to a case when PreCommit would not get called when pausing a composited animation. Reverse and updatePlaybackRate were also broken for composited animations. We cannot composite infinite duration animations in the reverse direction. We were using playback rate instead of EffectivePlaybackRate in one of our checks for compositor eligibility, and falling to catch this case. Finally, with changes to when start time is cleared, we can be in a case where it is important to preserve the start time or the current time when starting a composited animation. Fortunately, we can determine when start time is the important factor based in whether the animation is pending. Next step: Add WPT tests that would have caught the regressions. Filed as issue 1029123. Bug: 1028985, 1028986 Change-Id: I4edf851790a860d20962df84944558e7dbc1863a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940885 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#720042}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bc42a63a70fc..5e2f45a379a7 git log bc42a63a70fc..5e2f45a379a7 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 tvanderlippe@chromium.org Add script to remove unused globals Created with: gclient setdep -r src/third_party/devtools-frontend/src@5e2f45a379a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I46e1643432daea567743c5a9c7fd6bf1383d1162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942711Reviewed-by:
-
Yi Xu authored
Tracking transform/clip/fliter for non-drawing ops with PaintTrackingCanvas doesn't change how canvas is rasterred. Removing the implementation of PaintTrackingCanvas. Bug: 1014246 Change-Id: I3d57c3511b05151fac6b3b2821d9fb74c13675ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902272Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#720040}
-
Sean Gilhuly authored
This reverts commit baefa2e4. Reason for revert: Fixed the failing tests. In my refactor I removed a check to gpu_feature_info_.IsInitialized(), which would cause an issue during fallback if the gpu info was not ready yet. Original change's description: > Revert "Replace GPU Compositing feature with GL" > > This reverts commit 8834f5a3. > > Reason for revert: Likely culprit for consistent failure on Linux FYI Debug (NVIDIA): both GpuProcess_swiftshader_for_webgl and GpuProcess_feature_status_under_swiftshader fail DCHECK(gpu_feature_info_.IsInitialized()) > > Original change's description: > > Replace GPU Compositing feature with GL > > > > GPU compositing is never specifically blacklisted in > > software_rendering_list.json, only when all are disabled, so remove it, > > and add GPU_FEATURE_TYPE_GL. Use this as a proxy for GPU compositing for > > now. This will need to be fixed to support the case where GL is > > blacklisted, but Vulkan is still enabled. > > > > Bug: 1005383 > > Change-Id: I0330021cfa59c6c4cf2719785f7931e53ec50f80 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917753 > > Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Reviewed-by: kylechar <kylechar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#719399} > > TBR=zmo@chromium.org,kylechar@chromium.org,sgilhuly@chromium.org > > Change-Id: I65f801a3d790f864367101cbaabc7991308ffe03 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1005383 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940172 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719608} Change-Id: I0247a230dc074a7425bcd2cbfd25d1fb41322db1 Bug: 1005383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940884Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#720039}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6b3c2f71351..11c25d274307 git log e6b3c2f71351..11c25d274307 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 primiano@google.com Merge "Protozero decoder: skip large fields, don't abort parsing" Created with: gclient setdep -r src/third_party/perfetto@11c25d274307 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I24c24a508d31a8fd23f68ff5dcf1d8a896c93266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942710Reviewed-by:
-
chrome://managementDemetrios Papadopoulos authored
Bug: 1029308 Change-Id: I4c49b64fcb51a9d3915c7bc1b18012e769b67194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942970 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#720037}
-
W. James MacLean authored
This CL kicks off the removal of BrowserPlugin. It removes the final browser-plugin related flag (kMimeHandlerViewInCrossProcessFrame) and all conditional code that depends on it. It also removes tests that are specific to BrowserPlugin, or have a parameterization that runs on BrowserPlugin. WebPluginContainerTest.IFramePluginDocumentDisplayNone has been deleted since it relies on PDFs using PluginDocument (which it no longer does), but the desired behaviour (namely PDF content loads even with display: none) is covered by ChromeMimeHandlerViewCrossProcessTest .MimeHandlerViewInDisplayNoneFrameForGoogleApps. Other tests have been removed since they no longer work in their present forms, but re-writing them is tracked in blocker bugs for the associated issue. Bug: 533069 Change-Id: I09124c65fa1341b5b3b58f96c897a58433f184f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869121 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#720036}
-
Michael Ershov authored
Only HTTPS URLs should be allowed to receive VA challenge response. Bug: 1000589 Test: SAMLDeviceAttestationTest.* Change-Id: I11b692f1124a1a9f7c0c1b4db2faf6df23d28039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940183Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#720035}
-
Kamila authored
Implements showing a promo (In Product Help) explaining to the user that the notification prompts are suppressed and will be shown quietly in the address bar. Intentional implementation details: - The promo will be shown only the first time the user sees a quiet prompt. The rest of the quiet prompts will not have IPH. - The promo will not be shown if the user opts in for the notifications themselves through settings. - The promo can be dismissed by: - User action in the site (such as clicking/navigation). - Clicking on the permission prompt icon. Bug: 986737 Change-Id: I77ae3de0e2e76b921d8ea689a89a1afb18d586f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929238 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Tommy Li <tommycli@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720034}
-
Malay Keshav authored
This reverts commit fa202801. Reason for revert: Failing test has been triaged on skia gold. Original change's description: > Suppress Pixel_PrecisionRoundedCorner on Nexus 5/6/6P > > The test has been failing since it was introduced. > > TBR=ynovikov@chromium.org > BUG=chromium:1029329 > > Change-Id: Ifa053cbee22dee75700cbde0895659fe41e65f1c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942432 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720000} TBR=cwallez@chromium.org Change-Id: I25e89f393485df314bd3925c9ef908b40e9c57b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1029329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942491Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#720033}
-
Mark Cogan authored
Change-Id: Ie3fb20c37902459599a8a02202a6d4ff91907963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942692 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#720032}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55fea94c8239..4a8d66b9713e Created with: gclient setdep -r src-internal@4a8d66b9713e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I4de49284aa60ee78c33a8c67a269b88754787208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942550Reviewed-by:
-
Chris Sharp authored
TBR=davidben Bug: 1029339 Change-Id: I30603f483290d1d6fb59d484493222522a3bc490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942812 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#720030}
-
Chris Sharp authored
Tests are often timing out on the Win7 bots. TBR=svenzheng Bug: 1025335 Change-Id: If7b62427b2896d09d31fac39f3932a3786403a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942811 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
danakj authored
Use OnceCallback where possible, and use BindRepeating() where it is meant to be a RepeatingCallback. TBR=sergeyu@chromium.org Bug: 1007709 Change-Id: I4408f77d876e5b72017892ebc2195dafabadfccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943048Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/033be28e..c742e26b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1644331a3cb8c562001a227659ea07799f8723f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942988Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720027}
-
Sean Gilhuly authored
The Dawn swapchains now return TextureViews instead of Textures. Update to match the latest API. Following the swapchain change, this Skia patch is also needed to build SkiaRenderer Dawn: https://skia-review.googlesource.com/c/skia/+/254810 Bug: 1021566 Change-Id: I5ff967e5ddfc1fd66e59c4724c6e8f74bd6ff0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941188Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#720026}
-
danakj authored
TBR=sky@chromium.org Bug: 714018 Change-Id: I02a0ee32e2b8113c205ed0353e0b4b330fd732de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942871 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Antonio Gomes authored
BUG=787254 R=guidou@chromium.org Change-Id: Idf5eb75341cf69bce7038678cb596a738584e6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942989 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d6e903bdc9ef..4cea2aef55dc git log d6e903bdc9ef..4cea2aef55dc --date=short --first-parent --format='%ad %ae %s' 2019-11-28 bclayton@google.com Regres: Use android.googlesource.com for dEQP Created with: gclient setdep -r src/third_party/swiftshader@4cea2aef55dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iaab91d0a7acf36469d8fe5495deb86f315d24d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942967Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I5f5caa29c0ff72ca384c17a8b5c2426394f20c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942549Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720022}
-
Mihai Sardarescu authored
Bug: 1028523 Change-Id: I7c1de5e352bbf696e9d0a59c72d616c8daeafd8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942434 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720021}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/455af892685f..e6b3c2f71351 git log 455af892685f..e6b3c2f71351 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 ilkos@google.com Fix non-reentrant metadata Created with: gclient setdep -r src/third_party/perfetto@e6b3c2f71351 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I406c799131c56c67e76fdd92a362216c1678d9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942769Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1002539 Change-Id: I75d52584a892bb517b15e97a3d2877e676071ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932808 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLVideoElement> and DynamicTo<HTMLVideoElement> as new downcast helper 2. Use IsA<HTMLVideoElement>(element) in place of IsHTMLVideoElement(element) Bug: 891908 Change-Id: Ia65adf5e774d782c21cd911f11c065b96c9b2566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930759 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Mark Cogan authored
As the first step in making coordinators more consistent in their public APIs and internal usage of Browser, CommandDispatcher is moving to be created and owned by Browser instances. Note that this still leaves us with two dispatchers per scene; one for regular tabs and one for OTR tabs. Untangling that is a separate (and more painful) effort. This change should have no direct side effects Change-Id: I81211a33616cf3c47cc8c286da09166bf1003d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940244 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720017}
-
Alex Chau authored
- Disable check for SharingService instead, which only applies when kSharingDeriveVapidKey is enabled by field trial config, which is never the case for branded builds. Bug: 1028113 Change-Id: I1b9368692ffe3bcf8e2c6cfc4fa8ad4d51867ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942435Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#720016}
-
Koji Ishii authored
Following bot results are included. 418 419 420 424 431 433 437 439 440 447 449 450 451 33 lines were removed and 21 lines were deflaked by consecutive results since 419. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I110d57d3724c46ccd5b5131a2c364585775cb5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936695Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720015}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7694024878c8..55fea94c8239 Created with: gclient setdep -r src-internal@55fea94c8239 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ibce7ef7a09e7597c44f865ba2624353927046162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942868Reviewed-by:
-
Geoff Lang authored
GPU progress would only be reported after destroying all resources in PassthroughResources but when many objects were allocated the entire process could cause GPU hangs. Report progress after each texture, buffer, renderbuffer or program is destroyed to ensure that no hangs are detected during this process. BUG=1027064 Change-Id: I24fe4c89499f642e2137fd4b8b59d007b7690fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934587Reviewed-by:
-
Joe Mason authored
Bug: 1004848 Change-Id: If501b9dc47dade3fc03396935d8f775ff479d0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939934Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#720012}
-
Ella Ge authored
This CL migrates some UserActivation related web_tests (layouttests) to use testdriver (or gpubenchmarking), instead of EventSender. This CL also fixes these test with BrowserVerifiedUserActivationTypeMouse enabled. Because EventSender generated events are not from browser side, so the browser side verification will failed. This CL update the failing mouse type tests to use either testdriver or gpubenchmarking, so that events are correctly dispatch from browser side. Bug: 848778 Change-Id: I23380932d083aef18cf1f54d82621e5e96c52ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872928 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#720011}
-
Julian Pastarmov authored
The policy will lock some user selectable types in the disabled state while allowing the user to control all others individually. BUG=649062 TEST=Existing unit and browser tests cover this code. Change-Id: I14ecf261df5b218ba269fdf669eba1b9f0afcc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860026Reviewed-by:
-
