- 20 Nov, 2018 40 commits
-
-
Mikel Astiz authored
The legacy (pre-USS) implementation of session sync was the only remaining user of this field and has been deleted recently, so let's just remove the now unused API. This is convenient for pseudo-USS (SyncableServiceBasedBridge) because there is no need for additional plumbing to propagate this information through (it wasn't actually properly populated prior to this patch). Bug: 895455 Change-Id: I02a577978b5fd7a84ced4775cd200d0210928985 Reviewed-on: https://chromium-review.googlesource.com/c/1343003 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#609715}
-
Mike Klein authored
Guard for https://skia-review.googlesource.com/c/skia/+/171908 TBR=fmalita@chromium.org Change-Id: I368fa8f6539b9072a0ae2b75e72040c5d2f68130 Reviewed-on: https://chromium-review.googlesource.com/c/1343009Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#609714}
-
Geoff Lang authored
ANGLE now exposes this extension under the same conditions as Chrome: on top of a native ES driver. BUG=angleproject:1552 Change-Id: I6552e51bccd5ece43b7405b26d63127283a90c46 Reviewed-on: https://chromium-review.googlesource.com/c/1342497Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609713}
-
gogerald authored
Bug: 806868 Change-Id: Ia2d3ab25ab95645db5215a2c6d8c4b0f1d9d3a1c Reviewed-on: https://chromium-review.googlesource.com/c/1343561Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#609712}
-
David 'Digit' Turner authored
This is mostly to get the bugfix from [1], which will allow the removal of 2 workarounds in our build system. See [2] [1] https://github.com/google/bundletool/issues/32 [2] https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/719231 BUG=891931 R=agrieve@chromium.org, ntfschr@chromium.org Change-Id: Ibc6f406ce3b2d920b19435e392b51181308e24a2 Reviewed-on: https://chromium-review.googlesource.com/c/1343107Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#609711}
-
Vaclav Brozek authored
The test was meant to check what happens if a password field has a CVC-like name. Instead, it tested what happens if a text field has this name. This CL fixes that mistake. The test thankfully still passes. This is a yak-shaving for adding the fallback pass, hence the below bug association. Bug: 906584 Change-Id: I9228c0252c97397fb5486e8a62c4cfb6a3f14cf6 Reviewed-on: https://chromium-review.googlesource.com/c/1343269Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609710}
-
Koji Ishii authored
This patch fixes NGLineBreaker not to freeze when all of the following conditions met: * 'word-wrap: break-word' is set. * 'whitespace: pre-wrap' is set. * Two or more adjacent preserved spaces are split to two or more elements, and is the last space to fit in the line. e.g., <div style="whitespace: pre-wrap; word-break: break-word"> <span>xxx <span> yyyy </div> and "yyyy" does not fit. We need to handle trailing spaces not only when spaces follow a break opportunity but also spaces are after spaces. Bug: 903909 Change-Id: Ie4346a670ec22d35cca3a290b9a423161537e4e8 Reviewed-on: https://chromium-review.googlesource.com/c/1343466Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#609709}
-
Tien Mai authored
Pass the hosted e-mail domain to the gaia sign in page through GCPW. Bug: 887444 Change-Id: Ie77034dadc3873de35bbf32a30d20364877ec328 Reviewed-on: https://chromium-review.googlesource.com/c/1333869Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#609708}
-
Anand K. Mistry authored
BUG=None Change-Id: If9ca23541732251aa800c0335c8b094235e631a7 Reviewed-on: https://chromium-review.googlesource.com/c/1343458 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#609707}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=csharp@chromium.org Bug: 903957 Change-Id: I5ff84cb3c4169e19e04d59e682916eb6632a848a Reviewed-on: https://chromium-review.googlesource.com/c/1338127Reviewed-by:proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#609706}
-
Bill Budge authored
- Adds kWasmCodeCache to blink::features. - Checks if enabled before creating the cache in the browser. - Checks if enabled before fetching from cache in renderer. This is patterned after the Javascript IsolatedCodeCache feature. Bug: chromium:719172 Change-Id: I1ffea5d8029b2b550c45e3ba25821889c7c2183c Reviewed-on: https://chromium-review.googlesource.com/c/1341071 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#609705}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/316e4119ed88..afe4ec5b3170 Created with: gclient setdep -r src-internal@afe4ec5b3170 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I27157ee885e507b522fb506194f78c2841d242f6 Reviewed-on: https://chromium-review.googlesource.com/c/1342691Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609704}
-
Martin Barbella authored
1) Favor --renderer-cmd-prefix more heavil when generating flags files for ClusterFuzz. 2) Remove the --gpu-launcher option as it no longer works. Looking at existing issues I'm not sure that this is too important for our coverage, so it seems easier to remove it than to try to continue maintaining it. R=inferno@chromium.org Bug: 904773 Change-Id: I3f0f468337540dfc5af73289ad0a46e41dcdb5ae Reviewed-on: https://chromium-review.googlesource.com/c/1340978Reviewed-by:
-
Nico Weber authored
zip_mini_installer_tests runs this script as part of the build, and the build is supposed to be silent except for errors. Bug: none Change-Id: I97b25cabf36fe4f2df577877c46159fad389f3dc Reviewed-on: https://chromium-review.googlesource.com/c/1342597Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 756bea38. With Chromium commits locally applied on WPT: 5ee777f6 "Fix test exclusion logic of wpt/referrer-policy test generator warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1920 and retry the command." ec589a5c "Add referrer-policy module worker tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: If6f14d1b9a8ae01964251da83b525cbc6a48bdc1 Reviewed-on: https://chromium-review.googlesource.com/c/1342859 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609701}
-
Vladimir Levin authored
This patch adds style recalc and one of the stages that the display lock prevents. Note that in order to reach the element during commit, this also adds a "style needs recalc" to the element. I'll replace these with smaller hammers after updating the layout tests, and fixing any bugs that popup there. R=chrishtr@chromium.org Bug: 882663 Change-Id: Icf8ac9c285b5e340c38addca7483b419f34ebadc Reviewed-on: https://chromium-review.googlesource.com/c/1340570Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609700}
-
Juan Antonio Navarro Perez authored
These are the only two stories still often failing on android-pixel2-perf bot. NOTRY=true TBR=nednguyen@google.com Bug: 865400 Change-Id: I3439893506c11b92d0d18a337ec7eef43c55080b Reviewed-on: https://chromium-review.googlesource.com/c/1344133Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#609699}
-
Yi Su authored
ChromeTableViewController. This CL migrates the PrivacyCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. Bug: 894791 Change-Id: Ia35b023b4fc1231d6ef35c93fb1ab8961d56ea40 Reviewed-on: https://chromium-review.googlesource.com/c/1340330 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609698}
-
Takuto Ikuta authored
Luckily, nacl compiler has fdebug-compilation-dir and it makes nacl compiled result deterministic. https://chromium.googlesource.com/native_client/pnacl-clang/+/cfbfff6970d1fc876a6ed3f04289e3086c9a9129/include/clang/Driver/CC1Options.td#135 Bug: 906741 Change-Id: I4b8ea54d20ba4cc58c07cc941a14584df33426c8 Reviewed-on: https://chromium-review.googlesource.com/c/1343472 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Max Moroz authored
The issue is very similar to https://crbug.com/905648. TBR=dcastanga@chromium.org Bug: 906292 Change-Id: Ia4283dff5acc39b6146518a1dd7c2ebffe35d8e4 Reviewed-on: https://chromium-review.googlesource.com/c/1342404 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
-
Nico Weber authored
Bug: 899437 Change-Id: I25ab289eaf053f09974413431e70ec648def95f5 Reviewed-on: https://chromium-review.googlesource.com/c/1309114Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#609695}
-
Koji Ishii authored
r608360 enabled fragment caching when BFC block offset changes, but r609030 disabled it when RareData exists, probably due to merge failure. This patch re-enables it. It recovers some of the performance loss seen at go/layoutng-loading-perf: https://pinpoint-dot-chromeperf.appspot.com/job/1605b070140000 Change-Id: I071fd5b4dd177245aa402718ce6f737549aa1b12 Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/c/1341741 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
Used async functions, arrow functions, and const, and added some comments. Bug: 778497 Change-Id: I03f23c6adddbb0e317edb197dc8af197597b2381 Reviewed-on: https://chromium-review.googlesource.com/c/1343416 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#609693}
-
Makoto Shimazu authored
Reload type has two variants: RELOAD and RELOAD_BYPASSING_CACHE. PlzNavigate currently sets net::LOAD_NORMAL to load_flags and false to skip_service_worker as BeginNavigationParams, so RELOAD_BYPASSING_CACHE doesn't affect those. This CL tries to change those parameters according to the reload type. Bug: 906542 Change-Id: Ib2f9f645007966d86a694d54dccbb476ec0fb45d Reviewed-on: https://chromium-review.googlesource.com/c/1343875Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609692}
-
Peter Beverloo authored
Change-Id: I1867a301c4bb0c9cd95edc94473ff783b9504cdf Reviewed-on: https://chromium-review.googlesource.com/c/1341922Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#609691}
-
Xida Chen authored
When the kCompositorTouchAction flag is on, we use the white listed touch action to process a gesture event. This CL adds histogram to measure how often a GSB and GSU is allowed / filtered / deferred by the main thread / compositor thread touch action. Bug: 745718 Change-Id: I2a8b16904ad9fa3f75249d4a1bb10aa0849094ce Reviewed-on: https://chromium-review.googlesource.com/c/1340588 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609690}
-
Maxim Kolosovskiy authored
TBR=wzang@chromium.org Bug: 904644 Change-Id: I8cd86ab57a5a5fc782447569e933f095d34a8d4d Reviewed-on: https://chromium-review.googlesource.com/c/1344049Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609689}
-
Adam Rice authored
Enable ReadableStream objects to be transferred by postMessage(). Internally, the ReadableStream is converted to a MessagePortChannel and it is that that is transferred. This involves adding a "stream_channels" field to the TransferableMessage mojo struct for the channels that will be used by ReadableStream (and in future WritableStream and TransferableStream objects). Additional code is added to V8ScriptValueSerializer and V8ScriptValueDeserializer to recognise ReadableStream objects. SerializedScriptValue has new methods and an array of MessagePortChannels as a member variable to transfer them. The new code is behind the "TransferableStreams" Blink feature and must be explicitly activated. A set of new layout tests provides basic verification that postMessage() of ReadableStream objects work. They are run with the feature enabled via a new VirtualTestSuite. The changes are covered in more detail in the design doc: https://docs.google.com/document/d/1_KuZzg5c3pncLJPFa8SuVm23AP4tft6mzPCL5at3I9M/edit Bug: 894838 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I032306415aa0c4e146af25439f42bcff70436416 Reviewed-on: https://chromium-review.googlesource.com/c/1315367 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#609688}
-
Daniel Bratell authored
Jumbo is a unity build system for Chromium (see https://chromium.googlesource.com/chromium/src/+/lkgr/docs/jumbo.md ) which merges cc files at the build target level. The code in //ppapi needs roughly 15 CPU minutes to compile in my measurements, which is 2.3% of the total jumbo build time and one of the largest remaining non-thirdparty code blocks without jumbo support. This saves about 7.5 CPU minutes in a jumbo build, which is a bit over 1% of the total reference build time. It doesn't cover thunk which is most of the remaining compile time. There are too much generated code with reused symbol names in thunk for it to be trivially supported right now. Bug: 898475 Change-Id: I1ee592578ac765cbd58cb856fcd5f331d3dd8c50 Reviewed-on: https://chromium-review.googlesource.com/c/1297366Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#609687}
-
Daniel Bratell authored
The documentation didn't include the crucial information that generate_linker_map has to be set to true in gn for the tool to work in Linux. Bug: 716209 Change-Id: I62919e26a80a0b5d592f6b8953762e35575142d2 Reviewed-on: https://chromium-review.googlesource.com/c/1338085Reviewed-by:
-
Henrik Boström authored
This helper class keeps track of an offerer state and an answerer state and makes sure that the transitions between different states are valid. By having a single state that reports whether the call setup was successful or if (and in which step) it failed we can be sure to get trustworthy comparisons between % success and % failures, which is important for the Unified Plan experiments. Follow-up CL(s) will wire up RTCPeerConnection to use this helper class and make sure the states are reported with UMA. Bug: 906029 Change-Id: Iafb77533c66c7625269e3c6e33ef954d88e54cdb Reviewed-on: https://chromium-review.googlesource.com/c/1340299Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609685}
-
Kush Sinha authored
Context: https://sites.google.com/a/chromium.org/dev/flag-ownership Bug: 820046 Change-Id: I8c64fd39cd8624f0810e1300ee3a4bc0caa0791b Reviewed-on: https://chromium-review.googlesource.com/c/1343268Reviewed-by:
-
Peter E Conn authored
It appears that changes to custom-tabs-client code are not synced to https://github.com/GoogleChrome/custom-tabs-client until they are included in Chrome's DEPS. This rolls the custom tabs client code to include fixes to a Trusted Web Activity utility class and to make it build with Java 8 (it was previously using Java 8 features, so technically this is a fix). Bug: 854603 Change-Id: I0937d2ed077cdf716293182c8b1bac6ef0895534 Reviewed-on: https://chromium-review.googlesource.com/c/1337489Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1e54003639e3..d11507507daa git log 1e54003639e3..d11507507daa --date=short --no-merges --format='%ad %ae %s' 2018-11-20 perezju@chromium.org [soundwave] Use explicit dtype's for DataFrame columns Created with: gclient setdep -r src/third_party/catapult@d11507507daa The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:904876 TBR=sullivan@chromium.org Change-Id: Icb6e1555aca0dee52cf934d4c489034ae6b0d033 Reviewed-on: https://chromium-review.googlesource.com/c/1342690Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609682}
-
Elly Fong-Jones authored
TBR=avi@chromium.org Bug: None Change-Id: Ifbff77761cb69ef2d5f8c765d4aea1df63906459 Reviewed-on: https://chromium-review.googlesource.com/c/1343074Reviewed-by:
-
Koji Ishii authored
This is a reland of 05672d8d The original change was reverted as suspected to cause Android CFI builder to fail: [ RUN ] RenderViewImplTest.PreferredSizeZoomed [FATAL:data_pack.cc(444)] Check failed: !handle->HasResource(resource_id). Duplicate resource 25400 with scale 1 I cannot find any relationship to the failure, and android_cfi_rel_ng trybot passes. Relanding to see if this was really the cause. Original change's description: > Normalize Katakana to Hiragana in ScriptRunIterator > > This patch normalizes Katakana to Hiragana in ScriptData, and > thus in ScriptRunIterator. > > There are 3 ICU script code for kana; USCRIPT_HIRAGANA, > USCRIPT_KATAKANA, and USCRIPT_KATAKANA_OR_HIRAGANA. However, > OpenType has only one 'kana' for all these 3 script codes. > > When shaping, HarfBuzz handles the normalization. However, > Blink splits the incoming string by the ICU scripts. > Splitting these 3 scripts is not useful but consumes CPU > and memory. > > By normalizing in ScriptRunIterator, all types of Kana are > in single run. > > timeToFirstContentfulPaint:layout shows ~3% improvements > https://pinpoint-dot-chromeperf.appspot.com/job/10d9760fe40000 > > though bink_perf.layout does not show much differences > https://pinpoint-dot-chromeperf.appspot.com/job/14f19c00140000 > > This is probably because Katakana characters are not used > much in `japanese-kokoro-insert` (written in ~100 years ago,) > while they are more used in modern pages. > > Bug: 636993 > Change-Id: If692bb575f2232b8fca10cd2ea87e3022debdf05 > Reviewed-on: https://chromium-review.googlesource.com/c/1337650 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609119} TBR=drott@chromium.org Bug: 636993 Change-Id: I1d741fa47556c5e7bf47e3badcdcf60a81fbc22b Reviewed-on: https://chromium-review.googlesource.com/c/1343583Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#609680}
-
Maxim Kolosovskiy authored
TBR=wolenetz@chromium.org Bug: 689781 Change-Id: I432995526e5aa0a2e235bf2a8a496ed265cbff74 Reviewed-on: https://chromium-review.googlesource.com/c/1343086 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 756bea38. Reason for revert: FindIt suspects that this is the culprit for a number of failures https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/18261 Original change's description: > v8binding: Do not hold a cross origin ScriptState in IDL callback function > > Make IDL callback function not hold a ScriptState of its > creation context when it's cross origin from the incumbent > realm. > > Not holding a cross origin ScriptState, there is much > less risk to access a cross origin context. > > IDL callback interface will follow the same approach in > a separate patch. > > Bug: 892755, 886588, 904218 > Change-Id: Ie55b436fcc5f66f4ee053ef08ad98ea68fb3a2d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1314023 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609662} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: Ic0e5a3006a43f8a95202ac1d890f365307068877 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 892755, 886588, 904218 Reviewed-on: https://chromium-review.googlesource.com/c/1343093Reviewed-by:
-
Sami Kyostila authored
If we try to record a trace event during MessageLoop shutdown, we can get to a state where the MessageLoop is present but the thread task runner handle has been reset. Since we require both in order to initialize the thread local event buffer, this patch makes sure the initialization is skipped if that condition isn't met. Bug: 906795 Change-Id: I9ead620573387f8c329d954425ef43c60547bbef Reviewed-on: https://chromium-review.googlesource.com/c/1343263Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#609677}
-
Maxim Kolosovskiy authored
TBR=estark@chromium.org, elawrence@chromium.org Bug: 907061 Change-Id: I138f8a64717329d4141ee1c2d49289741e524707 Reviewed-on: https://chromium-review.googlesource.com/c/1343267Reviewed-by:
-
