- 10 Oct, 2019 40 commits
-
-
Francois Doray authored
With this CL, PerformanceManager(Impl)::CallOnGraph can safely be called from any sequence, at any time. The callback does not run if the call is made before creation of after destruction of the Performance Manager. Implementation details: CallOnGraph always posts a task to the Performance Manager sequence. When the task runs on the Performance Manager sequence, it checks if a global pointer to the Performance Manager if set. This is not racy because the pointer is only modified from the Performance Manager sequence. If the pointer is set, the task gets the Graph from it and invokes the callback that was passed to CallOnGraph. Otherwise, the callback does not run. Bug: 980533 Change-Id: I3d640e0ae13d012d76bab1483a5d59afb977c1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849213 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704602}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in services/shape_detection to the recommended methods/types. Bug: 1007831 Change-Id: Ie7ff4256ee62271fc7c3fe2b4acb17b791314090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839954 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704601}
-
Tim van der Lippe authored
- Also upgrade the refactor script to automatically add the extensionpoint to the BUILD.gn to save myself some typing. Bug: 1006759 Change-Id: I3f789f96122569141194ce26ac288f01af68f6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852209Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#704600}
-
Jan Krcal authored
This CL fixes a glitch with spacing between image and label when the button is shrinking down its label. Before this CL, the preferred size jumped by this spacing _at the end_ of the animation when GetText() becomes empty. This CL makes LabelButton disregard this spacing at the beginning of the animation. Bug: 1002160 Change-Id: I213d2ba50aefde01dba1b2615ef47b38f9e3b94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849388 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704599}
-
David Roger authored
A lot of GCM tests are flaky. Disabling the worst offenders. Tests disabled: GCMChannelStatusSyncerTest.DisableRestartAndEnable CMDriverFunctionalTest.MessageReceived GCMDriverFunctionalTest.MessageWithCollapseKeyReceived GCMDriverInstanceIDTest.GCMClientNotReadyBeforeInstanceIDData CMDriverFunctionalTest.RegisterAgainWithDifferentSenderIDs GCMDriverFunctionalTest.RegisterAgainWithSameSenderIDs GCMDriverFunctionalTest.RegisterError GCMStatsRecorderImplTest.CheckinTest GCMDriverFunctionalTest.RegisterAfterUnfinishedUnregister TBR=peter Bug: 1010462 Change-Id: Ibb6f80366d356cbd28fffb567095f282fbca12c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852445Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#704598}
-
David Roger authored
TBR=tommycli Bug: 1012211 Change-Id: I81816b35680dd3be345e2b699779663cc11bdd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852784Reviewed-by:
-
Lily Chen authored
This change allows the SameSiteDataRemoverImpl to use the appropriate CookieAccessSemantics value when determining whether a cookie is effectively SameSite=None. Bug: 978172 Change-Id: I214e115b08d9591462f8405d9e7420bda481db48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846316 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#704596}
-
Jan Krcal authored
This CL keeps the user email shown also if parent container is focused or hovered. It introduces a notification from the container towards the avatar button when the highlight state changes. In a follow-up CL the same notification will also be used to hide the border of the button. Bug: 967317 Change-Id: I80866957d7098c675ad20d7fd03d1f45ad5aeec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826678 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
David Roger authored
TBR=meacer Bug: 1010678 Change-Id: Iebd944e30415975bfef89c793a900cb5dfce6339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852250Reviewed-by:
-
Javier Ernesto Flores Robles authored
This is a reland of b400d6c7 Original change's description: > [iOS][MF] Fix search in all passwords > > If the password view controller was presenting something, it will stay > around. This is fixed and a test is added. > > Bug: 1008421 > Change-Id: I8248cbbf28be94bc4b84c65ccda42129a192db0b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826895 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702358} Bug: 1008421 Change-Id: I04c8b6baa91c87884c6b792cb67fa75cc8faed6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852284Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704593}
-
Rayan Kanso authored
TBR=mkwst@chromium.org Bug: 687444 Change-Id: Iaae3fe5443c12982fa10d22c85a0894630a8354d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831774 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#704592}
-
David Roger authored
TBR=jshikaram Bug: 1013094 Change-Id: I9f16d2bf56f1e9de6685a9058a31cf71bf3cd3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852246Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibe15c8703131ecceb5b8be3571b31ec8c99faf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704590}
-
Jan Wilken Dörrie authored
This change changes the type of CredentialPair::is_public_suffix_match from bool to a strong bool alias and updates callers. Bug: 945300 Change-Id: Ibea7fda806f07575635e66dce933b0fb218945cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849389Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#704589}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/35d020e5..5fdd5453 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib19cbf70e67f3ead4f906c038cb80e36028d1b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852667Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704588}
-
Matthias Körber authored
Changed |PresubmitError| to |PresubmitPromptWarning| to allow the call. Bug: 1013121 Change-Id: I1e38d8efb7c6bdf21568924e2cd51126a4e50aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852208Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#704587}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/066c2ab92f80..03f4b36bdd9a git log 066c2ab92f80..03f4b36bdd9a --date=short --no-merges --format='%ad %ae %s' 2019-10-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d9b4f45e..651f5a29 (704251:704530) 2019-10-10 danilchap@webrtc.org Replace virtual RtcpPacket::SetSenderSsrc with base member 2019-10-10 aleloi@webrtc.org Revert "Implement rollback for setRemoteDescription" 2019-10-10 nisse@webrtc.org Fix handling of large packets in RtxReceiveStream 2019-10-10 gustaf@webrtc.org Bypass unnecessary resampling. 2019-10-10 mbonadei@webrtc.org Add missing dependencies to the static library. Created with: gclient setdep -r src/third_party/webrtc@03f4b36bdd9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:980875,chromium:b/130016532,chromium:None Change-Id: I1445909db68fb45faa26e6e8d31ecdd65f63d377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852187Reviewed-by:
-
Al Muthanna Athamina authored
This CL attempts to cover ParsedURL.js with Karma tests. Note that some of the code was not covered because the it threw an error when trying to call Root but the coverage ended up being above 90% Change-Id: Iede3cda2a520f0a8a9a3c1378e48caecc11d183d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852287Reviewed-by:
Tim van der Lippe <tvanderlippe@google.com> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@google.com> Cr-Commit-Position: refs/heads/master@{#704585}
-
Thomas Tellier authored
Bug: 1002108 Change-Id: Id4473becaafe6e6d2477dfae0aad1aa2b4fd1669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850512Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#704584}
-
Clemens Arbesser authored
See bug description for more info. Bug: b/142454202 Change-Id: Iadebe24cc579502f32db8503e35e262651464ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852087Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#704583}
-
Miyoung Shin authored
This CL converts IsolatedXRGamepadProviderFactoryPtr and Binding<IsolatedXRGamepadProviderFactory> in chrome and device to the new Mojo type, and uses pending_remote<IsolatedXRGamepadProviderFactory> in isolated_xr_service.mojom. Bug: 955171 Change-Id: I109a2197c8e02bdd7908402837284f9f2c45970c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847233 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#704582}
-
Antonio Gomes authored
This is phase 6.2 on the design document [1]. CL moves RTCCertificateGenerator directly to blink/renderer, once its solely clients all reside in blink/renderer now. The existing base class WebRTCCertificateGenerator, needed to bridge between blink and content will be removed in a follow up step. The CL also removes the existing accessor in blink::Platform, and removes Mock implementations in //content/test/test_blink_web_unit_test_support.cc|h BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I7d065a3d9344d779c65938c174c74d82e71a8716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814604 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#704581}
-
David Roger authored
TBR=pfeldman Bug: 1013003 Change-Id: I6b98b0c4698c6c40d323bc996603e6595d3e4340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852291Reviewed-by:
-
Dominik Röttsches authored
Failing builds for example: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/83781 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/83780 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/83779 TBR=rmcilroy@chromium.org,perezju@chromium.org Bug: 1008001 Notry: true Change-Id: I1698c7b3d086d4238cca849c31ccb3ab806e581b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852206 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#704579}
-
David Roger authored
TBR=austinct Bug: 1008880 Change-Id: I9f9987e194fe59cbd8dd239105de76ce680a477f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852091Reviewed-by:
-
Dominik Röttsches authored
virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/update-bytecheck.https.html expectations fails on Win10, too, generalizing TestExpectations line. Bug: 1002377 Tbr: alancutter Notry: true Change-Id: I58fd8486fade53a11217c16010376e352aa40429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852266 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Bence Béky authored
These histograms are logged from third-party library QUICHE at the following places: https://quiche.googlesource.com/quiche/+/refs/heads/master/quic/core/qpack/qpack_encoder.cc#294 https://quiche.googlesource.com/quiche/+/refs/heads/master/quic/core/http/quic_spdy_session.cc#1081 For the definition of QUIC_HISTOGRAM_COUNTS, see https://quiche.googlesource.com/quiche/+/refs/heads/master/quic/platform/api/quic_exported_stats.h#86 https://cs.chromium.org/chromium/src/net/quic/platform/impl/quic_client_stats_impl.h https://cs.chromium.org/chromium/src/net/quic/platform/impl/quic_server_stats_impl.h Change-Id: Icf5a632d9f172cb2c79b53cccec349a2060351b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847797 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#704576}
-
Kent Tamura authored
The screen size flakiness should have been resolved by crrev.com/704235. Bug: 977153 Tbr: wangxianzhu@chromium.org Change-Id: I81a3c2acde46c4a0dfd8a58f78a85b95beab5c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852329Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#704575}
-
Tim van der Lippe authored
Bug: 1006759 Change-Id: I55ff55840cbf00a108cb0f3630cf5b489bf3aac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849386Reviewed-by:
-
Mikhail Khokhlov authored
Bug: 981349 Change-Id: I3a9231abd80cfb9098ac3b8e7d261e70547a0c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852245Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#704573}
-
Julie Jeongeun Kim authored
This CL converts URLLoaderFactoryRequest from Clone() in url_loader_factory.mojom using PendingReceiver and ReceiverSet. Bug: 955171 Change-Id: Ic85b66e016b4556ff234db1f4545586c294dc6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844010Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704572}
-
Maksim Moskvitin authored
New integration test injects backward-compatible keystore Nigori and tests that client can decrypt password encrypted with the default key. Backward-compatible keystore Nigori uses some old key (derived from GAIA passphrase) as the default encryption key. This key is used for encryption of passwords data and |encryption_keybag| in NigoriSpecifics. This key also stored in |keystore_decryptor_token|, which is encrypted with a keystore key, so client should be able to decrypt everything once it has the keystore keys. Bug: 922900 Change-Id: Ic76d76a60c89ff4e639ca6f0fda2becc81e939c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847271 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#704571}
-
Paul Lewis authored
Change-Id: Ibe628e70b3d53db9ca132378c2da2ac42cd7746c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847337 Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#704570}
-
Mirko Bonadei authored
Goma no longer supports cl.exe and the cl.exe version update in this CL hasn't been uploaded to goma's servers. Everyone who has bots that use cl.exe must make sure that these bots don't use goma before rolling this CL in. This change switches the MSVC toolchain to VS 2019 16.3.29324. Windows SDK is mostly 10.0.18362 Debuggers from 10.0.17763 d3dcompiler_47.dll from 10.0.17134 The instructions for the previous package are included below: Packaging was done on a Windows Server 2019 VM, cleanly created for this purpose. The package was created by downloading VS 2019 Update 3.29324, from https://visualstudio.microsoft.com/downloads/ and downloading the 16.3 Visual Studio Professional 2019, and then running the installer like this: $ PATH_TO_INSTALLER.EXE ^ --add Microsoft.VisualStudio.Workload.NativeDesktop ^ --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ --includeRecommended --passive Then the 10.0.18362.0 SDK was installed from: https://developer.microsoft.com/en-US/windows/downloads/windows-10-sdk. Then Add or Remove Programs was used to modify the 10.0.18362.0 SDK to add the Debuggers package. Then the packaging script was run like this: python depot_tools\win_toolchain\package_from_installed.py 2019 -w 10.0.18362.0 Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid shipping that the final packaging step was to unzip the package, copy over the two copies of that DLL from win_sdk\Redist, replace the Debuggers directory with the 10.0.17763 SDK, and then repackage the toolchain with: > python package_from_installed.py --repackage=<full-path-to-toolchain-dir> Bug: 1006238 Change-Id: I623632bd72f018a74ab513d2c79e89199915e647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836195Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#704569}
-
Antonio Gomes authored
This implements phase 6.1 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ Basically, the CL moves content/renderer/media/webrtc/media_stream_video_webrtc_sink.cc|h to Blink. Notes: - the header is temporarily moved to Blink's public API layer until all its clients move to Blink. - the associated unit test will be moved in a later step because of its inclusion chain that needs to be handled first (namely content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h). BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I8ede23160a249349e32bbf82a62e8aed1504bbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811179 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
arthursonzogni authored
Cause: Android webview is reaching a CHECK in the renderer process. See: https://crbug.com/1006814. Plan: 1) Revert speculatively. 2) Cherry-pick to M78 3) Reland later with: a) Some CHECK on the browser side to get useful StackTrace. b) Some Android webview specific tests. Reverted CL: ----------------------------------------------------------------------- Stop reviving crashed RenderFrameHost. Get a new one instead. On same-site navigations, the browser reuses the current RenderFrameHost, even if the current RenderFrameHost is crashed. Instead of reviving the crashed one, we should get a new RenderFrameHost. This can be seen as a small step in the direction of RenderDocument, which intend to get a new RenderFrameHost every time, even if the previous RenderFrameHost is not crashed. https://docs.google.com/document/d/1C2VKkFRSc0kdmqjKan1G4NlNlxWZqE4Wam41FNMgnmA/edit Bug: 981339 Change-Id: I17b11abe759906a7f360abeaa45f0bfc77e08768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688957 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> ----------------------------------------------------------------------- Bug: 1006814 Change-Id: Ic0b55d61739b5f64c46bf9326eb2fcd4fe03de0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848390Reviewed-by:
-
Alex Chau authored
- The check caused Android to return true for IsSyncDisabled when "sync the feature" is turned off but transport-mode is active - The check was a workaround for ClickToCallBrowserTest and is now replaced with proper test setup Bug: 1010968 Change-Id: I6031401d5a781a1f2436a5bfb738059d1ff51961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845717Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#704566}
-
Rayan Kanso authored
Change-Id: Id69c525307e93d1b45d0412de643f77efc53188e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844821Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
BackgroundSyncScheduler code was returning an incorrect delayed_processing_info for Periodic Background Sync. This change fixes that. Change-Id: Ic5aa4505de2613bea5cd676de8faeca76100eb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851424 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#704564}
-
Oriol Brufau authored
This patch extends the syntax of the list-style-type property to accept arbitrary string values in order to customize the marker contents. I have followed the same approach as https://crrev.com/c/879135 did for the display property. When a string is specified for list-style-type, the patch sets it to a special EListStyleType::kString, and the string is stored in an extra field. As a result of this split, list-style-type doesn't use as much auto generated code now, e.g. EListStyleType is not automatically generated. Intent to Implement and Ship: list-style-type: <string> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GojYpoeDbqc Spec: https://drafts.csswg.org/css-lists/#valdef-list-style-type-string Bug: 687946 TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-002.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-003.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-004.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-005a.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-005b.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-006.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-type-computed.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-type-valid.html TEST=third_party/blink/web_tests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/lists-3/list-style-type-string-001a.html TEST=third_party/blink/web_tests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/lists-3/list-style-type-string-001b.html This patch makes some ::marker tests in css-pseudo fail, but this is expected because ::marker has not been implemented yet. Change-Id: I5743b99bc1a8e66679235874623c82650860ea29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841472 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#704563}
-
