- 06 Feb, 2020 40 commits
-
-
Virender Singh authored
This reverts commit c2f07278. Reason for revert: This change is causing regression. Bounding box calculation of a given element requires the |kScrollX| and |kScrollY| positions. In case of PDF there is a scroll element which lives outside the PDF node. The scroll element also reports scroll positions. During calculation of bounding boxes in AXTree::RelativeToTreeBoundsInternal |kScrollX| and |kScrollY| are applied twice. Original change's description: > Add viewport scroll information to PDFAccessibilityTree > > This CL adds following information to PDFAccessibilityTree > - ax::mojom::IntAttribute::kScrollXMin > - ax::mojom::IntAttribute::kScrollXMax > - ax::mojom::IntAttribute::kScrollX > - ax::mojom::IntAttribute::kScrollYMin > - ax::mojom::IntAttribute::kScrollYMax > - ax::mojom::IntAttribute::kScrollY > > It enables partial implementation of IScrollProvider, following methods > will work with this change > - IScrollProvider::get_HorizontallyScrollable > - IScrollProvider::get_VerticallyScrollable > - IScrollProvider::get_HorizontalScrollPercent > - IScrollProvider::get_VerticalScrollPercent > > This information is required by Screen readers to announce the current > scroll position and extent of scroll to the user. > > Tests: The best way to test this change will be through browser tests. > However, it requires the second part of the change, detailed in the > associated bug, to be completed. > > Bug: 1034521 > Change-Id: I629b2773c75f2b6b222d339cd0ae01799d695295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985821 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Virender Singh <virens@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#728843} TBR=dcheng@chromium.org,thestig@chromium.org,mohitb@microsoft.com,virens@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1034521 Change-Id: I15675f9ba604be96e9c50c9bea1dbe84ef8c9a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041714Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#739108}
-
Yulun Wu authored
Bug: 1049281 Change-Id: Ib9d4ada81de8568cbfc5f7dc7f69ef3eb6470daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042192 Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739107}
-
Jose Lopes authored
The original method declared the argument as OnceCallback: https://cs.chromium.org/chromium/src/chrome/browser/offline_pages/background_loader_offliner.h?rcl=f1e0ecaf7d175cf0f4eb923daa10511be4b11931&l=75 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Change-Id: I4f477760f4cf423d6352fd82041da75b2f0e1903 Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031405Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#739106}
-
Thomas Lukaszewicz authored
Views with backing Layers that set a |clip_path_| will now create a ViewMaskLayer object that masks the area designated by the clip. The View Layer and all child Layers will be masked by the ViewLayerMask. Made some small changes to the original set_clip_path() setter and calling functions. Bug: None Change-Id: Id746a72042d9f114144db01e289a603abe5afe9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031640Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#739105}
-
Colin Blundell authored
This will simplify the task of changing WebLayer to take advantage of the newly-componentized ContentMetricsHelper in a followup CL. Bug: 1030692 Change-Id: Iad9d8e557b73837ffd9c4506cec4ed63424b63cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041626 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#739104}
-
Sebastien Marchand authored
Bug: 1028410 Change-Id: I99d415261b48e05d401148dcf6b1165c0f020f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042311 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#739103}
-
nancy authored
The Crostini new terminal app is a system web app, although the app type in AppService is still Crostini. So update IsOpenedInBrowser to return true for the new terminal app id kCrostiniTerminalSystemAppId, so that AppServiceAppWindowLauncherController can skip that, and leave it to BrowserStatusMonitor to handle all windows related requests. BUG=1048906 Change-Id: Ie06f0616cf3a3ff6f25d2ad878151c8f71c98e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038930Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#739102}
-
gogerald authored
Bug: 1048225 Change-Id: I39b1e3d99fd092d95ad9dc9361e4912f92d6461a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036375 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#739101}
-
Matthias Körber authored
Change-Id: I7225bb27624db7abe7c95a13df9b79830c81ef9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035954 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
-
Darin Fisher authored
This CL changes the IPC interface for prerendering by introducing Mojo interfaces PrerenderHandle, PrerenderHandleClient & PrerenderProcessor. PrerenderHandleClient is a rename of PrerenderDispatcher, but now with that name indicates how it relates to a requested prerender. PrerenderHandle corresponds to a requested prerender. This name is chosen intentionally to match prerender::PrerenderHandle and blink:: PrerenderHandle. These all correspond one-to-one. PrerenderProcessor is the interface used by a renderer to make requests for prerendering. It is instantiated per-frame, which enables the browser to get the render_view_id without it having to be passed over IPC as a parameter. A future CL will be able to move these interfaces into Blink, and then eliminate some of chrome/renderer/prerender, WebRenderer and other Blink layers of plumbing. As part of this change, PrerenderLinkManager's list of LinkPrerender objects is changed to be a list of std::unique_ptr<..> instead since LinkPrerender objects are no longer copyable since they have to store a mojo::Remote to the PrerenderHandleClient. This impacted a fair chunk of code. The concept of prerender_id is also removed. That is no longer needed as each PrerenderHandle instance is effectively a unique ID. This in turn caused a good amount of surgery to prerender_unittest.cc. It makes some tests unnecessary since they were testing codepaths related to no longer valid prerender IDs and such. Change-Id: I1d1911a3a44fe8b4478b9a109048c3081e78822d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036906 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#739099}
-
Robert Liao authored
This is a mechanical change to remove implicit conversions of ScopedBstr to BSTR. BUG=1034666 TBR=dtseng@chromium.org,ganesh@chromium.org,grt@chromium.org,jamiewalch@chromium.org,pmonette@chromium.org,proberge@chromium.org,sky@chromium.org Change-Id: I9fa7d62bddeecd81d1944bb289bad2a5758fe7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038171Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#739098}
-
Elly Fong-Jones authored
Currently, if a DialogDelegate's Accept() or Cancel() method leads back into its Close(), two of the registered callbacks can be run, which is a violation of DialogDelegate's contract and causes confusing workarounds in client code. This often happens in code like this: void SomeBubble::OnDialogAccepted() { NavigateTo(kSomeURL); } where NavigateTo causes a page navigation synchronously, which causes the involved bubble to be closed. Instead: * In the near term, DialogDelegate should ensure that it never delivers more than one of these callbacks * In the far term, DialogDelegate should enforce that callers do not re-enter Close() from inside Accept() or Cancel() The latter will likely need to wait for the Accept/Cancel/Close callback refactor to be finished. This change also removes the remnants of the GlobalErrorBubbleView unit test suite, which were exercising this behavior deliberately. These tests were providing very little actual coverage and I have been gradually deleting them as I refactor GlobalError anyway. Bug: 1011446 Change-Id: Ifd76330c0f79d04ce2e5741c5a1977159ee598d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042252 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#739097}
-
nancy authored
BUG=1006999 Change-Id: I2a85e86059c617e7676e9b9319fd8a245a197b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040639Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#739096}
-
Nick Burris authored
These tests need to perform cross-origin navigations as they test security restrictions that only apply to cross-origin. Bug: 1049624 Change-Id: I241962c44eaa1e4862e3df38be4b614491818b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042402Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#739095}
-
Jinsuk Kim authored
Now that Preview Tab is working on top of ThinWebView and BottomSheet, this CL deletes the old implementation that based it on OverlayPanel. Bug: 1043677 Change-Id: Icccc93cca3f09e9ae122b1e0dcb7537331136ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032466 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#739094}
-
Archana Simha authored
This is recorded in addition to the histogram so that we can use the user action sequencing dashboard to see what users do on the chrome://extensions page, and use the histogram to see which messaging is most effective. Design Doc: http://go/extensionscheckupmetrics Bug: 1034541 Change-Id: I490eeec2a666e7fac094f7ac0872540c50c0dc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031534Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Adam Labuda authored
[Problem] When Remote Web Inspector is connected to a page doing a lot of XHR requests (for example https://www.youtube.com/watch?v=Bey4XXJAqS8_) renderer's memory usage starts to grow with no limit. [Cause] There is a corner case in NetworkResourcesData when the limit of maximum_resources_content_size_ (100.000.000 bytes) is almost reached. When the next request finishes its raw data is replaced with decoded form. The decoded form can be larger that the raw data. Sometimes the difference is so big that it causes the NetworkResourcesData::content_size_ to go above the maximum_resources_content_size_. From now on there is basically no limit in appending requests in NetworkResourcesData as maximum_resources_content_size_ - content_size_ in NetworkResourcesData::EnsureFreeSpace() will give a very large number (unsigned overflow). [Solution] Ensure that after request data is decoded NetworkResourcesData has enough space to store the decoded form. It needs to have at least "decoded size" - "raw size" bytes free. Bug: 1019862 Change-Id: I5adf3aa4a91d01012f8620628f1a442697668105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946476Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#739092}
-
Rouslan Solomakhin authored
Before this patch, BobPay native Android payment app could be displayed side-by-side with BobPay service worker based payment app, even if the web app manifest was configured to prefer the native payment app. This patch adds a PaymentInstrument.getApplicationIdentifiersThatHideThisApp() override in ServiceWorkerPaymentApp, which was accidentally deleted in https://crrev.com/c/1988215 as it was being renamed from PaymentApp.getPreferredRelatedApplicationIds(). After this patch, BobPay native Android payment hides the service worker based payment app. Bug: 1049217 Change-Id: Id439daf9435317be30885e1e0adafce1284481ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039632 Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#739091}
-
Elly Fong-Jones authored
This change removes almost all the remaining overrides of ::Close() in cbuiv, and some of the overrides of other methods. Replacements are either: 1) Deleted outright 2) Replaced with lambdas inlined in the constructor 3) Replaced with void OnDialog*() methods that are used for the new callback system Bug: 1011446 Change-Id: Idfe315895958f7cc92db17a30fc4cf591e4ffec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036943 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
David Tseng authored
Change-Id: I286fe466283e329c5e71fdc4454bd521a32ee2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039810Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#739089}
-
Becca Hughes authored
Add the output of the origin table to the WebUI for debugging. BUG=1024353 Change-Id: I2eb8e99d94bf8792bd459529ae5aae3bacffe89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037642Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#739088}
-
Rune Lillesveen authored
The setTimeout with 0 delay caused notifyDone() to sometimes be called too early. Instead add an event listener in the non-isolated world that should be triggered when the media query changes and add an extra rAF() in case the event listener is called first for the non-isolated world handler. The test still fails though, so the *expected.txt, which is now the same for all platforms, needs to be kept. The tests were marked with Timeout. If it turns out it is still slow on some bots, we can add it to SlowTests. The media query event handler argument had changed since the test was written, so fixed the test itself as well. Bug: 390452 Change-Id: I31c370601d932152adeb16bdffc59e4b68a2907d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041476Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#739087}
-
Nathan Zabriskie authored
This CL moves GLHelper from viz into gpu in preparation for it to be used by RasterImplementationGLES in a future patch. This will allow us to remove calls to GLHelper from CanvasCaptureHandler which is necessary as part of the OOPR Canvas project. TBR=bsalomon@google.com Bug: 1023262 Change-Id: I9f7f98cfc4cc73acabcda275d2eee27488c992de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023282 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#739086}
-
Hongchan Choi authored
Previously OfflineAudioContext::resumeContext() method did not check if the context is cleared by ExecutionContext::ContextDestroyed(). Such case is possible when the audio context is a part of a detached iframe. This CL changes the check so we can verify if the context's resources is still available. Otherwise, we can reject the resume promise resolver. Test: Locally confirmed ASAN does not crash with the repro case. Bug: 1048373 Change-Id: I96a601dcf63963525d95cfc5089fd4a3b0176687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042409 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
This is a reland of 359bdf76 Proguard rules now extended to ensure Fragments aren't removed in release: https://crrev.com/c/2036872. There is no change to this patch from the original. Original change's description: > [Settings Refactor] Move autofill settings > > Move autofill settings alongside autofill code. > > Bug: 1047357 > Change-Id: Id5679d4392e23cff775dfcefa41930af9ab0f602 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031538 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Natalie Chouinard <chouinard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737874} Bug: 1047357 Change-Id: Ic87a7b18859e51fd9683910e3707a1ffb2a1da47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036871 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#739084}
-
David Tseng authored
TBR=dtseng@chromium.org Change-Id: I299c2905122c06a0cb5492545a8d7a695fc81e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042275Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#739083}
-
Ian Kilpatrick authored
... and places adjustment within: LayoutNGMixin<Base>::ComputeIntrinsicLogicalWidths Previously ComputeMinMaxSize could work in two different modes, one to return the border-box min/max sizes, and one for the content-box. This was primarily to support ComputeIntrinsicLogicalWidths. This patch removes this enum, and instead places the adjustment logic within ComputeIntrinsicLogicalWidths. Change-Id: I1bf839e5afc5f7a7241749b9e9eeb34d50fc77ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031533Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#739082}
-
Corentin Wallez authored
Split out webgpu. Bug: 1048907 Change-Id: I8313c7cb6757d040deb3cd77d7825c6158ab8492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040615 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4802d647c64..73f1b60756e3 git log d4802d647c64..73f1b60756e3 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 liviurau@chromium.org Whitespace to trigger builders 2020-02-06 aerotwist@chromium.org [e2e] Performs cleaner shutdown 2020-02-06 tvanderlippe@chromium.org Test that document.write console messages properly show up 2020-02-06 tvanderlippe@chromium.org Stop running unit tests on presubmit 2020-02-06 yangguo@chromium.org Show previously hidden experiments Created with: gclient setdep -r src/third_party/devtools-frontend/src@73f1b60756e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632,chromium:1047671,chromium:1048124 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I492cb13f4aa4621e55b16da4cef08712761a975d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739080}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/782a957f83c0..6c48aad1a347 git log 782a957f83c0..6c48aad1a347 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 michaelludwig@google.com Fix compiler warning using mixed enum types 2020-02-06 brianosman@google.com Remove SkScalarClampMax and SkScalarPin 2020-02-06 brianosman@google.com Remove SkMin32/SkMax32 2020-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f1b2c4bed48a..e9dc0201af3a (7 commits) Created with: gclient setdep -r src/third_party/skia@6c48aad1a347 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: If1570ea93c5fa67b6e992e569d433a49415fa078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041809Reviewed-by:
-
Devlin Cronin authored
The ExtensionsToolbarContainer relies on a non-null ToolbarActionsModel to work (otherwise it segfaults). Thus, any test that creates a BrowserView (or BrowserView-like) thing needs to instantiate a test model. Instantiate the model in the CocoaProfileTest suite. This puts it on similar status with other keyed services instantiated in this test, such as TemplateURLService and AutocompleteClassifier. Bug: 984654 Change-Id: I61e348d175dc2b23ee912886a0be34b09c96d09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037839Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Properly dispose of the custom views created in BrowserActionApiTest during the tear down phase. This prevents a UAF when the view tries to clean up after the profile is destroyed. This was just an issue in the test, not in the wild (where views associated with a browser will never outlive the profile). Bug: 984654 Change-Id: Ied7dc0bd9c471fa2445b92096550adf09575043a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042390Reviewed-by:
-
David Bertoni authored
Bug: 1049214 Change-Id: I64018260d06070da03821bbcb72578de62359be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042313Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#739076}
-
Donn Denman authored
Reenable testLongpressExtendinSelectionExactResolve which was disabled due to flakes. It's an important test of a new feature, so bringing it back in a limited way. It looks pretty solid on non-tablet M+. TBR=mastiz@chromium.org BUG=1048827 Change-Id: I5c3878a3e5059b71b9eebae6af43bd1e7158b273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042377Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-4028.0-1580732019-benchmark-81.0.4044.9-r1 to 81-4028.0-1580732019-benchmark-81.0.4044.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id57449e5a6c973f6e6dd1619c78a461fa10c45ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042333Reviewed-by:
-
Martin Kreichgauer authored
This adds a FidoDiscovery::Stop() method that can be used to terminate authenticator discovery without destroying the instance. FidoDeviceDiscovery upon receiving Stop() will ignore all calls to AddDevice() and RemoveDevice(). FidoCableDiscovery inherits this behavior and also calls Unregister() on all pending BleAdvertisements. Lastly, AuthenticatorCommon is changed to stop all discoveries of the current FidoRequestHandler prior to signaling failure of the request to the UI layer. This fixes an issue where Chrome might continue to advertise caBLE EIDs while the UI is showing an error sheet, e.g. because the request timed out or because one of the authenticator returned an error that causes the UI to show its retry error sheet. Bug: 1046164 Change-Id: Ic5678f13a10efbb56277e6bd3485dd985c8ab0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036266 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#739073}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74e27c36bc28..e4d9391c167c Created with: gclient setdep -r src-internal@e4d9391c167c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028270,chromium:1033112 Tbr: jbudorick@google.com Change-Id: I89e04cd6b3ac94954cc73838b9e41e1b32d4cfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041808Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739072}
-
alex linker authored
histogram macros it was recommended by bcwhite@ on another cl to change all the macro calls to function calls to avoid instantiating the caching code. BUG=1044710 Change-Id: I1e6dfd9caa2f8250892a7505f30398a50f243483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040632Reviewed-by:
-
Austin Eng authored
This reverts commit 1fd0446b. Reason for revert: These tests are failing on Android Nexus 9 Original change's description: > Add EXT_texture_compression_bptc extension support > > Bug: 1013369 > Change-Id: I04a8ce5ce11fb6a5d67acc782c2e297224b8685b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029236 > Commit-Queue: Shrek Shao <shrekshao@google.com> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738764} TBR=dcheng@chromium.org,kbr@chromium.org,shrekshao@google.com Change-Id: I3478e6e5b698d4a660d62794b7b524c9cdf7f0ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013369, 1049733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042294Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#739070}
-
Steve Becker authored
Splits each of the following tests into 3 separate tests to avoid timeouts: native_FileSystemBaseHandle-postMessage-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-MessagePort-manual.https.tentative.html These tests take 5 to 7 seconds to pass, which is dangerously close to the 7 second timeout. A previous attempt added <meta timeout=long> to address the timeouts. However, wpt.py does not respect <meta timeout=long> for tests with filenames that contain "manual". The following bug requests a fix for wpt.py: https://github.com/web-platform-tests/wpt/issues/21527 This change solves the timeout by splitting each test into 3 groups: iframe tests, window.open() tests and worker tests. The change adds the following 12 test files since each test runs twice, once for the native file system and once for the virtual file system: Native file system tests: native_FileSystemBaseHandle-postMessage-frames-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-windows-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-workers-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-MessagePort-frames-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-MessagePort-windows-manual.https.tentative.html native_FileSystemBaseHandle-postMessage-MessagePort-workers-manual.https.tentative.html Virtual file system tests: sandboxed_FileSystemBaseHandle-postMessage-frames.tentative.https.window.js sandboxed_FileSystemBaseHandle-postMessage-windows.tentative.https.window.js sandboxed_FileSystemBaseHandle-postMessage-workers.tentative.https.window.js sandboxed_FileSystemBaseHandle-postMessage-MessagePort-frames.tentative.https.window.js sandboxed_FileSystemBaseHandle-postMessage-MessagePort-windows.tentative.https.window.js sandboxed_FileSystemBaseHandle-postMessage-MessagePort-workers.tentative.https.window.js Bug: 1046634 Bug: 1044519 Change-Id: Ide552f708d7514e299a68887b91659ac2226018d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035055Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#739069}
-
