- 13 Nov, 2020 13 commits
-
-
Wan-Teh Chang authored
Bug: 1147863 Change-Id: Ia3186b0c09d3b73a14e0745ffb0a3b2fb12b1a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533915Reviewed-by:
Urvang Joshi <urvang@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#827063}
-
Yue Li authored
Currently we detect the language only using the surrounding text. Check user selected text first and fall back to the surrounding text if the confidence level is no high enough. Bug: b/172374961 Test: Run existing tests Change-Id: Ifbcd820828aa7628994b90b756bcd2c9797f30c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528646Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#827062}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f0517095b853..5157fbfbae86 2020-11-12 cwallez@chromium.org roll_dep.py: Support upstream branch being origin/main. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I536ee9bbc6f02a7ee8f0bba9ab15468f918a68b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535580Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827061}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/1980095da7f4..20a8d31849c9 2020-11-12 dsinclair@chromium.org Create an AST builder class. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: If33ce849b84f9809bc872d0cee70cb636197601d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535570Reviewed-by:
-
Dale Curtis authored
This allows for direct planar access to capture buffers on macOS. R=sandersd Bug: 1137288, 1141214 Change-Id: I6a4859a807f2d77fd2fdd87c61f8c15dbdfbb0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536035 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#827059}
-
Dave Tapuska authored
Collapse WebViewImpl's implementation together with WebFrameWidgetImpl's and place it in base. WebViewImpl's version was not checking for drag and drop, and IgnoreInputEvents state but WebFrameWidgetImpl's was. These were unnecessary because all input first goes through HandleInputEvent and if there were any messages would be first discarded there. Add a test to ensure the messages are dropped correctly without the additional checks. BUG=1097816 Change-Id: I0bb95f0585296a48bff96bcc553c5ca80c701ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532732 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827058}
-
Xiang Ji authored
Validation: tryjob Bug: 1105203 Change-Id: Ife6434732a999e32a44868bcf7bb996a72e907f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533308Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#827057}
-
Collin Baker authored
Bug: 1100596 Change-Id: I64212babff827e76f0f614ad375fc690a3d6db30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533835 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#827056}
-
Mark Pearson authored
Some of these would get different types of data depending on the process it is run from. Does not comment all relevant functions, just the ones I noticed. Change-Id: I4450624db96021d39dbc1fb11b41e7d2fa561d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519857 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#827055}
-
Josh Nohle authored
For each discovery session, report the number of devices * discovered, * lost, and * present when a send starts. Also, track the number of milliseconds between a the start of a discovery session and * discovery of the first share target, * discovery of any share target, and * the start of a transfer. Manually verified using chrome://histograms Bug: 1105579 Change-Id: Ib998663d968fadcfb016c580ecf9119eefb5f0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530169Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#827054}
-
Nick Diego Yamane authored
A regression was introduced with initial extended-drag integration in Ozone/Wayland as described in details at https://crbug.com/1148021. This CL addresses the issue 2 described in the link above: When an already mapped window is dragged, it is not supposed to get a wl_pointer::enter again after the DND/extended session finishes (it already had focus before it started), so it's client responsibility to restore the focused window when upon drop event. That's like that because it is updated by the window drag controller based on data device events during the DND session. This patch fixes it by explicitly restoring the focus to the dragged window, if any, when the session finishes. Bug: 1148021 Change-Id: I8315a873673c303fb7726ff98a4a247983225442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533036 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#827053}
-
David Bertoni authored
Bug: 1143311 Change-Id: Ie8a50d33f65b2799e1a36f8aeacfed423acc96ce NoTry: True Tbr: perkj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536118Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Auto-Submit: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#827052}
-
dstockwell authored
Change-Id: I3661c364631551ed4bb0cbb3f0ee3c0b9cc81681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536411Reviewed-by:
David Lei <dlei@google.com> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#827051}
-
- 12 Nov, 2020 27 commits
-
-
Jeffrey Kardatzke authored
This adds the VAAPI accelerator delegate for H265 decoding. This is not actually enabled yet because there are other pieces higher up in the decoding pipeline that still need to be turned on. BUG=chromium:1141237,b:153111783 TEST=HEVC playback works w/ full set of changes, vaapi_unittest Change-Id: Ic0a2dbe774267d4852e0d4d47aa378c6602ad41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530798Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#827050}
-
Dave Tapuska authored
No more widget associated messages exist they all have been moved to mojo, so remove this interface. BUG=993189,1097816 Change-Id: I069b3ae061ad8cd0587d12040779f183ef129878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514477 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#827049}
-
Jesse Schettler authored
Sort the page sizes and correctly select the default option. Bug: 1059779 Change-Id: Ibfc1f482d84b75785ae790f3349b93839590327d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532969 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#827048}
-
Sam Maier authored
This warning message doesn't flood the screen like we feared it might. Increase this message size so it's more usable when importing new libraries. Change-Id: Ie3d2424e2763ac5aa7b969a3baafb66dd3c9a450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535932 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#827047}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibfbe02eac593171dea3ace043dfa2c535410c028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535794Reviewed-by:
-
Stephen Chenney authored
The painting path that uses tiled image painting to draw background images was incorrectly orientating images sized with contains or covers. The problem was in using an un-oriented image size when correcting the source rect for orientation, when an oriented size is expected. In hindsight, we should be using the oriented size for the tile size, subsetting and other operations in the slow path. This also simplifies the repeated tile case. The test fails due to decoding artifacts from the oriented images, but the reference result also shows bad antialiasing artifacts around the edges. We need fuzzy matching. Bug: 1129956 Change-Id: I584b821f110720854fc21df49168afcf37fdc09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533505 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#827045}
-
Adam Langley authored
WebSocket connection failures resulted in a human-readable error message getting propagated to the Mojo interface, but there was no reliable way to, for example, know which HTTP status code caused an error. This change plumbs net error codes and HTTP status codes up into an optional calling in the Mojo interface. Other than implementing the new function in order to satisfy the interface, this has no effect on users. Change-Id: I8047b5b82422ca80e5bc0e0e8345408d29d9ede4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527889 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#827044}
-
Jeffrey Cohen authored
Bug: 1141839 Change-Id: I1da008817c240679b37193b1e2bb13faf0036a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530905 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827043}
-
Christopher Cameron authored
Merge GetSkColorSpaceForSkSurfaces with GetSkColorSpace. This function never returns nullptr, so remove branches that checked for that. Remove RequiresColorConversion and inline in its one location. TBR=fserb Bug: 1115317 Change-Id: Icb011165f5f18a328ff52492d1c4760de96847df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530184Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#827042}
-
James Hawkins authored
The initial implementation creates and persists a device name at startup, but this is not yet used anywhere else. Bug: 126802 Test: DeviceNameStoreTest.* Change-Id: Ibd185803947e90b53f87a789c4d4727e538d3a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523741 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827041}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/e258cf5e7aa9..88f9156d7f6a 2020-11-12 dneto@google.com Replace C-style cast with static_cast If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I7628e8a60aa9fce7ebb81ae63fafc31da892c5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535993Reviewed-by:
-
Patrick Noland authored
This delegate serves two purposes: 1. It severs unwanted coupling between StartSurface/tasks and LocationBar via ReturnToChromeExperimentsUtil 2. It enables us to supply the parent tab via glue code in ToolbarManager rather than leaking this implementation detail into FakeboxDelegate Bug: 1119256 Change-Id: I0b161df67bd94e3f3fa9c9dbfda0cfcaf0ba05da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533407 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#827039}
-
Nidhi Jaju authored
This CL aims to add polymorphism to the readable stream controller classes. In particular, it adds a new base class called ReadableStreamController, and the ReadableStreamDefaultController and ReadableByteStreamController classes inherit PullSteps() and CancelSteps() from the ReadableStreamController. This is based on the approach discussed in https://docs.google.com/document/d/1rvKpGjppeqRSWntokY-ft_hU2i2us8gis6zgrrLWSTI/view Bug: 614302 Change-Id: I58439e52e43b525cadbb1a9d36dd950005a7c32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531794 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#827038}
-
Yu Su authored
- move intent generation to the private repository. - remove extra Lens Prime class dependencies from Context Menu. - simplify the displaying and onClick handling logic for Lens chip. Part I can be found at: https://chromium-review.googlesource.com/c/chromium/src/+/2527724 Change-Id: I26516b1bc39d488922e963269da3114aaa5e998a Bug: 1145748, b/171252338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503636 Commit-Queue: Yu Su <yusuyoutube@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#827037}
-
David Bokan authored
Text fragments are allowed only if a text fragment token has been generated during loading. The token is effectively a navigation-time user activation flag. To allow user initiated text fragment navigations during a same document navigation, a token may be generated in DocumentLoader::UpdateForSameDocumentNavigation However, this method is called in a variety of other scenarios, such as calls to history.replaceState or portal navigations. In those cases, we would try to generate a new token, fail, and then clobber an existing token, causing pages like in the linked bug to fail. This CL makes it so that we only replace an existing token if the navigation is a standard navigation. Bug: 1147453 Change-Id: I2bad963884068d2de23833ffce37086fda9a034e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533688Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827036}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/5fa7c4e22c1b..4eb2d0b58ecc $ git log 5fa7c4e22..4eb2d0b58 --date=short --no-merges --format='%ad %ae %s' 2020-11-11 joedrago Fix comment typo and add parens around macro value 2020-11-11 jdrago Add avifDecoderNthImageReady() avifIO helper function 2020-11-11 jdrago Update changelog 2020-11-11 jdrago Expose maxThreads to avifDecoder, add --jobs to avifdec 2020-11-09 joedrago Minor rewording 2020-11-09 joedrago Create AVIF_VERSION_DEVEL, which allows for in-development changes to be ifdef'd in downstream projects 2020-11-09 joedrago v0.8.3 2020-11-07 wtc Reorder the offset checks in avifIOTestReaderRead 2020-11-09 joedrago Reword avifIOReadFunc comments for clarity (wantehchang) 2020-11-08 joedrago Allow checking the upsampling filter independent of subsampling choice to allow for a means for endusers to opt-out of libyuv, even if it is compiled in 2020-11-07 joedrago Remove misleading comment snippet about libyuv fast paths Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Bug: 1136922 Change-Id: I832341811c78d8698f75dafa1d3be8e76cb31e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536034Reviewed-by:
-
Nidhi Jaju authored
This CL aims to add polymorphism to the readable stream reader classes. In particular, it makes the ReadableStreamGenericReader the base class, and the ReadableStreamDefaultReader and ReadableStreamBYOBReader classes inherit from the GenericReader. This is based on the approach discussed in https://docs.google.com/document/d/1rvKpGjppeqRSWntokY-ft_hU2i2us8gis6zgrrLWSTI/view Bug: 614302 Change-Id: I4dde2976938325c21aeb87c6980ac4ad1def483f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528557Reviewed-by:
-
David Black authored
Previously we were only recording the time of the user's first pin to holding space. Now we will record the time when the first item of any type was added to holding space. This should help determine how discoverable the feature is. Bug: 1131266 Change-Id: Iacee3d00345fa2860b34d7695d92bf3e0bf91485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530751Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#827033}
-
Devlin Cronin authored
Add support for an allFrames boolean in the scripting.executeScript() API. If specified, the code is executed in all frames within the tab (that the extension has permission to access). Bug: 1144839 Change-Id: Idecc69cf9599dfc821e2d309078324a6e34b0a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532901Reviewed-by:
-
Eugene But authored
Update |hidden| argument calculations as follows: - Remove GetError() check, because same check was made earlier in the method and results in early return - Remove "is main frame" check as unnecessary, because DidFinishNavigation is not called for iframe - Remove navigation_context->GetResponseHeaders()->response_code() > 600 check, as it looks like a mistake which overrides correct comparison to status code 400 (range of HTTP status codes is [100, 599]). Bug: 924298 Change-Id: I0dc570d34ef6aed0654f7d0742190f425b2ac966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535017 Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#827031}
-
Daniel Hosseinian authored
Currently, GUIDs are returned as and stored in std::string. A dedicated base::GUID class would introduce greater type safety. Mark existing GUID functions as deprecated. Add tests for the new class. Bug: 1026195 Change-Id: I15d0c8a5907291d48d2e1ddf029390170e81993b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200456 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
spdonghao authored
In this CL, we do two changes: 1. Add a start surface check in ToolbarManager#ToolbarNtpDelegate#isLocationBarShown. Before[1], this returns true even if it's in start surface v2 homepage, that causes the ToolbarPhone[2] set background color transparent[3]. [1] Demo: https://drive.google.com/file/d/1dPJwI4lK-9ch5Wwnx06oY9IIXenLIGzr/view?usp=sharing [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java;drc=5b8933e94139a0ab5be46141666fdfcce0f624f6;l=2366 [3] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java;drc=5b8933e94139a0ab5be46141666fdfcce0f624f6;l=712 2. Add a shrink animation for omnibox when it's about to be scrolled up and toolbar container is showing. Please see demo (The left one is the fixed one): https://drive.google.com/file/d/1jRfYGx9lD3UfxaTabhaNe9Cs_YWTJt2J/view?usp=sharing Bug: 1113852, 1136595 Change-Id: I549223c7a8b7c2e2f56ab62e0d0a090e1185fc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517544 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827029}
-
adoneria authored
This is an attempt to fix the error where mac builder is not able to find file /opt/s/w/ir/cache/builder/src/out/Release/gen/chrome/updater/version_info.py. Bug: 1148430 Change-Id: I671f32660913c03f0fa61c993e4fcb027c00f3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535220Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#827028}
-
Joel Hockey authored
Refactor only change. Move data conversions into FileHelper where path translation and file sharing for VMs can be done. The current code assumes only Arc is using this code, but we will soon support crostini and pluginvm. FileHelper::GetFilenames receives a list of files from the source window and returns a list of ui::FileInfo. To support this, DragDropOperation::GetFilenames has been refactored to take FileHelper and aura::Window*. FileHelper::GetMimeTypeForUriList now takes target window since the mime type will be different based on target. FileHelper::GetUrlFromPath changed to SendFileInfo which takes a callback to run when data is ready. The async callback allows files to be shared with a VM before sending the data. FileHelper::GetUrlsFromPickle changed to SendPickle which also takes a callback to run when data is ready. Bug: 1144138 Change-Id: I0356d4681705df5be174ac1debff51f4903eb742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531087 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#827027}
-
Roman Arora authored
This is a reland of 74dbe648 This CL was reverted because of a flaky test in TabSearchAppTest. The test 'Verify ShowUI' was originally flaky and is now disabled with: https://chromium-review.googlesource.com/c/chromium/src/+/2533325 This is no longer an issue since this test is disabled. Original change's description: > Tab Search: Infinite list component > > A list component that renders DOM items on demand based on the viewable > scroll area and user navigation and scrolling interactions. Provides a > performance gain for use cases where users have several dozens of items > that should be available while scrolling the list by deferring scripting > and rendering costs until necessary to fill the current scroll view. > > Bug: 1099917 > Change-Id: Ib22c0edf5ebc5febe3d8d6d4f7d8ac319e9bd0a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503401 > Commit-Queue: Roman Arora <romanarora@google.com> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826287} Bug: 1099917 Change-Id: Ief4a032b3e66957576e5ce3677159345d1de9c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535013 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#827026}
-
Frank Liberato authored
Also removes "Allow copy" finch param. Code now uses "enabled" path. Bug: 1147960, 1022246 Change-Id: Ie3e7fcb85b2ed2a4ef67e41b0777aec137521bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533039 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#827025}
-
Will Harris authored
Change-Id: Ibb6f8213ef0892885cdcad3a3dd4d04e111a1edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535797Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827024}
-
