- 25 Jun, 2020 22 commits
-
-
dpapad authored
Bug: None Change-Id: I0aed7f841bcf6d9487aa16068a790ab64ffa1b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265189 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#782167}
-
Charlene Yan authored
Bug: 1018320 Change-Id: Id53c0cc6fecb825e705c886d780238d962c56c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265238Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782166}
-
wutao authored
This is a work around to not curate personal photos. Batch size 2 seems the max number will not get server side curation. Bug: b/158256201 Test: manual Change-Id: I9b9dcfd81c32f8db3dadd2552fcb5475f0638080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263234 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#782165}
-
Asanka Herath authored
Includes some fixes for issues found by `gn check` in the `privacy_budget` directories. Bug: 973801 Change-Id: Iad543786ea08108a165dc08fc6b7c7794e14f5e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251090 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#782164}
-
Nigel Tao authored
Skia-uses-Wuffs is still disabled by default in Chromium, but when enabled, it now uses a newer Wuffs version, the same as upstream Skia. New in Wuffs v0.3 is a finer sub-division of the base module, but the main reason to upgrade is to track upstream Skia. Change-Id: I5d0e152d45cccc24389a8091f93728047742943a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256918Reviewed-by:
Leon Scroggins <scroggo@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#782163}
-
Lijin Shen authored
'Always' matches TC ID 5575222334666843269 better in the context of default browser promo. See b/159047072 for more details. Bug: NONE Change-Id: Ic33649bbbb15bcbb5eb2534c3ee3ec6974928e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265334 Commit-Queue: Lijin Shen <lazzzis@google.com> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#782162}
-
Daniel McArdle authored
Rather than re-parsing the domain lists every time we check if a domain is experimental or control, we can just cache the result in a flat_set after parsing. Bug: 1052476 Change-Id: Ib47b300117c8c2d7e99e0332f6a8f699cdd13297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255650Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#782161}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4c9667c115b0..84c7f9877e9c 2020-06-24 tmathmeyer@chromium.org Adds unit tests for some of the helper code for the TickingFlameChart If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie46a71d21f791f68ae0530076e3257796fd9bd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782160}
-
Trent Begin authored
This change moves the mojom file to chromeos/services/network_health to be inline with the network_health.mojom file. It also creates an intstance of network_diagnostics_impl in the network_health_singleton. Bug: chromium:1098405 Change-Id: I48bde033494fefc2ac1769421711cc401ef4527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261184Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782159}
-
Reilly Grant authored
This change updates the serial port enumerators for Linux and macOS to read the serial number (if available) for USB devices and use this to construct a persistent ID for these devices. This means that only USB devices will have permissions stored persistently. Support for remembering other types of devices will be investigated in the future. Bug: 908836 Change-Id: I28c53b880e69723447c445d447d677f2799c2ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265357 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#782158}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b67fc374022a..f08ecebda15a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chcunningham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1092973,chromium:1098984 Tbr: chcunningham@google.com Change-Id: I37964a2b60ebe3db944ae6fa52a93a9e7e414afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265283Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782157}
-
John Lee authored
Bug: 1082344 Change-Id: Ied871842af5ef7005ec252c4528dc54530af3dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261417Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#782156}
-
Gang Wu authored
The goal of this change is to keep all clipboard suggestions bundled together and recognized as a common type. Currently different 'flavors' of clibpoard suggestions are treated differently, specifically the clipboard suggestion hosting a URL is demoted to the bottom of the suggestions list, and as a URL suggestion - is frequently dropped by SortAndCull. The issue is, 1. Search is higher than other suggestions. 2. clipboard suggestions's score is lower than zero suggestions. So this CL first mark clipboard text and image is search suggestions, and also give clipboard suggestion a higher score. Bug: 1091952 Change-Id: Ibf169ca1d18af58ed6de3efabfec0a7e3ff43d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259380 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#782155}
-
Jason Lin authored
Bug: 1087726 Change-Id: I7c64be4ca2069b7eae447760040242a2b5f0862e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262313Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#782154}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If7f4a21d823439d46b3e9eaa6056f2143a81513b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264031Reviewed-by:
-
Garrett Beaty authored
This is a re-land of https://crrev.com/c/2199978 now that we are moving forward with project-based milestones. Bug: 1056428 Change-Id: I59a40fa865ba1ced48fc7cd817d8086487ea036e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264206Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#782152}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593018578-236971dc116ecc25bb19bba334b12df71f24465e.profdata to chrome-win64-master-1593028798-f93250a81e374d70a67d584bcb245354b4612f62.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I6fa5d73c69c549274d3ef1722b1c2daaa6601fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264925Reviewed-by:
-
Reilly Grant authored
This change simplifies the management of data pipes by replacing the ClearSendError() and ClearReadError() messages with a StartWriting() and a StartReading() message, and no longer accepting the initial set of data pipes in the Open() message. This is in preparation for implementing flush and drain on the serial port, as these operations will close the data pipes for reasons other than errors. Bug: 989653,989656 Change-Id: Ib20893c6c54dd7c2f22f13684caea6d1cd2a39c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242006 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Rachel Wong authored
This CL does two things: 1) Remove the row_container_. This previously existed so that there could be an empty border outside the row. However, we can simplify the layout so that it has only one border and container. 2) Change the way PrivacyInfoView calculates its height, so that it does not depend on the child's height or include magic numbers. Bug: 1079169 Change-Id: I137bc57d431971974650a31cf7da84a3d9492ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255727Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#782149}
-
Erik Jensen authored
CGEventKeyboardSetUnicodeString seems only to handle up to 20 code units. In addition, this allows us to inject newlines correctly. Change-Id: If7d78f1a66416d5e3c435bd856f47171c0b20c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264946Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#782148}
-
Lukasz Anforowicz authored
Given: template <typename... TArgs> void GetViaTemplateParamPackRValue(TArgs&&... param_pack) {} Any argument passed to GetViaTemplateParamPackRValue will be matched by forEachArgumentWithParam(..., parmVarDecl(hasType(referenceType()))) Before this CL, the scenario above has undesirably led to marking fields used as such arguments as "in-out-param-ref" and skipped. After this CL, ParmVarDecl's with RValueReferenceType are excluded from the matcher than emits "in-out-param-ref" field filters. Bug: 1069567 Change-Id: I183a96f5dea30b90737727a6453f4678c4753a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239681 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ba416f33b636..36bfd8956dd0 2020-06-24 bsheedy@chromium.org [Telemetry] Fix LFBM exception handling 2020-06-24 utzcoz@gmail.com atrace_agent: Support /sys/kernel/tracing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1098683 Tbr: oysteine@google.com Test: Test: catapult/telemetry/bin/run_tests --device=android --test-filter=*tracing* --browser=android-webview-bundleTest: Test: catapult/telemetry/bin/run_tests --test-filter=*tracing*Test: Test: use systrace to capture atrace with emulator supports debugfs and Change-Id: I148c4668da60d166bf4c1db4cb0e5bbf0093adf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265272Reviewed-by:
-
- 24 Jun, 2020 18 commits
-
-
Li Lin authored
Based on feedback, update the notice which better represents the functionality of the feature and includes relevant information about the user's selection. Mock at: go/quick-answers(slide 28) Bug: b/159167345 Test: manual tests Change-Id: I28df28fb025e42292ccdf5eb4d273c5b78a056d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250586 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
-
Chris Cunningham authored
At default of 80, we're seeing regular timeouts for the swarming task. Bug: 1099049 Change-Id: I9b1c2a66fc15cad0ef3e5382780b95015d8c7ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265454Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#782144}
-
Chris Blume authored
CC has an ImageType to indicate the difference between Jpegs and Pngs, for example. I believe that name then became used in other places where it isn't quite right. When MIME types are being used, the functions named with *ImageType* aren't the correct fit. This CL renames those functions to *MimeType*, leaving *ImageType* in place when it is appropriate. Change-Id: I23cb4d0917459cb070f2ed88f0e9ffe6219124f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264024Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#782143}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/75fd127640bd..1b485322085d 2020-06-24 sprang@webrtc.org Revert "Allows FEC generation after pacer step." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0462d655dc1cd341d7e39902ea5eebbc26c957f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264920Reviewed-by:
-
Thomas Guilbert authored
To adjust the playback rate of audio, we use two algorithms: resampling, which shifts the audio's pitch, and WSOLA, which doesn't. At rates close to 1.0, WSOLA can introduce undesirable artifacts for certain types of, audio content, so we use resampling instead. However, this pitch shift is noticeable can be less desirable than the WSOLA artifacts to some users. This CL implements the preservesPitch flag, which is already present in Firefox and Safari. The flag allows web developers to choose between pitch preserving and pitch shifting time stretch algorithms (resampling and WSOLA in our case). This will allow users to chose the algorithm that suites their needs at playback rates close to 1.0. It will also allow users to use resampling at lower or higher playback rates, when pitch shifting is desirable for aesthetic or performance purposes. Bug: 1072067, 1096238 Change-Id: Ie0e7ff337da77c902a12259c30c33125104101ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255179 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f8393bee83f1..d626fbec817d 2020-06-24 rwkeane@google.com Code Coverage: Force Full Repo Coverage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I5bfba72245c68c33fc9e33eabd0b4ef2e6f7d8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264924Reviewed-by:
-
Yang Guo authored
This reverts part of 5abacc3b and restores the query param 'debugFrontend', which makes the frontend load resources locally rather from remote URL. R=caseq@chromium.org, paulirish@chromium.org, tvanderlippe@chromium.org Fixed: chromium:1098505 Change-Id: I61330d4f679fb280245e98122ac23d0031e89e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263733 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#782139}
-
Mitsuru Oshima authored
Bug: 1090616 Change-Id: I4d42843663c63bc57d7c2c5d6c92c1232c5f9455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250474Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#782138}
-
Eric Roman authored
* Exclude un-triaged bugs with Needs-Feedback * Add sorting by number of stars Change-Id: I600faa5f3f9b48a38b4e75c7874357dbc22c4b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265183Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#782137}
-
Stephanie Kim authored
Bug: 1072012 Change-Id: I3df4b4fc8b89b20e54339c2c1c802e7737282dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261704Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#782136}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/55c5fa2666a8..054aeeed3b4c 2020-06-24 cclao@google.com Vulkan: Batch vkUpdateDescriptorSets calls 2020-06-24 ianelliott@google.com Vulkan: Fix glBlitFramebuffer() for pre-rotation 2020-06-24 cwallez@chromium.org Suppress TextureTest failure on NVIDIA Shield. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Test: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_\*Test: Test: angle_end2end_tests --gtest_filter=*EGLPreRotationLargeSurfaceTest.OrientedWindowWithBlitFramebuffer Change-Id: Id3c8b10a5d0230375e70441b02c95f90647be77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264836Reviewed-by:
-
Bruce Dawson authored
Adding a SegmentHeap entry to the chrome.exe manifest will tell recent-enough versions of Windows (20-04 and beyond) to opt chrome.exe into using the segment heap instead of the legacy heap. Details are in the bug but it appears that the default Windows heap is tuned for server workloads where throughput is what matters most, and Chromium (especially due to its multi-process architecture) also has to care about memory footprint. Experiments with per-machine opting-in to the segment heap for chrome.exe suggests that this could save hundreds of MB in the browser and Network Service utility processes, among others, on some machines. Actual results will vary widely, with the greatest savings coming on many-core machines. In order to avoid build warnings this change depends on switching to building with the Windows 10.0.19041.0 (20-04) SDK. The initial investigation of this is in crbug.com/982452. Bug: 1014701 Change-Id: I217d045ee0d365ac57f7a73b0f5ed456469214c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163163 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#782134}
-
Bo Liu authored
There is no change on the renderer side. Just hook into the existing RenderFrameMetadata::new_vertical_scroll_direction and bubble up that to the embedder. Compute the scroll ratio in RWHVA. The API is specifically made to be extensible, and new types such as scroll start or end may be added in the future. Bug: 1076473 Change-Id: I8c539588468d39da9095b0eb23bb61249d06b7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264760Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782133}
-
Joe DeBlasio authored
This CL does three things to the target embedding heuristic. It: 1. detects embeddings with multi-label eTLDs (eg. google.co.uk), 2. allows finer-grain matching against engaged sites, so that if a user has engaged with foo.bar.com, and that entire domain is embedded, it can recommend the full domain (not just the eTLD+1 bar.com), and 3. removes support for cross-TLD matching. This is a significant re-write, and the cross-TLD ("enhanced protection") matching was removed because it kept the implementation simpler, and we've decided that we couldn't ship that capability without further tweaks anyway. I may re-add it in a future CL. Bug: 1092570, 1098473, 1087636, 1075659 Change-Id: Ia30bd2025ca938c8431ab22300c6e2e8de2a658c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261424Reviewed-by:Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#782132}
-
Dan Harrington authored
On first run, when the user signs in, we were making a signed-out FeedQuery request. This happened because the IdentityManager hadn't yet gotten any signals about the sign-in process before the feed surface was opened. This change waits to attach the feed surface (to native) until after ChromeTabbedActivity reaches the right initialization step. Bug: 1044139 Change-Id: Ia55096e8720bb2289ccddef14533caff4cb0c25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261217Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#782131}
-
Mei Liang authored
http://crrev.com/c/2149626 converts the LayoutTab to a PropertyModel and uses the constant start and end animation value when creating the CompositorAnimator for the shrink tab animation. The use of the constant values causes the shrinking tab animates to a wrong position, since the targeted Rect can be changed after the CompositorAnimator is created. This CL fixes the issue by using the Supplier to supply the start and end value. Change-Id: Ife607faa06aadd508816179ad856eadacc3e1e90 Bug: 1096718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254715Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782130}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I52d90c494d13f4e9bb9aeb0ee516a96077d7c63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264941Reviewed-by:
-
Li Lin authored
We decided to defer the translation use case to future milestone. Added a feature flag to gate translation intent. Bug: b/159472031 Test: unit tests Change-Id: I5772750202c2a3862f6efc437db7c82ef58a7652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261877Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
-
