- 17 Apr, 2018 40 commits
-
-
Lei Zhang authored
Valgrind bots are gone. BUG=605605 Change-Id: Ie722b831d0a6fca8b48620e5a9d993896346cbef Reviewed-on: https://chromium-review.googlesource.com/1014956Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#551376}
-
Yash Malik authored
Injecting HOVER_EXIT is done by the platform if the coordinates for the HOVER_MOVE are out of bounds, so we don't need to inject it ourself. Bug: 819348 Change-Id: I4486f9970fac031373215bdcb7021de6a422da02 Reviewed-on: https://chromium-review.googlesource.com/1014715Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#551375}
-
bsheedy authored
Adds an option to the VR bisect script to run in manual mode. This removes the automatic "gclient sync" and waits for user input before building and running the test. This is meant to be used in the rare case that some change in the bisect range breaks gclient sync and requires some DEPS change to fix. This allows the user to manually add in the fix and sync while still allowing the script to handle the building, running, and result retrieval. Change-Id: I7bfd5b7b059dec84b3feefbbc6ada3e01659d30d Reviewed-on: https://chromium-review.googlesource.com/1014460Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551374}
-
Greg Daniel authored
getTextureHandle on SkSurface is deprecated so moving chrome over to the new API. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_vr Change-Id: I55ec116814dbd62237b573da44938bc0a8fe877e Reviewed-on: https://chromium-review.googlesource.com/1010534Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Greg Daniel <egdaniel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551373}
-
Cody Peterson authored
The primary display rotation transforms for 90, 180, and 270 degree rotations have been updated so that located events are properly transformed to the new correct location after being subjected to the inverse root transform. The inverse root transform is used to take the (x, y) reported for a given located event and transform it to a new (x', y') to align properly with the transformation applied to the display graphics. Take the case of a display with the following characteristics: Height = 720 Width = 1280 Under the current case, the inverse root transforms are as follows: 90deg = [0, 1, 0, 0; -1, 0, 0, 720; 0, 0, 1, 0; 0, 0, 0, 1] 180deg = [-1, 0, 0, 720; 0, -1, 0, 1280; 0, 0, 1, 0; 0, 0, 0, 1] 270deg = [0, -1, 0, 1280; 1, 0, 0, 0; 0, 0, 1, 0; 0, 0, 0, 1] With the applied change, the inverse root transforms become: 90deg = [0, 1, 0, 0; -1, 0, 0, 719; 0, 0, 1, 0; 0, 0, 0, 1] 180deg = [-1, 0, 0, 719; 0, -1, 0, 1279; 0, 0, 1, 0; 0, 0, 0, 1] 270deg = [0, -1, 0, 1279; 1, 0, 0, 0; 0, 0, 1, 0; 0, 0, 0, 1] To see that these new transformations are correct, take the 270 degree rotation case and consider the corner points of the display. The corner point transformations under the old and updated transforms are: Old (0,0)-->(1280,0) (719,0)-->(1280,719) (0,1279)-->(1,0) (719,1279)-->(1,719) New (0,0)-->(1279,0) (719,0)-->(1279,719) (0,1279)-->(0,0) (719,1279)-->(0,719) The old transformations take the corner points and incorrectly update them, even outside of bounds for events at (0,0) and (719,0). The new transformations properly map all corner points. The same behavior can be observed for 90 and 180 degree rotations as well. BUG=None TEST=Check on devices with 90, 180, and 270 degree rotations Change-Id: I2d56cf1a4e871d3a08a886bc218fff7262157b73 Reviewed-on: https://chromium-review.googlesource.com/982373Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Cody Peterson <crpeterson@chromium.org> Cr-Commit-Position: refs/heads/master@{#551372}
-
Emily Hanley authored
Bug: 779631 Change-Id: Id4848d02863e3e1533171495f56041eb8c5ec347 Reviewed-on: https://chromium-review.googlesource.com/1014954Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#551371}
-
Adrienne Walker authored
Chromium-side changes for: https://skia-review.googlesource.com/c/skia/+/120608 Bug: 829614 Change-Id: I59dc05ae1d66622ce3c771311ec3e1b64023b66f Reviewed-on: https://chromium-review.googlesource.com/1008924Reviewed-by:
-
mrefaat authored
Bug: 833872 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6c06c7e031dd2fcf8569c377e1d4696b45e007ca Reviewed-on: https://chromium-review.googlesource.com/1014714Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#551369}
-
Jonathan Backer authored
This CL does several things: - Adds TransferCache methods to RasterDecoderImpl. This is copy-and-paste from GLES2DecoderImpl (including OOP-R setup). - Switches InProcCommandBuffer to use either RasterDecoder or GLES2Decoder based on ContextCreationAttribs. Logic for decision copied from GpuChannel. - Adds RasterInProcessContext for use by tests (copy-and-paste from GLInProcessContext but simpler). - Parameterizes TransferCacheTest to test both RasterDecoder and GLES2Decoder Bug: 789238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2629f0a9469abfaaf10b10ae28076d3e0881eb66 Reviewed-on: https://chromium-review.googlesource.com/1011104Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#551368}
-
Hans Wennborg authored
lld is LLVM's linker. It produces PE/COFF and PDB files just like link.exe, but it's significantly faster and it can also handle LLVM's internal representation, which will enable us to do link-time optimization and control-flow integraty checks with Clang. While lld is much faster at linking, it doesn't support incremental links, meaning builds that only touch a few files and re-link a large executable may become slower. This is the first attempt at switching everything over, with the purpose of gathering data and finding unknown unknowns. It's likely temporary until something breaks. is_win_fastlink is implicitly ignored when using lld, as lld without fastlink is faster than link.exe with it. Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's link.exe to make sure that configuration keeps working. Bug: 792131 Change-Id: I0f115a78c33d69eadbd480f75c2a5d636e86483d Reviewed-on: https://chromium-review.googlesource.com/983632 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551367}
-
Vaclav Brozek authored
This data member is not used. Bug: 833838 Change-Id: I0b1483ffb9195284de70f2b0649f431c0278345e Reviewed-on: https://chromium-review.googlesource.com/1013980 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#551366}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 02ba7243. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15711 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ecobos@igalia.com: external/wpt/css/css-display TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Iba62be41f86519a7e862eef4eaa1a27514dd666e Reviewed-on: https://chromium-review.googlesource.com/1015060 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551365}
-
Robert Ogden authored
Removes the histograms and related code, as well as what little helper functions were added when these histograms were added. Bug: 657541 Change-Id: I4bebf6d2b70fad9c0eb6b40edea9507f61e9bae3 Reviewed-on: https://chromium-review.googlesource.com/1014344Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#551364}
-
Sky Malice authored
Change-Id: I702a1a074b24961ba22ffed45fb856bd950f8dbc Reviewed-on: https://chromium-review.googlesource.com/1014372 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#551363}
-
Artur Khachatryan authored
Test CorrectEventFiringTest.testSubmittingFormFromFormElementShouldFireOnSubmitForThatForm has become flaky on Android Chromium build bot. Disabling test. Bug: chromedriver:2286 Change-Id: I6f2fca1b9f74669a3796f1b9868f6314e541b882 Reviewed-on: https://chromium-review.googlesource.com/1014713Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551362}
-
bsheedy authored
Adds early returns to XRWebGLDrawingBuffer if the drawing buffer client is null. This fixes a segfault that was causing a renderer crash when exiting (or entering?) WebXR presentation. Bug: 833620 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iaf03bff95f542da63e871b1abf8a96e1b0b29d7f Reviewed-on: https://chromium-review.googlesource.com/1014480Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551361}
-
Conley Owens authored
Just one more step in Removing the Physical Web from Chrome. BUG=826540 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2b99e83a64a0c655c37569cb7d9f0924bbfb6948 Reviewed-on: https://chromium-review.googlesource.com/988954Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#551360}
-
Alexei Svitkine authored
This reverts commit c3884364. Reason for revert: This has unintended consequences for Android Webview. Reverting so that the logic can be updated to not log the field for webview when the CL is relanded. Original change's description: > Update system_profile.proto. Populate app_package_name > > Bug: 833214 > Change-Id: I5552bdca37a2e3e20a039b9a0ca316f4480b1217 > Reviewed-on: https://chromium-review.googlesource.com/1010055 > Commit-Queue: Shuo Weng <shuow@google.com> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551296} TBR=asvitkine@chromium.org,wychen@chromium.org,shuow@google.com Change-Id: I3c14d6f4b1a565d651c69be5d11a28959149f0c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 833214 Reviewed-on: https://chromium-review.googlesource.com/1014205Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#551359}
-
Victor Costan authored
Bug: 829893 Change-Id: I892ab0504e87ea2c6f65bdf932b030e6a7589f2b Reviewed-on: https://chromium-review.googlesource.com/998982Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#551358}
-
https://pdfium.googlesource.com/pdfium.git/+log/6b26e1ae6932..3900ddb64f30 $ git log 6b26e1ae6..3900ddb64 --date=short --no-merges --format='%ad %ae %s' 2018-04-17 thestig Add a virtual CPWL_Wnd::GetText() method. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idd6d94a554ab292fea802bd28549f1e82b4a3d69 Reviewed-on: https://chromium-review.googlesource.com/1014953 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551357}
-
Artem Titov authored
Don't depend on //base for webrtc standalone build, because it breaks webrtc compilation Bug=none Change-Id: I68bb4400e858a008ba6dfb7debfe6f6a6237b9ca Reviewed-on: https://chromium-review.googlesource.com/1013574Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Artem Titov <titovartem@chromium.org> Cr-Commit-Position: refs/heads/master@{#551356}
-
Katie D authored
NOTRY=true TBR=dmazzoni@chromium.org Change-Id: I52c8cb2287f31554f5c6faab740ebd701b135eed Reviewed-on: https://chromium-review.googlesource.com/1013693 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#551355}
-
Christopher Grant authored
The method that now draws all our textures was missing a dedicated trace event. Add it for easier developer profiling. BUG= R=tiborg Change-Id: I05e318b49dac4f36e768cba5010228904d06053a Reviewed-on: https://chromium-review.googlesource.com/1014332Reviewed-by:
-
Mounir Lamouri authored
This is allowing the user to use Tab and up/down keys to navigation throughout the menu. It can also be closed using the Escape key. This change also trap the focus inside the menu while it's visible and make it so that hovenig an item will move the focus to it, like most menus will do. This is mostly for accessibility so users can interact with the controls using only a keyboard. The change applies to both the overflow menu and the text track list. Bug: 821131 Change-Id: I22db341d0d55a8e3297b3c7a18c92331e296cd9e Reviewed-on: https://chromium-review.googlesource.com/1013478Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#551353}
-
Bernhard Bauer authored
Opening multiple custom tabs in quick succession can lead to flakiness, so load a new URL in the same tab instead. Also use the correct icon for offline pages. Bug: 833569 Change-Id: I87e83f65bd8883146398e5ddd9dfd7a7acd2a5c8 Reviewed-on: https://chromium-review.googlesource.com/1013923Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#551352}
-
Peter E Conn authored
GURLUtils.getOrigin returns an origin formatted with a trailing slash because it calls GURL::GetOrigin which returns a GURL, then serializes this URL. This seems to be incorrect behaviour as more generally an origin is serialized without a trailing slash. GURLUtils.getOrigin is used by AwGeolocationPermissions.java where the returned value is saved to the user's Android Preferences. This means that changing its behaviour would be tricky. For now, I'm updating Origin.java to serialize without a trailing slash and documenting the deviance in behaviour between the two. Bug: 827161 Change-Id: Ia70f8a60263742b28477f969cc075dcb97062f48 Reviewed-on: https://chromium-review.googlesource.com/1013483Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#551351}
-
John Chen authored
Fix another race condition in frame detach sequence, found by stress testing. Change-Id: Ie342733a8627bfd36074d38b73209c751ba519dc Reviewed-on: https://chromium-review.googlesource.com/1014506Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551350}
-
Benoit Lize authored
Feature has been approved to launch in M67, see https://crbug.com/817854. Bug: 816837 Change-Id: Ibe2699ad633b3c9ae01cbfff91293a6ab7a77859 Reviewed-on: https://chromium-review.googlesource.com/1013487Reviewed-by:
-
wutao authored
This cl adds TODO to remove the dependency on aura::Window in Keyboard Shortcuts Viewer. In addition, this cl removes unused deps and include. Bug: 833673 Test: Manual Change-Id: Icc4fd0726cace1971674e371bb5053b20575933b Reviewed-on: https://chromium-review.googlesource.com/1014663Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551348}
-
Lindsay Pasricha authored
Bug: 828031 Change-Id: Ie16b147a49c08ea743b482e8bb7fc0a04b22938a Reviewed-on: https://chromium-review.googlesource.com/1011783 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#551347}
-
Oksana Zhuravlova authored
Bug: 646113,799482 Change-Id: Ib8bd6fa6b9bda30133b135778a47058d7e8efc1c Reviewed-on: https://chromium-review.googlesource.com/1012438Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#551346}
-
rbpotter authored
PrintJobWorkerOwner has very little implementation that is actually shared between PrintJob and PrinterQuery (task_runner_). Moreover, in all cases where PrintJobWorker refers to its owner, only one of the two subclasses is actually acceptable. Make this more clear by removing this class. Bug: None Change-Id: Icaf5ff15ee5856dcade54fc4b64bb92539dc7a6f Reviewed-on: https://chromium-review.googlesource.com/1013118Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#551345}
-
Florin Malita authored
After https://chromium-review.googlesource.com/c/chromium/src/+/581748 we no longer flatten SharedBuffers in GetRequestBodyForWebHTTPBody() but instead pass segmented data downstream (multiple DataElements). This minimizes unnecessary reallocations/copies in general, but relies on downstream clients being able to handle segmented data (or flatten it on the fly if really needed). Turns out WebRequest's FormDataParsers assume the input buffers are flattened (or segmented along expected chunk boundaries for multipart). This CL adds a buffering mechanism to ParsedDataPresenter which flattens consecutive byte segments before passing down to the parser. BUG=831169 Change-Id: Ibea9193ff783cad0c80bb9722f719ff063b65720 Reviewed-on: https://chromium-review.googlesource.com/1011322 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#551344}
-
Han Leon authored
This CL aims to mojofy the last one legacy IPC ServiceWorkerMsg_ServiceWorkerStateChanged, then service worker code finally enter the pure Mojo world! Currently ServiceWorkerRegistrationObject and ServiceWorkerContainer are channel-associated interfaces. For correctness, ServiceWorkerObject needs to have FIFO ordering with those interfaces, which means it would need to be a channel-associated interface as well. But when used for service worker execution contexts, we have been binding channel-associated interfaces on the IO thread rather than the service worker thread due to constraints of channel-associated interfaces.[1] But we want ServiceWorkerObject to be bound on the service worker thread. Actually we want SWContainer and SWRO to be bound on the service worker thread too instead of bouncing to the IO thread. Until now, we have worked around this using hacks like CallbackWrapperOnWorkerThread to mediate between the IO thread and service worker thread. But we do not want to keep doing these hacks. Since we no longer have legacy IPCs, there is no need for these interfaces to be channel-associated interfaces. So this CL makes these no longer channel-associated interfaces so they can be bound on the service worker thread directly. [1] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/RDO46Py0F3s Based on the above analysis, this CL goes a long way to introduce ServiceWorkerObject interface. This CL: ps#1 - firstly decouples EmbeddedWorkerInstanceClient interface from the world of Channel-associated interfaces, makes it use a dedicated Mojo message pipe, this turns out to make its several attached interfaces not be Channel-associated interfaces, either, like ServiceWorkerRegistrationObject, ServiceWorkerHost etc. ps#2 - then, for service worker execution contexts, starts to bind endpoints for interfaces like ServiceWorkerHost, ServiceWorkerObject[Host], ServiceWorkerRegistrationObject[Host] etc. on the service worker thread directly, rather than binding them on the IO thread and using PostTask to actually send/receive Mojo messages on the worker thread, this had been forced to be so because they were Channel-associated interfaces before. ps#6 - after the above preparations, introduces ServiceWorkerObject interface and mojofies the state changed legacy IPC, it's also associated with EmbeddedWorkerInstanceClient interface and now we can just bind its receiver endpoint directly on the service worker thread. Follow-up work: - CL https://chromium-review.googlesource.com/c/chromium/src/+/981898 Associate all interfaces living on the service worker thread with ServiceWorkerEventDispatcher interface rather than current EmbeddedWorkerInstanceClient interface. This will not only guarantee the FIFO ordering with ServiceWorkerEventDispatcher, but also make all Mojo messages dispatch skip the main thread completely to avoid possible congestion. - Fix the layout test external/wpt/service-workers/service-worker/skip-waiting-installed.https.html which becomes flaky due to this CL. - Remove channel-associated interfaces entirely for service worker code. This CL makes interfaces for SW execution contexts to be not channel-associated. A follow-up CL will make the same change for interfaces for SW client contexts. BUG=772788,783071 Change-Id: I3a6a666a41b4edc2289dceee6e071ef9510e2012 Reviewed-on: https://chromium-review.googlesource.com/967863 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#551343}
-
Josh Karlin authored
Add UKM for time before a popup is closed and whether it was closed due to user gesture or not. Bug: 825875 Change-Id: I9cd9abf40ee11c8404c7629b62cbdadc6b4069c9 Reviewed-on: https://chromium-review.googlesource.com/1005317 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#551342}
-
Yngve N. Pettersen authored
The parameters to setup_toolchain changed, adding an OS parameter and a filename for the environment file. Additional fixes: - Add missing base file to list of files - vs_toolchain should output Windows paths properly escaped Change-Id: I0e05bf34c8b603f16b901e76164e480121ed9d14 Reviewed-on: https://chromium-review.googlesource.com/1013926Reviewed-by:
-
Jérôme Lebel authored
This patch is to implement unified user consent dialog. This dialog is not used yet. This dialog will be used by ChromeSigninViewController in the workflow of sign-in. This dialog has 2 goals: - Asks to the user to choose an account - Shows the user consent to the user Some assets are not ready and are shown in red. The strings are not final neither. Implementation: with identity: https://drive.google.com/open?id=1ebwI5_pmWCuz09x-zJQYCuJIKxKoLVH5 https://drive.google.com/open?id=1WUdN_NtzF74tn28HaRwpqbUZ3L2vtJS8 https://drive.google.com/open?id=1zSBHzGsk-vwuhL4fJQw0vsDZ7sDzCwnk https://drive.google.com/open?id=1rWf_KT6hnKHUvtEoAYA3wr7koyepXEXF without identity: https://drive.google.com/open?id=1HQjRFu_cODRzKY2ZKpyJ7hTjJMXPjEui Mock: https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g353bc22139_3_19 Related to previous patch: crrev.com/c/995417 Related to next patch: crrev.com/c/1010346 Bug: 827072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I706c6024ff59d1c7870a39afcc04443e88dcb6dc Reviewed-on: https://chromium-review.googlesource.com/1009906 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551340}
-
Tom Anderson authored
This is a reland of 961ea628 Chromium r550608 has rolled clang to r329921, which includes the build fix. Original change's description: > Revert "Add more unbundle packages to sysroots" > > This reverts commit b828d53c. > > Reason for revert: Causing a build failure on Google Chrome Linux x64 > https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/29741 > > /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: exp2f@GLIBC_2.2.5 > >>> defined in obj/third_party/swiftshader/src/OpenGL/compiler/swiftshader_opengl_compiler/Intermediate.o > >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Context.o > /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: exp2f@GLIBC_2.2.5 > >>> defined in obj/third_party/swiftshader/src/OpenGL/compiler/swiftshader_opengl_compiler/Intermediate.o > >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Sampler.o > /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: powf@GLIBC_2.2.5 > >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Surface.o > >>> defined in obj/third_party/swiftshader/src/Shader/swiftshader_shader/Constants.o > /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: powf@GLIBC_2.2.5 > >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Surface.o > >>> defined in obj/third_party/swiftshader/src/Common/swiftshader_common/Math.o > > Original change's description: > > Add more unbundle packages to sysroots > > > > The new packages are necessary to test unbundling of flac, libxslt, and zlib. > > > > BUG=800977 > > R=thestig > > TBR=mark > > > > Change-Id: I2c5f88b3819ce000e906cf303fdffa30bdde84cb > > Reviewed-on: https://chromium-review.googlesource.com/981451 > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#549303} > > TBR=thakis@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,mark@chromium.org > > Change-Id: I90188d22140d7cdd60f8bbea5b0e88705e498988 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 800977 > Reviewed-on: https://chromium-review.googlesource.com/1003532 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549314} Bug: 800977 Change-Id: I6b5deb3cd3c2d6ab77dfd904eb641744b88d2231 Reviewed-on: https://chromium-review.googlesource.com/1012903Reviewed-by:
-
John Budorick authored
TBR=tandrii@google.com Bug: 776496 Change-Id: Ibca4e9ee732042e95fa10843f79d44c099bbaab9 Reviewed-on: https://chromium-review.googlesource.com/1010799Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#551338}
-
Allen Bauer authored
Proposal: https://docs.google.com/document/d/1KrKEWSK64es3W3LYKQUpvwMzUJqTz8owFGXuJQqeXzs/edit?usp=sharing Bug: 806936 Change-Id: Id086f9835a710cf2165f4ba8bd07904229301b67 Reviewed-on: https://chromium-review.googlesource.com/946554 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#551337}
-
