GitLab

BUG=448707

Review URL: https://codereview.chromium.org/818773005

Cr-Commit-Position: refs/heads/master@{#311492}

This allows PictureImageLayers to be rendered when running with
--enable-slimming-paint.

BUG=448447

Review URL: https://codereview.chromium.org/853463004

Cr-Commit-Position: refs/heads/master@{#311491}

- Produce nacl_helper_nonsfi binary in out/{Debug,Release}
- Enable all transitional non-SFI browser tests on ARM

BUG=433201, 372049
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_arm

Review URL: https://codereview.chromium.org/794573002

Cr-Commit-Position: refs/heads/master@{#311490}

Pulls in the following changes:

 f731837 - Fix v8 external snapshot code for Windows.
 7900739 - Merge to master: Fix include paths for pdfium_unittests under chromium checkout
 476cd69 - Add APIs for getting bookmarks and named destinations.

BUG=421063, 439661

Review URL: https://codereview.chromium.org/850043003

Cr-Commit-Position: refs/heads/master@{#311489}

embedded webview.  The length of the string was not correctly calculated.

BUG=None

Review URL: https://codereview.chromium.org/848943003

Cr-Commit-Position: refs/heads/master@{#311488}

This code was leading to a crash:
scoped_nsobject<MyClass> a([[MyClass alloc] init]);
scoped_nsobject<NSObject> b(a);

Because |a| is converted to raw pointer, and |b| is constructed with the
raw pointer, without calling retain. This creates a subtle crash later on
when the scoped_nsobject are destroyed.

This code however, was not crashing:
scoped_nsobject<MyClass> b(a);
Because in that case the copy constructor is used.

This was somewhat inconsistent and bug prone, especially if the type of
|a| is changed. In that case the type of |b| must be changed at the same
time, or it causes a crash.

This CL introduces a new constructor for the scoped_nsobject variants
that allows passing a scoped_nsobject of a different type.
It is consistent with scoped_refptr which also has this constructor.

Review URL: https://codereview.chromium.org/848033006

Cr-Commit-Position: refs/heads/master@{#311487}

BUG=

Review URL: https://codereview.chromium.org/816833006

Cr-Commit-Position: refs/heads/master@{#311486}

Replaces the outdated Kittens tutorial with a new getting started tutorial that uses the Google Image search API.

BUG=383385
NOTRY=true
R=kalman@chromium.org,mkearney@chromium.org

Review URL: https://codereview.chromium.org/732943002

Cr-Commit-Position: refs/heads/master@{#311485}

In the past Chrome for Android developers have excluded this directory using
src/.git/info/exclude or simply ignored it.

It's time to add it to .gitignore, since we already have
/third_party/android_tools_internal in there, and the codename isn't public
(https://plus.google.com/+FrancoisBeaufort/posts/AJwwscC1KxN).

Review URL: https://codereview.chromium.org/815353004

Cr-Commit-Position: refs/heads/master@{#311484}

Review URL: https://codereview.chromium.org/796063005

Cr-Commit-Position: refs/heads/master@{#311483}

The patch is to be reverted a few days later when we have a crash report with the new stack trace.

BUG=396900

Review URL: https://codereview.chromium.org/854593002

Cr-Commit-Position: refs/heads/master@{#311482}

BUG=446607

Review URL: https://codereview.chromium.org/839063003

Cr-Commit-Position: refs/heads/master@{#311481}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/26a00de..8018e68

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/817793005

Cr-Commit-Position: refs/heads/master@{#311480}

Update the AOSP prebuilts/ndk target to include fixes necessary to use
libc++ <atomic> on Android.

BUG=427718

Review URL: https://codereview.chromium.org/846633003

Cr-Commit-Position: refs/heads/master@{#311479}

Review URL: https://codereview.chromium.org/850923002

Cr-Commit-Position: refs/heads/master@{#311478}

None of these changes should change the behaviour of the
scripts with the exception of rst_index.py which now takes
both output and input as positional parameters since they
are both required.

TEST=./test_all.py

Review URL: https://codereview.chromium.org/720233003

Cr-Commit-Position: refs/heads/master@{#311477}

The deletions-only check is causing a lot of issues with the upstreaming
effort, so I'm disabling it temporarily.

BUG=

Review URL: https://codereview.chromium.org/820053003

Cr-Commit-Position: refs/heads/master@{#311476}

BUG=366349

Review URL: https://codereview.chromium.org/829133009

Cr-Commit-Position: refs/heads/master@{#311475}

BUG=443613
R=sergiyb@chromium.org

Review URL: https://codereview.chromium.org/844263005

Cr-Commit-Position: refs/heads/master@{#311474}

Add a virtual destructor since all class with a virtual method should
have a virtual destructor.

Disable copy constructor and assignment operator using the macro
DISALLOW_COPY_AND_ASSIGN since you don't want to do slicing when
using a class with virtual methods.

BUG=None

Review URL: https://codereview.chromium.org/853643003

Cr-Commit-Position: refs/heads/master@{#311473}

Blink team is planning to move DOM attributes into prototype chains.
DOM attributes will no longer be accessible as Object properties, e.g.
JSON.stringify will not see DOM attributes.  So WebRTC tests shouldn't
expect that they can stringify DOM attributes.

Fixes tests not to directly stringify DOM objects.

BUG=43394

Review URL: https://codereview.chromium.org/811653007

Cr-Commit-Position: refs/heads/master@{#311472}

This patch updates the Chromium side of the Blink platform changes,
removing method variants we no longer use, and converting the whole
thing to work on hostnames rather than WebURL/WebSecurityOrigin.

Patch 1 - Blink:    https://codereview.chromium.org/845303003
Patch 2 - Chromium: [THIS PATCH]

BUG=378566
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/852573002

Cr-Commit-Position: refs/heads/master@{#311471}

Cr-Commit-Position: refs/heads/master@{#311470}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5736df6..33868e6

TBR=zmo@chromium.org,yutak@chromium.org

Review URL: https://codereview.chromium.org/853673002

Cr-Commit-Position: refs/heads/master@{#311469}

SkCanvasVideoRenderer assumes that the VideoFrames belonging to one WebRTC
video are always either software VideoFrame or hardware VideoFrame.
However, it's not true. VideoFrame can be changed each frame.

TEST=content_browsertests WebRtcBrowserTest.CallAndVerify* on Nexus5
BUG=448014

Review URL: https://codereview.chromium.org/848683003

Cr-Commit-Position: refs/heads/master@{#311468}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/853663002

Cr-Commit-Position: refs/heads/master@{#311467}

I didn't realize the test actually hangs up the call as well. How
prudent of it! Now that the hangup code changed and isn't readily
available from the global namespace, I'll just remove it. Checking that
we can hang up isn't the most important thing anyway.

BUG=None
TBR=jiayl@chromium.org

Review URL: https://codereview.chromium.org/832593003

Cr-Commit-Position: refs/heads/master@{#311466}

Instantiate V4L2SVDA in GVDA and vdatest to be used if the hardware
cannot support the current frame-based API and try to use slice-based API
instead.

BUG=chrome-os-partner:33728
TEST=vdatest,veatest,apprtc,video playback

Review URL: https://codereview.chromium.org/808973004

Cr-Commit-Position: refs/heads/master@{#311465}

Reland: Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA.

This is a reland as the previous CL has an issue with BUILD.gn and failed gn build.

An AcceleratedVideoDecoder is a video decoder that requires support from an
external accelerator (typically a hardware accelerator) to partially
offload the decode process after parsing stream headers, and performing
reference frame and state management.

In this design, the hardware-independent decoder implementation interfaces
with a HW-specific Accelerator to offload last stages of the decode process.

Add the interface for AcceleratedVideoDecoder, decoders for VP8 and H264,
V4L2-specific Accelerators for VP8 and H264 and a common accelerator/client
class for V4L2.

TEST=vdatest VP8/H264, mp4 local video playback, apprtc decode
BUG=chrome-os-partner:33728
TBR=wuchengli@chromium.org,kcwu@chromium.org,owenlin@chromium.org,xhwang@chromium.org,scherkus@chromium.org,dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/813693006

Cr-Commit-Position: refs/heads/master@{#311464}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5cf6e0e..5736df6

TBR=zmo@chromium.org,yutak@chromium.org

Review URL: https://codereview.chromium.org/851973002

Cr-Commit-Position: refs/heads/master@{#311463}

Most everything was already in place for this, we just needed to wire
it up to the external API.

BUG=447989
R=bauerb@chromium.org,kalman@chromium.org

Review URL: https://codereview.chromium.org/843413003

Cr-Commit-Position: refs/heads/master@{#311462}

Revert of Refactoring of Cast-related crypto code (patchset #19 id:350001 of https://codereview.chromium.org/792353002/)

Reason for revert:
fails to compile on Linux ChromiumOS GN https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/6146/steps/compile/logs/stdio

Original issue's description:
> Refactoring of Cast-related crypto code to use the same certificate validation logic in chrome.networkingPrivate API and Cast Channel authentication.
>
> Here's what's being done here:
> * Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
> * Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
> * The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.
>
> BUG=442650
>
> Committed: https://crrev.com/ed1e90f4f980709cef6a8a9c7e0f64cfe5578cdd
> Cr-Commit-Position: refs/heads/master@{#311460}

TBR=stevenjb@chromium.org,mef@chromium.org,rsleevi@chromium.org,vadimgo@chromium.org,mfoltz@chromium.org,kmarshall@chromium.org,rockot@chromium.org,brettw@chromium.org,sheretov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=442650

Review URL: https://codereview.chromium.org/853663003

Cr-Commit-Position: refs/heads/master@{#311461}

Refactoring of Cast-related crypto code to use the same certificate validation logic in chrome.networkingPrivate API and Cast Channel authentication.

Here's what's being done here:
* Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
* Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
* The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.

BUG=442650

Review URL: https://codereview.chromium.org/792353002

Cr-Commit-Position: refs/heads/master@{#311460}

 - suppress leaks from extensions::ApiTestBase::SetUp() and extensions::MojoPrivateApiTest_Define_Test::TestBody() (issue 448700)

BUG=448700
TBR=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/850893002

Cr-Commit-Position: refs/heads/master@{#311459}

BUG=448323
TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/840373004

Cr-Commit-Position: refs/heads/master@{#311458}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/24e6399..5cf6e0e

TBR=zmo@chromium.org,yutak@chromium.org

Review URL: https://codereview.chromium.org/854553002

Cr-Commit-Position: refs/heads/master@{#311457}

789a019  Don't serialize linking for the make generator by default
8b69f7d  Add support for generating an Eclipse .classpath file (bug fix)

R=machenbach@chromium.org,thakis@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/851953002

Cr-Commit-Position: refs/heads/master@{#311456}

The system_wrappers target is already included due to the dependency
on the <(DEPTH)/third_party/webrtc/webrtc.gyp:webrtc target.

Review URL: https://codereview.chromium.org/851873004

Cr-Commit-Position: refs/heads/master@{#311455}

BUG=447440

Review URL: https://codereview.chromium.org/830673005

Cr-Commit-Position: refs/heads/master@{#311454}

This should make courgette_unittests green in this configuration.

BUG=345874
TBR=dgarrett@chromium.org

Review URL: https://codereview.chromium.org/850783002

Cr-Commit-Position: refs/heads/master@{#311453}