- 26 Jun, 2020 40 commits
-
-
Maksim Sisov authored
Currently, Ozone/X11 defines gfx::AcceleratedWidget as int32_t whereas non-Ozone/X11 defines that as x11::Window or uint32_t. To fix the inconsistency and allow use_x11 && use_ozone builds, make non-Ozone/X11 uses Ozone's definition of gfx::AcceleratedWidget. Also adds missing includes. Bug: 1098267 Change-Id: If9e98dd440c5d077990e390a0a10855723676b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260554Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#782872}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2599d76d6ec898d26429d8dfd6323e01f9c49911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269479Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782871}
-
Christopher Cameron authored
SkiaOutputDeviceBufferQueue currently holds the assumption that there always exists a primary plane. It may be that a frame's damage won't change that plane's contents, but the plane will always be there. On macOS, this is not the case. Frames will alternate between having only the primary plane (when not all content can be represented as a CALayer tree) and having no primary plane (when all content is represented by the overlay CALayer tree). Inform SkiaOutputDeviceBufferQueue when there is no primary plane for the current frame, by making the call to SchedulePrimaryPlane be unconditional, but with a base::Optional argument. The functions SwapBuffers, PostSubBuffer, and CommitOverlayPlanes are responsible for updating SkiaOutputDeviceBufferQueue::current_image_ and submitted_image_. Add an if-case for those functions when there no primary plane was scheduled. Update OverlayProcessorMac to always report full damage to the SurfaceAggregator. All quads are needed, every frame, to construct the CALayer tree. Bug: 894929 Change-Id: Id67f58eeb22a0e92f050f37be900bd6cfa5a7845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268478 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782870}
-
Xiyuan Xia authored
Replace FpsCounter with ThroughputTracker for overview metrics. Bug: 1021774 Change-Id: I4ae1dcf01ba092d55a46aa2d4d9f6c7ce3a9534f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264939 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#782869}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I664f8326da545e6ff69fa9e43ee44b8846d5c149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269760Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6ee18c2d01f6..c81da1c809fe 2020-06-26 syoussefi@chromium.org Vulkan: Avoid double-copy when generating mipmap If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I4a7f7cc9ed730387e9b44ea244a422a4880670de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269717Reviewed-by:
-
Hajime Hoshi authored
Change-Id: Ic329268bc74bd59a9bd52211563d24613202aa85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266412Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#782866}
-
David Bertoni authored
This test is no longer flaky. Any failures are infra/bot issues not related to this test. Bug: 1035620 Change-Id: I5bd4ddb0c4f870523d709fd1a93d0ee82459ecf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265098Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#782865}
-
Xiyuan Xia authored
Bug: 1021774 Change-Id: I3e725eba1e129980470b1d361791d4eee099b682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266902Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782864}
-
Yuki Yamada authored
NewLinkedHashSet needs to support HeapNewLinkedHashSet<WeakMember> to replace previous implementation LinkedHashSet by itself. The main points of this CL are: 1. Register custom weak callback in VectorBackedLinkedList to remove nodes which have reference to dead objects 2. Make iterator of NewLinkedHashSet have reference to HashMap value_to_index_ to strongify stored WeakMembers if there is an iterator Related tests: third_party/blink/renderer/platform/wtf/linked_hash_set_test.cc third_party/blink/renderer/platform/heap/test/heap_test.cc third_party/blink/renderer/platform/heap/test/incremental_marking_test.cc third_party/blink/renderer/platform/heap/test/weakness_marking_test.cc Rough note: https://docs.google.com/document/d/1zEr-V1zZC1I5kGyNbi1toCCDQlqdNh4vrwkHx8qsL34/edit?usp=sharing Bug: 1095525 Change-Id: Ic3a71aa45dccbd3ac276d21b43fcb2498320e8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246014 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#782863}
-
Ramin Halavati authored
BrowsingHistoryBridge is updated to receive profile object instead of |isIncognito| boolean, so that it would be properly initialized for all OffTheRecord profiles. Bug: 1060940 Change-Id: I1700ca45c08f6df8298d2456ebc774b2c80140e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260692Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#782862}
-
Mikel Astiz authored
There is no actual pre-USS datatype running and the code related to syncable::Directory is dead. Some of these concepts had leaked into higher layers in sync/driver, so this patch deletes them prior to deleting the functionality within the sync engine. In order to achieve this, SyncManagerImpl now takes ownership of UserShare and NigoriHandler, but this should cause no behavioral differences. Change-Id: I56f7f325f87206b985c064bb1c5e97acb7b05980 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264432 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#782861}
-
My Nguyen authored
Implement according to spec at http://go/e14s-emoji-addition-mock Pressing down will still move to the next candidate, pressing number after that will accept the number emoji. Bug: 1098692 Change-Id: Iad1cd39efa0f2ed5ccfad875b8018058cc3d63ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263692 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#782860}
-
Francois Beaufort authored
This CL makes sure pan, tilt, and zoom constraints set in getUserMedia are applied when internal image capture is created. This allows web developers to set pan, tilt, zoom at the creation of the video track. Change-Id: I7e6a747b24ffa27aaa266f900406bb1f81abf966 Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254280 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#782859}
-
Charlie Reis authored
This CL revises navigation.md and splits out navigation_concepts.md for describing several concepts that are important for understanding the navigation logic. BUG=1015882 Change-Id: I0397d2906aec9c24a658d96cf67123dc6bd7c3af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225745 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#782858}
-
John Delaney authored
What: Add an origin trial config for the Conversion Measurement API. This separates the base::Feature kConversionMeasurement from the runtime enabled feature. This allows the conversion storage layer to be setup without enabling the features in blink. The storage layer needs to be setup for all users regardless of the OT so that reports for conversions can be sent when the user is no longer on the site. This also moves the ConversionMeasurement runtime feature to experimental, and updates the about flags description to account for this. Change-Id: I534b6726b80146e90123b3116158d79872c00e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264767 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Charlie Reis authored
This CL adds special_case_urls.md to explain some of the interesting or unexpected corner cases that can occur for certain types of URLs, which may affect how other features are designed and implemented. BUG=1015882 Change-Id: I311d1c4c5b4962dba8b842c20200c344eacb46d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225374 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Saho Kobayashi authored
Send kAriaAttributeChanged event when state description change is sent from non range widget. AXTreeSourceArcTest.StateDescriptionChangedEvent Bug: b:154433831 Test: ArcAccessibilityUtilTest.FromContentChangeTypesToAXEvent Change-Id: I676dda6d6322375db2286510ab4759a5f4bc2fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262159 Commit-Queue: Saho Kobayashi <sahok@chromium.org> Reviewed-by:Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#782855}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c55849a7826f..1b047a2d37d8 2020-06-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5e0122d1e1a1e413f8cb286b068ef703d1a7604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269720Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f318b72e2035..a926fdc3321e 2020-06-26 jophba@chromium.org Disable certificate utils unittests in Chrome 2020-06-26 jophba@chromium.org [Hotfix] Fix presubmit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098562 Tbr: jophba@chromium.org Change-Id: I7df19c29290ce11549a28f316623a0572bba9f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269719Reviewed-by:
-
My Nguyen authored
This is described in http://go/e14s-emoji-addition-mock for emoji and http://go/personal-info-suggestion-mock for personal info suggestion. Bug: 1098057 Change-Id: Idb66d47db2f60c9da7344fffc68ab771c981a80e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257659Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I74d024362f09a2a3878ed6b6278c5a8b356b9c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257402Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#782851}
-
Julie Jeongeun Kim authored
This CL removes RenderWidgetHostOwnerDelegate::GetFocusedFrame and GetFocusedFrame from RenderViewHostImpl inherited from RenderWidgetHostOwnerDelegate since it could get the FrameTree from RenderWidgetHostDelegate::GetFrameTree() introduced on [1]. [1] https://crrev.com/c/2245450 Bug: 1094841 Change-Id: I7c427942d4ce2b93cde70ed19946d7411799cc85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253598 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts PrerenderMsg_SetIsPrerendering to ChromeRenderFrame Mojo message, and pass the message to chromePluginPlaceholder from ChromeRenderFrameObserver via PrerenderObserver. Bug: 798712 Change-Id: Id84240d8f16fc811df56fc05a734a4ee539c2a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246015Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#782849}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/883a4e449775..5eb778ad40e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1070150,chromium:1099009 Tbr: meredithl@google.com Change-Id: I037caac2cfb62a84cd9a4cdd2a3f829ee72368bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269517Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782848}
-
Marijn Kruisselbrink authored
Bug: 1099442 Change-Id: Id18e1bbc585577c82fc40cabba1ce387194be3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268881 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#782847}
-
James Cook authored
Fill out the ash-chrome side of the implementation. Add support for all dialog types (open, open folder, save, etc.). For now, place the file dialog in the default ash window container. Future CLs will add plumbing to use the Lacros window's exo ShellSurface as the parent. Fix the ExtensionDialog code to allow a parent aura::Window that isn't associated with a views::Widget. 1-page design doc at go/lacros-file-picker Lacros project overview at go/lacros Bug: 1090587 Test: manual, can open/save files with Ctrl-O/Ctrl-S Change-Id: I54f461e92b3e5d75808bcf04ce903b003b12490b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265191 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#782846}
-
Minoru Chikamune authored
We are going to deprecate kWithoutContextObserver. But SpeechSynthesis had a problem with kWithContextObserver mode. To avoid this problem, we temporally need to specify kForceWithoutContextObserver. When the ExecutionContext was destroyed, HeapMojo wrappers will automatically reset the mojom_synthesis_ mojo::Remote object. After that, if the `blink::SpeechSynthesis::cancel` is called, Null-dereference READ will be happen because it's already reset. To avoid this problem, HeapMojoWrapperMode::kForceWithoutContextObserver have to be specified. if this was specified, HeapMojoRemote doesn't reset mojo::Remote object when the ExecutionContext was destroyed. see also: https://chromium-review.googlesource.com/c/chromium/src/+/2123493 Bug: 1049056, 1058076 Change-Id: I84484ce85ddfc95705acbc7a9e0739a39b2a55ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269597 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#782845}
-
Andrew Moylan authored
* Bump sometimes-used histograms by 6 months * Remove TopCat-related histograms (model is obsolete) Bug: chromium:1098112, chromium:1097888 Change-Id: I893233fbef805c5f375852c119d0272d2d94bea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269377 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Auto-Submit: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782844}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9e3d7f1a205c1df04d139411c1dd709c4b9ca124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269198Reviewed-by:
-
Tal Pressman authored
[1] crrev.com/c/2265704/5/third_party/blink/renderer/platform/scheduler/main_thread/agent_scheduling_strategy.cc#225 Change-Id: I1b8b653c4ffdaf6e9073afd02a9f90619bcfe771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269380Reviewed-by:
-
Tal Pressman authored
Bug: 1090251 Change-Id: If665b0f5035f2ffaf9e45a9ba049654babec9f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269379Reviewed-by:
-
Dana Fried authored
Tabs are briefly resized to their ideal size when torn out of a window during a drag, then updated to the size and position they had before the drag for better visuals. The group visuals were getting updated based on the ideal bounds (which are never painted and therefore are not visible) but not the drag-appropriate bounds, resulting in strange group highlights and underlines. This causes the tab visuals to be updated after the appropriate dragging bounds are set on the tabs and tab group header. Bug: 1099047 Change-Id: I918d34efc47c6ec40e8558c0de5f8cbae2ad8a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268389 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782840}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593108049-347f75b6d1676a52301ec3ad36e2e55c1372542f.profdata to chrome-win64-master-1593129542-2eaae9cac4b4a7ab29032c694ec87a1eba9074ff.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I129db2cbab231d482cf253fa6ffbd65dffcb8fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269737Reviewed-by:
-
Meredith Lane authored
This reverts commit 300c6c11. Reason for revert: Original change was reverted in error, sorry :( Original change's description: > Revert "Disable AdTagging when the Ads content setting is set to allow" > > This reverts commit 19e537d0. > > Reason for revert: Suspected cause for CreativeOriginAdsPageLoadMetricsObserverBrowserTest.CreativeOriginStatusWithThrottlingUnknown deterministically failing. on Win7, first failure: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/61594 > > Original change's description: > > Disable AdTagging when the Ads content setting is set to allow > > > > What: Do not run the SF filter in DryRun mode on pages where the > > content setting is set to allow. > > > > How: Delete the ongoing activation throttle for the navigation when > > we receive an explicit disabled activation state. > > > > Currently we ignore disabled activation states when we receive them, > > as normally the SF filter is running in DryRun mode anyway. > > > > > > Change-Id: Ibc5202ec5f68bd284987cdd4d5dfa0e8de0708a4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218371 > > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > > Commit-Queue: John Delaney <johnidel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#782722} > > TBR=jkarlin@chromium.org,csharrison@chromium.org,johnidel@chromium.org > > Change-Id: I3f150050d45b258b664178c501254c8fc42315a4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269397 > Reviewed-by: Meredith Lane <meredithl@chromium.org> > Commit-Queue: Meredith Lane <meredithl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782817} TBR=jkarlin@chromium.org,csharrison@chromium.org,johnidel@chromium.org,meredithl@chromium.org # Not skipping CQ checks because this is a reland. Change-Id: Id22c9bba75cc5591f44fec9a9a02b8e5e9771494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269398Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#782838}
-
Meredith Lane authored
CreativeOriginStatusWithThrottlingNestedUnthrottled failing flakily on Win7 builder, so disabling that test. TBR=cammie@chromium.org, johnidel@chromium.org Bug: 1099545 Change-Id: I888c05963914c4c507c161f9bb9867e4cd49e3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269399Reviewed-by:
-
Yutaka Hirano authored
Adding a UKM similar to Extensions.WebRequest.KeepaliveRequestState. Proposal: https://docs.google.com/document/d/1XYsa2W1zjWIvrpuAq7IA1wEGZIvbJLoiPF6rMob01Tg/edit Bug: 1098251 Change-Id: I6bccb85935646bb9ed1879ec19fb409323807124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262402 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#782836}
-
Karandeep Bhatia authored
Add more tests for navigation to javascript urls in isolated worlds. The tests show that the isolated world CSP is not enforced for them. This will be fixed in a follow up. This doesn't introduce any behavior change. BUG=896041 Change-Id: I77510f4931608b2d0990ac5e6b60555d75959e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262117Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#782835}
-
Yoshifumi Inoue authored
Rather than changing |PositionForEndOfLine()| to work with overflowed layout, this patch changes |AdjustSoftLineWrap()| to check whether specified position in |NGOffsetMapping| or not. When the position isn't in |NGOffsetMapping|, |AdjustSoftLineWrap()| returns specified position without adjustment, for keeping source code simple. Here is steps to |PositionForEndOfLine()| to return wrong position: 1. Layout places <select> at |LayoutUnit::Max()| and sets line width to |LayoutUnit::Max()|. 2. |NGInlineCursor::PositionForEndOfLine()| calls |PositionForPointInlineBox()| with |LayoutUnit::Max()| for <select>. 3. |LayoutBlock::PositionForPointIfOutsideAtomicInlineLevel()| is called and returns null. 4. |LayoutBlock::PositionForPoint()| returns end of |Text| node position by traversing layout tree. Bug: 1098795 Change-Id: I5e86732fe15e9980da46ad3e32db4ef0b7170b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265974 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#782834}
-
Gavin Williams authored
For CrOS, this will show a printer icon with a status badge next to the currently selected destination only if it is a local printer. Screenshot: http://screen/xOt5q6RBGHO Bug: 1059607 Change-Id: I6afeed18ea5eb4ed9482f6358b59347ffd63d426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230761 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#782833}
-
