GitLab

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164938:164945&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/136203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244475 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/133013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244474 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244473 0039d316-1c4b-4281-b951-d872f2087c98

Likely cause of WebGL conformance test crashes on Android GPU bot.

BUG=333761,181120

> Use ContextProvider subclass to provide WGC3D pointers
> 
> Some cc::ContextProvider instances will also need to provide WebGraphicsContext3D*
> interfaces to the underlying GL context, but not all. This adds a subclass of ContextProvider
> in content:: to use for these users. The compositor itself doesn't need the WGC3D
> accessor so it just uses the base class.
> 
> BUG=181120
> 
> Review URL: https://codereview.chromium.org/126093010

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/136273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244470 0039d316-1c4b-4281-b951-d872f2087c98

Patch from joaodasilva.

BUG=308740
R=scottmg@chromium.org
TBR=wtc@chromium.org

Review URL: https://codereview.chromium.org/136083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244469 0039d316-1c4b-4281-b951-d872f2087c98

This test has been flaking out on the Win7 bots.

BUG=332528
NOTRY=true
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/136093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244468 0039d316-1c4b-4281-b951-d872f2087c98

HTTP Live streaming is supported by Android media player where
Clank can be installed (ICS and above) but mime type was not
being recognized properly. This CL rectifies it by adding the
types to the supported list.

BUG=332309
Tested: Android 4.04, 4.3, 4.4

Review URL: https://codereview.chromium.org/130853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244467 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316062
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/111553008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244466 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244456 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244452 0039d316-1c4b-4281-b951-d872f2087c98

r1834 update comment to add tracking bug from r1833
r1835 Pass the mspdbsrv flag as a command line argument to the link wrapper
r1836 ninja win: Allow parent environment variables through when running actions

TBR=thakis@chromium.org
BUG=333738

Review URL: https://codereview.chromium.org/136173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244451 0039d316-1c4b-4281-b951-d872f2087c98

The "conditional jump or move depends on uninitialised value(s)"
error triggered in WebCore::Document::webkitPointerLockElement()
in Valgrind has been fixed in Blink r164898. Removing suppression.

BUG=293049
NOTRY=true

Review URL: https://codereview.chromium.org/134293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244450 0039d316-1c4b-4281-b951-d872f2087c98

RootWindowTest.TouchMovesHeld is flakily failing on CrOS Valgrind bots.
The cause is unclear, but it might be related to r230206 or r244436.
Disable the test on ChromeOS for now to allow for followup investigation.

BUG=333644
TEST=NONE
TBR=thakis@chromium.org,tdresser@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/136013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244449 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: browser_test crashes on Linux ChromiumOS Tests (dbg)(2)

TBR=sky@chromium.org,vollick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/131473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244448 0039d316-1c4b-4281-b951-d872f2087c98

AutofillDialogControllerTest.SimulateSuccessfulSignIn is flaky on Windows XP:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/25976
It fails on that run, but then passes on builds 25977, 25978, and 25979.
It might be related to my r244436, I'll disable on XP for now and investigate later.

BUG=333641
TEST=NONE
TBR=dbeam@chromium.org,estade@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/134473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244447 0039d316-1c4b-4281-b951-d872f2087c98

Every instance of default-constructed FontList has been calling CacheCommonFontHeightAndBaseline() and CacheFontStyleAndSize(), and it's inefficient.  This CL creates an instance of FontList which holds pre-calculated metrics, and copy the pre-calculated metrics in the default ctor.  This change improves the performance very much.

BUG=330975
TEST=Run unit_tests, views_unittests, ui_unittests.

Review URL: https://codereview.chromium.org/124693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244446 0039d316-1c4b-4281-b951-d872f2087c98

--parent-window is used to pass HWND of the chrome window when launching
native messaging hosts. It was brokend with Aura because

BUG=330777

Review URL: https://codereview.chromium.org/115683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244445 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: requires one more iteration

TBR=jam@chromium.org,aa@chromium.org,abarth@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=297480

Review URL: https://codereview.chromium.org/135983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244444 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/135963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244443 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333572
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/130433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244439 0039d316-1c4b-4281-b951-d872f2087c98

Test fails on the valgrind bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28tsan%29%281%29/builds/11739/steps/memory%20test%3A%20unit/logs/EphemeralAppServiceTest.RemoveOverflow
EphemeralAppServiceTest.RemoveOverflow: 
../../chrome/browser/apps/ephemeral_app_service_unittest.cc:83: Failure
Value of: removed->first < retained->first
Actual: false
Expected: true

> Support GU retry command in sync engine. The command specifies a delay after which syncer should issue a GU to pick up updates missed by last GU.
> 
> BUG=
> 
> Review URL: https://codereview.chromium.org/124083002

TBR=haitaol@chromium.org

Review URL: https://codereview.chromium.org/135923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244438 0039d316-1c4b-4281-b951-d872f2087c98

Move sample service test to be with the rest of the bindings tests, and change it to not echo output by default.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/134823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244437 0039d316-1c4b-4281-b951-d872f2087c98

Reverted in r244402 for Linux-Aura test failures.
I fixed Ctrl+Shift+Delete/Backspace behavior on Linux here.

Consolidate the split textfield code into Textfield.
No behavior changes (except STYLE_LOWERCASE GetText nit).
Use the underlying model's text and font_list storage.
Remove unused code; rename TextfieldViewsModel::text().
Revise gesture and command handling.

Skip NotifyAccessibilityEvent native behavior without widget.
(No HWND for Views not yet added to view hierarchy)

Make TouchEditable::GetNativeView const; avoids conflict.
Fix includes, forward decls, Font[List] usage, tests.

Ideas for followup cleanup and refactoring:
-Cleanup View overrides decl/def order.
-Refactor RemoveBorder, SetHorizontalMargins, etc.
-Try to use composition instead of inheritance.
-Remove textfield style ctor; refactor style code.
-Remove STYLE_LOWERCASE functionality (one user).
-Replace placeholder DrawStringRect with a Label view.
-Cleanup CreateTouchSelectionControllerAndNotifyIt, etc.
-Cleanup SetColor/SetTextColor, etc.

BUG=131660
TEST=No textfield behavior/appearance regressions.
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/135863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244436 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332217
TBR=arv@chromium.org

Review URL: https://codereview.chromium.org/134623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244435 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244432 0039d316-1c4b-4281-b951-d872f2087c98

Currently, we just ignore setting visible to false if a window is animating
opacity to zero. This is silly; folks could be listening for this animation
to finish. Instead, we should simply delay setting visibility until the opacity
animation completes.

BUG=None

Review URL: https://codereview.chromium.org/132903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244431 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164883:164937&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/131123005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244430 0039d316-1c4b-4281-b951-d872f2087c98

InstantPolicyTest.NoThemeBackgroundChangeEventOnTabSwitch and others
failing on XP, Mac 10.6, Linux ASAN.

> InstantExtended: remove dead code related to the non-cacheable NTP.
> 
> BUG=none
> 
> Review URL: https://codereview.chromium.org/132733002

TBR=samarth@chromium.org

Review URL: https://codereview.chromium.org/135903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244429 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244427 0039d316-1c4b-4281-b951-d872f2087c98

When trying to enable chrome://components for Android "return NULL;" was
accidentally moved together with the if check resulting in an early return.

Breaking CL https://codereview.chromium.org/112673008

BUG=332714

Review URL: https://codereview.chromium.org/135113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244425 0039d316-1c4b-4281-b951-d872f2087c98

These tests don't succeed because of desktop_browser_finder.CanFindAvailableBrowsers:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py&q=CanFindAvailableBrowsers&l=84

BUG=331940
TEST=manual

Review URL: https://codereview.chromium.org/135063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244424 0039d316-1c4b-4281-b951-d872f2087c98

Make the appearance of pressed and hover states the same so that it's consistent with other menu items.
Fix memory leak (SetImage does not transfer the ownership)

BUG=333232

Review URL: https://codereview.chromium.org/135003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244423 0039d316-1c4b-4281-b951-d872f2087c98

Fixes 2 memory leaks related to GPU accelerated video encoding.
The TaskRunner must run one final time to clean the memory.

BUG=333142

Review URL: https://codereview.chromium.org/134943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331940
TEST=manual

Review URL: https://codereview.chromium.org/134623006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318411

Review URL: https://codereview.chromium.org/134993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244420 0039d316-1c4b-4281-b951-d872f2087c98

This (finally) completes the effort to remove all uses of base::Time as a clock for tracking time passage in the media component.  For more info, please see src/media/PRESUBMIT.py.

Review URL: https://codereview.chromium.org/134603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244419 0039d316-1c4b-4281-b951-d872f2087c98

And make it use ExtensionRegistry in one more place. It's used by ExtensionHost
and this is a small step toward eliminating chrome dependencies.

BUG=309909
TEST=browser_tests

Review URL: https://codereview.chromium.org/134393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244418 0039d316-1c4b-4281-b951-d872f2087c98

Also make the logic and formatting in ToolbarView::Layout more consistent.

BUG=333294

Review URL: https://codereview.chromium.org/134013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244417 0039d316-1c4b-4281-b951-d872f2087c98

At the moment running windowed applications can be mixed with pinned applications - which is incorrect (checked with kuscher).

This CL is a pre-CL for the order preservation of all running applications in multi profile mode (trying to keep it small).

BUG=309029
TEST=unit test

Review URL: https://codereview.chromium.org/133743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244416 0039d316-1c4b-4281-b951-d872f2087c98