- 14 May, 2020 1 commit
-
-
Erik Chen authored
Bug: 1077348, 1080466 Change-Id: I1d27c2e041960b99345148a1668431c780f18b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200070 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#768550}
-
- 13 May, 2020 39 commits
-
-
Yoav Weiss authored
As a followup to [1], this CL ensures that on-by-default Client Hints don't get removed from cross-origin redirects. It similarly makes sure that legacy hints that don't abide to FeaturePolicy get a free pass on the removal in that case. Finally, it makes sure that UA-Mobile's FeaturePolicy's default value is "all". [1] https://chromium-review.googlesource.com/c/chromium/src/+/2178572 Bug: 911952, 1082072 Change-Id: I1f329a3c24397a287a1cbc333cd0976bb16d640a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199107 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#768549}
-
Olivier Li authored
After we previously run as an inconclusive beta trial by itself we grouped it with the HistoryService ThreadPool trial to try and coax a larger impact from the ThreadPool migration. This meant groups ran with either both services on the ThreadPool, none or only HistoryService (status quo). 28 day aggregation trial in beta showed no likely negative impact. Crashes seemed slightly elevated in the group when running both the HistoryService and the ProfileSyncService on the ThreadPool but closer examination suggests this is simply noise since all top-crashers are the same. Bug: 1014464 Change-Id: I3a1604413fcf1f4b5350c3b9161251f46a449865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198932 Commit-Queue: Oliver Li <olivierli@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#768548}
-
Anatoliy Potapchuk authored
In Web App kiosk mode, even though web apps are enabled, system web apps are not. We should explicitly disable them here. Bug: 1061068 Change-Id: Iea6f6f439d11c408ba3c9a48d4987f5cdcad0da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199280 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#768547}
-
Karandeep Bhatia authored
Introduce getEnabledRulesets extension function which returns the IDs for the set of enabled static rulesets. BUG=754526 Change-Id: Ie7647c718b96953a7ba2fbb0e2322443b9a18fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189692 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768546}
-
Mugdha Lakhani authored
1. PageInfoController uses the now componentized PermissionParamsListBuilder. 2. A PermissionParamsListBuilderDelegate is created for WebLayer and passed into PageInfoController. Bug: 1052375 Change-Id: I71b1d61e60c755887b5ae767d4a945aa4eec8d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185070 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#768545}
-
David Bertoni authored
for flakiness. The UnlimitedStorageForLocalButNotSync was disabled long ago for flakiness. This test passed 3000 iterations on the bots with no flakes. Bug: 227296 Change-Id: I24da0f1718658348dafb866c2eb6e7770400f843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196959Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#768544}
-
Darwin Huang authored
Rename OSExchangeDataProviderAuraX11 to OSExchangeDataProviderX11. AuraX11 classes were named as "AuraX11" for historical reasons, but X11 no longer requires Aura, so X11 is a more concise name. No intended logic changes. Only names and comments should have changed. Change-Id: I444466032621a65d4e176f3278e5b0bb6f7dad30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197867 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768543}
-
Yulun Wu authored
App list folders should expand from the folder's origin.The bounds for the folder should be 8 dip from the edge of the screen and should not be limited by the app list container bounds. Bug: 1018305 Change-Id: I3597dbe96c697f5c268ddd9cc5157c62f7600f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197422 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#768542}
-
Karandeep Bhatia authored
Introduce the updateEnabledRulesets extension function which allows extensions to update the set of enabled static rulesets. This is a partial implementation and the set of enabled rulesets still needs to be persisted to prefs so that it is sticky across extension loads. BUG=754526 Change-Id: I5b8e76ef4cc5a3c1049131109057e4f20efc8d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186989 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Alex Gough authored
See linked bug for rationale. This does not change functionality. Bug: 1065087 Change-Id: Id6e938b64594cc029f716270cfbb0435b9efacd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198373Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#768540}
-
Olya Kalitova authored
Introduces and adds UserPluginVmAllowed policy, that controls whether Plugin VM is allowed for a user. Policy handling will be added in the follow up CL. Will co-exist with the current PluginVmAllowed device policy. Test: browser_tests --gtest_filter="PolicyPref*" Bug: 1081744 Change-Id: Ic3f794d340215a69ba0ad6814326d1ddfff0bf73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199057 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768539}
-
John Williams authored
The change allows a Presentation API to control a 1UA mode presentation. Bug: 1069126 Change-Id: I943293d884c77319f865273105cf93f0c6727ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186109 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#768538}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit e87e4072. Reason for revert: compilation failure. See https://ci.chromium.org/p/chrome/builders/ci/arm64-builder-rel/21384. Original change's description: > [Offline indicator v2] Add metrics > > Bug: 1068727 > Change-Id: I5470452fcdfd5d9b7310e65802ef2867326fb27a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191376 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Cr-Commit-Position: refs/heads/master@{#768507} TBR=bcwhite@chromium.org,twellington@chromium.org,sinansahin@google.com Change-Id: I04a42405e1803ca808e7465589d31dc8940fa9f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1068727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199988Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768537}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8355052cad11..0a227c84a559 git log 8355052cad11..0a227c84a559 --date=short --first-parent --format='%ad %ae %s' 2020-05-13 paolosev@microsoft.com Make DWARFSymbolServer build on Windows Created with: gclient setdep -r src/third_party/devtools-frontend/src@0a227c84a559 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id1678c6de07662c77f04eb712f6b8a99e62840d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199661Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768536}
-
Dominic Schulz authored
We don't need to check if a URL is "HTTP" and then also check that it's not "chrome://" Bug: 1044855 Change-Id: Idf843951668d88de831dfe28a4f567f0b9717893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185832Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Dominic Schulz <dominicschulz@google.com> Cr-Commit-Position: refs/heads/master@{#768535}
-
Tibor Goldschwendt authored
Logs - NewTabPage.Promos.LinkClicked - NewTabPage.Promos.RequestLatency2 - NewTabPage.Promos.RequestLatency2.Failure - NewTabPage.Promos.RequestLatency2.SuccessWithoutPromo - NewTabPage.Promos.RequestLatency2.SuccessWithPromo - NewTabPage.Promos.ShownTime on chrome://new-tab-page and extends and updates ownership of the metrics. Fixed: 1072874 Change-Id: Id22a10e4e376d987607a5795ffdd42631d0120cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197997 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#768534}
-
Dana Fried authored
external/wpt/pointerevents/pointerevent_capture_mouse.html is failing in blink_web_tests on WebKit Linux Leak Bug: 998948 Change-Id: I32248d6cf9183605a4fd5b5ebaf959af6179a75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200007 Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#768533}
-
Erik Chen authored
Setting the switch will cause ash-chrome to launch the lacros-chrome binary from the given path rather than from component updater. Bug: 1077348 Change-Id: I50f5a1be84c31df434b37997007112e7c1296767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200078 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Alex Gough authored
This should not change behaviour. TEST=Manual browser_tests.exe --gtest_filter=EdgeImporter* Bug: 1065087 Change-Id: Ia67cd29625ff34575682da57a45ab68bd3104d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196838 Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#768531}
-
Muyao Xu authored
appParams is encoded in the presentation URL by the sender SDK in JSON format, and is passed to Cast MRP as a string. Bug: b/153748066, 1074358 Change-Id: I3e62baa4ebad7b73e026e3ac73a5db38c9425e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166132 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#768530}
-
Anatoliy Potapchuk authored
We want the spoken feedback user to be notified about what what happens when the user presses the "change position" button on the floating menu. Bug: 1061068 Change-Id: Ib1c6a70f7d94825ee057e1d7fa2406b569a84564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199262 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#768529}
-
Sammie Quon authored
Currently works on browser windows due to ScopedRootForNewWindows due to opening sync (or before AfterItemSelected callback is fired). V1 and V2 apps are launched async though. This moves deleting the scoped object until ShelfItemStatusChanged which can be called by window activation change, which is async. It's a little worrisome that we might not clear the changed root window so added a delayed task to ensure deletion (when I tested window activation always happened though). Tried adding a test in ChromeLauncherControllerTest but it doesn't seem like there was support for launching a app in a separate window, even by launching manually and not clicking on the shelf shortcut. Test: manual Bug: 1080390 Change-Id: I0d5f6126571f92d86c5d4530d205b6cfc3e635be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198550Reviewed-by:
-
Robert Sesek authored
Change-Id: I05e3f6f6b3521e8df097f03faaeb3f41e4c3419b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198921Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#768527}
-
Jon Mann authored
This change adds text which indicates the synced status of networks to the network details page. To do this, it adds an is_syncable property to network_config::mojom::ManagedWiFiProperties to determine if a network is eligible, and the existing [Os]SyncBrowserProxy to determine if wifi sync is enabled for the active user. Bug: 966270 Change-Id: Iac01c901b40cff92cb0c6bf804bc397bdfd81285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189644Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#768526}
-
Nick Burris authored
This patch records additional metrics for TextFragmentAnchor to get insight into how the parameters are used. It records an enum indicating which combination of parameters were specified, as well as the length of the text matching parameters and the total match length. These metrics will help determine whether there should be a minimum range match length requirement, and what that length should be, to discourage the overuse of text ranges which may be easier to manually create but result in a more fragile link. Bug: 1039778 Change-Id: I71c46ee219b9718f33fb8e922b576ec939798dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196951 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#768525}
-
Sergey Ulanov authored
This is a reland of 02ee5e26 Original change's description: > [Fuchsia] Add unittests for VideoCaptureDeviceFuchsia > > Added unittests of for VideoCaptureDeviceFuchsia with fake > fuchsia.camera3.Device and fuchsia.camera3.Stream implementations. > > In the future the fakes can be used for web_engine_integration_tests. > > Bug: 866669 > Change-Id: I0b5b0267127f9843b12123eb9e9a61890ec95a25 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181184 > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768422} TBR=kmarshall@chromium.org Bug: 866669 Change-Id: I6c68aee7c50b8e3dc93744446042920c79c37db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200000Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#768524}
-
Tibor Goldschwendt authored
Third party theme background images are served via chrome[-search]://theme/IDR_THEME_NTP_BACKGROUND?<theme-id>. The WebUI NTP embeds the background image via a chrome-untrusted:// iframe since most background images are fetched from the web. This means to use the common WebUI NTP background image machinery the theme image has to be available to a chrome-untrusted:// iframe. Therefore, this CL adds support for serving the theme data source on the chrome-untrusted scheme. With that, this CL sets the background image URL to chrome-untrusted://theme/IDR_THEME_NTP_BACKGROUND?<theme-id> if a theme with a third-party background image is set. Furthermore, this CL adds white pills around the shortcut titles as the local NTP does it. Bug: 1081441 Change-Id: Ia26546c395fabbcee17062ebec17956042cd85f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197661 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Darwin Huang authored
Design Doc: https://tinyurl.com/raw-clipboard-access-design Restrictions: https://docs.google.com/spreadsheets/d/178S5nBJ7YZY7NLcrJ67qSs03i70VOkLkIA5EsBG8y2M/edit Bug: 897289 Change-Id: I7835c64f7f8e89dca78360fa9077183c2e0f5bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194939 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#768522}
-
Raymond Toy authored
Now that all AudioParams with inputs have been updated to accept inputs when the automation rate is k-rate, remove the old HasSampleAccurateValues and rename HasSampleAccurateValuesTimeline to HasSampleAccurateValues. This change requires a modification of the DelayDSPKernel to add the method IsAudioRate() so that the delay node handles k-rate delayTime input correctly. Bug: 1015760 Change-Id: Ieb59889017328bfa58bf82df636643878b6ad3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199133Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#768521}
-
Brian Sheedy authored
Adds an '"ignore": "1"' pair to the JSON for GPU pixel tests if a test has a grace period active. This is so that newly added noisy tests do not affect unrelated CLs by causing Gold to comment on them because they happened to produce a new image due to bad luck. Bug: 1081942 Change-Id: Ife8dbe1baa349c203a4e95d7a152cb42d29d384f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199908Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#768520}
-
Bence Béky authored
Do not call HasUploadData() from OnDataSent() if |request_info_| is already reset when response headers are received. Bug: 1082196 Change-Id: I2bfac8ba5eb9d4694f2eb1078275713176fc86dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198544 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768519}
-
Nick Burris authored
In https://crrev.com/c/2089973, the ScrollUnification feature flag was added along with various changes to ensure the compositor has the complete scroll tree. Most of that CL was behind the feature flag, except for traversing the LocalFrameView set to gather all scroll translation nodes, which is likely the cause of the regressions in bug 1081923. This patch puts this step behind the feature flag as well. Bug: 1081923 1047178 Change-Id: I6ee3e3f60c29c1739c3221871e0baf8a96d114ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199597 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
Previously D3d11VideoDecoder can handle encrypted stream via CdmProxy. Now CdmProxy code has been removed. This CL further removes all CdmContext related code as they are unreachable. Bug: 1067786 Change-Id: I14445a500e3eff3f0b0139951c4223648f4c9ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198600Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#768517}
-
Zentaro Kavanagh authored
- New CrOS keyboards do event rewriting based on scan code and a mapping supplied via sysfs attribute - This change just adds a default scan code to all test cases Bug=1076241 TEST=unit_tests --gtestfilter="EventRewriterTest.*' Change-Id: I4e33746ff7feb6a32982b3ef89581dda29bbbead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199576 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
John Delaney authored
Adds about flag entries for enabling the API as well as the debug mode version. Exposed for developer testing. Bug: 1082421 Change-Id: Ib68277248ba35c563932d7d296cce6b74e77ad66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198645 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#768515}
-
Nicolás Peña Moreno authored
This CL addresses a forgotten nit from https://chromium-review.googlesource.com/c/chromium/src/+/2191238/2/third_party/blink/web_tests/external/wpt/event-timing/resources/event-timing-test-utils.js#125 Change-Id: Ibf5d168d912294b1a5df4099c4d8c269ae505a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199689 Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#768514}
-
Matthew Mourgos authored
Currently the shelf navigation setting is supposed to be hidden on clamshell-only devices. PowerManagerClient is used to detect when tablet mode is unsupported but has not been accurately been detecting when this is the case. After discussion with UX, it has been decided to instead only show the setting when in tablet mode. This will ensure that clamshell-only users are not shown a setting intended for tablet mode users. This change removes usage of PowerManagerClient and instead uses ash::TabletMode::Get()->InTabletMode() to determine when the shelf navigation setting should be shown in a11y settings. ash::TabletModeObserver is also used so that when tablet mode is changed the setting is shown in tablet mode and hidden in clamshell mode. Bug: 1062213 Change-Id: I01a7c3946c557dc65eebd69b52b63240aa39461e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197868Reviewed-by:
-
danakj authored
This moves the main-frame-specific API off of WebView, and puts it on WebLocalFrame. We go directly there from TestRunnerBindings. To reset the value between tests we add TestRunner::ResetWebFrame() which is called from WebFrameTestProxy. This place can reset all things on the frame that may be modified by TestRunnerBindings during a test. TBR=rdevlin.cronin@chromium.org Bug: 866140, 1069111 Change-Id: I2e49b137bd7c9334972ec6b128921870d1fa5a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198680 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768512}
-
Jae Hoon Kim authored
"GetExistingDlcs" DBus method constant is in system_api now and can be used within dlcservice client files. BUG=none TEST=./unit_tests Change-Id: I347fbabef4691f69ec3482ffbf51cbe7c9b54c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199679 Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
