- 10 Nov, 2017 39 commits
-
-
Tom Sepez authored
The change at @514907 appears to have subtly changed the logic, so mimic the GetGpuPreSandboxHook() flow as existed in the old code at https: //chromium-review.googlesource.com/c/chromium/src/+/757767/4/content/gpu/gpu_sandbox_hook_linux.cc Bug: 783312 Change-Id: I14996782de9fc469d3e31e7f1ba46ec353922710 Reviewed-on: https://chromium-review.googlesource.com/761838 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515389}
-
Victor Costan authored
This CL implements a subset of cookie filtering in RestrictedCookieManager::GetAllForUrl. The implementation is the minimum needed to verify that CookieStore.{get,getAll,has} passes matchType correctly to the backend. Bug: 729800 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I02f9dcf624ef47e0f8e79d68fb51fae27b1c489d Reviewed-on: https://chromium-review.googlesource.com/756093 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#515388}
-
Andrey Lushnikov authored
FileSystemWorkspaceBinding relies on file paths to route FileChanged events to correct file system projects. Consider the following scenario with 2 isolated filesystems: - first FS has root path file:///foo - second FS has root path file:///foo_old Currently, if the event happens inside the |foo_old| file system, we incorrectly route it into both |foo| and |foo_old| file systems. This patch fixes the issue. R=pfeldman Change-Id: I6b787cbc8261c87c3bbdfa1861b4847d84076a5f Reviewed-on: https://chromium-review.googlesource.com/758828Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515387}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/09baacd899ce..7af1dc56fc10 $ git log 09baacd89..7af1dc56f --date=short --no-merges --format='%ad %ae %s' 2017-11-08 myjang [presubmit] Base64 encode for config validation Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I87615b92bc47061cbfc032514d880cd51e9e9a4e Reviewed-on: https://chromium-review.googlesource.com/761978Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515386}
-
Kenichi Ishibashi authored
Before this CL, OomInterventionTabHelper assumed that all crashes with TERMINATION_STATUS_OOM_PROTECTED are actual OOM crashes, which isn't always true. Instead of making such assumption, it's better to use newly added OutOfMemoryReporter, which allows the tab helper to register to be notified of foreground OOM. Bug: 776665 Change-Id: I15c911b8e80e2029a41b404f5d8392a66040e0fe Reviewed-on: https://chromium-review.googlesource.com/760059 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#515385}
-
Trent Apted authored
There's an unnecessary call to SetFocusBehavior on a views::Label. Except on Mac, View::SetFocusBehavior(ACCESSIBLE_ONLY) only has meaning inside a views::AccessiblePaneView. On Mac, it puts a view into the focus chain when "Full Keyboard Access" is set in System Preferences. Screen readers and a11y tools always traverse the full tree. Bug: 782185 Change-Id: I90402a05d3811c14704004d99d14f67c831fc648 Reviewed-on: https://chromium-review.googlesource.com/760077Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#515384}
-
Chris Blume authored
zlib_inflate_fuzzer currently asserts when the call to inflate() fails. However, invalid inputs are expected in fuzz testing. So inflate() failing is an expected case here. Remove the assert on inflate() succeeding. BUG=780898 Change-Id: If62bff55f31a67d2fefa4e780f283f97f88f7707 Reviewed-on: https://chromium-review.googlesource.com/753133 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515383}
-
Paul Jensen authored
If the process has been bound to a network, don't attempt to explicitly bind to networks as this would override the process-bound-network. Having a process-bound-network is rare case (AFAIK only used by Android's captive portal app to make the WebView only communicate with the captive portal) so it should be fine to simply disable network binding. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic4ec6c4f0da6bc5ff3fa21091282f320e1e93db4 Reviewed-on: https://chromium-review.googlesource.com/727840 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515382}
-
Renee Wright authored
StylePropertySet -> CSSPropertyValueSet ImmutableStylePropertySet -> ImmutableCSSPropertyValueSet MutableStylePropertySet -> MutableCSSPropertyValueSet These names make more sense than the old names now that CSSProperty has been renamed to CSSPropertyValue (as of https://chromium-review.googlesource.com/c/chromium/src/+/753545) Bug: 779928 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I37e2129a94b7f52f15020f9e19089a4222b7637d Reviewed-on: https://chromium-review.googlesource.com/758153 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515381}
-
John Chen authored
Modify desktop builders in chromium.perf waterfall to compile chromedriver, to help projects that use chromedriver for bisecting. Bug: chromedriver:2058 Change-Id: Idbd6ead9a870f3b83b34c3a3f9c3e74bc4c58b74 Reviewed-on: https://chromium-review.googlesource.com/758022Reviewed-by:
David Tu <dtu@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#515380}
-
Yuzhu Shen authored
It reports the total delay, in milliseconds, caused by SafeBrowsing for a resource load, if the SafeBrowsing interstitial page is not showed and therefore no user action is involved. At most one value is reported for each resource load. If SafeBrowsing causes delays at different stages of a load, the sum of all the delays will be reported. BUG=782418 Change-Id: Ie467d181c4f535dbb4e5fcc67a8e23c284a4b4f7 Reviewed-on: https://chromium-review.googlesource.com/756962 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#515379}
-
Peter Boström authored
Introduces CONTEXT_MESSAGE_BOX_BODY_TEXT and styles it like CONTEXT_BODY_TEXT_LARGE and STYLE_SECONDARY under Harmony. This specifically styles the JavaScript dialogs. Bug: chromium:652015, chromium:652017, chromium:683346 Change-Id: I846c33736cfffb368105ea1cd49c2a8079e20b14 Reviewed-on: https://chromium-review.googlesource.com/759409Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#515378}
-
Tom Anderson authored
BUG=753067 R=erg@chromium.org CC=sky@chromium.org Change-Id: I6496f0e7ff269de9f6518c89f8ff03cba0f3cf7e Reviewed-on: https://chromium-review.googlesource.com/762377Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#515377}
-
Rohit Rao authored
After closing the last tab, tests need to wait for the tab switcher animations to complete before opening new tabs. Failing to wait can put the app into an inconsistent state. BUG=768563,783190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4d9434e7d66cbde036c32d2b1d4d6d0733cde031 Reviewed-on: https://chromium-review.googlesource.com/760480 Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#515376}
-
Jacob Dufault authored
Impl is not specific, and since there are going to be two separate implementations it would be better to call it out explicitly. NOPRESUBMIT=true Bug: 719015 Change-Id: Ief5e75c6d00f99366f8ed49a99fcf76ec87fbe1d Reviewed-on: https://chromium-review.googlesource.com/752076 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515375}
-
Vincent Scheib authored
The series of Observer methods for Service, Characteristic, & Descriptor Added/Removed events are marked deprecated. They are rarely used and add API & implementation complexity. They are not reliable for cross platform use, and devices that modify their attribute table have not been tested or supported. Also, GattDiscoveryCompleteForService is marked deprecated as it is not functional on all platforms. Use GattServicesDiscovered. Bug: 710352, 782494 Change-Id: I96aef12d961cf1033c88aa4933bd3882601da1fa Reviewed-on: https://chromium-review.googlesource.com/758057Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#515374}
-
Daniel Bratell authored
X11 headers define a lot of common symbols and that will interfere with other code, in particular in jumbo builds where the X11 headers get wider visibility. This wraps common X11 headers in ui/gfx/x/x11.h and adds the necessary symbols to the namespace x11 instead. So instead of writing XAtom prop_type = None; you now write XAtom prop_type = x11::None; and the same for True, False, Status and a few others. Bug: 782184 Change-Id: I0d1b83720da615c808a2f7a291ddbf7664b26cd8 Reviewed-on: https://chromium-review.googlesource.com/756711 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515373}
-
John Abd-El-Malek authored
The renderer has webui bindings, so it can't load web schemes. BUG=778846 Change-Id: I37cfbaf471381e4d22508ec80fc843f9ced31c8d Reviewed-on: https://chromium-review.googlesource.com/759032 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#515372}
-
Reid Kleckner authored
We needed symbol_level=0 as a workaround for http://crbug.com/706492, but that's fixed upstream, so we don't need it anymore. Most bots used symbol_level=1, so the LLD release bots should too. R=dpranke@chromium.org, hans@chromium.org Bug: 706492, 782784 Change-Id: Idc8596df997a77e278cea82745430adc4eb25644 Reviewed-on: https://chromium-review.googlesource.com/758702Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#515371}
-
Alexei Svitkine authored
Original review: https://chromium-review.googlesource.com/c/chromium/src/+/754079 Reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/760116 Previously, we would use a CoreFoundation-based version of these functions implemented in time_mac.cc because time_t on Mac was capped at year 2038. However, with 64-bit that is no longer the case and we can just use time_exploded_posix.cc. From UMA sampling profiler data (see bug), we know that the CoreFoundation versions of these functions are slow and currently account for around 80ms cost during startup. After this change is submitted and makes it to Canary, we can see how the POSIX versions of these functions perform - hopefully much faster than the CoreFoundation ones. Some code in net/ had assumptions around the min and max years that are supported on different platforms by these functions. To make that logic a bit cleaner, this CL introduces two constants in time.h specifying the platform-specific limits - so that downstream code like net can use them instead of baking their own assumptions. Some net error codes are changing as a result of this clean up - which can be seen in the updated net tests. BUG=781601 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5d10a06dd5b0073bfd943f58af08f67980227d4a Reviewed-on: https://chromium-review.googlesource.com/760443Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#515370}
-
Eugene But authored
The name of the feature is "download" not downloads. Also singular name is consistent with the rest of the names. Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibe34f0088b5cbcfaa669451f053bbe8031e33c38 Reviewed-on: https://chromium-review.googlesource.com/761344Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515369}
-
Pavel Feldman authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ie58b5d9f2c93ecad2d8cabe63f45b3c5787f5283 Reviewed-on: https://chromium-review.googlesource.com/757773 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515368}
-
Pavel Feldman authored
This addresses an issue where DevTools new integration test framework destroyed the DevTools bindings too late, which caused a race where protocol messages were executed in an about:blank page. This resulted in flaky results: CONSOLE ERROR: line 57: Uncaught TypeError: Cannot read property 'dispatchMessage' of undefined Bug: 667560 Change-Id: Idb68cc4e2093f0de6586375be5245271657ea2e2 Reviewed-on: https://chromium-review.googlesource.com/761957Reviewed-by:
Will Chen <chenwilliam@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515367}
-
Maks Orlovich authored
This changes the behavior under LOAD_SKIP_CACHE_VALIDATION to handle Vary:* consistently with other Vary headers. It also makes sense organizationally, since Vary is a separate concept from freshness in the spec, and this change fixes two buglets that previously affected Vary:* because it was handled in effectively the "wrong" spot: 1) We will no longer incorrectly use Last-Modified for validation of Vary:* 2) LOAD_SKIP_VARY_CHECK works for it now. Bug: 778681 Change-Id: Ie6d854d55cfc7ad46ac2db054f42a2e72a4f08fe Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/760539Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#515366}
-
Dale Curtis authored
BUG=777555 TEST=cq Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8343b5afab16dfcf7d0f7438a675593ddef5f30b Reviewed-on: https://chromium-review.googlesource.com/754261 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#515365}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/73dcc60c868f..9e888a46f04d $ git log 73dcc60c8..9e888a46f --date=short --no-merges --format='%ad %ae %s' 2017-11-06 jgilbert Fix HALF_FLOAT/HALF_FLOAT_OES selection with the ES3 backend. 2017-11-06 jgilbert Set TextureGL dirty bits when workaround usage of levels changes. 2017-10-16 oetuaho Work around NVIDIA GLSL vector-scalar op bug Created with: roll-dep src/third_party/angle BUG=772651 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I0ab39fee7818f6f76b30fa7e730a0d98dbd5d8bd Reviewed-on: https://chromium-review.googlesource.com/761238Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515364}
-
CJ DiMeglio authored
This CL is a preparatory CL that gathers up the required parameters for obtaining resources for video frames (viz::SharedBitmapManager*, gpu::GpuMemoryBufferManager*). Along with this intent, it accomplishes a few other things: - Moves creation of VideoFrameCompositor and VideoFrameSubmitter into MediaFactory for ease of testing and moves the use of flags higher up into the code. - Along with this, we now pass the VideoFrameCompositor a WebVideoFrameSubmitter, which also helps with testing. - WebMediaPlayerImpl_unittest has been simplified, using a MockVideoFrameCompositor to narrow down the scope of testing (before this unittest acted more like an integration test). - Splits SubmitFrame into SubmitFrameInternal, controlling access to the VideoFrameProvider in situations where we can't be sure it isn't null. The rest of SubmitFrame is inlined in OnBeginFrame. Bug: 746182 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I40ff88f37be8db91aef89284e8351610ad83f043 Reviewed-on: https://chromium-review.googlesource.com/717263 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Dimitri Glazkov <dglazkov@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515363}
-
Peiyong Lin authored
This patch removes last audible time from MetricsCollector and adds an API in FrameCoordinationUnit to return last audible time. BUG=775691 Change-Id: I17b78285a9403bf85c0443420ed31c9110e5f9ef Reviewed-on: https://chromium-review.googlesource.com/761836Reviewed-by:
Zhen Wang <zhenw@chromium.org> Commit-Queue: lpy <lpy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515362}
-
Reid Kleckner authored
ASan generally reports OOM by printing an ASan error report to stderr and exiting with exit code 1. That interferes with base's termination status classification, and therefore OOM detection. Disable the test for now. TBR=csharrison@chromium.org Change-Id: Ie88b2975cc2fb2fc531462f4cbf98c740b556db2 Reviewed-on: https://chromium-review.googlesource.com/762189Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#515361}
-
Philip Rogers authored
These tests had rls-specific expectations that had an inner-editor that is not present in the actual test. These now match non-rls. Bug: 781419 Change-Id: If54b8ee00f1895c39c4c6ec90b012f88570a6d83 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/762096Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515360}
-
Zhenyao Mo authored
BUG=781349 TEST=compositor_unittests R=danakj@chromium.org Change-Id: I1891709940e0028d65c7f80d126a62696102d7b7 Reviewed-on: https://chromium-review.googlesource.com/759424Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#515359}
-
James Cook authored
I left them commented out in the filter file because they do work, they just seem to trip flaky failures that are not particularly related to the code under test. Bug: 781391, 783450 Test: browser_tests --mash Change-Id: I293c5e4ecb41b35a9effd9ced8d8b5773e7f49d9 Reviewed-on: https://chromium-review.googlesource.com/762336 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515358}
-
Scott Violet authored
I'm a bit hand wavy here as my hope is all this goes away once --mus no longer includes Viz. Will need to reevaluate then. BUG=776513 TEST=test only changes Change-Id: Ib680763d2ad09d6389400e788b9bd434910144f6 Reviewed-on: https://chromium-review.googlesource.com/761709Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515357}
-
David Roger authored
The Dice migration state (i.e. if the profile is consistent and can be migrated now) even when the Dice migration is not actually enabled. This is useful for the "Prepare Migration" step, where we try to make the profiles consistent without actually performing the migration. Bug: 781761 Change-Id: I179dca5d7ee370434df26143edeefd0f34faa3a5 Reviewed-on: https://chromium-review.googlesource.com/758638Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#515356}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ada886c..14592920 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I57975a5b7f2c9657e98ec5f256f1b7b763e64299 Reviewed-on: https://chromium-review.googlesource.com/761738Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515355}
-
Renee Wright authored
Also remove unneeded explicit namespace references Discussion with style guide owners concluded that we should use the Chromium style guide rules for header guards, which in turn refer to to Google C++ style guide https://google.github.io/styleguide/cppguide.html#The__define_Guard This guide says that we should use the full file paths for the guard name. I also looked at the precedent of using paths in header guards in Chrome. Random example from third_part/Webkit/: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webdatabase/WebDatabaseImpl.h There are no examples from gen/ Bug: 779928 Change-Id: Ief1986596a78c5c6c01c1eb94949fce6deea0b7a Reviewed-on: https://chromium-review.googlesource.com/758026Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#515354}
-
John Rummell authored
Draft spec changed MediaKeysPolicy from an interface to a dictionary, so updating the code to match. BUG=782443 TEST=updated layout test passes Change-Id: Iecabda2d0eb662efbce44050994a4241b1ffa4bb Reviewed-on: https://chromium-review.googlesource.com/759057 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#515353}
-
John Rummell authored
To ensure the file name is allowable on all file systems, limit it to be only letters (A-Za-z), digits(0-9), or "._-". It also must be between 1 and 256 characters long. Current CDMs do not currently use names that violate these new restrictions, so there is no problem with existing saved files. BUG=771359 TEST=encrypted media browser_tests pass Change-Id: Id5926c7391f18336718bbd4b145c2bf88968c704 Reviewed-on: https://chromium-review.googlesource.com/759736Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515352}
-
Sam McNally authored
Some //content interface binders are registered in both RenderFrameHostImpl's BinderRegistry and the WorkerInterfaceBinders. After trying to bind using the RenderFrameHostImpl's BinderRegistry but before passing the request to the embedder, try binding frame interface requests using the worker BinderRegistry. Interfaces with a frame-specific implementation continue to be handled directly by the RenderFrameHostImpl-registered binder; interfaces handled by the embedder continue to be forwarded to ContentBrowserClient::BindInterfaceRequestFromFrame(). Interface requests are still filtered by the per-context-type capability specs in the content_browser manifest so this does not change which interfaces are exposed to each context type. Rename WorkerInterfaceBinders to RendererInterfaceBinders to reflect its coverage of all renderer context types. Remove common interface binders from RenderFrameHostImpl's BinderRegistry. Bug: 779444 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I49e6c5658b9f545214eeaf1f13828bfddc2081f0 Reviewed-on: https://chromium-review.googlesource.com/758297Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#515351}
-
- 09 Nov, 2017 1 commit
-
-
James Cook authored
We'll see how stable they are over the weekend. Bug: 678687 Change-Id: I85c50f47f1e1f148f7e52bc7f09be7cf5eee4d25 TBR=sky@chromium.org Change-Id: I85c50f47f1e1f148f7e52bc7f09be7cf5eee4d25 Reviewed-on: https://chromium-review.googlesource.com/762403Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#515350}
-