- 03 Oct, 2018 40 commits
-
-
yusukes authored
BUG=b:116761000 TEST=None Change-Id: I183b22eaa8c1bebad3f2797604bf7a98712c958d Reviewed-on: https://chromium-review.googlesource.com/c/1252385Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596339}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1709049243e..bfa76f20bfcf git log f1709049243e..bfa76f20bfcf --date=short --no-merges --format='%ad %ae %s' 2018-10-03 robertphillips@google.com Add GM for less common YUV formats (take 2) Created with: gclient setdep -r src/third_party/skia@bfa76f20bfcf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I107c872f19588728980df853ca7e5d470d6a9e33 Reviewed-on: https://chromium-review.googlesource.com/c/1259402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596338}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5cc52fbcc765..18c0a2b44777 Created with: gclient setdep -r src-internal@18c0a2b44777 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icdd628529a8ce0c45c9d2697f187464ad6eda22b Reviewed-on: https://chromium-review.googlesource.com/c/1259482Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596337}
-
Timothy Loh authored
While the other classes in chrome/browser/chromeos/crostini are in the crostini namespace, the crostini_util functions are currently in the global namespace. For consistency, this CL moves these to the crostini namespace. Change-Id: Idf46afb76f1196a6a0ab961ea53195e536623bc4 Reviewed-on: https://chromium-review.googlesource.com/c/1250263Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#596336}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7988589e4858..59021ba4e1dc git log 7988589e4858..59021ba4e1dc --date=short --no-merges --format='%ad %ae %s' 2018-10-03 sprang@webrtc.org Refactoring of VP8 TemporalLayers interface. Created with: gclient setdep -r src/third_party/webrtc@59021ba4e1dc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I711ec23882236e0eaeacb79d40d2d93d036d6da9 Reviewed-on: https://chromium-review.googlesource.com/c/1259106Reviewed-by:
-
Benjamin Ackerman authored
Removing everything associated with inline installation as it is deprecated per the announcement in https://blog.chromium.org/2018/06/improving-extension-transparency-for.html Bug: 882045 Change-Id: Ia24cb4076a841d9b37febe68cad89db7ea1ce1c8 Reviewed-on: https://chromium-review.googlesource.com/c/1220299Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Benjamin Ackerman <ackermanb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596334}
-
Jun Mukai authored
This is phase-1 of tab-dragging with touch on Mash. This CL adds GestureRecognizerObserver class, which will be used in upcoming CLs. BUG=867074 TEST=events_unittests Change-Id: I7a8c50ac16b58e1c3e31c7f0d8df097489ee49c3 Reviewed-on: https://chromium-review.googlesource.com/c/1247101 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
rbpotter authored
(1) Increase line height for destinations items (2) Remove "Advanced" label for printer options button (3) Remove margin on paper-icon-button so Print with system dialog... does not wrap (for English + normal font size) (4) Change pages per sheet label to sentence case (5) Fix alignment of "Destinations" label with printer names, particularly for printers that do not have a status/location displayed. Bug: 891375, 891378, 891379, 891395, 891577 Change-Id: I13fbcd167e2e9ee513ef056ce5c9e471248dd3d8 Reviewed-on: https://chromium-review.googlesource.com/c/1257370 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596332}
-
Ryan Sturm authored
This CL moves the state of whether DRP can skip the long term blacklist checks for Previews from DRPConfig to PreviewsDecider. This happens through some thread Posts, and will eventually move to one thread PostTask instead of 2 when Previews is on the UI thread. Bug: 842233 Change-Id: Id8129338eeb1b2401f8f70ab2d02aebcbbd5c0e1 Reviewed-on: https://chromium-review.googlesource.com/c/1252783 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#596331}
-
Bailey Berro authored
This change adds a GetWindowsUNCString method to the SmbUrl class so that Windows style UNC can be displayed rather than the smb:// style URL. Bug: chromium:889289 Change-Id: If7f9d3235a7cd38ac854d6bd186ea4af257de6be Reviewed-on: https://chromium-review.googlesource.com/c/1256107Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#596330}
-
Scott Graham authored
This is the very initial stages of writing a bindings generator to allow interop to/from JS with FIDL. The main pieces are: - the build time generator which consumes the JSON IR from `fidlc` and outputs a fidl.js - integration with gn in fidl_library.gni - a JS runtime support library (mostly helps with message encoding) - new unittest binary (which also currently holds some Zircon integration points that will eventually be moved to a C++ runtime support library.) There are many, many things it does not yet handle, e.g. responses (either sync or async), events, passing structs, passing unions, ... For reference, test/simple.fidl generates this https://gist.github.com/sgraham/3935c64d5bc1b67eea1f6e3b38fef6f1 Bug: 883496 Change-Id: I58e5d2b81213f20a3198b68cbd2bc01660ba58f7 Reviewed-on: https://chromium-review.googlesource.com/c/1222697Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596329}
-
Reilly Grant authored
This change updates RemoveSafeBrowsingCookieTester and its base class RemoveCookieTester to use the CookieManager Mojo interface instead of the net::CookieStore interface directly. These tests now pass however I am leaving them marked as disabled until issue 812589 is investigated more thoroughly. Bug: 721395,812589 Change-Id: Iaadf98b31969bd159dfda5f5ff0802b8c8dd3239 Reviewed-on: https://chromium-review.googlesource.com/c/1257785 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#596328}
-
Antonio Gomes authored
This is a preparation CL for bug 879777, where data_reduction_proxy::WarmupURLFetcher is being migrated away from URLFetcher in favor of SimpleURLLoader. WarmupURLFetcher unittests' correctness relies on checking whether the appropriate net::ProxyServer instance is used. This CL makes this information available through network::ResourceResponseInfo. Note that, because it is a non-trivial c++ object, an specific IPC trait was implemented, so that the object can be passed across mojo pipes. BUG=879777 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I3728ba3173a23ad59dd3bf00877d7b1131944488 Reviewed-on: https://chromium-review.googlesource.com/c/1251642Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Change-Id: I62c9193ac74ea77280197438b1d91fa252200f1e Reviewed-on: https://chromium-review.googlesource.com/c/1257149 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch reverts a part of crrev.com/367a97eb. This seems to have caused DCHECK failures on one of the telemetry tests. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Bug: 891270 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib99768154470fe69796e3a47645ffb1c981661a9 Reviewed-on: https://chromium-review.googlesource.com/c/1259298Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596325}
-
Clark DuVall authored
After crrev.com/c/1242296, we no longer need to proxy browser initiated requests with webRequest. This cleans up the proxy for the URLLoaderFactory used for browser initiated requests. Bug: 888672 Change-Id: I96c55fa5849285ae8f86c4b6d7c24d47c8ac4c19 Reviewed-on: https://chromium-review.googlesource.com/c/1254725 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#596324}
-
Tom Sepez authored
Change-Id: I91e90d653c45fc7a8bebd433f10907a7c35caa0b Reviewed-on: https://chromium-review.googlesource.com/c/1258976Reviewed-by:
-
Aaron Colwell authored
Change-Id: Ib4f291702a3e0c388c12b112724c735b808251d1 Reviewed-on: https://chromium-review.googlesource.com/c/1259464Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#596322}
-
erikchen authored
Layout test initialization is non-deterministic. WidgetInputHandler::OnFocus() races against the contents of the layout test, which may also attempt to set/unset focus -- the ordering between the two is non-deterministic. This CL adds a FlushForTesting() message to WidgetInputHandler to make the ordering explicit. Bug: 889036, 889952 Change-Id: I26adca82915e75a9941c93b60a555f0c16084014 Reviewed-on: https://chromium-review.googlesource.com/c/1255782Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596321}
-
Stephen McGruer authored
These tests are failing flaky with crashes. TBR=pnoland@chromium.org Bug: 891419 Change-Id: I99d699e29e3be1f0d167531fe702011bbf2c3c9e Reviewed-on: https://chromium-review.googlesource.com/c/1259422 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596320}
-
Leonard Grey authored
flagsChanged: is under-documented, but in Apple's examples, the actual key which causes the change flag is provided in the |keyCode| property and |modifierFlags| is used to determine whether it's a keyup or keydown. When sending command key combinations via AppleScript (and possibly other methods), the system feeds us a flags changed event with modifier flags set correctly for "Command down" but an unset key code. Since key code 0 is A, we interpret this as Cmd+A (select all) when no such thing was intended. The correct event is sent as well (with, for example, key code 55 for left command), so we should drop the key code 0 event instead of trying to intepret it. Hopefully this change also fixes https://crbug.com/885163 Bug: 889618 Change-Id: Ibc8fe0216b917cc50a23c252209f2ac09a10edf9 Reviewed-on: https://chromium-review.googlesource.com/c/1259243Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#596319}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a1c846c4cf3f..f9e0498bb1ce git log a1c846c4cf3f..f9e0498bb1ce --date=short --no-merges --format='%ad %ae %s' 2018-10-03 thestig@chromium.org Simplify CFX_FontSourceEnum_File's file iterator. Created with: gclient setdep -r src/third_party/pdfium@f9e0498bb1ce The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I820449983fba5cf85c8263619a988e24d245ad37 Reviewed-on: https://chromium-review.googlesource.com/c/1259105Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/22300e1fb562..6af3aa854956 git log 22300e1fb562..6af3aa854956 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 brucedawson@chromium.org Support omitting the space after -C Created with: gclient setdep -r src/third_party/depot_tools@6af3aa854956 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:890744 TBR=agable@chromium.org Change-Id: Icd16a680abeca3e8c534c04e6ad6a0e743a06bbd Reviewed-on: https://chromium-review.googlesource.com/c/1259103Reviewed-by:
-
Caleb Rouleau authored
This fixes the exception: File "/b/s/w/ir/testing/scripts/run_telemetry_benchmark_as_googletest.py", line 176, in run_benchmark if rc == 0: UnboundLocalError: local variable 'rc' referenced before assignment TBR=nednguyen Bug: 891332 Change-Id: I81b8502f8f95bf8db070d8ccc062a343b062e880 Reviewed-on: https://chromium-review.googlesource.com/c/1258978 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:Ned Nguyen <nednguyen@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596316}
-
Ian Clelland authored
Bug: 888668 Change-Id: I2ca249628b9395480f5dfcaaf2b300046dba9b2c Reviewed-on: https://chromium-review.googlesource.com/c/1243503Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#596315}
-
Ian Clelland authored
Bug: 888668 Change-Id: Iddc72d0638ddebbab044f070237d6bd885c557aa Reviewed-on: https://chromium-review.googlesource.com/c/1243523Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#596314}
-
Becca Hughes authored
This CL converts AudioFocusManager to use mojo MediaSessions and converts the required methods. We also add a mojo MediaSessionObserver to keep track of MediaSession state. This changes the AudioFocusManager logic slightly so we recieve a request ID when we get focus. This is used to identify the MediaSession in the future when we want to abandon or request a different audio focus type. Adds GetMediaSessionInfo which gets session state in a struct to avoid needing multiple calls over Mojo. Makes GetDebugInfo public which is needed by Mojo media session implementations. The next step will be to move AudioFocusManager to the media session service. BUG=875004 Change-Id: Ideb7c761c647bb057ab988f0af9bf867688df3fe Reviewed-on: https://chromium-review.googlesource.com/c/1187707Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596313}
-
Luke Sorenson authored
establish for the test app. Bug: 889151 Test: Deployed to guado device and verified that a connection can be Change-Id: I2704c373b30efb49b2932f30f24939c7f9dbb7b2 Reviewed-on: https://chromium-review.googlesource.com/c/1220728 Commit-Queue: Luke Sorenson <lasoren@chromium.org> Reviewed-by:Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Misha Efimov authored
The cronet_package target packages cronet library, headers and license into $root_out_dir/cronet. Disable histogram manager on Mac and Win platforms to reduce binary size. Bug: 786559 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: I3f5ac065e405734260926ea774b9fa08efa4d060 Reviewed-on: https://chromium-review.googlesource.com/c/1255802 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596311}
-
Brandon Wylie authored
Specifics: +6,604 bytes normalized apk size +1 zip entries file count +5,308 bytes main dex size InstallSize: +1,296 bytes APK size +22,740.32 bytes Estimated installed size InstallBreakdown (+24,585.32 bytes): +268 bytes Non-compiled Android resources size +173 bytes Package metadata size +23,436.32 bytes Java code size +708 bytes Compiled Android resources size Dex: +23 entries fields +33 entries methods +3 entries types +9 entries strings Change-Id: I9dcf0da1a60a2d50925a68bc0b5345245b64059d Reviewed-on: https://chromium-review.googlesource.com/c/1257654 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#596310}
-
Joe Downing authored
This is a preventative fix for the case where the pacing bucket has a zero rate. We may want to continue investigating why the bucket has a zero rate though (that can be a follow-up CL though). This was a tricky one to track down as the crashes from the last 2 releases had optimized stacks which obfuscated the exact LOC which was causing the divide by zero. I looked back to our earlier releases and found that this crash was occuring back then (lower hit rate due to fewer connections using WebRTC back then) with the same base stack but pointing to the LOC I am addressing in this CL. Bug: 891725 Change-Id: Ic42e910614d35c683959b8c6e4417b0197a63818 Reviewed-on: https://chromium-review.googlesource.com/c/1258823Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#596309}
-
Joe Downing authored
This change adds a fudge factor of ~1px to the logic which determines whether to reshow the disconnect window after it has been hidden. I suspect the reports of the window being reshown are due to small accumulations for the cursor position or potentially just raw input events where the cursor does not change. We want to avoid reshowing the dialog in cases such as this because it is quite annoying for the remote user. Bug: 891584 Ignore mouse messages if the position or button states don't change We've received reports that the disconnect window is appearing at odd times after the auto-hide timeout has taken effect. I suspect there could be hardware which is emitting spurious HID events which is triggering the reshow logic. My assumption is that this behavior is't egregious, otherwise the user would notice the mouse cursor moving or errant keypresses. Thus I want to prevent triggering the reshow logic if we receive a RAWINPUT event where the cursor has not moved and no button states have changed. Change-Id: I310f2cb4a5f30b0b7e14bf7221d250030492add8 Reviewed-on: https://chromium-review.googlesource.com/c/1258979 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#596308}
-
Takumi Fujimoto authored
For Hangout sinks in the AVAILABLE state, show its domain as the status text in the sink list. Screenshot: https://drive.google.com/open?id=1pOk8gsxW5MH8sUFJeg1WMLFanMtclPKv Bug: 891087 Change-Id: I7faf94e4d89a03da8487264aae2aa73e95debb7c Reviewed-on: https://chromium-review.googlesource.com/1258245 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#596307}
-
Alexei Filippov authored
The sampler used to always record the very first allocation on each thread because the accumulator is initialized with zero. The patch makes such allocations be treates as all the others. BUG=803276 Change-Id: I3eeec1e069ecc640e6c9756f707dfc336d16e159 Reviewed-on: https://chromium-review.googlesource.com/1257597 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596306}
-
Boris Sazonov authored
This CL fixes the color of the Download icon in the three-dots menu. The appearance of this icon was broken by https://crrev.com/c/1245786. Apparently, a color filter set on drawable by AppMenuPropertiesDelegate overrides ImageView.setImageTintList used by ImageViewCompat on API 21+. Fortunately, there's no need to manually tint the drawable, because AppCompatImageButton for the Download icon is always tinted. This CL removes the manual tinting of the drawable. Bug: 891645 Change-Id: I9eb9f326445e044a77fa8802b6816e5bc16e0993 Reviewed-on: https://chromium-review.googlesource.com/1258987Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#596305}
-
Xianzhu Wang authored
Cc requires that a rectangular clip is 2d-axis-aligned with the render surface to correctly apply the clip. When we find that a rectangular clip is not 2d-axis-aligned with the render surface, we should create an effect node and let it create a render surface. Bug: 890919 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6f7b462d5506949d1571c60231e066d27b9a238d Reviewed-on: https://chromium-review.googlesource.com/1244104Reviewed-by:
-
Matthew Jones authored
This patch adds a check for tablet in the logic that decides whether a light or dark title is used. Bug: 891666 Change-Id: I6f05aa06ef01cd67a1f58a12e6f7436debe74e6b Reviewed-on: https://chromium-review.googlesource.com/1259285Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#596303}
-
rbpotter authored
Adding/modifying tests to cover some newly tweaked behaviors and a recent regression: (1) Destinations dialog correctly does not close if escape is pressed while in the search box if there is any text, but does close if there is no text. (2) Copies setting correctly stays valid for an empty input, and the input is reset to the default value if blurred. However, if an invalid value is explictly entered, the setting does not stay valid or reset to the default value when cleared. (3) Number settings sections correctly block 'E' and '+' key events. (2) is broken into 2 separate tests. The new interactive test for number-settings-section validates the reset/no reset on blur behavior. The additions to the SetCopies test verify that the setting value is correctly set/not set for the various cases. Bug: None Change-Id: If7e3461c525c9cf057ac9404d5bf5da5da03e9f2 Reviewed-on: https://chromium-review.googlesource.com/1252339 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/457799c2a3af..5cc52fbcc765 Created with: gclient setdep -r src-internal@5cc52fbcc765 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734 TBR=mmoss@chromium.org Change-Id: I2531849fbfae321612a79fb6828ea363a93ed5ae Reviewed-on: https://chromium-review.googlesource.com/1259262Reviewed-by:
-
Fady Samuel authored
This CL enables throttling of child synchronization events. In a child- initiated synchronization, the child's frame will likely activate before the dependent parent's CompositorFrame arrives. Upon activation, the child will see that the new surface does not cause any damage to the display (because it's not embedded by any parent yet) and calls the draw callback immediately, thereby sending back a DidReceiveCompositorFrameAck to the client immediately. This, in turn, results in the client sending another CompositorFrame to Viz, and another and so on, letting the child get further and further ahead of the parent. This results in a lot of wasted work because the child's surface will not be shown on screen until the parent embeds it and so multiple child initiated synchronization events are pointless. This CL throttles DidReceiveCompositorFrameAck of the child on child-initiated synchronization events until the parent references the child. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I62416d87f8d871b32f4caad565cff515a9c55445 Bug: 672962, 879207 Reviewed-on: https://chromium-review.googlesource.com/1236931 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596300}
-
