- 27 Feb, 2020 40 commits
-
-
Mark Schillaci authored
This CL creates a throttling/debouncing effect in Android that will limit the number of events being sent by Chrome. We decided to go with an approach that is a mix between a typical "throttle" and "debounce". We want to ensure: 1. No solitary (first) event is delayed 2. The last event sent is accurate 3. No two events of the same type are fired in a given timespan When we are ready to fire an event of a type that has not been fired before, then we send it without any delay. We record this time to start a timer, and we enforce the rule that no event of the same type can be sent within that delay window (200 ms). When an event of a duplicate type is sent in that window it is queued to be sent after the delay. Any subsequent events would replace the event in the queue but not modify the delay time. This ensures we never delay an initial event, the final even sent is the final event received, and no two events of the same type can be sent in any 200 ms timespan. Bug: b143730839 Change-Id: If17e946ee394b22da0a9e6c290a725dcaf9bac34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067443 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#745231}
-
Kent Tamura authored
HTMLOptionElement's InsertedInto() and RemovedFrom() called MenuListSelectType::UpdateTextStyleAndContent(), which updates a Text node in a UA shadow tree. It triggered a DCHECK failure about IsSlotAssignmentRecalcForbidden(). We should not update the DOM tree in these functions. This CL moves the logic of the InsertedInto() and the RemovedFrom() to HTMLSelectElement::ChildrenChanged() and |HTMLOptGroupElement:: ChildrenChanged()|. As for kAllChildrenRemoved such as |select.innerHTML=''|, ChildrenChanged() had no ways to know removed nodes. This CL adds ChildrenChangedAllChildrenRemovedNeedsList flag, and ContainerNode provides a list of removed nodes if the flag is true. This CL also updates comments on Node::InsertedInto(), Node::RemovedFrom(), and ContainerNode::ChildrenChanged(). Bug: 1056094 Change-Id: I5a28a371b8bacd6551f17acfaf681032d615f1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074840Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#745230}
-
David Bokan authored
This CL fixes an issue introduced in https://crrev.com/c/1999288. Scrollers can set |user_scrollable_horizontal| (or vertical) to false to indicate that the user shouldn't be able to scroll them This corresponds to |overflow: hidden| in CSS (which can still be programmatically scrolled). In several places, compositor code checks these bits and, if false, clears the requested scrolling delta in the disabled axis. The bug in the CL above was that, now that the scrolling paths were consolidated, we moved this "user_scrollable" adjustment from the update animation curve to happen as part of the common path in ScrollUpdate so that it would happen for all kinds of scroll modalities in one place. However, this adjustment is too simplistic for viewport scrolling. Scrolling the outer viewport must use the cc::Viewport class which will distribute the scroll between both inner and outer scroll nodes. The outer viewport may have user_scrollable=false, corresponding to the documentElement having |overflow: hidden| but we should still be able to scroll the inner viewport if the user zooms in. The above adjustment prevents that since it clears the delta. (I suspect this issue existed prior to this in the "update existing animation" case but is hard to hit since pinch-zoom and animated wheel scrolling aren't a common combination). The solution here is to move these adjustments to the point of node scrolling. This means that we'll adjust the delta right before applying a scroll to an individual ScrollNode. This ensures the entire delta is sent to the viewport which has special cases for dealing with the double nodes. Bug: 1055790 Change-Id: I2e9849b15c512003352299fc82e58817a98ef778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072407 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#745229}
-
Yue Li authored
Bug: b/150238588 Test: Running the test locally for 20+ times Change-Id: I320c8a3c0d1f2e2cfc0155de950632649025c633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076795 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745228}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/11efa18eca9f..dbb0a25d1fab git log 11efa18eca9f..dbb0a25d1fab --date=short --first-parent --format='%ad %ae %s' 2020-02-27 senorblanco@chromium.org Skia-Dawn: update for recent GrRenderPass::onDraw* changes. 2020-02-27 bsalomon@google.com Fix NVPR with explicitly sampled FPs. 2020-02-27 mtklein@google.com add metadata to calculated bounds Created with: gclient setdep -r src/third_party/skia@dbb0a25d1fab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I22cb2c0c4aa687f85e4b25085da778fc51bb1281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079282Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745227}
-
Christopher Thompson authored
Bug: 1055906 Change-Id: I974c8cc5993299a6611c4bd14f515c865d9bef02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073218Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#745226}
-
rbpotter authored
This is in preparation for migrating settings-languages to Polymer 3. Bug: 1026426 Change-Id: I375d9dfa5868a78d20fccc7184601975936047b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076763 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#745225}
-
Jinsuk Kim authored
This CL introduced additional parameter |lazyLoad| in TabModelObserver.didAddTab, TabModelSelectorObserver.onNewTabCreated to allow the info UrlLoadParams for a lazily-loaded Tab to be passed through these observers instead of TabImpl API |hasPendingLoadParams|. Bug: 995903 Change-Id: I0d79338529c04001e8b06c7754446296dbae4ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053227Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#745224}
-
Garrett Beaty authored
We do not trigger other builders from try builders, so the property is irrelevant. Change-Id: I45c4ef7be624c779e0cb2e557103c426f54d6eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079434 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#745223}
-
Henrique Nakashima authored
Change-Id: Icd86dccbea865e42373500f08fa354383150bff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079230Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#745222}
-
Katie Dektar authored
[Sheriff] Revert "Roll src/third_party/devtools-frontend/src 29c52f9cafce..4665866ae8db (4 commits)" This reverts commit dee355ff. Reason for revert: Speculative fix for build breakage which mentions typescript: Traceback (most recent call last): File "../../third_party/devtools-frontend/src/third_party/typescript/ts_library.py", line 113, in <module> sys.exit(main()) File "../../third_party/devtools-frontend/src/third_party/typescript/ts_library.py", line 90, in main copy_all_typescript_sources(sources, path.dirname(tsconfig_output_location)) File "../../third_party/devtools-frontend/src/third_party/typescript/ts_library.py", line 109, in copy_all_typescript_sources shutil.copy(generated_javascript_location, dest) File "/b/s/w/ir/cipd_bin_packages/cpython/lib/python2.7/shutil.py", line 139, in copy copyfile(src, dst) File "/b/s/w/ir/cipd_bin_packages/cpython/lib/python2.7/shutil.py", line 97, in copyfile with open(dst, 'wb') as fdst: IOError: [Errno 2] No such file or directory: '/b/s/w/ir/cache/builder/src/out/Debug/resources/inspector/formatter_worker/FormattedContentBuilder_test.js' Original change's description: > Roll src/third_party/devtools-frontend/src 29c52f9cafce..4665866ae8db (4 commits) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/29c52f9cafce..4665866ae8db > > git log 29c52f9cafce..4665866ae8db --date=short --first-parent --format='%ad %ae %s' > 2020-02-27 jacktfranklin@chromium.org Typescriptify FormattedContentBuilder + move tests > 2020-02-27 kahinds@microsoft.com Remove transparent border-top from Elements tree rows > 2020-02-27 tvanderlippe@chromium.org Run TypeScript without building mode > 2020-02-27 jacktfranklin@chromium.org Update screenshot testing to enable element screenshots > > Created with: > gclient setdep -r src/third_party/devtools-frontend/src@4665866ae8db > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: chromium:1011811,chromium:1048378,chromium:1051458 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I256e61998f62ceac547d1f7c42dbed56f70ff533 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078606 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#745197} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic7cdfe15a103c24a23f5620e572350e50217860e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1011811, chromium:1048378, chromium:1051458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079381Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#745221}
-
Kazuhiro Inaba authored
On GPUs that only supports FP16 arithmetic, just doing a copy between the same size of large (>1024px) rectangles already introduces some imprecision. Using GL_NEAREST in such a case increases the quality and produces results closer to pixel-perfect copying. BUG=b:141898654 TEST=android.view.cts.SurfaceViewSyncTest#testSmallRect on kukui (ChromeOS) Change-Id: I2d58ee387122b3977e8e3f439179ce01ff5bf14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076642Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#745220}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ad3e42a439e2..05f5e0b34ac8 git log ad3e42a439e2..05f5e0b34ac8 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 jmadill@chromium.org Add codereview.settings. Created with: gclient setdep -r src/third_party/swiftshader@05f5e0b34ac8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0f048771555b5975ae060f3ebc05fe76bd43956e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079276Reviewed-by:
-
rbpotter authored
This is needed to autogenerate a JS module version of chrome/test/data/webui/settings/fake_language_settings_private.js Bug: 1026426 Change-Id: I5b3886cde240494235dda367f43af1d0e90a3085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076556Reviewed-by:
-
Xing Liu authored
Mobile.SystemNotification.* is core Android notification metrics to meature the stability of all Android notifications shown in Chrome. This CL marks them to be never expired. Noticed these are used by multiple teams. TBR=holte@chromium.org Bug: 1055423,1055440,1055441,1055443 Change-Id: I67a2df90bfbfa6319a5891344d89d055e44153b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067830 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#745217}
-
nancy authored
AppUninstallDialogView replaced ExtensionUninstaller, so ExtensionUninstaller can be removed. https://cs.chromium.org/chromium/src/chrome/browser/ui/views/apps/app_uninstall_dialog_view.h?l=44 BUG=1010303 Change-Id: I215dad0977b2d37bc126ac68e06689eb0a3b0c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076857Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#745216}
-
Tim Song authored
BUG=1040648 Change-Id: Ifb92fcb180c8b6a504cc2d22165b9b7bf96499bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072821Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#745215}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0363c3e46d35..e299afa9ec11 git log 0363c3e46d35..e299afa9ec11 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 enga@chromium.org Support CPU adapters in dawn_end2end_tests Created with: gclient setdep -r src/third_party/dawn@e299afa9ec11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic838b8d59801bdc7b883e07af475864ee3f24cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078602Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4112d4f0c61a..840d5db64e4d git log 4112d4f0c61a..840d5db64e4d --date=short --first-parent --format='%ad %ae %s' 2020-02-27 rwkeane@google.com mDNS: Update MdnsQuerier Relevant Answer Filtering Created with: gclient setdep -r src/third_party/openscreen/src@840d5db64e4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I4f22dc4e0ccfe2682ffa21f1fb8e5227b85ca20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079271Reviewed-by:
-
dpapad authored
Bug: 1026426 Change-Id: I3c8f1da0776a279d250969a2c2384339b405ae51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076544 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#745212}
-
Kevin McNee authored
These imports were almost ordered alphabetically and had some duplicates. Bug: None Change-Id: I3ada8bcbc9d8956ca74c6bb37c358b96f7f3975b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079136Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#745211}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/29d5cf85ac28..a4f9aa037585 git log 29d5cf85ac28..a4f9aa037585 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 iannucci@chromium.org Refactor OWNERS for LUCI-related tools. Created with: gclient setdep -r src/third_party/depot_tools@a4f9aa037585 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Idc7d60aab072dbde783f4049a8b654d12fd6c144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078608Reviewed-by:
-
Jarryd authored
Add calls to QuotaManagerProxy::NotifyWriteFailed() where ServiceWorker write errors might occur. With this information, the quota system can reasonably guess if the disk storing the user's profile is out of space, and decide if any actions should be taken. Bug: 997258 Change-Id: I2d2216d69cbfb9609d895c28afc8af18d444e243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050752 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#745209}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6e167903252f..4745a47b272f git log 6e167903252f..4745a47b272f --date=short --first-parent --format='%ad %ae %s' 2020-02-27 thestig@chromium.org Clean up ReportUnsupportedFeatures(). 2020-02-27 thestig@chromium.org Make ReportUnsupportedXFA() more efficient. 2020-02-27 dhoss@chromium.org Space-efficiently destroy chained CXFA_FMSimpleExpression instances 2020-02-27 dhoss@chromium.org Create abstract class CXFA_FMChainableExpression 2020-02-27 thestig@chromium.org Handle case of nothing to restore in SkiaState::ClipRestore(). 2020-02-26 thestig@chromium.org Roll DEPS for build/ and tools/clang/ Created with: gclient setdep -r src/third_party/pdfium@4745a47b272f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052724,chromium:986108 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I4345a5910c260f0309fbd45efc25e2627469c669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079036Reviewed-by:
-
Manu Cornet authored
Separate logic of calculating target bounds and actually updating layout. Bug: 1047012, 1042918, 1056514 Change-Id: Iffba0d8b691ed45a04447274a3e8ed174268c70c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076421 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c93595b4b916..729310aa1810 git log c93595b4b916..729310aa1810 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 alessiob@webrtc.org iSAC fixed|float encoder fuzzers 2020-02-27 alessiob@webrtc.org Opus Encoder fuzzer: separate target for FuzzAudioEncoder 2020-02-27 srte@webrtc.org Adds binary proto ANA support in scenario tests. 2020-02-27 srte@webrtc.org Use the last video stream for scenario tests stats. 2020-02-27 danilchap@webrtc.org Make ProcessThread be a TaskQueue implementation 2020-02-27 alessiob@webrtc.org iSAC API wrapper unit test fix 2020-02-27 titovartem@webrtc.org Add ability to enable AV sync in PC level tests 2020-02-27 hta@webrtc.org Remove deprecated "description" field of cricket::ContentInfo Created with: gclient setdep -r src/third_party/webrtc@729310aa1810 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I49a95c0aa208406bd182c9a8c8f1dc503fdfcebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079333Reviewed-by:
-
James Cook authored
The crash is a CHECK failure that the user's email and gaia ID are non-empty. I introduced the regression in this CL: cros: Migrate assistant off the identity service http://crrev.com/c/2033572 The CHECK was moved to its current location in this CL: Reland "assistant: Fix mic button doesn't work with fake gaia account." http://crrev.com/c/2053284 It's not clear if Assistant is supposed to work in Active Directory accounts. AD accounts don't seed the IdentityManager with an email or gaia ID, so it's unclear to me if/how Assistant ever worked. I did not add a unit test for the fix because it's not clear if the empty email/gaia ID is expected behavior or not, so I don't want to enforce support for it in tests. Bug: 1056717 Change-Id: Ib17100c6b2f403d8782f5f7faed79b7d64aac1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078841 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#745205}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5084b4ef. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I8e82f9856f2ea6572fe9ea95043f02370b628a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079094Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745204}
-
Peng Huang authored
Bug: 1053239 Change-Id: Icb94e544439360bc34d709755702ebf731f21100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070558 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#745203}
-
Ahmed Fakhry authored
The windows of removed desks should be demoted to be LRU across all desks. That's why they're appended at the end of the overview grid list. However, their relative order should be maintained. This CL makes sure the MRU order is updated to match the above expectation, as well as the windows' stacking order (that is windows of the removed desk should be stacked at the bottom of the target desk's container's children). BUG=1048271 TEST=Expanded existing tests. Change-Id: I400b2ac3ce2b5de1f1d8defaff7c4d155e4fab29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076670 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#745202}
-
Scott Violet authored
This patch makes it possible (guarded by flag) for block-flow to handle -webkit-line-clamp. Change-Id: I6b64d7402892578344a1c30e8ac167fa87e258d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034898 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#745201}
-
Vadim Bendebury authored
The util/tpm_hash_gen.py script from Chrome OS EC tree cr50_stab branch was used to generate version strings for all images. BUG=chromium:728134 TEST=None Change-Id: If12f3f8924fdc43140c76797607ab8423214e27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076014Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#745200}
-
Sorin Jianu authored
This change uses prefs to store and retrieve app ids for the apps registered for updates. Bug: 1020285 Change-Id: I92f08bbc31979fa80e5621e2bd00d1c83cb5c11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079142Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745199}
-
Becca Hughes authored
Add support for clearing media history if we clear it by origin. BUG=1024352 Change-Id: I8c053d8cca11b0a63b1e4cc9168acf8fbc3b3e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057634Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#745198}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/29c52f9cafce..4665866ae8db git log 29c52f9cafce..4665866ae8db --date=short --first-parent --format='%ad %ae %s' 2020-02-27 jacktfranklin@chromium.org Typescriptify FormattedContentBuilder + move tests 2020-02-27 kahinds@microsoft.com Remove transparent border-top from Elements tree rows 2020-02-27 tvanderlippe@chromium.org Run TypeScript without building mode 2020-02-27 jacktfranklin@chromium.org Update screenshot testing to enable element screenshots Created with: gclient setdep -r src/third_party/devtools-frontend/src@4665866ae8db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1048378,chromium:1051458 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I256e61998f62ceac547d1f7c42dbed56f70ff533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078606Reviewed-by:
-
Nico Weber authored
Bug: 1056189 Change-Id: Iee607dda6c4788d836115c53e43c5c93f63486a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078426 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745196}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f99345291868..9b194b7a67c8 Created with: gclient setdep -r src-internal@9b194b7a67c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1012975 Tbr: jbudorick@google.com Change-Id: I7cf8aa119cde51c7b3ed4df83ba525df3830f1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079045Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745195}
-
evliu authored
This CL adds a histogram metric to track the percentage of caption settings that come from the system settings. Bug: 1056381 Change-Id: Ia8e7dee0e521f986e6bcbfcd887702d6ef63dd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076542Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#745194}
-
Nico Weber authored
This reverts commit bf1f5892. Reason for revert: It's not clear why we want this, see discussion on bug. (And it prevents typing suggestions and emojis in gmail.) Original change's description: > Make autocorrect=off and spellcheck=false disable Touch Bar typing suggestions. > > Bug: 1024914 > Change-Id: I3ff68438b028fe38ad7270d7f90772b595f4f46e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917603 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715401} TBR=avi@chromium.org,sdy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1024914 Change-Id: Ib14cd55fde1af09cd2485d86724ce480fa431c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079174 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745193}
-
Nicolas Ouellet-Payeur authored
This reverts commit a1b98ca7. Reason for revert: https://crbug.com/1054895#c27 Original change's description: > Traffic annotation auditor: fix Python 3 compat > > filter() results are not subscriptable in Python 3, so we need to use > next() to retrieve the first element instead. > > Bug: 1056747, 941669 > Change-Id: I003eda9a8044d18bf7a2aae82086693aa0386c90 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079191 > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Commit-Queue: Domenic Denicola <domenic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745163} TBR=msramek@chromium.org,domenic@chromium.org Change-Id: I973a3fb59a7a678031a0bbfe239657d300512c87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1056747, 941669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079256Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#745192}
-
