GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288022 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/be21e3432e4cf925fe494efe23edcb457bd05fcb..da7a944e293d27ec5c7be06b224921ae0058d35a

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bungeman@google.com
BUG=

Review URL: https://codereview.chromium.org/444163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288021 0039d316-1c4b-4281-b951-d872f2087c98

I consider "file" somewhat misleading since the field either contains a path
segment (file name plus lowermost directory) or an URL.

TBR=bshe@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/443163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288020 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the Translate bubble's behavior not to steal the focus.

BUG=378643

Review URL: https://codereview.chromium.org/425223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288019 0039d316-1c4b-4281-b951-d872f2087c98

Previous implementation did the parsing of string to base::Value
on blocking pool, and that of base::Value to specific data types
either on UI thread or on yet another post to blocking pool.

The previous implementation is slightly inefficient and moreover
involves a subtle bug 284244.

BUG=284244

Review URL: https://codereview.chromium.org/442193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288017 0039d316-1c4b-4281-b951-d872f2087c98

This method is not used in the production code.

BUG=None

Review URL: https://codereview.chromium.org/449763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288016 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315439
TEST=run the js tests.
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/441643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288015 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395356

Review URL: https://codereview.chromium.org/449723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288014 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/423963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288013 0039d316-1c4b-4281-b951-d872f2087c98

Make a routine, but it is not called.


BUG=347425
TEST=./unit_tests --gtest_filter="DriveMetadata*"

Review URL: https://codereview.chromium.org/446653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288012 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288011 0039d316-1c4b-4281-b951-d872f2087c98

According to the latest data, about 0.02% of DB initialization results in discarding old DB which may contain users' unsynced data.
About 2/3 of these failures are due to errors detected by CheckValidity().

Add UMA histogram to help future developers improve this.

BUG=None

Review URL: https://codereview.chromium.org/445513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288010 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179655:179675&mode=html
TBR=jbroman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/450573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288009 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rockot@chromium.org, asargent@chromium.org
NOTRY=true

BUG=399251

Review URL: https://codereview.chromium.org/447113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288008 0039d316-1c4b-4281-b951-d872f2087c98

This CL effectively reverts https://codereview.chromium.org/344793013 for
Windows only.

BUG=394672
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/446673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288007 0039d316-1c4b-4281-b951-d872f2087c98

It was originally committed at r286362 and reverted in r286467.

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn
R=scottmg@chromium.org,brettw@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/427293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288006 0039d316-1c4b-4281-b951-d872f2087c98

Currently WaitMany doesn't ensure that the corresponding |Signal| is done
when the WaitMany call is returned.
That is problematic when we share the event over threads and want to wait
for detaching it in order to delete it after that.

BUG=397435
R=agl@chromium.org

Review URL: https://codereview.chromium.org/419773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398946
TEST=manual and browser test

Review URL: https://codereview.chromium.org/442833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288004 0039d316-1c4b-4281-b951-d872f2087c98

If the cast extension is not install, video player doesn't activate the cast-related feature.

BUG=399557
TEST=manually tested
R=fukino@chromium.org

Review URL: https://codereview.chromium.org/443083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288003 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400989
TEST=trybots

Review URL: https://codereview.chromium.org/448803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288002 0039d316-1c4b-4281-b951-d872f2087c98

+ Use env var LD (default to CXX)
+ Exclude run_all_unittests.cc from build

NOTRY=true
R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/445713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288001 0039d316-1c4b-4281-b951-d872f2087c98

It is possible that Enterfullscreen() is called on an video element without src attribute.
Then later on, when the player got initialized, we should let the player enter fullscreen.
The current implementation calls Enterfullscreen first in video url cases.
This will cause an issue that the BrowserMediaPlayerManager doesn't know which player to pass the surface to.
As a result, we should delay EnterFullscreen() call until the player is initialized.
And there is no point to ask a player to enterfullscreen if it is not created.

BUG=400935

Review URL: https://codereview.chromium.org/446003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288000 0039d316-1c4b-4281-b951-d872f2087c98

The Polymer which Audio Player currently used is outdated. This patch uprev it to the latest version (currently 0.3.4).

BUG=397520
TEST=manualy tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/444223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287999 0039d316-1c4b-4281-b951-d872f2087c98

Will let us show gpu memory usage in a more-intuitive way in frame viewer.

Review URL: https://codereview.chromium.org/447963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287998 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates the lexer, parser and also the internal representation of mojom modules. The changes to the generators will be in a separate CL.

This CL doesn't change data_tests.py because it has been broken for quite a while. We could fix it in a separate CL if we think that it is still useful.

BUG=324170
TEST=those updated test files.

Review URL: https://codereview.chromium.org/437643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287997 0039d316-1c4b-4281-b951-d872f2087c98

First steps towards allowing AiS on more platforms.

R=stevet@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/447073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287996 0039d316-1c4b-4281-b951-d872f2087c98

Added function that allows javascript apps using gcdPrivate to get a list of networks with prefetched passwords.

Fixed reland of https://codereview.chromium.org/434733003/ which was reverted due to test failure.

BUG=383167
TBR=asargent@chromium.org,vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/450533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287995 0039d316-1c4b-4281-b951-d872f2087c98

This regressed with the LegacyRenderWidgetHostHWND. It looks like the reason is that the LegacyRenderWidgetHostHWND eats
paint messages which would previously cause an invalidation in the parent when bounds change, etc.

Proposed fix is to pass SWP_NOREDRAW to the SetWindowPos calls used by the LegacyRenderWidgetHostHWND class.

BUG=388690
R=sky

Review URL: https://codereview.chromium.org/440793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287994 0039d316-1c4b-4281-b951-d872f2087c98

This CL enables autosizing for extension options guests using
the built-in autosizing functionality in GuestViewBase.

BUG=386838

Review URL: https://codereview.chromium.org/431503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333201

Review URL: https://codereview.chromium.org/446063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287992 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dbeam@chromium.org

Review URL: https://codereview.chromium.org/444373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287991 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400611

Review URL: https://codereview.chromium.org/446153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287990 0039d316-1c4b-4281-b951-d872f2087c98

This creates a PageManager.Observer class which delegates handling of
page history and title changes to an uber page observer:
- page_manager.js
- uber_page_manager_observer.js

The About page content is separated into its own file so in a future CL
it can be used as an overlay on another page.

The custom overlay implementation in help_base_page.js is no longer needed.

R=dbeam@chromium.org
BUG=313244
TBR=ben@chromium.org (for c/b/browser_resources.grd)

Review URL: https://codereview.chromium.org/423533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287989 0039d316-1c4b-4281-b951-d872f2087c98

Currently, it only adds pylint checks, with a blacklist for all the
files that fail horribly (or in otherwise mysterious ways).

Also fix a few (less mysterious) pylint failures. Remove some pylint
suppressions (since we now add appropriate directories to the python
module path for pylint).

R=sky@chromium.org

Review URL: https://codereview.chromium.org/443293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287988 0039d316-1c4b-4281-b951-d872f2087c98

the real context type, not assume it's BLESSED_CONTEXT_TYPE (which has always
been wrong). This cleans up some other code.

BUG=391944
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/427983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400948
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/449673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287986 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287985 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/445133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287984 0039d316-1c4b-4281-b951-d872f2087c98

r172: Respect output_all_resource_defines when generating structures in resource maps.

TBR=tony@chromium.org

Review URL: https://codereview.chromium.org/446693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287983 0039d316-1c4b-4281-b951-d872f2087c98

If |type| in RequestPrintPreview() equals PRINT_PREVIEW_USER_INITIATED_ENTIRE_FRAME and |is_loading_| is true, RequestPrintPreview() returns,
then is called again, right after |is_loading_| is set to false in DidStopLoading(). 


BUG=376969
TEST=See bug for steps to reproduce.

Additional way to reproduce:
Build blink_tests and browser_tests in out/Release. Then in src/webkit/tools/layout_tests run this command:
./run_webkit_tests.py --platform browser_test.linux source_pdf/

you can replace linux with win or mac depending on your platform.

The program will attempt to save a PDF as a PDF through print preview. It will eventually fail because Print Preview will hang due to this bug.
If you want visual confirmation that this will happen open:
src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py.

Then add this line of code to the function cmd_line.
cmd.append('--enable-pixel-output-in-tests')

Then run the script again. Enabling pixel output will also make it significantly more likely for the bug to occur.
Its also more likely to happen on windows for some reason.

This is how I came across the bug.

Review URL: https://codereview.chromium.org/427723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287982 0039d316-1c4b-4281-b951-d872f2087c98