- 02 Oct, 2019 40 commits
-
-
Javier Ernesto Flores Robles authored
Adds a simple view controller and coordinator for the password breach screen. To be tweaked once UX is done with the details. Bug: 1008862 Change-Id: I3cc49d5de7f33e453a4a9504b7d976672427a71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832817 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#701989}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/dc9f1e680699..867f72058a4f git log dc9f1e680699..867f72058a4f --date=short --no-merges --format='%ad %ae %s' 2019-10-02 enga@chromium.org Add missing "strlen" parameter for Device InjectError command. 2019-10-02 enga@chromium.org dawn_wire: Only generate has_member for optional members Created with: gclient setdep -r src/third_party/dawn@867f72058a4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:1004368,chromium:1009166 Change-Id: Idf72b8fa81d01508217bd08fa25cbcd625f34dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701988}
-
Philip Jägenstedt authored
Based on https://chromium-review.googlesource.com/c/chromium/src/+/1833804/: > Using wpt-import in Chromium 8c798c26. > With Chromium commits locally applied on WPT: > 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" > ab4b7009 "[Native File System] Aborting a directory iteration succeeds" > 8d24de75 "Port rotate-interpolation.html to wpt" > c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Bug: 1010422 Change-Id: If498cede6b6873bb5069d49c34610fedcbd6e1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835611Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#701987}
-
Oleg Davydov authored
ContentHash::Status enum has three values assuming that having valid verified_contents.json is mandatory intermediate step on a way to get full ContentHash. We can simplify code a bit by removing this intermediate stage from enum (and replacing remaining two-values enum with just a bool). Also this will simply things a little for self-hosted extensions (which don't have verified_contents.json, but still have to be checked for corruptions). Bug: 796395 Bug: 958794 Change-Id: Iacbd7a90853b0e30d611c7f0e90eb2d53aea989d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810899Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701986}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including find_in_page.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in find_task_controller.h, text_finder.h, and web_local_frame_impl.h. This CL has no behavior changes. Bug: 1001360 Change-Id: I276e5e9c286525a72f3a1998a181a4bcf45f96dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833373Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#701985}
-
Nico Weber authored
Bug: 1010458 Change-Id: Ie36ee1a87e7801fafdbfc2f38c0762ebbf7cace7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835155 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#701984}
-
BUG=762641 TBR=achuith@chromium.org Change-Id: I7eda207ef9e2e0145df4261ed7c87ec2f8934c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834832Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701983}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dec74f3ff6ec..8d2930613094 git log dec74f3ff6ec..8d2930613094 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@8d2930613094 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I13447be729f7c592d076c831f115faf8b1fb5d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835252Reviewed-by:
-
Mikel Astiz authored
This patch changes the implementation within NigoriSyncBridgeImpl to avoid reusing the codepath for user-entered passphrases, since there are subtle differences, including: 1. Different observer notifications should be triggered. 2. The selection of the default encryption key is determined via Nigori specifics (sync protocol). Bug: 1834222 Change-Id: Ief85905bb576a82faba515a71c7a6afd9e1612d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834227 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#701981}
-
Javier Ernesto Flores Robles authored
Merge c/b/ui/passwords/credential_leak_dialog_utils.* with components/password_manager/core/browser/leak_detection_dialog_utils.h. Move the strings it uses to components/password_manager_strings.grdp. Move the constants it uses to components/password_manager/core/browser/leak_detection/leak_detection_dialog_constants.* Bug: 1008862 Change-Id: I5766efef92cc343b861baaf4cf66ca8aeb1315f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833473 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701980}
-
Michael Ershov authored
Extract main part of challenge key flow from extension API to allow calling it without an extension. Bug: 1000589 Change-Id: I4f32eeedc87f3b76511bf471fd3ea7641102bf5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782810Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#701979}
-
David Van Cleve authored
This commit extends metrics coverage to provide more descriptive logging of TLS 1.3 handshakes' 0-RTT state, by logging the ssl_early_data_reason computed in BoringSSL. This records whether TLS 1.3 early data handshake attempts succeed and, if they fail, why. R=csharrison@chromium.org,davidben@chromium.org Bug: 1000659 Test: expanded prior metrics unittests to cover new cases Change-Id: Iaeba249c2be3ddb23900a51f9d223580481421f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784159 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#701978}
-
Henrik Boström authored
See bug. TBR=michaelbai@chromium.org, changwan@chromium.org NOTRY=True Bug: 1010416 Change-Id: I03df0ab4ea40aecd09511a0129861b439326f577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834085Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701977}
-
Mikel Astiz authored
This separates the codepath for trusted vault keys from the regular user-entered passphrases. This patch covers the plumbing from SyncEngine to SyncEncryptionHandler, which excludes the very upper layers. TODOs have been added to address SyncUserSettings in follow-up patches. Bug: 1010189 Change-Id: I6a01a444018698cd0d75e68bfb83edf3ab72085b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834222 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Henrik Boström authored
See bug for details. TBR=michaelbai@chromium.org, changwan@chromium.org, tobiasjs@chromium.org, jochen@chromium.org NOTRY=True Bug: 1010417 Change-Id: I9a68b4f29a76a1941fe42b9d741e653d9541b00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835499Reviewed-by:
-
Juan Antonio Navarro Perez authored
These will still be reported as regular measurements. Bug: 1003530 Change-Id: I207540eeaa4447b01536ab4205712d0822c1c91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828904Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#701974}
-
Paul Lewis authored
This adds tests for common/SegmentedRange that broadly match those of the original layout tests. Bug: 1009443 Change-Id: I60a986c2568bd46bb0f9ba64a85b42d24b54b40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831910Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#701973}
-
Henrik Boström authored
See https://crbug.com/1010418. TBR=livvielin@chromium.org, jdonnelly@chromium.org, pkasting@chromium.org NOTRY=True Bug: 1010418 Change-Id: Ide19821fa54dc1033c216799352cd37445f5d143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835497Reviewed-by:
-
Adam Rice authored
The WebSocketStream explainer describes being able to pass an AbortSignal object to the WebSocketStream constructor to abort the handshake. This wasn't implemented yet in Blink. Implement it. Bug: 983030 Change-Id: I9d96bf145a4978867dd8ae98a13af9ad9cff752c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827116Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#701971}
-
Yi Su authored
Since we are using Xcode11 beta6 for compiling right now, FontSizeJsTest can be re-enabled. Bug: 983776 Change-Id: Id3a36a9fb5666ff5eca1f20f3c7fad4b194a070b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816497Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#701970}
-
Keishi Hattori authored
BodyJsonConsumer::DidFetchDataLoadedString() was binding ScriptValue which is a traceable disallow new type. This shouldn't be allowed as GC fails to trace them. This CL - adds a check disallowing binding traceable disallow new types. - adds WrapDisallowNew() to wrap a disallow new type in a GarbageCollected class, making it possible to be referenced off heap from a Persistent. - fixes BodyJsonConsumer::DidFetchDataLoadedString() Bug: 1009740,1009944 Change-Id: I7b15b46550b9994f0b7982c3508de9c3e7ff66be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833039 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#701969}
-
Michael Lippautz authored
Blink stand-alone GCs are used in testing and on thread termination. Such GCs iterate Blink->V8 references (global handles) to find the corresponding V8->Blink references that should be treated as roots. On WorkerOrWorkletGlobalScope dispose we also clear the DOMWrapperWorld that holds the Blink->V8 references (global handles). In the case a stand-alone GC happens at this point, WorklerOrWorkletGlobalScope is reclaimed. Access through the JS wrapper back references results in UAF. Bug: chromium:1003729 Change-Id: Iba0cb340a2037445947920888596ea7ecf7c32da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833825Reviewed-by:
-
Oleg Davydov authored
Whether we have loaded or not valid verified_contents.json is an internal detail of ContentHash class, which doesn't need to be exposed to clients. The only external usage of this is passing it to ContentVerifier::TestObserver. But TestObserver and its implementations never used this flag since TestObserver introducing in https://codereview.chromium.org/1250473002. Therefore it is possible and makes sense to change it to overall success flag. Bug: 796395 Change-Id: Ibd48b998a4c42d68e30549a4078184179f5593e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810358Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2025b9840119..d9682cc2dc22 git log 2025b9840119..d9682cc2dc22 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d9682cc2dc22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I6c4583fca4abf7fbffe576f724f84c14d5f78937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834865Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/23dacd6b..17fcc592 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic35d98f42682be42c6fc1f0da0a355abe305097f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833571Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701965}
-
Jérôme Lebel authored
Change-Id: Ie811205717b62316aee37790249bb8c92b00f7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833591 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#701964}
-
Mikel Astiz authored
No behavioral changes: the API and implementation of SyncServiceCrypto are decoupled from the enum that is designed for SyncEncryptionHandler, a lower-level interface. Bug: 1010189 Change-Id: Icd8d3124a93a928535894f877b64ade53bcd1e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834226 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#701963}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1c934fade666..dec74f3ff6ec git log 1c934fade666..dec74f3ff6ec --date=short --no-merges --format='%ad %ae %s' 2019-10-02 csmartdalton@google.com Remove an assumption that fOpsTask != nullptr Created with: gclient setdep -r src/third_party/skia@dec74f3ff6ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Ieb5631db34e5a9924dc80d0f5d7cad8d83e73de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834864Reviewed-by:
-
Christian Dullweber authored
Whether the button is shown depends on sites.length but the dependecy was not declared, so the button didn't show up. Also hide the button when there is a filter as the filter can't be applied to third-party cookie deletion yet. Bug: 987177 Change-Id: Id36a286ed73da404446c8b98dabbf3751b5658e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831874 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#701961}
-
Kuo Jen Wei authored
Bug: 980812 Test: Send intent from ARC++ app, see if result is correctly return to app. Change-Id: I2810a31879abf80657aa75becde3e2a99ddcf1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804940 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#701960}
-
Edward Jung authored
- Adjust the padding around the checkbox for RTL layouts. - Reduce the size of the bottom nav button container fade for mobile layouts. - Bottom padding adjustments on the content and detail content for mobile screen sizes. Bug: 968173,1006232 Change-Id: I14e78825ce8fe357dbf7ac89efe3af9bb76e6f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834082Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#701959}
-
Jérôme Lebel authored
Adding comments, fixing @property and @synthesize, and moving all private methods together. Related to: crrev.com/c/1718370/4/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm#275 Bug: 988060 Change-Id: Ic4986ea549bb6ade54afb0fe8a86e0fe8edda10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824463 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#701958}
-
Colin Blundell authored
Part of the elimination of the legacy IPC system. Bug: 1007300 Change-Id: I3c8f3e0e17c157be07b494217e8cbe87edbb990f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832802 Auto-Submit: Colin Blundell <blundell@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#701957}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/display to the recommended methods/types. Bug: 1007849 Change-Id: I4f884da0b9cc4c3bfd248082d963f40c377e887a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831913 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701956}
-
François Beaufort authored
This CL redefines GPUOrigin3D as not only a GPUOrigin3DDict, but also a sequence of unsigned long as specified in https://gpuweb.github.io/gpuweb/#typedefdef-gpuorigin3d Bug: 877147 Change-Id: Ifa8dfef0891b1018fd497a30b8a9b5d4a05c91a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828905 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb06828e0343..b4eef2d93601 Created with: gclient setdep -r src-internal@b4eef2d93601 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I5fdf25a1c4a485f48a775dde93baf0dd905a2607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834862Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701954}
-
Javier Ernesto Flores Robles authored
Change-Id: I2fd0addc01c22156ac1623aec262908d240f5087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832217 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL implements the option F in [1]. Add Material-like theme as a platform-matching theme. [1] https://github.com/tkent-google/std-switch/issues/6#issuecomment-499842423 Bug: 972476 Change-Id: I643d36b0a4750191d45e7e6cfe2ae320826e3f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832128 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#701952}
-
Arthur Hemery authored
Excluding for failure: org.chromium.content.browser.InterstitialPageTest#testCloseInterstitial Bug: 1007276 Change-Id: Idb1914d3692d98d5ec77cdf46dede5ebd34594e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832274 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#701951}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in components/favicon to the recommended methods/types. Bug: 1007688 Change-Id: I2554067448ac8ac8d27776a7c0e9d1977568cd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832809 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701950}
-
