- 15 Aug, 2018 40 commits
-
-
Stephen McGruer authored
The crash that these were meant to help debug has been long fixed. They are no longer needed. Bug: 770886 Change-Id: I7abf99be6cd00b9ae9a99934edaca95fe48e638d Reviewed-on: https://chromium-review.googlesource.com/1174992Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583341}
-
Yuwei Huang authored
This CL removes old audio playback code that is no longer in used. Bug: 868088 Change-Id: I0dc350fc6d7fcabe89c6c7deba1da34fe53c3667 Reviewed-on: https://chromium-review.googlesource.com/1171855Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#583340}
-
Eugene But authored
These are existing User Actions, which were not logged on iOS. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id1700628a2c54dbd2ba2bbc43bf631a9e474b1ff Reviewed-on: https://chromium-review.googlesource.com/1175208Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#583339}
-
Tim Dresser authored
Bug: None Change-Id: I00f80dc9050109303747534b78216b67a9f310d3 Reviewed-on: https://chromium-review.googlesource.com/1176109Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#583338}
-
Becky Zhou authored
Use AppCompatButton in modal_dialog_view so that the text appearance can be applied to pre L devices. Bug: 872212 Change-Id: Ib84be209d086306983267cff5be0151202093ad6 Reviewed-on: https://chromium-review.googlesource.com/1173450 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#583337}
-
Ned Nguyen authored
1) Merge the abstract class _Top25RuntimeStats with V8Top25RuntimeStats since it's the only one inherit from the abstract class. 2) Remove the disabling Android in perf/expectations.config & switch to use SUPPORTED_PLATFORMS which is meant for permanent disabling logic like this case Change-Id: I07fecfd3d9cce3e7d35ac71b274bb9416f0cdcac TBR=perezju@chromium.org Change-Id: I07fecfd3d9cce3e7d35ac71b274bb9416f0cdcac Reviewed-on: https://chromium-review.googlesource.com/1175928Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#583336}
-
Avi Drissman authored
This relands 3dcaec6e with a fix to the test. BUG=873080 TEST=as in bug Change-Id: Ie68b197fc6b92447e9633f233354a68fefcf20c7 Reviewed-on: https://chromium-review.googlesource.com/1175925Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583335}
-
Filip Gorski authored
* While investigating the problem of not reporting triggering on some pages, I discovered a race condition in fetching canonical URL -> in some cases the tab does not provide correct infromation yet. * This patch postpones fetching of canonical URL until later, when we are about to perform the fetch. * Fetching URLs would also cause some problems with marking fetch as in progress, which could prevent actual fetch from happening. * It appears to also be positively affecting the EoC start time when loading a page for the first time. Bug: 873004, 841811 Change-Id: Ic7e91579d083efd54a695a10e251ec245797ba84 Reviewed-on: https://chromium-review.googlesource.com/1175108Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
Ryan Daum authored
- Issue 'tap' gesture events while panning or zooming, to avoid idle screen during interaction. - Properly disable magnification when magnification gesture is turned off. Bug: internal b/112615721 Bug: internal b/112612596 Test: manual Change-Id: If6ec273ddab0f70d0c56743e38c0c40b49a579c4 Reviewed-on: https://chromium-review.googlesource.com/1175854Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#583333}
-
Lei Zhang authored
TBR=tommycli@chromium.org NOTRY=true NOTREECHECKS=true Change-Id: Ib8a3268f5eefc51491ae49ef2c942c0dcb6b7a8f Reviewed-on: https://chromium-review.googlesource.com/1176192Reviewed-by:
-
Emil A Eklund authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/b6fdcf4f8bd09e065c767939125861c9dc8ff18f..7112c6413ca7a1773847fe258145cc5162420953 Bug: 873568 Change-Id: Ia6a7c9baa0bdce0bc3d4dc50c75c70c0dbbb6555 Tbr: behdad@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174951 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#583331}
-
bsheedy authored
Updates the script used for bisecting VR/AR regressions to support bisecting binary size regressions between builds with and without VR or AR support. Bug: 874240 Change-Id: Ib37926c0d3d77570206ff267d2aab20d86a1f439 Reviewed-on: https://chromium-review.googlesource.com/1175146Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583330}
-
Ryan Sleevi authored
Presently, CertVerifier::Verify() takes a series of per-verification flags that express the ways in which certificate verification may be configured. However, these flags represent overall verifier-wide configuration, in that they are tied to user preferences or enterprise policies. These flags are plumbed through the layers by virtue of SSLConfig, but generally do not change between verifications. As part of making the verification configuration opaque to callers, move the flags from being something passed in each verifier-call to something that is implicitly handled on the CertVerifier, via the CertVerifier::Config. All verifications started will share the same configuration, while allowing callers to focus on the per-verification parameters that are unique (such as the hostname or certificate). This sets the stage for moving the CRLSet in as explicit CertVerifier configuration, rather than passed-per-call, as well as to having the socket pools more intelligently respond to these configuration changes. TBR: zea@chromium.org, pmarko@chromium.org Bug: 848277, 854635 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2098783f1c4100720438e2dea447a24789ebf8c9 Reviewed-on: https://chromium-review.googlesource.com/1122709 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583329}
-
Lei Zhang authored
The NaCl plugin is built into the Chromium binary, so it does not have a real path. Instead of calling PathService::Get(chrome::FILE_NACL_PLUGIN) to get the fake path, just use a constant like the PDF plugin. Change-Id: I7487f6be7ddbdbecf6255b6faa5b104593e6193e Reviewed-on: https://chromium-review.googlesource.com/1175546 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Justin TerAvest <teravest@chromium.org> Cr-Commit-Position: refs/heads/master@{#583328}
-
Sergey Ulanov authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I99a21f1060e81a5f7930d6ec6b6b269f76a23c41 Reviewed-on: https://chromium-review.googlesource.com/1174011 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583327}
-
Lei Zhang authored
third_party/mesa/src is no longer checked out as of r582655. BUG=873321 Change-Id: I6ee0dabd58b77a2c1995b7d42df4fb4df909884c Reviewed-on: https://chromium-review.googlesource.com/1175403Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583326}
-
Lei Zhang authored
Make methods private when possible. Move methods that can go into an anonymous namespace into one. Change-Id: Ia921b6539aae45ce145c6a4583ebdbb7b9611707 Reviewed-on: https://chromium-review.googlesource.com/1174996Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583325}
-
Lei Zhang authored
Make it base::FilePath::CharType instead of char because that is what all its users expect. Remove uses of base::FilePath::FromUTF8Unsafe(). Do the same for ChromeContentClient::kNotPresent. Change-Id: Ifae02593f05eec02d783cc865a5c29441f606ecb Reviewed-on: https://chromium-review.googlesource.com/1175498Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583324}
-
chaopeng authored
This patch fixes viewport scrollbars flashing page issue. The issue is causing by it has incorrect effect node. In this patch, we create the effect and correct the position for viewport scrollbars. Bug: 870520 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I954d6cddb36d811f693b597644b65ee175137dcf Reviewed-on: https://chromium-review.googlesource.com/1172919 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583323}
-
Koji Ishii authored
The only difference from legacy at this point is when 'box-shadow' is applied to the '::first-line' style. Edge and Gecko do not support it. NOTRY=true Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2fbfba36b9a606ea4a1f0e40dada8102fd0ed623 Reviewed-on: https://chromium-review.googlesource.com/1175755Reviewed-by:
-
Xida Chen authored
The current code has a type, it should be DISABLED_xxx TBR=wjmaclean@chromium.org NOTRY=true Bug: 872340 Change-Id: I910b6913eace9b4710a7aac990d783f0f842beee Reviewed-on: https://chromium-review.googlesource.com/1176176Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583321}
-
Pavel Shmakov authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1172425 Another memory leak was found in ToolbarProgressBar. It happens due because animations are not cleaned up when activity is destroyed. The references to animation listeners get stuck in android.animation.AnimationHandler, which is a singleton. From the animation listeners the chain of references leads all the way up to ChromeTabbedActivity instances. So this leak happens when user closes Chrome while the page is loading, and then the system kills the activity. It's easily reproducible with "Don't keep activities" option. Bug: 872661 Change-Id: I6eebc11a575d45c899f37be5ca7a6862923f0ee5 Reviewed-on: https://chromium-review.googlesource.com/1175795Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#583320}
-
tzik authored
The declarations of move ctors and assigns of DisjointRangeLockManager::LockRequest, ScopesLockManager::ScopeLock and ResolveProxyMsgHelper::PendingRequest have `noexcept` specifier, but their implementations don't. This is OK in C++14, but causes compile errors in C++17. This CL adds missing `noexcept` for them. Bug: 752720 Change-Id: I849f613c63c990afd23c590a9567069b772146d1 Reviewed-on: https://chromium-review.googlesource.com/1175656Reviewed-by:
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor ans has no intended behavior change. Bug: 842194 Change-Id: I46e242b51c99ef720ee6700ab6bf0fdc8c2a4720 Reviewed-on: https://chromium-review.googlesource.com/1174582Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: 855127 Change-Id: I2942e122373c210bd0bceaa59791e2619186f79b Reviewed-on: https://chromium-review.googlesource.com/1175935Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#583317}
-
Xida Chen authored
Flakiness dashboard shows that it has been flaky for a while: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=components_unittests&tests=SslCastSocketTest.TestMessageEndToEndWithRealSSL TBR=wjmaclean@chromium.org NOTRY=true Bug: 874491 Change-Id: I5c0fe9656f3c9e74d21660db6430899e4824c6d5 Reviewed-on: https://chromium-review.googlesource.com/1176170Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a3a0b7f4. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22763 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2587d254f484b32739d6192d72369cbe79b3fc13 Reviewed-on: https://chromium-review.googlesource.com/1175858 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#583315}
-
Xida Chen authored
This reverts commit 4efeaf16. Reason for revert: <INSERT REASONING HERE> Causes a lot of unit test failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7319 Original change's description: > [ozone/Wayland] Implement Wayland dmabuf approach. > > This patch makes it possible to run Wayland backend with a separate gpu process. > That is, WaylandConnection is not available on the GPU process side > and so buffers cannot be created that way. > > To overcome this, a Wayland dmabuf based approach is used: > - On the gpu process side, gl::Surfaceless is used, which is > implemented by GbmSurfaceless. It differs from the one provided by > the Ozone/Gbm backend (the difference is that there are no frame > buffers, because DRM render node is used instead.) Basically, > on the GPU side, a gbm_bo buffer is created and its file descriptor is > shared with the WaylandConnection, which then imports a wl_buffer and attaches > it to a requested surface. > > TL:DR; > - There are two communicating parties - WaylandConnection, which establishes > a connection with Wayland, and a WaylandConnectionProxy, which serves > the GPU process with a forwarding mojo connection to the WaylandConnection. > In single process mode, WaylandConnectionProxy just forwards calls to > WaylandConnection, and GLSurfaceEGL is used. In a multi process mode, > the l::Surfaceless and dmabuf based approach is used instead. > > - The communication is established in the following way: > when WaylandConnectionConnector receives a OnGpuServiceLaunched, > it binds WaylandConnection and WaylandConnectionProxy interfaces, and > calls to WaylandConnectionProxy to set a mojo ptr to the WaylandConnection. > The WaylandConnectionProxy receives the pointer, stores it and also stores > a task runner to make sure mojo is called on the right sequence. > > How buffers are created: > - Basically, the GPU process doesn't know about Wayland. What it does > is that it creates a GbmBuffer utilizing a DRM render node (it can't use > a drm card device, because authentication requires master access), takes > a gbm_bo file descriptor and shares it via a mojo call with the > WaylandConnection, which then uses the zwp_linux_dmabuf interface to > import a wl_buffer, which can be attached to a needed WaylandWindow > and commit-ed to show contents. That is, the gbm framework is used to share buffers > between the browser and the GPU process, where the browser process can read from them and > the GPU process is able to read and write using gl commands. > > How buffers are committed: > - GbmSurfaceless uses a normal procedure and submits frames on > SwapBuffersAsync call: a frame is created and scheduled as an overlay plane, > once scheduling is done, a widget is taken from that pending plane and > WaylandConnection::ScheduleBufferSwap is called. In order to specify, which > wl_buffer must be used, gbm bo handle is used as a buffer id. > Once the WaylandConnection receives a buffer swap call, it finds a buffer by a > buffer id and attaches that buffer to a WaylandWindow, which is also found > by a widget passed to it. PresentationCallback is not used and will be > enabled in the future. > > The missing feature is the software rasterization. That is, the gbm buffers cannot be > mmap'ed using unix mmap method. Thus, it's impossible to get a mapped memory range and let the cpu > write to it. I think this problem can be resolved in the downstream projects in different ways > but these solutions are not generic enough to be upstreamed. > > Another missing feature is presentation feedback. This will be implemented in follow up > CLs. > > COMPILE= compiles only with third_party minigbm now. For example, add use_intel_minigbm=true > if intel gpu is ozone_platform_wayland=true. Using system libgbm will be available soon. > TEST=run and compile ozone/wayland. > Bug: 820047 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Id351edd9883a765d3e549543a50175299108c6ab > Reviewed-on: https://chromium-review.googlesource.com/1057468 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#583265} TBR=rjkroege@chromium.org,reveman@chromium.org,sky@chromium.org,spang@chromium.org,isherman@chromium.org,tsepez@chromium.org,piman@chromium.org,msisov@igalia.com Change-Id: I69eadb7666d275dabeceff306e3e5cde62ddf795 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820047 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1175468Reviewed-by:
-
Min Chen authored
Bug: 847587 Change-Id: Iab2a11d1f11b6b6b703d77e7c94a01b564fd07d1 Reviewed-on: https://chromium-review.googlesource.com/1175411Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#583313}
-
Tommy Steimel authored
This CL adds a try/catch block to prevent SecurityExceptions from crashing media opened via the media intent handler. In certain cases, we don't have permission to query for the file display name. In those cases, instead of crashing we will instead just fall back to having no display name. Bug: 874149 Change-Id: I18ed34655e093cf04c9cb745eeeb6182c8fe28b6 Reviewed-on: https://chromium-review.googlesource.com/1175212Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583312}
-
Oksana Zhuravlova authored
This change moves the logic from DeviceMotionDispatcher into DeviceMotionEventPump and removes DeviceMotionDispatcher. DeviceMotionController now uses DeviceMotionEventPump directly,and a separate instance of DeviceMotionEventPump is created forevery document. Webkit layout tests were updated to reflect this, and webkit unit tests have been updated to use a MockDeviceMotionController. Bug: 861902 Change-Id: Ic9a33b26c6c5771a3a7312724f1056ef311ea6a3 Reviewed-on: https://chromium-review.googlesource.com/1167994Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#583311}
-
Alex Newcomer authored
This reverts commit 32cd8fcf. Reason for revert: Reverting the revert because this change was proven to not have caused the issue. Original change's description: > Revert "cros: Enable touchable app context menus by default." > > This reverts commit b58ccf6d. > > Reason for revert: Possibly introduced a use-after-free bug. > > This is a speculative fix for a use-after-free bug in two ash_unittests: > > 1. OverflowButtonInkDropTest.MouseContextMenu > 2. OverflowButtonActiveInkDropTest.MouseContextMenu > > [ RUN ] OverflowButtonInkDropTest.MouseContextMenu > ================================================================= > ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188 > READ of size 8 at 0x613000031f68 thread T0 > #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30 > #1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670 > #2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168 > #3 0x8c82105 in HasObserver base/observer_list.h:267 > #4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543 > #5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15 > #6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13 > #7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15 > #8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33 > #9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1 > #10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45 > #11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5 > #12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634 > #13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588 > #14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969 > #15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > #16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > #17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > #18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > #19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > #20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > #21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > #22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > #23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > #24 0x72b9892 in Run base/callback.h:99:12 > #25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > #26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > #27 0x178df94 in main ash/test/ash_unittests.cc:37:10 > #28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88) > freed by thread T0 here: > #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3 > #1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7 > #2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19 > #3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3 > #4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17 > #5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3 > #6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21 > #7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > #8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > #9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > #10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > #11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > #12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > #13 0x72b9892 in Run base/callback.h:99:12 > #14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > #15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > #16 0x178df94 in main ash/test/ash_unittests.cc:37:10 > #17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > previously allocated by thread T0 here: > #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 > #1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15 > #2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14 > #3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10 > #4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334 > #5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3 > #6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27 > #7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11 > #8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3 > #9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3 > #10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30 > #11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14 > #12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3 > #13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3 > #14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21 > #15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18 > #16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20 > #17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778 > #18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc > #19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 > #20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 > #21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 > #22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc > #23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 > #24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277 > #25 0x72b9892 in Run base/callback.h:99:12 > #26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224 > #27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10 > #28 0x178df94 in main ash/test/ash_unittests.cc:37:10 > #29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287 > > SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin > Shadow bytes around the buggy address: > 0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa > 0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > 0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd > 0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa > 0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > 0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd > 0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa > 0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd > Shadow byte legend (one shadow byte represents 8 application bytes): > Addressable: 00 > Partially addressable: 01 02 03 04 05 06 07 > Heap left redzone: fa > Freed heap region: fd > Stack left redzone: f1 > Stack mid redzone: f2 > Stack right redzone: f3 > Stack after return: f5 > Stack use after scope: f8 > Global redzone: f9 > Global init order: f6 > Poisoned by user: f7 > Container overflow: fc > Array cookie: ac > Intra object redzone: bb > ASan internal: fe > Left alloca redzone: ca > Right alloca redzone: cb > Shadow gap: cc > ==28149==ABORTING > > Original change's description: > > cros: Enable touchable app context menus by default. > > > > This will enable: > > - New context menu UI for: > > - Application icons > > - Shelf context menus > > - Desktop context menus > > > > Note: > > - Removed tests whose functionality were already being tested. > > - MouseContextMenu already tests whether the ink drop is being > > shown, so there is no need for > > ShelfButtonShowsInkDropHighlightOnMenuShow. > > > > Bug: 871843 > > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058 > > Reviewed-on: https://chromium-review.googlesource.com/1170985 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#582978} > > TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org > > Change-Id: Ib85676861251f41c84f48f956d36c01edb353266 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 871843 > Reviewed-on: https://chromium-review.googlesource.com/1174641 > Reviewed-by: Chris Mumford <cmumford@chromium.org> > Commit-Queue: Chris Mumford <cmumford@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583088} TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org Change-Id: I4edeef479d40e1e591ac906aa89ede363668b6a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871843 Reviewed-on: https://chromium-review.googlesource.com/1174777Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583310}
-
agrieve authored
Change-Id: I34b87a55631eda7a76c5291c95444848c051b6cf Reviewed-on: https://chromium-review.googlesource.com/1175861Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
Becky Zhou authored
TBR=perezju@chromium.org Bug: 871708 Change-Id: I49d63079721102aa58396f5efc21ca428e9647c2 Reviewed-on: https://chromium-review.googlesource.com/1176065Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#583308}
-
Scott Violet authored
MASH_DEPRECATED is never set anymore. BUG=692193 TEST=none Change-Id: I49a99e9e3c6bbc7f3c77238e450e18c4ffd6b992 Reviewed-on: https://chromium-review.googlesource.com/1176102Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#583307}
-
Sigurdur Asgeirsson authored
Bug: 755840 Change-Id: I5eba22ebcc2e8a11c1d0df7d249b0dd5c0aa5066 Reviewed-on: https://chromium-review.googlesource.com/1175847 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#583306}
-
Xida Chen authored
Failure here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11980 TBR=wjmaclean@chromium.org NOTRY=true Bug: 669227 Change-Id: I4836948e52e9b1b2a1cbb5d6dde6b9707c27fdbc Reviewed-on: https://chromium-review.googlesource.com/1176123Reviewed-by:
-
Xiaohan Wang authored
This reverts commit 56d3597e and relands the original CL. Reason for revert: The failure (revert reason) doesn't seem to be caused by this CL. Original change's description: > media: MediaBrowserTest not watching for plugin crash > > Now the CDM is not running in a plugin, there's no need for > MediaBrowserTest to watch for plugin crash. Bug: 772160 Change-Id: I387abcd37e85b703e2d0d1bf67be1f82dd68bf68 Reviewed-on: https://chromium-review.googlesource.com/1174852Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#583304}
-
Matt Menke authored
Previously, these could only be set on construction, but the Pepper Mojo API lets consumers change these at runtime. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia75aeeda26e3ea09ba3b2647ab42b97161a6bae9 Reviewed-on: https://chromium-review.googlesource.com/1173341Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#583303}
-
Xida Chen authored
See failure here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14935 TBR=wjmaclean@chromium.org Bug: 669227 Change-Id: I75f036c0c4bf3cb883a094ed4f60741b53f3338b Reviewed-on: https://chromium-review.googlesource.com/1175843Reviewed-by:
-
