GitLab

RemoteArray wrapper incapsulates at and length methods. RemoteFunction incapsulates targetFunction method. Wrappers have createFromObject methods which check type of object.
In utilities.js method storeResultTo is added to Promise.prototype. This method allow to save promise result value to object[propertyName] and return it for following processing.

BUG=61643
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1325783003

git-svn-id: svn://svn.chromium.org/blink/trunk@201653 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We want to introduce a WebTaskRunner which maps to a chromium
SingleThreadTaskRunner and migrate WebScheduler and WebThread
over to it.  The motivation is:

* Brings the blink side closer to the underlying chrome code.
* For spatial scheduling we plan to have a loading and timer
  task queue per frame.
* We want to be able to post delayed tasks to the loading
  task queue and architecturally we feel the WebTaskRunner
  will be cleaner than adding a postDelayedLoadingTask to
  WebScheduler.

Patch 2: https://codereview.chromium.org/1308183005
Patch 3: https://codereview.chromium.org/1303153005
Patch 4: https://codereview.chromium.org/1309423004
Patch 5: https://codereview.chromium.org/1310253009

BUG=510398,497761

Review URL: https://codereview.chromium.org/1325073002

git-svn-id: svn://svn.chromium.org/blink/trunk@201652 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524115

Review URL: https://codereview.chromium.org/1327693002

git-svn-id: svn://svn.chromium.org/blink/trunk@201651 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/1312073003

git-svn-id: svn://svn.chromium.org/blink/trunk@201650 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should remove stray "TracingStartedInPage event not found" message
when using screenshot recorder in Network panel.

- extract processMetadataEvents() from TracingModel to TimelineModel
- ditto for session id
- nuked TracingModel.Loader

BUG=

Review URL: https://codereview.chromium.org/1305373004

git-svn-id: svn://svn.chromium.org/blink/trunk@201649 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Oilpan: fix build after r201639. (patchset #1 id:1 of https://codereview.chromium.org/1312073003/ )

Reason for revert:
Not complete, reverting to reland.

Original issue's description:
> Oilpan: fix build after r201639.
> 
> TBR=oilpan-reviews
> BUG=none
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201647

TBR=oilpan-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1319623006

git-svn-id: svn://svn.chromium.org/blink/trunk@201648 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/1312073003

git-svn-id: svn://svn.chromium.org/blink/trunk@201647 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This file does not use RetainPtr; move the include to
FontPlatformDataMac.mm, which does need it.

Review URL: https://codereview.chromium.org/1314663002

git-svn-id: svn://svn.chromium.org/blink/trunk@201646 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turn this unit test helper into something more RAII-like to avoid
Resources not having their clients removed.

For the tests touched, addresses reported Resource leaks.

R=haraken
BUG=526423

Review URL: https://codereview.chromium.org/1327653004

git-svn-id: svn://svn.chromium.org/blink/trunk@201645 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522797
TEST=fast/repaint/subpixel-shadow-included-in-invalidation.html

Review URL: https://codereview.chromium.org/1308033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201644 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Part of a 3-sided patch:
1. https://codereview.chromium.org/1309273007
2. https://codereview.chromium.org/1313363006
3. this patch

BUG=507751

Review URL: https://codereview.chromium.org/1313013006

git-svn-id: svn://svn.chromium.org/blink/trunk@201643 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Link header wasn't handling well extensions parameters with no value
that were not followed by a white space.
This CL fixes that.

BUG=520698

Review URL: https://codereview.chromium.org/1322543003

git-svn-id: svn://svn.chromium.org/blink/trunk@201642 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Make m_executeScriptsWaitingForResourcesTimer a loading task (patchset #2 id:20001 of https://codereview.chromium.org/1312353004/ )

Reason for revert:
Oilpan leaks.

Original issue's description:
> Make m_executeScriptsWaitingForResourcesTimer a loading task
> 
> We would like to be able to prioritize loading tasks, but in order to
> do that we need to make sure loading tasks are posted to the right queue
> to make sure tasks run in the expected order.  If this task is posted as
> a timer, and loading tasks are prioritzed, it's possible
> FrameHostMsg_DidStopLoading will be sent before the corresponding
> FrameHostMsg_DidStartLoading ipc which causes various browser tests to
> break.
> 
> BUG=497761,510398
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201563

TBR=mkwst@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=497761,510398

Review URL: https://codereview.chromium.org/1304943004

git-svn-id: svn://svn.chromium.org/blink/trunk@201641 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1323943008

git-svn-id: svn://svn.chromium.org/blink/trunk@201640 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes FIXME(OILPAN) that is out-dated or doesn't make much sense.

BUG=

Review URL: https://codereview.chromium.org/1327793002

git-svn-id: svn://svn.chromium.org/blink/trunk@201639 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The functionMap is already a global static variable. The createFunction has a check
which makes the method createFunction being called only once. Hence there is no need
of this function table to be a static table.

This reduces the bss size on linux by 656 bytes

R=haraken

Review URL: https://codereview.chromium.org/1324133002

git-svn-id: svn://svn.chromium.org/blink/trunk@201638 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=514651

Review URL: https://codereview.chromium.org/1309523008

git-svn-id: svn://svn.chromium.org/blink/trunk@201637 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=523249
NOTRY=true

Review URL: https://codereview.chromium.org/1325983003

git-svn-id: svn://svn.chromium.org/blink/trunk@201636 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Updated modules/accessiblity, app_banner, audio_output_device, bluetooth, 
  cachestorage, canvas2d, compositorworker, crypto, encryptedmedia, fetch, and filesystem.

- Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1315743003

git-svn-id: svn://svn.chromium.org/blink/trunk@201635 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Evict resources from the memory cache upon shutdown.

R=haraken
BUG=526423

Review URL: https://codereview.chromium.org/1309843011

git-svn-id: svn://svn.chromium.org/blink/trunk@201634 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL ships Oilpan for core/animations except for temporary animation objects.
We confirmed that this CL won't regress any animation benchmark in telemetry.

Look at the discussion in the following thread for more details
and performance results: https://groups.google.com/a/chromium.org/d/topic/oilpan-reviews/V7d-7o4AbeA/discussion

BUG=340522

Review URL: https://codereview.chromium.org/1318543009

git-svn-id: svn://svn.chromium.org/blink/trunk@201633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1308273007

git-svn-id: svn://svn.chromium.org/blink/trunk@201632 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The API has evolved a bit, dropping the 'password' and 'formData'
accessors in favor of a 'toFormData(FormDataOptions)' method which
is intended to be used in conjunction with 'fetch()' to submit
credentials to a server-side endpoint.

Defined at [1] and [2].

[1]: https://w3c.github.io/webappsec/specs/credentialmanagement/#interfaces-credential-types-passwordcredential
[2]: https://w3c.github.io/webappsec/specs/credentialmanagement/#generate-formdata

BUG=526995

Review URL: https://codereview.chromium.org/1317043003

git-svn-id: svn://svn.chromium.org/blink/trunk@201631 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ScopedPageLoadDeferrer is an RAII-like class that does some work when it is
constructed and destructed, just like other ScopedXXX classes.

It was oilpanized in the past, and a new method, dispose(), was added to
do clean-ups that had been done in the destructor. However, a few stack-
allocated usages were overlooked in that change.

Garbage-collected objects shouldn't be allocated on the stack. So, stack-
allocated usages should be converted to heap-allocated, with dispose() calls
added in every single place where the object can go out of scope.

However, I find this conversion too cumbersome and less C++-idiomatic.

Therefore, this patch instead de-oilpanizes ScopedPageLoadDeferrer. The only
reference to will-be-heap-managed class in ScopedPageLoadDeferrer is
RefPtr<LocalFrame>, so it is safe to convert it to RefPtrWillBePersistent.

I think this patch makes the code cleaner overall.

BUG=486590
R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1316663004

git-svn-id: svn://svn.chromium.org/blink/trunk@201630 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=513568
NOTRY=true

Review URL: https://codereview.chromium.org/1310633005

git-svn-id: svn://svn.chromium.org/blink/trunk@201629 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Root cause:
Our testharnessreport.js removes unnecessary text nodes in a callback registered
by add_completion_callback() [1]. The html5lib tests add other completion
callbacks to show failure reasons, and they run after the callback of
testharnessreport.js.  So, the failure reasons remain in *-expected.txt.

Resolution:
testharness.js doesn't provide a way to specify that "This callback must run at
the end of callbacks." So we delay the text nodes cleanup by setTimeout(done, 0).

[1] https://github.com/w3c/testharness.js/blob/master/docs/api.md#callback-api

BUG=527262

Review URL: https://codereview.chromium.org/1303313006

git-svn-id: svn://svn.chromium.org/blink/trunk@201628 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://html.spec.whatwg.org/multipage/scripting.html#script-processing-for
> 12. If the script element has an event attribute and a for attribute, then run
> these substeps:

Our implementation was "... has a non-empty event attribute and a non-empty for
attribute, ...".  This CL corrects isEmpty() checks to isNull().
The new behavior is compatible with IE and Firefox.

BUG=520844

Review URL: https://codereview.chromium.org/1305213005

git-svn-id: svn://svn.chromium.org/blink/trunk@201627 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ResourceClientWalker uses a reference to m_clients (a member of the
RawResource instance). Therefore, when w.next() is invoked, the RawResource
instance must be alive.

RawResourceClient (e.g. DocumentThreadableLoader) may destroy the RawResource
in didSendData() and didDownloadData().

Like other methods (appendData(), willFollowRedirect(), ...) these methods
should also have a protect.

BUG=527046
R=japhet,hiroshige

Review URL: https://codereview.chromium.org/1307743009

git-svn-id: svn://svn.chromium.org/blink/trunk@201626 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch replaces static member function |VisibleSelection::selectionType()|
by |VisibleSelection::Strategy::selectionType()| in |PendingSelection| class
as preparation of moving |VisibleSelection::selctionType()| out from
|VisibleSelection| as local static function, since it is used only
|PendingSelection| and |VisibleSelection| classes for ease of templatizing
|VisibleSelection| to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1323933003

git-svn-id: svn://svn.chromium.org/blink/trunk@201625 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=516604, 496496

Review URL: https://codereview.chromium.org/1320443005

git-svn-id: svn://svn.chromium.org/blink/trunk@201624 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/1326773002

git-svn-id: svn://svn.chromium.org/blink/trunk@201623 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |honorEditingBoundaryAtOr{Before,After}()| for
|VisiblePosition| to "VisibleUnits.cpp" form "VisiblePosition.cpp" to make
"VisiblePosition.cpp" to simpler for improving code health and ease of
templatizing |VisiblePosition| class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1303173010

git-svn-id: svn://svn.chromium.org/blink/trunk@201622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=rev&rev=201530 fixed the assertion
failures.

BUG=519997
TBR=kouhei@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1321663004

git-svn-id: svn://svn.chromium.org/blink/trunk@201621 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Style attribute declarations were added in a separate scope after all
other author origins. Instead add style attribute declarations right after
collecting matching rules from the element's scope. This means that we can
override values set on the style attribute from outer scopes, like we can
with values from inner scope's stylesheet.

Without this fix, you would get green on orange below:

<style>html /deep/ span { color: green; background-color: lime }</style>
<host>
  <host:root>
    <style>span { color:red }</style>
    <span style="background:orange">Green on orange?</span>
  </host:root>
</host>

With this change, we will get green on lime.

The regression (issue 526634) was not relying on this, but it would be
more complex code to fix the regression without fixing the style attribute
cascading order.

R=kochi@chromium.org,hayato@chromium.org
BUG=526634

Review URL: https://codereview.chromium.org/1322753006

git-svn-id: svn://svn.chromium.org/blink/trunk@201620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch replaces member variables |Position| and |TextAffinity| in
|VisiblePostion| class to |PositionWithAffinity| to simplify construction
of an object for preparation of templatizing |VisiblePostion| to introduce
composed tree version.

This patch also moves default constructor into .cpp file from header file to
reduce size of header file.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311913006

git-svn-id: svn://svn.chromium.org/blink/trunk@201619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the standard and web-platform-tests, empty attribute value should
return the document URL.
https://html.spec.whatwg.org/multipage/forms.html#dom-fs-formaction

> The formAction IDL attribute must reflect the formaction content attribute,
> except that on getting, when the content attribute is missing or its value is
> the empty string, the document's address must be returned instead.

This CL removes empty formaction tests in submit-form-attributes.html.
html/semantics/forms/attributes-common-to-form-controls/formaction*.html cover
them.

BUG=520835

Review URL: https://codereview.chromium.org/1321033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201617 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removed m_isQuirkValue from CSSValue and updated callers to use
CSSPrimitiveValue::UnitType::QuirkyEms instead.

Review URL: https://codereview.chromium.org/1316153003

git-svn-id: svn://svn.chromium.org/blink/trunk@201616 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201598

BUG=521730
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1329663002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201615 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1314773006

git-svn-id: svn://svn.chromium.org/blink/trunk@201614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521730
NOTRY=true
TBR=pilgrim

Review URL: https://codereview.chromium.org/1326593003

git-svn-id: svn://svn.chromium.org/blink/trunk@201613 bbb929c8-8fbe-4397-9dbb-9b2b20218538