- 26 Aug, 2020 40 commits
-
-
chrome://flagsDale Curtis authored
This will make it easier for users and early testers to check out the feature and verify it's working properly. chrome://flags/#videotoolbox-vp9-decoding Bug: 1103432, 1122109 Test: chrome://flags Change-Id: Id2e7d176e894c6b9866d8e112b83d362c2efd25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376378 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#801924}
-
David Roger authored
If the last active profile was deleted, a new browser was always opened. After this CL, no browser is automatically opened if there is a profile picker. Note: if the last profile was deleted, a new profile is still created and loaded in memory. This CL also fixes a few instances where the wrong user manager was opened (ProfilePicker opened instead of UserManager or vice-versa). Fixed: 1121545 Change-Id: Ifbcd02ec1b1015a5736dd1714e36d5cf61d043da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375211 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#801923}
-
Xianzhu Wang authored
Bug: 1011914 Change-Id: I2978b8bd6c7ee94c133b4a133c9df311382fc963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377610Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801922}
-
Xianzhu Wang authored
This is based on the answer in https://docs.google.com/spreadsheets/d/1FeigUaKrTBKPx36U4v0hJMlQZ_DAq-tYlSiG-LvhWLg/edit. This prepares for letting blink feature status override chromium feature status. Bug: 1121839 Change-Id: Ia44d4cc167319cac267820e30bd5388836327e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377996Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801921}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fa7dd9bb. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" 3dbd8ec2 "[Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ia4117d96a1231ba106785b58c8935c41521624ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377431Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801920}
-
Keishi Hattori authored
Moves frame tree from WebFrame to Frame. The parent frame is required in the Frame constructors (e.g. by AdTracker) so we set it there. After the constructor, the frame will be in a provisional state where the parent frame is set, but not attached to the frame tree. By calling InsertAfter, the Frame can be inserted into the frame tree. Bug: 1100056 Change-Id: I9a8226ef9611a7c0e453af3353781a9576ccdc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350208 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801919}
-
Evan Stade authored
This relands commit c4aceb16. Difference: updates to ContactsPickerDialogTest to fix L tester Original change's description: > Move Contacts Picker to //components/browser_ui/contacts_picker > > Bug: 1016938 > Change-Id: Ib3a86b4a3e3c0356c292ce55291ef0487e94c5ae > Skip-Translation-Screenshots-Check: True > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325272 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lijin Shen <lazzzis@google.com> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801610} TBR=dcheng@chromium.org,finnur@chromium.org,tedchoc@chromium.org,wfh@chromium.org,lazzzis@google.com Skip-Translation-Screenshots-Check: True Exempt-From-Owner-Approval: TBRing Bug: 1016938 Change-Id: Ifa455c12c37b98120ad0bac2a75796eaa6ff2190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378211 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#801918}
-
Stephanie Kim authored
Bug: 1114291, 1072012 Change-Id: I8f2684aefba663538f42402c0be133cabed32993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377652Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#801917}
-
minch authored
Switch kAshColorMode was added to show prototype to UX before. Remove it now since we are going to add a dark/light mode switching UI at the system tray. Bug: 1106012 Change-Id: Id5cb946217530f2a21fdc1c139d3943b24959b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373950 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#801916}
-
Chris Lu authored
This change shows the default browser fullscreen promo on resumeSessionWithTabOpener: if the user's past behavior fits the categorization of potentially interested users or if the user is signed in. Do not show if it is determined that Chrome is already the default browser or if the user has already seen the promo UI. Creates a WhatsNewCommands for AppState to send signals to BVC. Video: https://chromium-review.googlesource.com/c/chromium/src/+/2363660 Bug: 1107489 Change-Id: I63c30b4a705faf2b1e729b8be167f9ef38815e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368156 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801915}
-
Charlie Hu authored
This CL adds PolicyValueType::kEnum. Internally, it is represented as |int_value_| in PolicyValue. Bug: 1119481 Change-Id: I3b25572b15f3557317ca658709a123b9af7fd48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345488 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#801914}
-
chrome-untrusted://new-tab-pageEsmael El-Moslimany authored
Trusted types were enabled by https://chromium-review.googlesource.com/c/chromium/src/+/2353547. The untrusted source also needs to opt out so the OneGoogleBar can load without errors. Bug: 1121817 Change-Id: Ied18bdbfcee9a5ef92ffc59fe5a429790478eb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375679 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#801913}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c6aa15118046..d410c664e6e3 2020-08-26 bpastene@chromium.org gclient: Preserve ANSI color codes when calling hooks. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1034063 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I855310acf79ca7d260286e0407a374051cc5cada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378177Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801912}
-
Jonathan Mengedoht authored
Adding metrics to check if the the gstatic file is fetched in time and how often a url override is available. Bug: 927473 Change-Id: I32723366b3c3132ed58429cf4bb6a166a2405fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360084 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801911}
-
Sahel Sharify authored
external/wpt/webrtc/protocol/crypto-suite.https.html times out on multiple platforms, flake portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWAsSBUZsYWtlIk1jaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L3dlYnJ0Yy9wcm90b2NvbC9jcnlwdG8tc3VpdGUuaHR0cHMuaHRtbAw Bug: 1122106 TBR=hta@chromium.org Change-Id: Ibe51858b90608fd854e69dad63176d5d9dcbedd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378388Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#801910}
-
Chris Palmer authored
Fall back to reading from urandom only when that fails. Bug: 995996 Change-Id: Id503ca2dc412a392d5a7e252fcfff65b61d0c20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762604 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Julien Tinnes <jln@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#801909}
-
Justin Cohen authored
This reverts commit 163b6034. Reason for revert: Speculative revert for beta 6 Original change's description: > ios: Disable RemoveCookie test on iOS14. > > TBR=mrefaat > > Bug: 1121425 > Change-Id: I77602b224fe06577aa7d2a7da50df17b036b54e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373705 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Auto-Submit: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801345} TBR=justincohen@chromium.org,mrefaat@chromium.org Change-Id: Ideb21ea26cee61249444139f7a0c59735f1e5754 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376314Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801908}
-
Daniel Rubery authored
This CL calls the GetMatchingVisualTargets in a worker thread, since the process of scoring visual features takes longer than expected and was blocking interaction. Fixed: 1121375 Change-Id: I8f3e33d20f812645a72adfc16fe33241b49a6ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372869 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#801907}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7023f47299aa..0fdfdcf61cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If1c3b94eb78a5143715d71608cca6bbcd122c496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376977Reviewed-by:
-
Haiyang Pan authored
This trybot mirrors the existing waterfall builder of the same name. Bug: 1115229 Change-Id: I5355e563437846b0f1ec310f2487f243aee20c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376876 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a54f10f750ba..8e24b3cc2f00 2020-08-26 mmenke@chromium.org NetLogViewer: Add support for renamed DNS entry field "net_error". If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1122054 Tbr: skyostil@google.com Change-Id: I01e74c3405e001de6444150698cbacd7658e3bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378195Reviewed-by:
-
Viviane Yang authored
Add a new refresher class with unittests. Bug: 1116498 Test: unit_tests --gtest_filter=PushMessagingRefresherTest* Change-Id: Ia64e8ef3fa6a26f6c1a7c7e1ea913938fe40cc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375366 Commit-Queue: Viviane Yang <viviy@google.com> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801903}
-
James Vecore authored
Adds the Nearby Share action to the ChromeOS sharesheet and wires up the View to show the chrome://nearby WebUI. Change-Id: I2938228911001c6ad1fcfeaf9510f9a3983266be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315820 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#801902}
-
Michael Crouse authored
This change adds a histogram to record the time for evaluating the current language detection model (CLD3). This will help planning for an updated model and provide a baseline to compare that with. Bug: 1121680 Change-Id: I0270ce12a656fc34ad1b963d1a774efc87677e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376305 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#801901}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fdfdcf61cd4..14a9bffb3e9e 2020-08-26 treehugger-gerrit@google.com Merge "perfetto: add GPU Memory totals UI control" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I43870e90d9fdfa61f014601c90f262a5b442a5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378176Reviewed-by:
-
Dominic Farolino authored
Design doc: https://docs.google.com/document/d/1VPrEpLD1mFSHmBDYOtNuFB1deJwtRS_zpFzG1wGDmy0/edit Bug: 1112515 Change-Id: Ic3889a848cfd594fba5600bfdf916d08180041eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325429Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#801899}
-
Lan Wei authored
Right now the Action API cannot generate the drag and drop actions by sending the mouse press, mouse move and mouse release, because the drag and drop events are generated from the OS level. Therefore, Webdriver WPT test test_drag_and_drop_with_draggable_element will fail and the dragged element is still been dragged, the rest of tests will fail because all the following mouse actions would not work correctly. I add a fixture_session function to open a new window for every test. Bug: 850071 Change-Id: Iaa00e8980567cebc70046fd244ecdc1376bf785a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368713Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#801898}
-
Dave Tapuska authored
Screen metrics are emulated for devtools emulation mode. This moves the screen metrics emulator into blink and is a member of the WebViewFrameWidget since it can only be activated on the MainFrame. This change also moves a few members like the WindowRect/ViewRect and storage of the original screen info inside blink. BUG=1097816 Change-Id: Ieb508588c67ec595cc4b83645bdd973f7e230112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363302 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801897}
-
Emily Stark authored
This unexpires and updates owners for a bunch of Enamel-related histograms, mostly related to interstitials. Bug: 1121879 Change-Id: Id146e8c5ddf452caf00325bf6b9411dcf463db35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377406 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#801896}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f60cabfb25c4..b8e8ad564da3 2020-08-26 sigurds@chromium.org [ts] Type-check sdk/ResourceTreeModel.js with TypeScript 2020-08-26 sigurds@chromium.org [ts] Type-check resources/StorageItemsView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia63356f8e9185c30e3484608140f2bd02ccf3f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378197Reviewed-by:
-
Jazz Xu authored
This CL adds MediaNotificationProviderImpl as a MediaNotificationServiceObserver and it will inform its own observer when MediaNotificationListChange so that the Zenith button living in ash can show/hide correspondingly. This CL also modifies MediaNotificationService such that it can show session from all profiles when needed. Bug: 1121723 Change-Id: I778976a154dd00dda9f83b300dced364cadfb56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369653 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#801894}
-
Muyao Xu authored
Cast device buttons will be added to the MediaNotificationAudioDeviceSelectorView. This CL renames related classes and functions to reflect the change. Bug: b/161610050, 1107162 Change-Id: I2e6f38c3440c3315eb61bc691e44d8c516849321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373423 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Stefan Zager authored
BUG=1060884 Change-Id: If988b891883e9e5ce1d6ba56695a84b149803eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368452Reviewed-by:
-
Anne Lim authored
The field is added for the Offers project(go/autofill-buyflow-offer-design). Chrome uses legacy_intrument_id for credit cards, while the Payments server mostly uses instrument_id. Usually, this gets converted in Orchestration. However, it has been decided that for the Offers project, we will not go through Orchestration like the credit cards do, but will instead call the Offer backend directly. Hence, instrument_id is added here so that it can be passed down current credit card sync flow. This will also help migrate from legacy_instrument_id to Instrument_id, as the former will be completely deprecated in the future. Change-Id: I965b35784a5af9be50d3be5695c3b10ddca5751d Bug: 1121806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368459 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#801891}
-
Michael Thiessen authored
Native Java Unittests are going away, these tests need to be migrated to an Instrumentation Test apk. Bug: 1103344 Change-Id: Idf14f10e535cc8a7f37271892fb823c4aad7a17e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377549Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#801890}
-
Ben Pastene authored
Chromite is also used extensively throughout the OS-side of the world. this comment should hopefully make it clear that chromium's pin of it only affects chrome things. Bug: None Change-Id: I721ef80050cde8a5f76d318aec0cde9a94b42201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377236Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#801889}
-
Brian Malcolm authored
BUG=chromium:1103816 Change-Id: I24f101467b21667115902d56c5e346c763911a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367448 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801888}
-
Henrique Nakashima authored
This reverts commit 3ddb9b70. Reason for revert: Causes crbug.com/1120268 Original change's description: > Use IncognitoTabModelObserver to break IncognitoTabModel->.incognito > > Two new classes IncognitoNotificationPresenceController and > IncognitoProfileDestroyer now bind the TabModelSelector to the > .incognito package, controlling respectively the incognito notification > and the incognito Profile destruction. > > Since TabModelSelectorBase creates the TabModels only after native load, > it acts as a relay for the events. It is changed to recognize that there > are two TabModels, one normal and one incognito, so it can observe the > incognito one. > > Splitting IncognitoTabModel into interface and impl keeps tests from > having to depend on IncognitoTabModelImpl. > > Bug: 1109013 > Change-Id: I697f8422777ec42b44ddf19af8abb82702e136a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343790 > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Mei Liang <meiliang@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798298} TBR=dtrainor@chromium.org,twellington@chromium.org,hnakashima@chromium.org,meiliang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1109013, 1120268 Change-Id: I583264cfdf87335b5067fce9f27a833d0b1c6d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377317Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#801887}
-
Sahel Sharify authored
This reverts commit c5a74e50. Reason for revert: [Sheriff] Compile failure on mac: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8870878190370395696/+/steps/compile/0/stdout Original change's description: > [ozone/wayland] fix 'interactive_ui_tests' build > > In file included from ../../ui/base/clipboard/clipboard_unittest.cc:57: > ../../ui/base/clipboard/clipboard_test_template.h:177:7: > error: use of undeclared identifier 'features' > > if (features::IsUsingOzonePlatform()) { > ^ > 1 error generated. > > BUG=789065 > R=sky@chromium.org > > Change-Id: I60a5322b70cf03e206ba0854dfe61115c71b0337 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376129 > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#801652} TBR=sky@chromium.org,tonikitoo@igalia.com,msisov@igalia.com Change-Id: Ie7236ce92e34a8f389d25e07b95e9b997f3abcc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378393Reviewed-by:
-
David Black authored
This reverts commit 57e175db. Reason for revert: Seems to break presubmit due to missing OWNERS file Original change's description: > Remove HoldingSpacePresenter. > > No longer needed given evolution of feature requirements. > > Bug: 1112469 > Change-Id: Ic31d2a02fcc624ddc101447f68089cfff9bd2660 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377535 > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Commit-Queue: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#801857} TBR=tbarzic@chromium.org,dmblack@google.com Change-Id: I6c7b1254e9af0ae662b8afc7d37db50dff5c312d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377654Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#801885}
-
