- 25 Sep, 2020 40 commits
-
-
Xiaocheng Hu authored
The feature is already shipped with M83. Now that 4 milestones have passed, this patch removes the flag and the dead code paths. Bug: 441925 Change-Id: I4bebfcf8b1277ddc29c4f4448ff778496ea5e30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429825 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810766}
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: I146a8e396afc20341d9feac27a0115beba227d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429933 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#810765}
-
chrome://managementChris Lu authored
This reverts commit 46c6817b. Reason for revert: Chromium upsteam Egtest failing https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8868162076936730176/+/steps/ios_chrome_integration_eg2tests_module_iPhone_6s_13.6_on_Mac-10.15/0/stdout [12:20:39:INFO] Interaction cannot continue because the desired element was not found. [12:20:39:INFO] [12:20:39:INFO] Check if the element exists in the UI hierarchy printed below. If it exists, adjust the matcher so that it accurately matches the element. [12:20:39:INFO] [12:20:39:INFO] Element Matcher: [12:20:39:INFO] Omnibox contains text 'support.google.com' Original change's description: > [ios] Add EG test to chrome://management page > > Added EG test to chrome://management page. > > Updated omniboxContainingText: matcher to avoid crash when the > element is not an UITextField. > > Bug: 1131052 > Change-Id: Ia68ad5a6071867e8ae3cf4751ce1ef792cd741dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424546 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: Tina Wang <tinazwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810645} TBR=michaeldo@chromium.org,sczs@chromium.org,gambard@chromium.org,tinazwang@chromium.org Change-Id: I3ca8a0e6d189ec6c8045439abc6b76c8bbaafb6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432316Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#810764}
-
Justin Cohen authored
This reverts commit 785cd90b. Reason for revert: Better fix here: https://chromium-review.googlesource.com/c/chromium/src/+/2432053 Original change's description: > ios: Block universal links during restore. > > NOTRY=True > Bug: 1129875, 1132099 > > Change-Id: I901f4aea4a0df4e33c23c848289acb0aa2561369 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430290 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Ali Juma <ajuma@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810720} TBR=rohitrao@chromium.org,ajuma@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,michaeldo@chromium.org,mrefaat@chromium.org,gambard@chromium.org Change-Id: I7b48feab29a592af07c8ebf4a1540fe6279bc04e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129875 Bug: 1132099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432132Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810763}
-
Erik Chen authored
This CL adds the basic plumbing necessary for Lacros to avoid calling unavailable methods on ash due to ash being too old. This requires modifying browser tests to disable all crosapi functionality, and to modify production logic to avoid using crosapi functionality if it's unavailable. Bug: 1130810 Change-Id: Iedf7faae93372e42c59a61186df49d683d859f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424544Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810762}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4262.0-1600690455-benchmark-87.0.4265.0-r1 to 87-4262.0-1600690455-benchmark-87.0.4274.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I65ae4ef6a5254f306b79049df3a89d165868277c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810761}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4258.0-1600689257-benchmark-87.0.4265.0-r1 to 87-4258.0-1600689257-benchmark-87.0.4274.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1bcbb0f8f71cff4a689d2450bcb5f6bfe39f02fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432283Reviewed-by:
-
Eric Willigers authored
When navigator.share() is called with files, the files are saved to a new directory, and sharesheet::SharesheetService is used to present the user with a choice of share targets. ShareServiceUnitTest now adds blobs to blob storage context. Test cases TotalBytes and FileBytes are removed as they became redundant with https://chromium-review.googlesource.com/c/chromium/src/+/2415431 and they risk flakiness by creating large blobs. Spec: https://w3c.github.io/web-share/#share-method Bug: 1110119 Change-Id: I8c7d44f899cf8c0d31cd87fcb0ce77b25f5a98b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422107 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810759}
-
Sinan Sahin authored
Currently, the ContextMenuPopulator is a per-tab object. This requires us to pass the same set of params to #buildContextMenu() and then #onItemSelected(). Also, other methods of the class are called with the same params multiple times. This CL creates a ContextMenuPopulatorFactory and makes the ContextMenuPopulator a per-menu object. This way, we can reduce the number of params the class methods take, and we don't need to call the same methods with the same set of params many times. Change-Id: Iacfab7b35fad60cf191ea84443b456f8b60c43c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427137 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#810758}
-
François Doray authored
This reverts commit 8986879b. Reason for revert: Tests are still flaky, see bug. Original change's description: > Ad metrics: Re-enable CreativeOrigin*Browser* tests that were flaky. > > Flakiness may have been fixed by > https://chromium-review.googlesource.com/c/chromium/src/+/2290775. > Re-enable and monitor tests for any signs of further flakiness. > > Bug: 1098373 > Change-Id: I3bb147b3b5fd7a1ec8fd17d99e5db44008278c80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391722 > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810661} TBR=jkarlin@chromium.org,cammie@chromium.org Change-Id: I06884bc864eb74fc8c7274785f66f289ffd82093 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432366Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#810757}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4247.0-1600681610-benchmark-87.0.4265.0-r1 to 87-4247.0-1600681610-benchmark-87.0.4274.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib2f3baac726e494533dc682455336c0391838bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432276Reviewed-by:
-
Kramer Ge authored
For SeqLocks, it is recommended for data accesses protected by the SeqLock to be atomics. Hence, we are adding atomic memcpy functions to save the inconvenience for users having to implement their own atomic accessors. Use std::atomic in seqlocks instead of atomicops.h. unittest: Use atomic memcpy functions instead. Test max_retries feature of ReadBegin. Fix: Use std::atomic in tests See: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1478r1.html https://www.hpl.hp.com/techreports/2012/HPL-2012-68.pdf Bug: 1132012 Change-Id: I0dad5d63cbc9e30ec44535b35fce62fe7c66b2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572369Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#810755}
-
Sammie Quon authored
This is a reland of 4c93f79b. The original change patch is in ps1. The reason for the revert was an error was something with managing GPU textures (mailbox name not found). Tried copying some GPU test code [1] but still got the same error and was building up a lot of GPU dependencies. Instead of creating fake output, this cl wraps the existing TakeScreenshot calls and puts a waiter in. [1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/test/fake_skia_output_surface.cc;drc=361ef8a161b516ba106966bb0740314c41dc2678;l=272 Original change's description: > desks: Add tests for RootWindowDeskSwitchAnimator. > > Test: added > Bug: 1111445 > Change-Id: I0f79be1c09d4ef0eeff276e3c50f491efbe56244 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380517 > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809854} Bug: 1111445 Change-Id: Ib4e50c22fb063b82f50c3f4f79bb026e648a6157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429363 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#810754}
-
Alexander Surkov authored
Bug: 1131921 Change-Id: Id8b5a92a3c74763a57cf267caee612e158045875 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429251Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#810753}
-
Stepan Khapugin authored
Removes the surprisingly few unused includes and GN deps I could find. Fixed: 1045664 Change-Id: I2cab2467857b1d60b527911cc54074af8f8e5677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424253 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#810752}
-
Morten Stenshorne authored
It was failing with LayoutNG block fragmentation due to subpixel differences. Rounded border painting is very sensitive to what layers are involved, it seems. In legacy multicol we establish a layer for the flow thread and perform clipping and translation to slice the tall single column (internal representation) into columns (what you see on screen). This is not the case for NG block fragmentation, where we just paint stuff, without any additional clipping. The ref had some absolute positioning and clipping. which appeared to match the layer situation when legacy multicol was used (but not NG). We already have plenty of coverage for rounded borders in block fragmentation in wpt/css/css-break/ , e.g. borders-003.html Bug: 829028 Change-Id: If5ce0626f004acb0466497e0f1eee06ddeccbd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429009Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#810751}
-
Patrick Noland authored
This only requires giving TabSwitcherModeTTCoordinatorPhone a MenuButtonCoordinator and setting the MenuButton view once inflation happens. The logic removed (tinting, setting the onClick/accessibilityDelegate) is now handled internally by MenuButtonCoordinator/MenuButton. Bug: 1086676 Change-Id: Iafbe6539974406fcd3db0f8a904e581d355a872b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411401 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#810750}
-
James Vecore authored
When testing with Nearby Share we were seeing crashes during Bluetooth socket sending. When ever the crash happened we would see the same write_request getting processed twice. When the write request gets to the underlying socket implementation we would hit this CHECK: [1]. This was happening because SendFrontWriteRequest can get called again while write request is still pending (a call is always queued after write completion regardless of the queue state) and it grabs the front of the queue. The queue item for a write request does not get popped off until the transfer is complete which allows the same request to get processed twice (depending on timing). The solution here is to remove the pending request from the queue right away and store while it is in progress. In SendFrontWriteRequest we check if there is already a pending request and exit early. SendFrontWriteRequest always gets re-queued when the pending write request completes so we always keep processing. Tested on device with transfers between Android and ChromeOS. [1] https://source.chromium.org/chromium/chromium/src/+/master:net/socket/socket_posix.cc;l=331 Fixed: 1121747 Change-Id: I67b69f735798f832aecdd62b6697ecef8d99cfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429863Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d0ddf023e1c8..ea1181f182dc 2020-09-25 yichengli@chromium.org Add api/controllers endpoint for BundleFpmcuUnittests 2020-09-25 saklein@chromium.org Test/BuildTargetUnitTest: Begin blocklist language transition. 2020-09-25 mmortensen@google.com Refactor portage_util to isolate portage system calls. 2020-09-25 yichengli@chromium.org Generate python bindings for new BuilderConfig artifact type 2020-09-24 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-24 moragues@google.com strongbad: enable builder 2020-09-24 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-24 gbiv@google.com lddtree: add LD_ARGV0_REL 2020-09-24 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I497dc99d761de51247711b075f5dcdf5a5acaa77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431829 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Becca Hughes authored
Change-Id: Ic47ee8e027e8e545e51d2b791f5ceb6c19660c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432106 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#810747}
-
Nnamdi Theodore Johnson-Kanu authored
- Romoved duplicated string - Updated base page UI Screenshots: - https://imgur.com/OZPqyfj - https://imgur.com/OGFU3fI - https://imgur.com/jDLcIQu - https://imgur.com/Lndkx7C - https://screenshot.googleplex.com/ckyhXWunKco7LHP.png Bug: 1093185 Change-Id: Ied55dbf424f0715ea9a728c6266336e957a29469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417312 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#810746}
-
David Dorwin authored
This appears to have been a merge error on top of https://crrev.com/c/2362589 in patch set 12 of https://crrev.com/c/2293110 (relanded as https://crrev.com/c/2417492). Also report an error if both incoming and outgoing transfers are present. Bug: 1104369 Change-Id: I09ca94ce5225ebd2fc540a3a93fa0b63d1b70d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430302Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810745}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601024402-e01a8b4ea46e599b0bc76ffef4e1caecb20ec78d.profdata to chrome-win32-master-1601034748-4cd4b98b310bb3013acaee2e7944821542e902f7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic719ff0c094d6d9fc0414526232c9428a89b68ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431840Reviewed-by:
-
Dirk Pranke authored
The above flag is currently always passed by the recipe to isolated_script tests. Nothing uses it for anything substantial, but I forgot when I tried to remove it in https://crrev.com/c/2427305 that there is one trivial use of it (to reconstruct a command line). This CL removes that one trivial use, so that I can re-land the original build-side recipe change and remove the flag. Bug: 1127545 Change-Id: I11b861be35be43f193be24117073a69906c5a73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429866Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#810743}
-
Marijn Kruisselbrink authored
The base::Feature has been enabled by default for many many milestones now, so it seems unlikely we'd ever want to turn it off again. Remove it to make code simpler to maintain. Embedders can still turn off the API using the blink runtime feature. Change-Id: Ifad92d39adac1e656cf75a02918f33409aea44ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427287 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#810742}
-
Matt Menke authored
This depends on ResourceRequest::site_for_cookies(), which we plan to remove, and histograms indicate no one is using it, so remove the API. Bug: 1076043, 1130633 Change-Id: I05ee962221c3a86bf4a541339862976004a250f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424548Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#810741}
-
Adam Langley authored
It's now possible to mock out the network service and run the authenticator code against the desktop code in a test environment. BUG=1002262 Change-Id: Ie2bf611d529baddfb1d04be1b0c60d6c4026d419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419337 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#810740}
-
Alice Wang authored
This CL adjusts the bottom sheet subtitle line height to make it look consistent with the incognito interstitial message style, which is required by UX. Bug: 1132215 Change-Id: I786e4ce1d86cabc26bbb026a5a666d5caefc6593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429404Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810739}
-
Emily Stark authored
This is a reland of 992e5b90 Original change's description: > Send SCT reports to Safe Browsing > > This implements sending new SCT audit reports to the Safe Browsing > servers for opted-in users. The SCTAuditingCache now sends reports using > a SimpleURLLoader when new reports are sampled for sending to Safe > Browsing. This reporting is configured by the SCTReportingService via a > new NetworkService::ConfigureSCTAuditing() API. This redesign eliminates > the round-trips between the network service and the browser process > entirely by having the SCTReportingService configure which network > context (and URLLoaderFactory) the SCTAuditingCache should use to send > reports (in this case, we use the system network context). > > This also: > - Removes the OnSCTReportReady Mojo API. > - Moves the feature flag for opt-in SCT auditing from services/network/ > into chrome/ now. > - Adds the network traffic annotation for opt-in SCT auditing. > - Extends the existing SCTReportingService browser tests to track > whether reports sent their results to the reporting server. > - Adds unittests covering reports being sent. > - Adds an optimization where empty reports are stored for reports that > we do not sample (and thus will never be sent to the server), rather > than storing the full report object. > > Bug: 1082860 > Change-Id: I29fd0ee1cb9c2d5c850601e0b54203363d4f8282 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331755 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809867} Bug: 1082860 Change-Id: I3e895c1dcd202d3aab0c1ef8ccaf97bfb04ea7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429240Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Anastasia Helfinstein authored
Also ensures that non-browser tabs are treated as web elements, not browser tabs. Unblocks crbug.com/1131689 AX-Relnotes: n/a. Bug: None. Change-Id: Ic841403a07941804e1605169ab0e6db481de4d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429844Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#810737}
-
Andrew Xu authored
This CL adds an option to the context menu (with copy/paste options) to show the clipboard history menu. The CL does the following work: (1) It creates an interface called ClipboardHistoryController, enabling the Chrome side to access the clipboard history menu. (2) It renames ClipboardHistoryController to ClipboardHistoryControllerImpl which implements the interface. (3) Adds the option to the context menu. The execution of the menu option's command should open the clipboard history menu through the interface. Bug: 1118158 Change-Id: Idb383571765233514b91d4f2e5629220ddeee1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425192 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/31c5354707f0..d3ba0ee3a4e7 2020-09-25 alexrudenko@chromium.org Show contrast ratio and preview for each element in CSS Overview 2020-09-25 jacktfranklin@chromium.org Migrate SearchConfig.js to TypeScript 2020-09-25 janscheffler@chromium.org [WebAuthn] Format keyfile If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1120316,chromium:1131055 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I41f7e3e5f7eac8d9ed1fa3dba6afc9a4d78171e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431838Reviewed-by:
-
James Cook authored
kMediaRouterEnableCloudServices was missing a namespace in one file. Tbr: khorimoto@chromium.org Bug: none Change-Id: Ia2abe411046f991893c2e8349d0424d3d7754123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431778Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#810734}
-
Sergey Poromov authored
This is a reland of 1546f3b4 Original change's description: > Add policy logic to clipboard dlp controller > > 1. Changed EnterpriseClipboardDlpController logic > to be based on the policy logic in DlpRulesManager. > 2. Added DlpRulesManager::IsAnyRestrcitedComponents > to decide if any component is restricted. > > Bug: 1102332 > Change-Id: Ib1abc64c71540cb431f94d4dfae44212ef8d3597 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416451 > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810586} Bug: 1102332 Change-Id: I2416dea8c4fa08d40d89feea9f28f590cd47c819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431927Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810733}
-
chinsenj authored
Currently the logic that handles the focus ring and scrolling the window cycle list are coupled together. However, there are cases where the focus ring should move and the list should not scroll and cases where the focus ring shouldn't move and the list should scroll. To handle the aforementioned cases, this CL separates the handling for scrolling and the focus ring. Test: Manual Bug: 1067327 Change-Id: I9fed7362c33dd2c5589b8bb5f52e81269273cad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425483 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#810732}
-
Austin Sullivan authored
In preparation of shared unit tests between the various FileStreamWriter implementations. Merge this before https://crrev.com/c/2422682 Change-Id: I56e4a3f5973a13a2bb39108114be5462296ff8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425429Reviewed-by:
-
Lei Zhang authored
Add Uri::ShouldPrintPort() to make a slightly complicate conditional more clear. With a separate method, it is easier to add local variables. Take advantage of that and use an iterator to avoid doing two searches on the same key. Change-Id: Iea98d7d532448e3ec43e6cf6a6d190079f655b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427222 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#810730}
-
Mugdha Lakhani authored
The recursive prefetch token is generated from the browser process, passed to the renderer process and then back to the browser process. This crashes the renderer in response to a request with an incorrectly set recursive prefetch token. Bug: 1123715 Change-Id: Ia6e627de66566a506b44d31b93e65d4acf07e27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421597Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#810729}
-
Fletcher Woodruff authored
The implementation of StartScan now matches StartScanMultiPage in Lorgnette. Convert LorgnetteManagerClient to use StartScan so that StartScanMultiPage can be deleted. Bug: b:161239919 Change-Id: Id3cd3bd7221aec461ade27cf3450f7f8fbf3fc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427018Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Cr-Commit-Position: refs/heads/master@{#810728}
-
Trevor Perrier authored
This CL calls SplitCompat.installActivity on the context returned by |ChromeBaseAppCompatActivity.createConfigurationContext|. This is needed because internally |applyOverrideConfiguration| creates a new context each time getResources() is called. This new context does not have access to the SplitCompat language packs. By calling SplitCompat.installActivity on this new activity hopefully the localization resources will be found. Bug: 1128698 Change-Id: I121ae24a84e456b9cacdfabefc310a0e7ee1c6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430825Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#810727}
-
