GitLab

This will eventually go away, but it doesn't belong on ChromeClient
in the meantime.

BUG=339659
TEST=No behavior change.

Review URL: https://codereview.chromium.org/642823006

git-svn-id: svn://svn.chromium.org/blink/trunk@183839 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rename it to generateReferrer() to better match its return type.

Also, make setHTTPReferrer() remove the header if the value parameter is empty. There shouldn't ever be a reason to send an empty referrer header (rather than not sending a referrer header at all), so this enables us to enforce this property in one place, rather than several.

BUG=

Review URL: https://codereview.chromium.org/650023003

git-svn-id: svn://svn.chromium.org/blink/trunk@183838 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,haraken
BUG=423536
NOTRY=true

Review URL: https://codereview.chromium.org/640813003

git-svn-id: svn://svn.chromium.org/blink/trunk@183837 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch modifies GraphicsContext::drawPicture to make it
avoid the use of image filters for presenting canvas
contents, and just use a plain save layer when drawing
contents at 1:1 pixel scale.

BUG=386601

Review URL: https://codereview.chromium.org/662673002

git-svn-id: svn://svn.chromium.org/blink/trunk@183836 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduced accidentally by copy-paste.

Review URL: https://codereview.chromium.org/658073003

git-svn-id: svn://svn.chromium.org/blink/trunk@183835 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423536

Review URL: https://codereview.chromium.org/655063003

git-svn-id: svn://svn.chromium.org/blink/trunk@183834 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The logs for these EME tests expect all the "onencrypted" events to
occur before the "message" event is received. Modify the tests to
create the session on the second event rather than the first, to avoid
the "message" event occasionally happening before the second
"onencrypted" event".

BUG=407993
TEST=modified tests still pass

Review URL: https://codereview.chromium.org/634243005

git-svn-id: svn://svn.chromium.org/blink/trunk@183833 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are 101 different classes in the RenderObject class tree and
they share 150-250 virtual functions each. That scales to 60-200 KB
of vtbls (depending on architecture), which cost space in the
binary and time during startup since they need to be copied 
to RAM and adjusted. In fact, some RenderObject vtbls are the
largest vtbls in Chrome.

There doesn't have to be anything wrong with any of this, but the
use of 60+ virtual isXXX functions which were the same for 100 out of
101 classes could easily be replaced by a single virtual function, saving 20-50 KB of the space mentioned above (again depending on architecture).

When the class is known, the isOfType functions will constant fold, just
like the isFoo methods.

clang x64 space info:
Total change: -47075 bytes
==========================
  78 added, totalling +4731 bytes across 70 sources
  142 removed, totalling -4008 bytes across 70 sources
  397 grown, for a net change of +5064 bytes (296097 bytes before, 301161 bytes after) across 128 sources
  115 shrunk, for a net change of -52862 bytes (209130 bytes before, 156268 bytes after) across 5 sources

gcc x64 space into:
Total change: -49078 bytes
==========================
  141 added, totalling +19000 bytes across 90 sources
  200 removed, totalling -21292 bytes across 90 sources
  371 grown, for a net change of +17491 bytes (387125 bytes before, 404616 bytes after) across 164 sources
  261 shrunk, for a net change of -64277 bytes (387358 bytes before, 323081 bytes after) across 98 sources

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/613783002

git-svn-id: svn://svn.chromium.org/blink/trunk@183832 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r183289 caused a new overwriting alerts bug because it didn't replicate
the way builder_alerts handled null failure reasons. Using step::reason
won't actually be unique if the reason is null since builder_alerts
doesn't merge failures with null reasons.

R=leviw@chromium.org,jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/638333002

git-svn-id: svn://svn.chromium.org/blink/trunk@183831 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Here is the OWP tracking bug: https://code.google.com/p/chromium/issues/detail?id=422984
Here is the link to the entry on the feature dashboard: https://www.chromestatus.com/features/4871530282483712

Currently canvas clips are not antialiased which differs what what other
browsers are doing and what the users expect. Skia supports antialiased clipping
but Skia's gpu backend (which is used for canvas) can be significantly slower
for concave clips. 

This CL starts surfacing the desired antialiased clipping behavior behind a flag
so developers can start assessing the capability. There is a lot more work that
needs to occur in Skia before we have a consistently good story for gpu-backed
antialiased clipping so we will not be ready to switch behaviors for a while.

BUG=crbug.com/7508
BUG=crbug.com/422984

junov: core & platform
dglazkov: Source/web & public/web

Review URL: https://codereview.chromium.org/652483003

git-svn-id: svn://svn.chromium.org/blink/trunk@183830 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes the FrameViewer json serialization of annotatedInvalidationRects.
This CL fixes the format from (x, y, maxX, maxY) to (x, y, width, height).

BUG=402033

Review URL: https://codereview.chromium.org/659003002

git-svn-id: svn://svn.chromium.org/blink/trunk@183829 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rather than NULL-checking it directly, I've instead plumbed through
ActiveDOMCallback::canInvokeCallback(), which handles all the logic
MutationObserver was doing previously and also handles the NULL check.

The test case is crazy-looking because it was generated by ClusterFuzz.
I've simplified it as much as possible.

BUG=410755

Review URL: https://codereview.chromium.org/657983002

git-svn-id: svn://svn.chromium.org/blink/trunk@183827 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=373552
R=eroman
Tests= crypto/ LayoutTests

Review URL: https://codereview.chromium.org/595873003

git-svn-id: svn://svn.chromium.org/blink/trunk@183826 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/661793002

git-svn-id: svn://svn.chromium.org/blink/trunk@183825 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=392606
TEST=RecordingImageBufferSurfaceTest

Review URL: https://codereview.chromium.org/659873002

git-svn-id: svn://svn.chromium.org/blink/trunk@183824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When we decide to promote all children of an anonymous block and then
nuke it, ignore any continuation set on the new parent of the children,
to make sure that the children are in fact inserted as children of said
new parent, and not somewhere else in the tree.

This is a hack that's needed as long as we keep the old multicol
implementation. The root cause is probably buggy block continuation
handling, but fixing that would be risky.

BUG=421720

Review URL: https://codereview.chromium.org/656143003

git-svn-id: svn://svn.chromium.org/blink/trunk@183823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit 9c188b20fbb4d4c2006ab1a611ed8a9b971e7cee.

Broke several browser_tests which depended on the previous behavior:
BrowserEncodingTest.TestOverrideEncoding
EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/16
BrowserEncodingTest.TestEncodingAutoDetect
EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/3

E.g.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserEncodingTest.TestOverrideEncoding&testType=browser_tests

TBR=jshin@chromium.org
BUG=412053
NOTRY=true

Review URL: https://codereview.chromium.org/658193002

git-svn-id: svn://svn.chromium.org/blink/trunk@183822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are some legal tricks used to encode JSON. But JSON.parse rejects
to parse it, whereas XHR response is correctly transformed to JSON.

BUG=406900

Review URL: https://codereview.chromium.org/654083006

git-svn-id: svn://svn.chromium.org/blink/trunk@183821 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, SASSSourceMapping polls CSS for 5 seconds after the SASS
change, and this turns out to be insufficient in case of complex
css-processing build steps.

Instead of adding one more setting "css polling duration", this patch
tries to solve most of the problems by increasing polling duration
to 30 seconds.

BUG=421925
R=vsevik, apavlov

Review URL: https://codereview.chromium.org/658123002

git-svn-id: svn://svn.chromium.org/blink/trunk@183819 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a bug that I introduced in r164832.
This caused SMIL animation targeting <marker>'s refY to animate refX attribute instead.

TEST=svg/markers/animate-refY.svg
BUG=None

Review URL: https://codereview.chromium.org/661733002

git-svn-id: svn://svn.chromium.org/blink/trunk@183818 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The expected result of fast/canvas/webgl/draw-webgl-to-canvas-2d.html
is failure because this test uses setTimeout to go to next frame.
testRunner.displayAsyncThen() can fix this test.

BUG=423674

Review URL: https://codereview.chromium.org/655133003

git-svn-id: svn://svn.chromium.org/blink/trunk@183817 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Improves code readability

BUG=none
TEST=no layout test failures

Review URL: https://codereview.chromium.org/642293004

git-svn-id: svn://svn.chromium.org/blink/trunk@183816 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of RELEASE_ASSERT if last resort fallback font cannot be loaded. (patchset #1 id:1 of https://codereview.chromium.org/641763003/)

Reason for revert:
Reverting per request.
https://code.google.com/p/chromium/issues/detail?id=421370#c11

Original issue's description:
> RELEASE_ASSERT if last resort fallback font cannot be loaded.
> 
> This will help confirm the suspicion that a number of ClusterFuzz reports
> from constructTextRun are a result of this failing. There's probably nothing
> useful that can be done with a font that lacks any font data anyhow.
> 
> BUG=421370
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183470

TBR=eae@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=421370,423643

Review URL: https://codereview.chromium.org/659073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183815 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=393913
NOTRY=true

Review URL: https://codereview.chromium.org/662633002

git-svn-id: svn://svn.chromium.org/blink/trunk@183814 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The glasspane should be a component-root so that it inherits all the
basic styling.

R=pfeldman

Review URL: https://codereview.chromium.org/659043002

git-svn-id: svn://svn.chromium.org/blink/trunk@183813 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183802

BUG=397902
TBR=kouhei@chromium.org

Review URL: https://codereview.chromium.org/664503002

git-svn-id: svn://svn.chromium.org/blink/trunk@183812 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=393913
R=pfeldman@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/657063002

git-svn-id: svn://svn.chromium.org/blink/trunk@183810 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch prevents ElementTreeELements from selecting if they have
inner inplace editor.

BUG=423720

Review URL: https://codereview.chromium.org/663453003

git-svn-id: svn://svn.chromium.org/blink/trunk@183809 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423737

Review URL: https://codereview.chromium.org/655273002

git-svn-id: svn://svn.chromium.org/blink/trunk@183808 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Section 10.4 of the specs forces us to ignore items spanning tracks with
flex sizing functions when resolving the content-based track sizing
functions. Items with span < 2 are not affected by this rule (as they will
belong to a single track). This way the algorithm ensures that min-content
and max-content restrictions are fulfilled before distributing the extra
space.

BUG=392200

Review URL: https://codereview.chromium.org/448993002

git-svn-id: svn://svn.chromium.org/blink/trunk@183807 bbb929c8-8fbe-4397-9dbb-9b2b20218538

the current stacking context.

If a stacking context element has descendants with blend mode, it should
create a new transparency layer, so that blending descendants will blend
only with the content within this stacking context (stacking context
will isolate blending).

With this CL, hasDescendantWithBlendMode will be set only if
the descendant is right inside the current stacking context, without
looking into nested stacking context elements. It also renames
hasDescendantWithBlendMode to hasNonIsolatedDescendantWithBlendMode,
which is more self-explanatory.

This change is necessary after https://codereview.chromium.org/466193002
(Disentangle blend mode from updateDescendantDependentFlags).

The "isolating" state used to be tested with DRT, but this property has
been removed with https://codereview.chromium.org/466943002/
(Remove isolatesBlending from render tree dumps).

We cannot test this change using layout tests. The effect is that
RenderLayer doesn't create any aditional and unnecessary skia
transparency layers.

Review URL: https://codereview.chromium.org/478333002

git-svn-id: svn://svn.chromium.org/blink/trunk@183806 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When I shipped marquee-in-JS, it increased UseCounters for Web Animation APIs because the marquee-in-JS uses the Web Animation APIs. This was an unexpected outcome because what we want to count is the number of JS APIs used by web developers, not the number of JS APIs used internally (i.e., private scripts).

Given the above, this CL adds UseCounter::countIfNotPrivateScript() and uses it in a binding layer so that we can count only the number of JS APIs used by web developers.

BUG=341031

Review URL: https://codereview.chromium.org/656693002

git-svn-id: svn://svn.chromium.org/blink/trunk@183805 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Current WebGL relies on glDiscardFramebufferExt() to clear FBO, but the API
doesn't guarantee clearing FBO.

TEST=fast/canvas/webgl/draw-webgl-to-canvas-2d.html,
fast/canvas/webgl/webgl-composite-modes-repaint.html
BUG=423674

Review URL: https://codereview.chromium.org/656053002

git-svn-id: svn://svn.chromium.org/blink/trunk@183804 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=420005
R=sergeyv, pfeldman

Review URL: https://codereview.chromium.org/653413002

git-svn-id: svn://svn.chromium.org/blink/trunk@183803 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, SVGFitToViewBox::parseAttribute handled negative width, height
errors inline. To migrate parsing to property map (crbug.com/397902), we want
to delegate this to SVGAnimatedProperty::setBaseValueToString implementation.

This CL introduces SVGAnimatedViewBoxRect which is a SVGAnimatedRect implements
handling of negative width/height.

TEST=svg/custom/viewbox-syntax.svg
BUG=397902

Review URL: https://codereview.chromium.org/664433002

git-svn-id: svn://svn.chromium.org/blink/trunk@183802 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When checking 'frame-ancestor', we end up asking for the SecurityOrigin
of the protected resource before we actually have a protected resource
whose origin we could ask for. This, unsurprisingly, crashes.

This patch adds a protocol property to the ContentSecurityPolicy object
so that we can perform all the checks for source expressions that don't
specify protocols without crashing the renderer.

BUG=424074
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/658073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183801 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[WillBeGarbageCollected] is already inherited from the parent EventTarget.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/653263006

git-svn-id: svn://svn.chromium.org/blink/trunk@183800 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's easy to miss adding USING_GARBAGE_COLLECTED_MIXIN macros to classes
that inherit from GarbageCollectedMixin. To avoid the programming error,
this CL adds a pure virtual method to the GarbageCollectedMixin class.
If we miss the USING_GARBAGE_COLLECTED_MIXIN macro, we'll hit a compile error.

This CL also fixes existing programming errors.

BUG=420515

Review URL: https://codereview.chromium.org/659953002

git-svn-id: svn://svn.chromium.org/blink/trunk@183799 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=126902
TEST=None

Review URL: https://codereview.chromium.org/637873006

git-svn-id: svn://svn.chromium.org/blink/trunk@183798 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,haraken
BUG=355467
NOTRY=true

Review URL: https://codereview.chromium.org/660723003

git-svn-id: svn://svn.chromium.org/blink/trunk@183797 bbb929c8-8fbe-4397-9dbb-9b2b20218538