- 26 Feb, 2018 40 commits
-
-
Kevin Marshall authored
Change-Id: I5858b7f7adf1b4fe8ed343a88132ae6a3af52f8f Reviewed-on: https://chromium-review.googlesource.com/937886Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#539208}
-
Mounir Lamouri authored
This CL works around the fact that cloning does not call the parser callbacks and the HTML specifications require the attribute to only have an effect when the element was created. There is unfortunately no notification that the element creation from `cloneNode()` happens so we instead rely on a callback meant for something slightly different. Bug: 811743 Change-Id: Ib7ac55088b9eaad23f9bce0cfc8366fec6fc5b0d Reviewed-on: https://chromium-review.googlesource.com/937504 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#539207}
-
Fredrik Söderquist authored
In preparation for passing/using an SVGResourceClient as the 'client', make sure the LayoutObject& is only used as a cache key by extracting and passing the object bounding box as a separate argument. Bug: 769774 Change-Id: I673ef74f2e65d645037a65d85e75846f37d3859b Reviewed-on: https://chromium-review.googlesource.com/931465Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#539206}
-
Matthew Jones authored
Previously onTabSwitcherTransitionFinished was only called when exiting the tab switcher. This change implements onOverviewModeFinishedShowing to call this method. BUG=710750 Change-Id: I1a34551a6cd93a54a9461441c25ce022144efa9e Reviewed-on: https://chromium-review.googlesource.com/929991Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#539205}
-
Bailey Berro authored
This change removes an extra callback.Run() call in SmbFileSystem unmount(). BUG=chromium:757625 Change-Id: Iedc3eeadc28a50aca4ef5ead763eb19eda52dc1f Reviewed-on: https://chromium-review.googlesource.com/934979Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#539204}
-
Nico Weber authored
linux-win_cross-rel: Reenable most tests now that v8_use_snapshot defaults to false in 64-bit win/cross builds. crashpad_unittests remain disabled because crashpad still doesn't work in cross builds. Depending on impact on cycle time, I might re-disable browser_tests. Bug: 495204 Change-Id: I1623a80f26c0ff5ee775417b8045f7d0b64e7560 Reviewed-on: https://chromium-review.googlesource.com/937685Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#539203}
-
John Abd-El-Malek authored
Add a check that network::URLLoader is only used by the browser process when network service is disabled. Bug: 814913 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7a3f7746491bdd2a6e65ea532af38147098a4c1a Reviewed-on: https://chromium-review.googlesource.com/936011Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#539202}
-
Morten Stenshorne authored
NG cannot always calculate the correct size of objects that are laid out by the legacy engine, so just lay them out if we need to know their size. The computed CSS width on a table may not end up as its used value, for instance. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iaa327ad21055d6c1af96241b5403193c8b4b5ba3 Reviewed-on: https://chromium-review.googlesource.com/937261Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#539201}
-
Raymond Toy authored
Move the DelayNode, DynamicsCompressorNode, and GainNode tests to WPT. Manually verified that Firefox passes these texts, except for the no-dezipper tests which use suspend() on an offline context. The tests that weren't moved are Chrome-specific. Bug: 745778 Change-Id: Iea2d31fd556d51ddcd63e9d139e53f05732261fe Reviewed-on: https://chromium-review.googlesource.com/922544Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#539200}
-
Chris Blume authored
The exact* same code shows up in RWHVA:: OnDeviceScaleFactorChanged() WasResized() InternalSetBounds() This patch refactors that code out to its own function. *There is one tiny difference, notifying the host of the resize or not. Bug: 814916 Change-Id: I9336d476a904930cd6a700ee0700d7685000c00c Reviewed-on: https://chromium-review.googlesource.com/932830 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#539199}
-
Theresa authored
The omnibox security icon and URL scheme weren't being updated correctly when loading an https page while another https load was still in progress. In addition to checking whether the security icon resource and http scheme emphasis has changed, we need to also check whether the location bar icon type has changed. BUG=816494 Change-Id: I18e01b329a475b44bea66d5b6568f015f3df1b03 Reviewed-on: https://chromium-review.googlesource.com/937656Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/534191e5068d..766143cf63df $ git log 534191e50..766143cf6 --date=short --no-merges --format='%ad %ae %s' 2018-02-26 charliea Use normal platform/arch strings in BattOr binary dependencies Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I58831a69dd32cd657241487a45c2d617b1496974 Reviewed-on: https://chromium-review.googlesource.com/937648Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539197}
-
Alexis Hetu authored
Currently, ImageTransportSurfaceOverlayMac uses system gl functions instead of using functions from Chromium's gl bindings. The cl modifies the included files in order to solve this issue. The key change removing "ui/base/cocoa/remote_layer_api.h" and adding "ui/gl/gl_bindings.h". R=ccameron@chromium.org Bug: 517208 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic9a55b31e896ab9636655d806ce11f9fa622f3ca Reviewed-on: https://chromium-review.googlesource.com/937652Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#539196}
-
Xi Cheng authored
This is a reland of issue 930368, which has a race condition with the following CL in the CQ: https://chromium.googlesource.com/chromium/src/+/6200d332518cd781f87ab86554bc71ff7a01ec4e%5E%21 This CL fixes the race condition by merging that CL. For chrome_switches.{h,cc}, this CL makes the following changes: 1) Remove function PowerOverlayEnabled() which is not used. 2) Remove function ExtensionsDisabled() which is not used. 3) Move ExtensionsDisabled(base::CommandLine) to chrome_extensions_browser_client.cc, which is the only call site. 4) Move them to lib "non_code_constants", as they don't contain any functions now. Now notification_helper can have a deps on lib "non_code_constants" rather than lib "constants", hence more lightweight. Bug: 734095 Change-Id: I2b5ca5ffa873537c8df21315cd0850b2433dbc4d Reviewed-on: https://chromium-review.googlesource.com/935826Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#539195}
-
Roman Sorokin authored
Fixes that setting the policy to incorrect JSON crashes Chrome. BUG=chromium:811338 TEST=DeviceSettingsProviderTest.SetWallpaperSettings Change-Id: I4f51c4b13975215ec486618c3609b895a39f9718 Reviewed-on: https://chromium-review.googlesource.com/934447 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#539194}
-
Morten Stenshorne authored
If a negative margin pulls a new formatting context block child back up to where there is an adjacent float, but the block is too wide to fit there beside it, make sure that we don't get pushed further down than just below the bottom edge of the float. Simply ignoring the top margin on the child might take us too far down. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I22de7205518dd3c08d56e4ca8d07e4ae062508fc Reviewed-on: https://chromium-review.googlesource.com/937503Reviewed-by:
-
Daniel Erat authored
Bug: none Change-Id: I801959a08e5b544e0738f7932a5a2c4622c484c0 Reviewed-on: https://chromium-review.googlesource.com/937813Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#539192}
-
Dominic Mazzoni authored
We weren't using GetInheritedStringAttribute consistently on all platforms for the language and font family attributes. In addition, one of the forms of GetInheritedStringAttribute was buggy. Remove it in favor of just one form. Finally, expose the language and font family in the whole subtree in Blink accessibility tests so that we can see it's working correctly. Change-Id: I30e281b0d874f291581dfb047255455f863b1e80 Reviewed-on: https://chromium-review.googlesource.com/936441Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#539191}
-
Peter Boström authored
Removes use_titlecase entries for bubble titles and reverts the corresponding prior test update. It's not a pure revert as "Password Saved" is removed as a title as well. Bug: chromium:810111 Change-Id: I1582ac05e859b8a53d19490b4ab52f47c03d7fe1 Reviewed-on: https://chromium-review.googlesource.com/932916Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#539190}
-
Michael Thiessen authored
Bug: 816535 Change-Id: I30d097081441a5ac496868e1154a8c52c634174c Reviewed-on: https://chromium-review.googlesource.com/937570Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#539189}
-
Martin Sramek authored
The HTML file presenting the UI is annotated with attributes marking which UI elements carry the consent description and confirmation. When the user consents, the text is retrieved and converted to GRD IDs which are then recorded. This is done for the old dialog, as well as the DICE one. Tests: - Unittest to verify that SyncConfirmationHandler translates the resource names to ConsentAuditor correctly - Browsertest to verify that the correct set of strings is passed from the DICe dialog - Tested manually for both DICe and the old dialog. See the design doc: https://docs.google.com/document/d/1Psl9VJ4Dbc1Dh5bXCTa85OF1_DE3viTTHYwybu3V6Uk/edit#heading=h.l9ok1t7qgp5p for more details. Bug: 781765 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id1ed846aa1151dc9f074f1299b54d814c21a6cc0 Reviewed-on: https://chromium-review.googlesource.com/897948 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#539188}
-
Eugene Ostroukhov authored
Introduces a search module with an extensible search view. R=dgozman, pfeldman Bug: 468416 Change-Id: I2fcb0d527d1e3ceab785712a234851a9274949af Reviewed-on: https://chromium-review.googlesource.com/929893 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#539187}
-
https://webrtc.googlesource.com/src.git/+log/151be2dffcc1..bd7b461f16b5 $ git log 151be2dff..bd7b461f1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4cbb6f6f9ab28fcb2b21c1be3b2c65f2f4d7447a Reviewed-on: https://chromium-review.googlesource.com/937647 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539186}
-
Jay Civelli authored
Now that service_manager::TestConnectorFactory supports multiple services, changes TestConfigurator to use it. Bug: 814372 Change-Id: I04647c81616d993b7c8486b83c2e84a4217b4f70 Reviewed-on: https://chromium-review.googlesource.com/929015 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#539185}
-
Daniel Bratell authored
There are local variables named next_id so having a global variable with that name triggers -Wshadow warning. This patch renames the global next_id -> g_next_indexed_db_connection_id. Change-Id: I31925418e69999ea789fef856058ab66125f60fa Reviewed-on: https://chromium-review.googlesource.com/937206 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#539184}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0f780f3c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12963 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure mlamouri@chromium.org: external/wpt/screen-orientation TBR=danyao No-Export: true Change-Id: Idcdf07a395c6fd2d085953ac51ef56a1462601ec Reviewed-on: https://chromium-review.googlesource.com/937562 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#539183}
-
Finnur Thorarinsson authored
This prevents a UaF in notification_helper, triggered by the fact that c_str() points to a deleted string when the ShellExecute call runs. TBR: robliao, chengx Bug: 734095 Change-Id: I17437368254fb138d1a3fe5db432dba86e30c161 Reviewed-on: https://chromium-review.googlesource.com/937702Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#539182}
-
https://skia.googlesource.com/skia.git/+log/904b08cf1fc0..84d823a5e2a0 $ git log 904b08cf1..84d823a5e --date=short --no-merges --format='%ad %ae %s' 2018-02-26 robertphillips Revert "Separate creation time & flush time behavior in GrDrawOpAtlas (take 2)" 2018-02-26 liyuqian Revert "Do not return null paint if shaderFP is null" 2018-02-23 egdaniel Send correct clear count to vulkan beginRenderPass 2018-02-26 mtklein Revert -isystem related CLs. 2018-02-23 robertphillips Separate creation time & flush time behavior in GrDrawOpAtlas (take 2) 2018-02-26 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 4cbf9f959..0d1aefed6 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I009f2c14f3e5e5146ca9ff210ba25e14cb9a545d Reviewed-on: https://chromium-review.googlesource.com/937650Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539181}
-
ckitagawa authored
This CL makes the new Zucchini patcher available (alongside Courgette), for diff generation experiments on Chrome release infra. Note that this does NOT ship Zucchini. This change was originally part of https://chromium-review.googlesource.com/916553 Bug: 729154 Change-Id: I110da42dfa1c3ba05785a545cdd99fa5613caeea Reviewed-on: https://chromium-review.googlesource.com/937396Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Cr-Commit-Position: refs/heads/master@{#539180}
-
Christopher Grant authored
BUG= R=mthiesse Change-Id: I8c33393c152c7e092d494b8368e956fb2059c7b4 Reviewed-on: https://chromium-review.googlesource.com/937642 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#539179}
-
Scott Violet authored
Prior to this patch Ash pushes a new cursor to the Window Service on every cursor move. The cursor is pushed in such a way that the Window Service thinks its a new cursor, which results in the Window Service pushing the cursor to hardware. This is slow on some devices. This patch avoids this by only pushing the cursor to the Window Service when it changes. BUG=none TEST=none Change-Id: I179ca2c521b75856142d29592bde7307939b8947 Reviewed-on: https://chromium-review.googlesource.com/935783 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#539178}
-
Quinten Yearsley authored
There are around 1200 tests that need to be rebaselined for Mac10.13 This is an initial CL which just rebaselines a couple hundred of these tests (the ones that appear first alphabetically, mostly in compositing/ and css*/. What I did for this CL was: 1. Add "Chromium Mac 10.13" to webkitpy/common/config/builders.json 2. Commit. 3. `webkit-patch rebaseline {list of tests}` 4. Revert builders.json change and commit. Bug: 774301 Change-Id: I6033f04d62ffebf5526c036665100fa2d1e6231e Reviewed-on: https://chromium-review.googlesource.com/929008Reviewed-by:Robert Ma <robertma@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#539177}
-
Rouslan Solomakhin authored
Before this patch, a modifier without a total field would crash on desktop. This patch adds a check for presence of the total field in the modifier before dereferencing it. If the modifier total is absent, then the global total is used. After this patch, a modifier without a total field results in the global total being used without a crash. Bug: 814968 Change-Id: I1f946ed4526b948b2836e2144e3bdb2e7c167321 Reviewed-on: https://chromium-review.googlesource.com/935426Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#539176}
-
Jan Krcal authored
Bug: none Change-Id: I5b6b87f8f93f36075de26a67eb2e103425c5d030 Reviewed-on: https://chromium-review.googlesource.com/937464Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#539175}
-
Alessio Bazzica authored
This CL adds part of the rnnoise library in 3rd party. What is retained are pretrained parameters and a few functions implementing a recurrent neural network. Change-Id: I66c55958d13b7f120aa508f6d7afd7f13f59f659 Reviewed-on: https://chromium-review.googlesource.com/931553Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#539174}
-
Bo authored
This reverts commit 69ac9fe8. Reason for revert: Caused crbug.com/816538, which is a crash causing test flakes. Bug: 816538 Original change's description: > Enable mojo based synchronous compositor > > Turn off disabling mojo input messages for webview. That will enable > the mojo input channel and the mojo synchronous compositor input channel. > > BUG=722928 > > Change-Id: I14ae3d3a83405eb9c6a228f7f08171dab3ca86f2 > Reviewed-on: https://chromium-review.googlesource.com/898553 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539127} TBR=boliu@chromium.org,dtapuska@chromium.org Change-Id: Ic0b24d2fb2d68366f9ce5a7a25daab06ef387c7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 722928 Reviewed-on: https://chromium-review.googlesource.com/937781Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539173}
-
Philip Rogers authored
Remove leviw and jchaffraix from WATCHLIST as they are no longer actively watching for changes. Change-Id: I8ac59b451551566519c1cc559920c4052097f51e Reviewed-on: https://chromium-review.googlesource.com/929781Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539172}
-
Anita Woodruff authored
- Display() Part 2: Write notification data to database; use a real notification ID. - Note this is still behind the NotificationsWithMojo flag while development continues. Bug: 796991 Change-Id: I61d146b8f675c5e82fc7b3ea5e7782a3229f9a7c Reviewed-on: https://chromium-review.googlesource.com/925461 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
-
Joe Downing authored
This CL introduces a Windows implementation of the KeyboardHook class as well as a simple integration with the low-level window classes used in Aura for Windows. Changes to WindowTreeHostPlatform / PlatformWindow will be made in a separate CL. I will send out that change once the method names and platform hook scope questions have been answered. The next CL will build on this work in the content layer: https://chromium-review.googlesource.com/c/chromium/src/+/905507 BUG=680809 Change-Id: I8d35c895d80a58c64ff5b2bc119d5ee340790050 Reviewed-on: https://chromium-review.googlesource.com/900344 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
-
kylechar authored
This CL moves test classes from cc/test to components/viz/test. The main classes being moved are implementations of viz types and belong in components/viz/test. 1. FakeOutputSurface 2. TestContextProvider 3. TestContextSupport There are a number of ancillary classes that also need to be moved. These classes are test implementations of gpu types. The dependency structure, where cc:test_support depends on components/viz/test, requires the classes be moved also. It's likely the base gpu types will eventually be moved to components/viz/service/gpu in the future. 1. OrderedTextureMap 2. TestGLES2Interface 3. TestTexture 4. TestWebGraphicsContext3D Bug: 814475 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic1fdb0262b222b6cf6054621ef8647f63ee26bcd Reviewed-on: https://chromium-review.googlesource.com/934624 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#539169}
-
