- 07 Oct, 2019 40 commits
-
-
Rune Lillesveen authored
This ParentOrShadowHostNode() -> GetStyleRecalcParent() change was missing in [1]. Caused many test failures with FlatTreeStyleRecalc enabled. [1] https://crrevs.com/d7eefe3ee4e1b35b57faf3060bed03ca2b1f73c3 Bug: 972752 Change-Id: Ife9858e7ab36f6dfbca0a423ffef953fedd6ffba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841452Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#703286}
-
Rune Lillesveen authored
Document node is not marked with ChildNeedsStyleRecalc when FlatTreeStyleRecalc is enabled. Test StyleEngine::NeedsStyleRecalc instead. Bug: 972752 Change-Id: I9d3276c76d74d7e1c9f44bbc1a30dff318aebce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841954Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/939454821c49..3eafc49228d0 git log 939454821c49..3eafc49228d0 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 perezju@chromium.org [Telemetry] Confirm startup tracing on establishing DevTools conection Created with: gclient setdep -r src/third_party/catapult@3eafc49228d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:914092 Change-Id: I98532ef0927d7c232b9370ba448e7e601c1b31ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703284}
-
Vadym Doroshenko authored
For detecting success of the form submission detection, Password Manager checks whether there is a form similar to the submitted form after navigation. One of the criterion of similarity is to check actions. There is checking with respect to http <-> https. It was introduced to fix only one site, which currently doesn't need this. So it's better to keep things simple and to compare actions on exact match. Bug: 949519, 400769 Change-Id: I65aaba98aa87a4ad8b0d1e171112817fa3f12f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834083 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#703283}
-
Dave Tapuska authored
We've decided to move away from RevocableInterfacePtr and just use the remote interface directly. BUG=978694 Change-Id: I2dbc293b8c89f7a2cb7ed8067d0879f4d5deaba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842275Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#703282}
-
Alexander Timin authored
Do not cache abusive pages as we are not running checks when navigating to the cached pages and therefore would lose information whether the page was abusive or not. Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 R=csharrison@chromium.org CC=bfcache-bugs@chromium.org BUG=1001087 Change-Id: I3c61cd9a4c96818070eb4a0047e344a83fb8bd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833974 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#703281}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44a55afebe67..27399bbb1d0e Created with: gclient setdep -r src-internal@27399bbb1d0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8b4f3333d58e09c807f596fde53b1f0ae67a0c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844054Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703280}
-
Rune Lillesveen authored
This is mostly about moving code from Document into StyleEngine. The other change is relying on the StyleTraversalRoots for deciding if we need to do style invalidation, recalc, or layout tree rebuilding instead of the dirty flags on the Document or documentElement(). It is a simpler way of doing the check since we are no longer marking the Document with ChildNeedsReattachLayoutTree() and we will not mark the Document with ChildNeedsStyleRecalc() when FlatTreeStyleRecalc is enabled. Bug: 972752 Change-Id: I68a5dd1ffaa4f4f844a7641c143c301ce7417687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840832Reviewed-by:
-
Alexander Timin authored
Add BackForwardCacheTestHelper class, which can check whether a particular frame was disabled for a given reason. R=clamy@chromium.org,arthursonzogni@chromium.org TBR=crharrison@chromium.org CC=lowell@chromium.org,hajimehoshi@chromium.org,sreejakshetty@chromium.org,carlscab@google.com BUG=1001087 Change-Id: I4e5b3649e412e3e4a6c97b572597958b02f1382e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833603 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#703278}
-
Keishi Hattori authored
Change all GCs in internals-observe-gc.html to precise GC in an attempt to fix the failures on Win7 bot. Bug: 1011714 Change-Id: Ie9c101b01b3ca28dc87c927ddc2cf73eec1b991e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844525Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#703277}
-
Marc Treib authored
It's very flaky. Bug: 1004312 Change-Id: Ieb13eb3860e0003451beeeed57f882845d9c2769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844997 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#703276}
-
BUG=762641 TBR=achuith@chromium.org Change-Id: I0a4bd95e290a4a4d16c5d7354334019a3460105a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844344Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703275}
-
Ulan Degenbaev authored
This enables the reportedByPageMetric for system health and v8 browsing benchmarks. Bug: 1007178 Change-Id: I1ba85f6984c7a3db257595c369d13759d3180f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831808Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703274}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/23d6a0e668bf..e94f473753be git log 23d6a0e668bf..e94f473753be --date=short --no-merges --format='%ad %ae %s' 2019-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 8fa0f1a6567c..c18c9ff6bc30 (2 commits) Created with: gclient setdep -r src/third_party/angle@e94f473753be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: I5321d6ef84b4992c5660442fe462c343792df885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843778Reviewed-by:
-
Christoph Schwering authored
Bug: 1007974 Change-Id: I26357ca5b4d6cde425b2bd16315e63d72db6d3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844972 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#703272}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6413c178..21d05ebc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I523e4b16feba1ab1528734254c97ee0aca213b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844033Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703271}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df2a8385c33d..f4389a6ddae5 git log df2a8385c33d..f4389a6ddae5 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 ilkos@google.com Add statsd subscription id to metadata Created with: gclient setdep -r src/third_party/perfetto@f4389a6ddae5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I8c4899f8fe237e4feac2b8b8eeeb44985ad740bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843777Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 67be65ef. With Chromium commits locally applied on WPT: c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bajones@chromium.org: external/wpt/gamepad NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3538dc73f6893824c24d644d95cc7aaa5ccec927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844394Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703269}
-
Juan Antonio Navarro Perez authored
This prevents the size of the output csv from growing without bounds. The limit on the input that DataStudio can take seems to be around 100 MiB. Change-Id: Ib4656fe066686931135e2280e042fc832f1bb520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844974 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#703268}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in services/resource_coordinator to the recommended methods/types. Bug: 1007831 Change-Id: I85e6a627d8b65feffb9a0d95a0c9620e343f9062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840635 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#703267}
-
Javier Ernesto Flores Robles authored
Bug: 1008862 Change-Id: Ibbf2b068977cbaf34481f11faac85c3af830bd84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836502 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#703266}
-
Boris Sazonov authored
Changes layout to match mocks. Screenshot: https://crbug.com/1009331#c6. Bug: 957532, 1009331 Change-Id: If35ec176ca278c6c4c0aeb83f281202fe76b8b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841337 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#703265}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c59193cb7ce..44a55afebe67 Created with: gclient setdep -r src-internal@44a55afebe67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib3ca54a810749f2be18c20d600a1bddc785bccc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844360Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ddbd321fd7d7..939454821c49 git log ddbd321fd7d7..939454821c49 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 rmhasan@google.com Revert "[Telemetry] Remove --verbose option and Popen hook" 2019-10-07 rmhasan@google.com [typ] Add optional file manager arugment to Artifacts constructor 2019-10-04 khokhlov@google.com [Telemetry] Remove --verbose option and Popen hook Created with: gclient setdep -r src/third_party/catapult@939454821c49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:985712,chromium:982208,chromium:985712 Change-Id: I237c5d466adb3e4cbaae65839fda056390f5cc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844342Reviewed-by:
-
Ulan Degenbaev authored
This adds IDL files and an experimental feature flag for the API. The implementation simply forwards to v8::Isolate::MeasureMemory. Bug: 973627 Change-Id: I80ac8b78e81a6fad6b25370b419a0392f6589cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796364Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: Iebfc438ca750766748023d2ea2acfc59c3fb2803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842960 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703261}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I02d90db13767179c8286e9febf4fbdfa459824ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844343Reviewed-by:
-
arthursonzogni authored
There is a weird code: ~~~ if (!find_in_page_ || !find_in_page_.is_bound() || !find_in_page_.is_connected()) GetRemoteAssociatedInterfaces()->GetInterface(&find_in_page_); ~~~ The functions: AssociatedRemote::(operator bool) AssociatedRemote::is_bound() are the same. So there is no need call both. Moreover, using AssociatedRemote::is_connected() here is risky. It means it can call GetInterface on an already bound AssociatedRemote, which will trigger a DCHECK. I can reproduce this depending on race conditions. To make things correct and simpler here, we just reproduce the same pattern used by the other AssociatedRemote stored in the RenderFrameHostImpl. Change-Id: I81507242853691de6ff4ee75f54e6911983e3f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841471Reviewed-by:Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#703259}
-
Benedikt Meurer authored
Previously background parsing and compilation was always labeled "Parse Script" whereas foreground parsing and compilation was always labeled "Compile Script". But in either case the engine might parse and/or compile, so we should be consistent here. Also for developers it doesn't really matter whether V8 is parsing or compiling to bytecode. Bug: chromium:940958 Change-Id: I320095e10613d7cc1405069345e0dd0613a7130a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844993Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#703258}
-
Huanzhong Huang authored
Introduce a toggle in the incognito ntp that links to cookie controls setting. Layout should be fixed in a subsequent cl. Bug: 967668 Change-Id: Icedcae6575ae84b1ed6ef2feb353e0f0ae1b37c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826900 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#703257}
-
Roman Sorokin authored
Also removed paddings overrides from the sync consent screen and fingerpring setup screen. Bug: 1009531, 1000606, 1011284 Change-Id: I1b22cd2619691d628feb5a5bb084105ee41a4d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844952 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#703256}
-
Mathias Bynens authored
Explicitly passing `'no-preference'` as a CSS media feature value has different semantics than passing the empty string (which clears the emulation override), causing difficult-to-debug issues. Bug: chromium:1011722, chromium:1004246 Change-Id: I371681ba646306d4f5e8bff10e8c502329a87093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844816Reviewed-by:
-
Mikel Astiz authored
This reverts commit c305a2ba. Reason for revert: DCHECK failures observed on ios. Original change's description: > Send variation headers to sync server > > This information is already sent to other servers such as the one used > for omnibox personalization, hence the patch doesn't upload additional > information but allows measuring the impact variations have on the sync > server and debug errors caused by client-side experiments. > > Bug: 887521 > Change-Id: I3358956639bf96260bb5010279012195086eec37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827368 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700678} TBR=mpearson@chromium.org,treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 887521, 1011088 Change-Id: I07fb576d156cf9efd334ce89617e9a823db61662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844814Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#703254}
-
Edward Jung authored
will-change property causes the page background not to respond to the background colour change. The CL scopes that property away from iOS devices. Bug: 1008776 Change-Id: I4bc2bd8fde0e9f60389be8be55108ad77b8bf8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834228Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#703253}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01fdeab2a3a2..df2a8385c33d git log 01fdeab2a3a2..df2a8385c33d --date=short --no-merges --format='%ad %ae %s' 2019-10-06 ilkos@google.com Scrape real uid at onPids Created with: gclient setdep -r src/third_party/perfetto@df2a8385c33d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:141914164 Change-Id: I6590b88a1a3928b3b5aa2250efcab01e23472ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844361Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/523df09a..6413c178 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I63d7e5e45af42089f5068280e42ba029a5856590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844555Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 1834141 Change-Id: I67f95f6ffd9f35b8197b0cb9c8021eaaa62aa1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834147 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 181fcf74. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" 69c11064 "[WPT/upgrade-insecure-requests] Regenerate files" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I73071fffd365d907f534a7ef984340c13235819a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844393Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5e9d4ee99ea1..23d6a0e668bf git log 5e9d4ee99ea1..23d6a0e668bf --date=short --no-merges --format='%ad %ae %s' 2019-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 135e3e35ea87..4b97a1108114 (1 commits) Created with: gclient setdep -r src/third_party/angle@23d6a0e668bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: I25840131d002ef731947ea2e8708df06f3050f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844233Reviewed-by:
-
Mario Sanchez Prada authored
This file was out-of-sync after recent migrations, let's fix it. Bug: 955171, 978694 Change-Id: Id6a85b66c50cd36d64bf9b4d8e1c04860959a48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844973Reviewed-by:
-
