- 04 Dec, 2020 40 commits
-
-
Andrew Grieve authored
Tested that all targets now build via: autoninja -C out/Release $(build/android/list_java_targets.py --proguard-enabled) Bug: 1155547 Change-Id: Ie32d62e108778c219a190e363be9c82b747a2a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574597 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833824}
-
Ken Buchanan authored
Some callback aliases were missed when I was taking out the BLE authenticator code earlier this year. This removes them. Change-Id: Ic69352e4fde6892821e9076f111d030299e9451f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575156Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#833823}
-
Sorin Jianu authored
Change-Id: Ie468abd468d88cca3f6eb01855f1033718545b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575319Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833822}
-
Juan Mojica authored
This change adds the intent parameters data class as well as API methods into LensController for starting the AGSA connection early and launching the intent via the Lens SDK. Bug: 1098431 Change-Id: I5e9d1777e352c246bf93372d6e7fe2d2b22c78f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551424Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Juan Mojica <juanmojica@google.com> Cr-Commit-Position: refs/heads/master@{#833821}
-
Ben Pastene authored
This reverts commit 00437792. Reason for revert: suspect to be causing apps.LaunchGallery failures on CrOS https://bugs.chromium.org/p/chromium/issues/detail?id=1155028#c21 Original change's description: > [FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle. > > This isn't directly using net::IsSafePortablePathComponent since what > is safe for the File System Access API is not the same as what is safe > for Downloads. As such currently this duplicates a lot of the > implementation of this method, but in a followup we should attempt to > unify these two implementations as much as possible. > > Bug: 1150810, 1154757 > Change-Id: Iba4c92ef5f1cd924aa22b9dd201762d48b4bbc3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568383 > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833042} TBR=mek@chromium.org,pwnall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1150810 Bug: 1154757 Bug: 1155028 Change-Id: I6c0fb2af7096d4f7f47d3e17a40c5a69105808cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574931Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833820}
-
Toby Huang authored
This CL fixes the CachedMetricsProfile and DemographicMetricsProvider for ChromeOS Ash. It introduces a profile selection strategy for CachedMetricsProfile and skips the number of profiles on disk check in DemographicMetricsProvider for ChromeOS Ash. Bug: 1145655 Change-Id: I3cf69673e428cc7ff81e4d1e5f1650a6d96bdcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527521Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Vincent Boisselle <vincb@google.com> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833819}
-
Egor Pasko authored
In http://crrev.com/833775 a command line flag was renamed in list_java_targets.py. Update generate_gradle.py accordingly. Bug: None Change-Id: I91c85063f5eb1ae442731536103492c2fe15ff7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575018 Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833818}
-
Andrew Grieve authored
We couldn't do this when increment_install was not a GN arg, but it's easy to do now that it is :). Bug: None Change-Id: I42c243fa530e448158405bf4157016f578f319ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573011 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833817}
-
Rouslan Solomakhin authored
This patch checks the result of WebContents::FromRenderFrameHost() for null to avoid crashing. Bug: 1064628 Change-Id: Ib755a014e72e2428e8343aa2aac2b3b707c484ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572908Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833816}
-
David Tseng authored
Previously, chrome.accessibilityPrivate.enableChromeVoxMouseEvents only sent mouse events through the accessibility -> chrome.automation layer only when ChromeVox was enabled. Make it so that we also send (when requested) to the accessibility common extension when magnifier is enabled. R=josiahk@chromium.org Test: browser_tests --gtest_filter=*Spoken*.SpeakingTextUnderMouseForShelfItem* for ChromeVox. Magnifier tests tbd when it gets used for upcoming features. Change-Id: If620e69d3d7a0d0480afac412ae9c4d52b8cfba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572797 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833815}
-
rajendrant authored
Change-Id: I59d9725499dfabe490411391350f5050ebe326c8 Bug: 1152527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574258 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#833814}
-
Joon Ahn authored
Screen: http://screen/BhQEsVaDzMLxAEj Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp#000933fc-29e1-4d4b-aa49-9d1b8fb16a24 Bug: 1125150 Test: browser_test --gtest_filter=Diagnostics* Change-Id: Ic52a8249e29e17ce703a1acc91d1e8280db93073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572790Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#833813}
-
Chris Thompson authored
Support for the enterprise bypass of the TLS 1.0/1.1 removal will be removed in May 2021. This adds a notice to the policy page to clarify this. The sunsetting of this bypass has been previously announced in https://www.chromestatus.com/feature/5759116003770368, https://security.googleblog.com/2018/10/modernizing-transport-security.html (in 2018), and https://blog.chromium.org/2019/10/chrome-ui-for-deprecating-legacy-tls.html (in 2019). Bug: 896013 Change-Id: Ib0cb2ba9bc8a925a1a8bfd3ee17995ae0a23bd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569811 Commit-Queue: Chris Thompson <cthomp@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#833812}
-
John Abd-El-Malek authored
Add NavigationCallback.onFirstContentfulPaint variant that matches up to CCT's version for easier comparison. Bug: 1152600 Change-Id: I3025464676ecb2cc649e445701cdc5797e4d068d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559285Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#833811}
-
Elaine Chien authored
Bug: 1145666 Change-Id: I452ba10bb5fab5cada0aa072d9c33f0ae79bab37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567985 Commit-Queue: Elaine Chien <elainechien@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#833810}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fa8d6915cbbf..db873dd600c3 2020-12-04 reed@google.com add util for checker image 2020-12-04 reed@google.com Reland "Remove some flutter flags" 2020-12-04 johnstiles@google.com Code cleanup: fix case of member functions. 2020-12-04 johnstiles@google.com Disallow identifier names that overlap existing types. 2020-12-04 mtklein@google.com don't parse svgs we won't run 2020-12-04 reed@google.com Revert "Remove some flutter flags" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I72e9e5993d5f8092f87fe137d948ebb63c3d1753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575099Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833809}
-
Karandeep Bhatia authored
BUG=1043200 Change-Id: Idec165bcfb959b75d789315703c69151cc6434b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551320 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833808}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I82b7c6bfe236eb122ca642e0141e75c9097706fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574599Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#833807}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/12b95e78a4d5..b9d9529da93a 2020-12-04 jophba@chromium.org Add RBE-CAS instance names to buildbucket If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I150c2969c5d97535c39bccf97907b9c55def5ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833806}
-
Wez authored
Bug: 1071393 Bug: b/154204041 Test: web_engine_unittests Change-Id: I3ba86964279ef7f467506d0781bee1e75b169a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571699 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833805}
-
Jimmy Gong authored
CanRequestNewDndState indicates whether or not the DoNotDisturb feature should be enabled for the Phone Hub UI. Bug: 1155244 Test: chromeos_components_unittest Change-Id: Ief42e2f3cefdcb2aa4a74b5e41a5f7329ae330c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572958 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#833804}
-
Yifan Luo authored
Bug: 1116418 Change-Id: Icecc7124ce0f8e448a5ae95037eb3a3adfe7af2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575296Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#833803}
-
Phu Le authored
Currently today OpenXR event pump does not have a callback to the render loop and instead setting a state for session end and relies on the next frame to check that state. This is not reliable as most of the time, the frame pump stops after sessions ends and the state logic has race condition inside that changes as the code churns. This change add an explicit callback to notify the end of a XR session so that the render loop can reliably trigger the blink callback on session's end. Bug: 1148648 Change-Id: I5447b0d053bbc1d575c9b509edc0ca5d6f76bca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535852 Commit-Queue: Phu Le <phle@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#833802}
-
Erik Chen authored
This reverts commit 8d4df26b. Reason for revert: Reverting for now -- this enables Finch configs for Lacros -- which in turn will turn on Vulkan backend for Skia, which can (sometimes) crash Lacros on launch. Original change's description: > Set "dev" channel for all lacros builds. > > Linux-chrome (of which lacros is a variant) has its channel set as a > runtime environment variable by the launcher script. For Lacros, we must > set the environment variable from ash. For now, we always set "dev" for > all builds of Lacros. > > Change-Id: I840286b6fd5772701c3f6d927986405697b82097 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570448 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833460} TBR=jamescook@chromium.org,erikchen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I25d3d72d27571645ef9b1723e624e75859579d8b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574803Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833801}
-
Alan Screen authored
TestPrintBackend was reworked to include a more consistent behavior across its interfaces. With this in place we can now update the testing for print backend service to use AddValidPrinter() that ensures valid printer definitions. This allows the GetDefaultPrinterName test to be re-enabled and prepares for further updates related to printer capabilities. Bug: 809738 Change-Id: Iedf2d219da40cb508b6778f70889e86cccfb0052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538365Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833800}
-
Stepan Khapugin authored
Exposes necessary tail suggest fields of an autocomplete match, wrapped in Foundation types. Bug: none Change-Id: Ia8a8a1e69befc3a8e510dfa196deda1544b9290e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571876 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833799}
-
Gang Wu authored
Bug: 1155430 Change-Id: I5e323b8ecfdcdfbbbd9c98f575c864e17ff62d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574078Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833798}
-
Tommy Li authored
Previously, we were using "key1", "key2", etc. as the GUIDs for our test engines. This was confusing, because "key1", etc. was also used for the keywords to our test engines. For clarity, we've changed all GUIDs of the form "key1" to "guid1", and added a DCHECK to warn developers not to do it again. No functional changes here, just a simple rename of constants in our test files. Bug: 1022775 Change-Id: I776feb17190942fc23e4c5a5d669bc0dbfec537b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573339 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#833797}
-
Sergey Ulanov authored
This reverts commit 4c19ca70. Reason for revert: Broke NTP tests on MSan bots, see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/26482/test-results?expected=false&exonerated=true&flaky=true Original change's description: > [NTP][RQ] Adds field trial testing config for repeatable queries > > This is in preparation to promote the canary experiment which > originally landed in cl/339288320 to Beta. > > Fixed: 1155314 > Change-Id: I4b87b89736e4cb461d416aacef98ed888596568c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573130 > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Weilun Shi <sweilun@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833576} TBR=mahmadi@chromium.org,sweilun@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I2f53745425e4df57bae943cbd3a4ab3c23de8cda No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575340Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833796}
-
Muhammad Hasan Khan authored
There are multiple reasons for which we show same message in case of sign-in and check-in failure so we're adding an error code on the UI to help distinguish the underlying reasons. BUG=b:166322619 TEST=deploy to DUT, force the sign-in failure, verify message is shown Change-Id: If8e758d02777c3aaa5ced74ac44eaa54dee8a59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569988 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#833795}
-
David Maunder authored
Apply batching to CriticalPersistedTabData tests so that they run faster. Bug: 1152295 Change-Id: I655e4ffe2f79a8549311b32a1f7ff760f3dda34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556453Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#833794}
-
Egor Pasko authored
The test creates a fake RELRO region in private memory and checks that it is spawned into a sealed read-only shared memory region. Since the normal way of using the ModernLinker involves a separate DSO (=shared library), this would add more moving parts to base_unittests. We prefer less advanced ways with GN, so another approach is chosen: all the necessary code is linked with base_unittests. Testing the way ModernLinker loads libraries would be difficult without extra libraries pushed to the device, but RELRO region creation, sharing and consumption can be tested using this approach. Bug: 1154224 Change-Id: Ia78cce98f566084f6f799a7a35ab3cc45beb9346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571758Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#833793}
-
Ben Wagner authored
This is a followup to https://chromium-review.googlesource.com/c/chromium/src/+/2566935/5#message-8b391d170d115a9b89c0a985ab0a8a42a208695b Change-Id: I3c63a4792d26206a9cb91136ce9da72edcb1b70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573038 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833792}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607061555-9d7880873554417bd44ed300f865acac635c5256.profdata to chrome-win64-master-1607070900-a3f370d99263588b261e824540349b020ef94941.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie8b00905ee134164d074ad60ecb6988916cb5c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574422Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833791}
-
Shu-yu Guo authored
When top-level await is enabled, all module script evaluation is expected to return a Promise. This CL changes ValueWrapperSyntheticModuleScripts (CSS and JSON) to return a Promise that's resolved to undefined. Bug: v8:1154497 Change-Id: I92114d42f0080918e9e61bf1b62d5eda4cffdabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568823 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#833790}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1ad5791d97be..51a0e95d78eb 2020-12-04 ianelliott@google.com Revert "Suppress memory leaks detected by LSAN" 2020-12-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 524e5bcfba33 to 41331850eb21 (39 revisions) 2020-12-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d76e39a7 to 78187c02 (806 revisions) 2020-12-04 sugoi@google.com Suppress memory leaks detected by LSAN If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:972686 Tbr: ianelliott@google.com Change-Id: I512c7d239bc2eb8860eea0bcd8421c205342193b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574721Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833789}
-
Charlie Hu authored
This CL renames 'feature policy' to 'permissions policy' in console messages. Bug: 1123116 Change-Id: Ia7a526e44ccc1d0eb3109f2fb86b12ad7ba2daec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513824Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#833788}
-
Toni Barzic authored
This is a reland of 2a07cc57 Original change's description: > Shutdown holding space delegates while device is suspended > > Some file systems are unmounted during device suspend (for example drive > FS), which was causing the holding space file system delegate's file > path removal detection to remove them from the holding space on device > suspend. To avoid this issue, holding space keyed service now observes > device suspend status and shuts down holding space delegates when the > device suspends. The delegates are re-initialized when suspend ends, > restoring the model from persistence again. > > BUG=1152924 > > Change-Id: Iffe4586bcb87f47d687ceeff0fc76e60a443c0d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568355 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#833515} Bug: 1152924 Change-Id: I4ef1fa83d684260e4ebf66fe4c01e9627e5c46af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573893Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833787}
-
Findit authored
This reverts commit 5326cda9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 833751 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzUzMjZjZGE5NmNhOTdlN2ZiMDdlYTBhMzNkODUyN2RmYmRkZmJiNWYM Sample Failed Build: https://ci.chromium.org/b/8861821025876153104 Sample Failed Step: compile Original change's description: > Patch in Fix For Protobuf Deserialization Bug > > This CL picks up a bugfix integrated into protobuf as part of commit: > http://cl/342360226 > > This fix is responsible for fixing a bug in the serialization code > when trying serialize/deserialize protobuf messages at the end of an > iostream > > Change-Id: I7608174a083b6b63c152c1250d3ccd1fd53914c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535667 > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Commit-Queue: Ryan Keane <rwkeane@google.com> > Cr-Commit-Position: refs/heads/master@{#833751} Change-Id: If9e7cb5da756a985bfc53fe03be0632e3cdbdef1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575436 Cr-Commit-Position: refs/heads/master@{#833786}
-
Ana Salazar authored
In the Holding Space's Screen Capture section, we display screenshots and screen recordings. At the moment, both previews display as still images. In order to differentiate between screenshots and screen recordings, we add a play icon over the screen recordings. Screenshot: https://screenshot.googleplex.com/9YVVkvvyAk7Duds Bug: 1144927 Change-Id: Id1614a867caa73676d24c9ab59289337fea88c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566051 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833785}
-