- 20 May, 2020 16 commits
-
-
Theresa Wellington authored
Add a new histogram that records 'true' if there is a device owner app installed, which indicates that the device is fully managed/corporate-owned. BUG=1084538 Change-Id: Ia171287b566794121bc5008ffb6d5717952d4ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208538 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#770380}
-
John Lee authored
Bug: 1000989 Change-Id: I965f1a0ebc3cffca8a66043e90540cc3740e41c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209277Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770379}
-
Clark DuVall authored
getNavigationEntryDisplayUri() says it throws an IndexOutOfBoundsException, but it wasn't actually doing it. Change-Id: I77827cfc71e061feec7663ec4e0e1413c999c43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209567Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770378}
-
Kyle Horimoto authored
We still have some polish work to go, but we should be ready for more feedback now that we've addressed all of the obvious bugs. Change-Id: I52997f9acf6426f39eb7227aebad4d371f00bf5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208025 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770377}
-
Reilly Grant authored
According to hang reports this function performs an RPC call which may take some time to complete. Mark calls with a base::ScopedBlockingCall so that the thread pool knows this task may be busy for a while. Bug: 637404 Change-Id: Ibf15e9b6d7ca59453a40c1282622e9a2b0f11460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209387 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#770376}
-
Virender Singh authored
|cr-icon-button| contains icons, represented by |iron-icon| polymer controls. The icons appear in the accessibility tree of the |cr-icon-button|. The tree looks like this |BUTTON name=Download| - |IRON-ICON| - |SVG/IMG name=''| |BUTTON name=Print| - |IRON-ICON| - |SVG/IMG name=''| As child <svg>/<img> are not interactable and lack name property, it makes sense to remove the svg and image children of |iron-icon| from a11y tree. This change explicitly marks the <svg> and <img> children of |iron-icon| inaccessible by adding aria role as none. Bug:1069531 Change-Id: Idcd7912c865ce08e8871d416b30959ab64ae3d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143183 Commit-Queue: Virender Singh <virens@microsoft.com> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#770375}
-
Erik Jensen authored
Bug: 1084669 Change-Id: I77ca302c8310d2705aec14241c961d8ae2ac9bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209349Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#770374}
-
Findit authored
This reverts commit 8cff2cd0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 770361 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzhjZmYyY2QwYzM1ZWZmZDU2OGUwZGI5OTUwODNhODg4M2JjNmI5NWQM Sample Failed Build: https://ci.chromium.org/b/8879828535463664672 Sample Failed Step: compile Original change's description: > vulkan: enable the possibility of using vulkan c++ binding > > The vulkan.hpp is included in the upstream Khronos vulkan headers > package. It is a vulkan c++ binding generated from vulkan registry. > It is implemented with c++ template in a single header file. > > This change updates gpu::VulkanFunctionPointers to make it compatible > with vulkan.hpp, and adds vulkan_cxx.h which setups several necessary > macros before including <vulkan/vulkan.hpp>. So any code wants to use > vulkan c++ binding just needs to include vulkan_cxx.h. > > This change also adds a test for the vulkan c++ binding. > > Change-Id: I74c7003008082686984b559c729bdecac1b08efd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198140 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770361} Change-Id: Ia0653585ec07d6a36fc55515fdede36dce478c45 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209308 Cr-Commit-Position: refs/heads/master@{#770373}
-
Mason Freed authored
This is part of a multi-CL set that will move all "Web Components v0 only" tests into a separate folder. This will make landing the eventual removal of WCv0 easier, because this entire folder can simply be skipped rather than requiring file-by-file changes. There should not be any tests in this folder that are needed for testing Web Components VERSION 1 features. While this CL does not change any behavior or testing now, care should be taken in reviewing the list of tests, since when WCv0 is removed, all of these tests will be deleted. So any tests being moved here that are required for testing a non-WCv0 feature should *not* be included in this move. This set should only include tests of the (Shadow DOM v0 specific) <content> element. Bug: 937746 Change-Id: I60d0d1df2ff3b35572f0af7c7bbad6213a47a05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209247 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#770372}
-
Anders Hartvoll Ruud authored
Not really part of the MatchedPropertiesCache project, but we are obviously missing a clear() call for the matched_properties_types vector. It looks to me like this could potentially cause non- deterministic crashes in case of hash collisions (operator== makes assumptions about the size this vector), although no such crashes are known. Bug: 1057072 Change-Id: Ia741544fe2e69eba505c57e8315e01786674a56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207153 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#770371}
-
Mei Liang authored
This CL modifies the TabSuggestionMessageCardViewModel to build a PropertyModel based on the TabSuggestionAction. In addition, this CL updates the relationship between the shown Message and the available Message in MessageCardProviderMediator. Prior to this change, each MessageType is allowed to live in either the shown Message queue or the available Message queue, not both. After this CL, each MessageType can live in both. The available Message for the same MessageType can be queued up, and each MessageType will have one Shown Message. Change-Id: Icb57147823bbcf81679d38c600d894ed6e47317c Bug: 1076538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196845 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#770370}
-
Kyle Horimoto authored
After discussions with jessejames@, we should not use internal code names as search tags. Bug: b/156109290 Change-Id: I67d2badcf1af5db66812d189d99a72ecb1ab6ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209611 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770369}
-
Anupam Snigdha authored
This patch contains a new virtualKeyboardPolicy that will let web authors control the virtual keyboard behavior through JS. It only contains the changes to idl and in the next patch I'll add a complete end-to-end implementation describing the working of the new attribute in conjunction with the virtual keyboard show/hide APIs that I implemented in the earlier patches. Explainers and Design Doc: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/VirtualKeyboardPolicy/explainer.md https://docs.google.com/document/d/1I0LUNxK_gP5IaNQsbYN6gL6Zpm71XzduCKkublU5o5Q/edit?usp=sharing Bug: 856269 Change-Id: I5311eefa717827a44654c3cdc59f341d6d8a89b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204848Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#770368}
-
Mason Freed authored
This is part of a multi-CL set that will move all "Web Components v0 only" tests into a separate folder. This will make landing the eventual removal of WCv0 easier, because this entire folder can simply be skipped rather than requiring file-by-file changes. There should not be any tests in this folder that are needed for testing Web Components VERSION 1 features. While this CL does not change any behavior or testing now, care should be taken in reviewing the list of tests, since when WCv0 is removed, all of these tests will be deleted. So any tests being moved here that are required for testing a non-WCv0 feature should *not* be included in this move. This set should only include tests of the (Shadow DOM v0 specific) distributed nodes concept. Bug: 937746 Change-Id: Ia5c38f31cd999dcd96aa116183a1fa99920c152a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209594 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#770367}
-
Alex Moshchuk authored
Multi-process AW already supports cross-process navigations and swaps processes when navigating to WebUI pages due to our existing WebUI security checks. However, we currently don't lock WebUI processes to origin on AW, due to a blanket exception for all URLs. This CL changes WebUI processes to also be locked to origin on AW, which should better protect them (e.g., by enabling site isolation runtime checks based on process locks). This applies to AW multi-process mode only; in single-process everything is in one process, and there's not much we can do, though this CL does add a test that we can at least navigate to a WebUI page successfully when in that mode. Currently, AW supports just one WebUI page, chrome://safe-browsing, which is what's used in the tests. Bug: 1071464 Change-Id: I246662d3d542a64e0e0bdcd593bbb686bde41d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204517 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#770366}
-
Piotr Pawliczek authored
A new unit test for port number. BUG=none TEST=none Change-Id: Id8ef89130f543c5dd7a474d9a1d996aa5655d75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207576Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#770365}
-
- 19 May, 2020 24 commits
-
-
Charlie Harrison authored
This CL adds a new mode to print_histogram_names.py to print the added and removed histograms relative to a git revision e.g.: ./print_histogram_names.py --diff origin/master ./print_histogram_names.py --diff HEAD~ This is especially useful for CLs which add lots of histogram suffixes, so that it is easy to learn precisely what histograms are generated by the change. Documentation is also updated to encourage using this tool when using histogram suffixes. Bug: None Change-Id: Ibc1a8cde4216ad49f19a795bbfaa31dc61451705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205330 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#770364}
-
James Cook authored
Fix some camelCase_ -> snake_case_ TBR=khmel@chromium.org Bug: none Change-Id: Ie646c43072175ba2122b036ffe97f0374920fada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209613Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#770363}
-
Jenny Zhang authored
The flag was set to expire in M83, so it stops showing up from M84. However, we have not launched this feature to 100% user yet. We need to keep it until to we fully launch the feature. Bug: 1082623 Change-Id: I55eef3188ce23432f88ab80feb3ad309cfcfa3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200428Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#770362}
-
Peng Huang authored
The vulkan.hpp is included in the upstream Khronos vulkan headers package. It is a vulkan c++ binding generated from vulkan registry. It is implemented with c++ template in a single header file. This change updates gpu::VulkanFunctionPointers to make it compatible with vulkan.hpp, and adds vulkan_cxx.h which setups several necessary macros before including <vulkan/vulkan.hpp>. So any code wants to use vulkan c++ binding just needs to include vulkan_cxx.h. This change also adds a test for the vulkan c++ binding. Change-Id: I74c7003008082686984b559c729bdecac1b08efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198140 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#770361}
-
Martin Kreichgauer authored
Authenticator{MakeCredential,GetAssertion}Blocking meant to free the unmanaged pointers returned by Windows by wrapping them in unique_ptrs. But they assigned nullptr, and the actual pointers were never freed. Also make FakeWinWebAuthnApi ensure callers free all returned pointers before it is destructed. Also fix some doc strings. This is a follow-up to comments in https://chromium-review.googlesource.com/c/chromium/src/+/2197475. Fixed: 1081450, 1084698 Change-Id: Ifc4d228a63f679f1f3cd2f2f75b11c49b4af8d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207736 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#770360}
-
David Munro authored
In addition to the settings UI the disk size can also change during installation. If you uninstall then reinstall Crostini while keeping settings open the UI components aren't reloaded, so we don't refresh the disk size shown in the UI. To handle this case we reload disk info after Crostini is reinstalled. Bug: chromium:1083110 Test: Manual, following repro steps in the bug with and without fix Change-Id: Ic8ad74ca594fb79d6c239286793d2ec976b98db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208152Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#770359}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cdfc69c7f0f8..78ef4133f8de 2020-05-19 shrekshao@google.com Fix invalid enums for OES_draw_buffers_indexed 2020-05-19 jdarpinian@chromium.org Enable regenerateStructNames workaround on iOS 2020-05-19 amaiorano@google.com Reland "Add support for GL_CHROMIUM_texture_filtering" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1058744 Tbr: geofflang@google.com Change-Id: I4d1ccac2a0be118a821217964fe5c2fc91852482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209478Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770358}
-
Moe Ahmadi authored
There is no way around not giving the header row focus when clicked. If the header is unfocusable, clicking it would close the realbox popup. This CL changes the header CSS rules so that it won't appear as focused when clicked. The header continues to appear as focused when the toggle button receives focus. Bug: 1082516 Change-Id: I5ec63f1adeb4a3f82e621924a5de8bfdacf06136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209564 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770357}
-
Andrew Xu authored
It is a partial fixing for the issue 1072043, where hotseat still shows after launching an app from context menu. In this CL, when the activated window is not a shelf window, reset |is_manually_extended_| of Hotseat- Widget. Create an end-to-end browser test for this scenario. However, this solution does not cover the edge case of launching an app in a new tab instead of a window. Bug:1072043 Change-Id: Ia94947baecc8d71690e82a7ba4def08f9a7bab7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197343 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#770356}
-
Christopher Cameron authored
This will not be a canvas color space option (there will likely be an explicit extended-srgb and extended-linear-srgb space, eventually). TBR=fserb Bug: 1083693 Change-Id: Ib89e3f9ab0bcd0681ddd5fb4e3a26608fb293df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205002Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#770355}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b63b4ac6933..5e6d789ce47c 2020-05-19 egdaniel@google.com Revert "Remove deprecated flush calls." 2020-05-19 egdaniel@google.com Revert "Fix flush change breaks." 2020-05-19 egdaniel@google.com Revert "Implement submit API to GrContext." 2020-05-19 egdaniel@google.com Revert "Another missed flush call fix." 2020-05-19 bungeman@google.com Avoid GDI measuring modes with CBDT fonts. 2020-05-19 bungeman@google.com Note typeface usage in layers. 2020-05-19 johnstiles@google.com Allow --disableDriverCorrectnessWorkarounds to enable MSAA on Intel GPUs 2020-05-19 egdaniel@google.com Another missed flush call fix. 2020-05-19 egdaniel@google.com Implement submit API to GrContext. 2020-05-19 bungeman@google.com Correct TestTypeface::onCharsToGlyphs signature. 2020-05-19 egdaniel@google.com Fix flush change breaks. 2020-05-19 mtklein@google.com remove support for mips64el/loongson3a 2020-05-19 mtklein@google.com port GrDataUtils to use generic transfer functions 2020-05-19 key.draw@gmail.com try adding some code to example.html 2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 97bfcc9529c9 to da218e6af725 (1 revision) 2020-05-19 csmartdalton@google.com Reland GrRectanizerPow2 2020-05-19 egdaniel@google.com Remove deprecated flush calls. 2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 60d5d65325e6 to 97bfcc9529c9 (1 revision) 2020-05-19 bungeman@google.com Reland "Cache hb_face." 2020-05-19 jvanverth@google.com Add GrD3DPipelineStateDataManager. 2020-05-19 reed@google.com extract original paths at big size to improve precision If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:527565,chromium:983926 Tbr: lovisolo@google.com Change-Id: I40d32e2b8166871849d2cf32a4033ae8667744c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209488Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770354}
-
Xianzhu Wang authored
Previously this was needed because scrolling stacked elements under a non-stacking-context scroller would otherwise be forced composited and lose LCD-text if the elements didn't have a opaque background. After crrev.com/c/2194791 we can squash such layers into the scrolling contents layer if possible, so composited scrolling can be allowed without sacrificing LCD text in most cases. In rare cases, a child stacked element will be composited and lose LCD-text if it can't be squashed, but this is the same situation as other indirectly composited layers. It's a bigger win to use composited scrolling than blocking it just for LCD text of the rare cases. Bug: 1080056 Change-Id: I182aa2b9030becf684d9292b9246e4b81b90dd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191313Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770353}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Bug: 1084509 Change-Id: If0ba708aeec31682f1852803930935ca24a5fddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209672Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770352}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3b8db088. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 74ac20cc "Use original URL before redirects as blocked URL in CSP reporting" ba055028 "Revert "Reorganize COEP + reporting tests"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I3bd05698907fdad411a152ae5c2a30b3093e2272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209510Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770351}
-
Rouslan Solomakhin authored
Before this patch, only Java PaymentHandlerHost bridge would be able to access the pointer to the cross-platform PaymentHandlerHost, which prevented moving more of the payment app factories into C++. This patch replaces Java PaymentHandlerHost.getNativePaymentHandlerHost() call with C++ PaymentHandlerHost::FromJavaPaymentHandlerHost(). After this patch, C++ code has the ability to convert a Java PaymentHandlerHost object into a cross-platform PaymentHandlerHost object, so more logic can be moved to C++. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1083242 Change-Id: Id56770a205d5dee0941cdb26c61cad8d9ecf2cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205876 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#770350}
-
Anastasia Helfinstein authored
Add a function to the Switch Access end-to-end test base to wait until a tree change happens, after which a specified predicate function return true. This function is not yet used, but will be in a follow-up change. AX-Relnotes: n/a. Bug: None Change-Id: I12802fc50cae80463f1b28adfd573abd0dacfa5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203641 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#770349}
-
Jeff Yoon authored
The beta/stable only definitions were in master-only, and was not present in commit-queue.cfg of beta. I'm moving these out of master-only and into the root try.star, such that they are propagated correctly for m84. Bug: 1084655 Change-Id: I16dcf48a28cae7302ebdd1288d18b84439b058bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209373Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#770348}
-
Xing Liu authored
This reverts commit 0f9b2fd4. Reason for revert: Breaks download stream(clank) compile. https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879834797612365360/+/steps/compile/0/stdout Original change's description: > [Web Payment] Cleanup PaymentRequestUpdateEventListener. > > Move PaymentRequestUpdateEventListener from sub-interface in > PaymentApp.java to its own file. > > Bug: 1083242 > Change-Id: I0d8323b7dc2f75546ca3086897cb642e1e85111d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205873 > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770319} TBR=rouslan@chromium.org,sahel@chromium.org Change-Id: Ic0c26f934562a03768d88cd30692c194e5606816 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1083242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209512Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770347}
-
Darren Shen authored
This reverts commit eb686109. Reason for revert: Suspecting as the cause for https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/29115 Original change's description: > Update fontconfig cache key handling > > Since If6853404f1e87de4f95a24f6231282543814bd63, the "uuid" variable has > been referring to the MD5 of a fixed string. Update the comment as such, > and remove the now-unneeded .uuid file writing. > > Also update test_fonts/README.chromium as the manual UUID change is no > longer necessary or effective. > > Bug: 767754 > Change-Id: I07a9b10a631e755877cbcb7df40a53359329f8a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209397 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Auto-Submit: Timothy Gu <timothygu@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770287} TBR=thomasanderson@chromium.org,timothygu@chromium.org Change-Id: I7cc1c702d84a1c1a82933ae104d9d0e7fb4dcf5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208322Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#770346}
-
Xing Liu authored
StartSurfaceTest.testShow_TasksOnly and StartSurfaceTest.testShow_TwoPanes are still flaky on Android M bots, not only on Nexus5x(bullhead). testScroll_OmniboxOnly_Pinned is failing on Android P as well. TBR=wychen@chromium.org Bug: 1081822,1084176,1083459 Change-Id: Ic52dc5527f2962773d15cc0ec7f88de891fa56aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209302 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770345}
-
Anastasia Helfinstein authored
This change generalizes the RootNodeWrapper.findChildren() function so it can be used in tests (in a follow-up change). It also changes all references to chrome.automation.AutomationNode to use the abbreviated version of the name (AutomationNode), and moves the declaration of that abbreviation into the constants file. AX-Relnotes: n/a. Bug: None Change-Id: I8061ea8f2cec1587ae3b73e4f85ccc57b0f3de1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208177 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#770344}
-
Kaustubha Govind authored
Add a check to ensure that DoH is enabled correctly, and not turned off due to unhandled configurations (e.g. domain-joined Windows machine, or VPN configuration). The existing navigation check passes even when DoH is forced-disabled, and is therefore insufficient. Bug: 1032710 Change-Id: Idf20f8c4ce1b20c5017ce8693ab5bc57b77b7bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200156 Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#770343}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2671dac29c27..4ab61cb9b449 2020-05-19 sprang@webrtc.org Optionally allows TaskQueuePacedSender to coalesce send events. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib9b110ca8f1263d4133d3eca60edb8d787d850fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209552Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770342}
-
Moe Ahmadi authored
The a11y label changes between "Hide the 'X' section" and "Show the 'X' section" depending on the suggestion group visibility where X is the suggestion group header (e.g., 'Recommended for you'). The tooltip changes between "Hide Suggestions" and "Show Suggestions" depending on the suggestion group visibility. Bug: 1052514 Change-Id: Ib7bce19b8d203e57b9b916fbcc089a58593bdd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206222 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#770341}
-