- 11 Oct, 2019 25 commits
-
-
Kent Tamura authored
The original code of SpaceSplitString::Data::Contains() was equivalent to Vector::Contains(). This CL simplifies the code. This CL has no behavior changes. Change-Id: I0ed0f68e87e07bb003a7b67159982600431618f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852524Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#704920}
-
Sajjad Mirza authored
Also extract common full-codebase coverage properties to a mixin. Bug: 1010702 Change-Id: If60cc49c9040702e4f8138d46af74bbd89e204d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834951 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#704919}
-
Jaeyong Bae authored
This patch means remove tracing to make IndexedDB (and more importantly, compaction) faster. Bug: 1012883 Change-Id: I0f05171ecf8986d8cccdc151243e1de02d124090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851365 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#704918}
-
Wenbin Zhang authored
system_health_smoke_tests.py has a logic to make sure we only run the latest version of a story in smoke test. For example: Case 1: Story_A:2019 Story_A Case 2: Story_A:2018 Story_A:2019 In both cases, Story_A:2019 is expected to run, and all other versions should be listed in the _DISABLED_TESTS in order to save CQ run time. However, in the current implementation, none of the old versions in the above cases will be detected.This CL will update the logic cover the above cases. The new logic also discovered two stories which we currently run smoke tests with their older versions. In this case, those older versions now are added in the _DISABLED_TESTS. Those stories are: benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:social:vk benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:social:vk:2018 benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile/load:social:twitter benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile/load:social:twitter:2019 R=crouleau@google.com Bug: catapult:1006771 Change-Id: Ia90f38568685ca8be45710f97e91cd8ea81dc856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845792 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#704917}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6a1d77869d77..b2b51418596e git log 6a1d77869d77..b2b51418596e --date=short --no-merges --format='%ad %ae %s' 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-10 dbeam@chromium.org git-cl: add --fixed / -x option to upload Created with: gclient setdep -r src/third_party/depot_tools@b2b51418596e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I6194a05084f3dd9fe62ba8d4bc8e86cc98385afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854551Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704916}
-
Victor Costan authored
Bug: 729800 Change-Id: Iff06269a032bf22de79b84508c923fe3215c07ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852326 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#704915}
-
Brian Cui authored
This PR addresses an interaction bug with the NVDA screen reader. When the NVDA screen reader is in "scan" mode (instead of "focus" mode), pressing the Enter key when focused on a button element in the Settings pane causes the Settings pane to close unexpectedly. Before: https://i.imgur.com/GNRvdyW.gif This is because NVDA is simulating a click event triggered on the UI.Dialog element that wraps the Settings pane, which is not supposed to be clickable by the user. The default behavior for click events on the UI.Dialog is to hide the dialog. Our hypothesis is that NVDA is incorrectly targeting the UI.Dialog element in the accessibility tree, which is not meant to be directly interacted with. The fix in this PR simply disables the default behavior of clicking on the UI.Dialog for the Settings screen. This should have no side effects on existing behavior as the UI.Dialog element was never intended to be interacted with. With the hide behavior disabled, NVDA interaction acts as expected (button is pressed), and normal usage is unaffected. After: https://i.imgur.com/Gas1ydF.gif Bug: 963183 Change-Id: Ie1773ed8987dd6d42f8c9cb897fea3de5a091bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848114Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Brian Cui <brcui@microsoft.com> Auto-Submit: Brian Cui <brcui@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704914}
-
Tim Song authored
Certain feature pod buttons (e.g. accesibility) are not togglable, but are currently announced as such for ChromeVox spoken feedback. BUG=1009727 Change-Id: I2db6c3a53bb04ba677457ff5590574d2c384b503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848454 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#704913}
-
David Black authored
Previously the timer notification message was manually constructed. Now we rely on ICU APIs for better I18N support. Tested in en_US, fr_CA, ja. Bug: b:122475245 Change-Id: Idf8f375adee0aba198ad7091a2aa96bbe283c6df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660261 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#704912}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7fd7a8aef06c..9f765966461e git log 7fd7a8aef06c..9f765966461e --date=short --no-merges --format='%ad %ae %s' 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@9f765966461e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Iec9e20f8214f85192ed6a2727f7ce179c24f64d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854918Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d372b6c1..f505d9d8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I487f46cee3819e4726cd26322520ed1585d03ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853951Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704910}
-
John Lee authored
Previously, the tab strip was using favicon by using chrome://favicon, which depends on history and consequently did not work in incognito mode for sites the user did not visit in a normal window. Bug: 992972 Change-Id: I6407353c649876fe78c4ffb2425ebcd761e5d0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850965 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#704909}
-
Christopher Cameron authored
The profile_storage_ member of AvatarMenu is commented as "weak", but the lifetime relationship is not discussed. Use an actual weak pointer (ProfileAttributesStorage supports it already), and avoid dereferencing profile_storage_ if it is gone. Bug: 1008947, 1001215 Change-Id: I0e8a2fbb55465f1680c064c7cdb6193c93eb3e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853647Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#704908}
-
Marijn Kruisselbrink authored
This is in preparation for migrating native file system code to the UI thread, and decoupling it from whatever thread file system backend code actually wants to be called on. Bug: 1011534 Change-Id: I9d956dac5761380654842cdd07b67e1c7c2000d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841764 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
-
Regan Hsu authored
Bug: 1013094 Change-Id: I27d3fd476d3c747ac7eb7a90eb179c3b787baec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852420Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704906}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/383a4e801d41..788d15f52867 git log 383a4e801d41..788d15f52867 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 rmhasan@google.com [typ] Makes changes so that Host or FakeHost can be used as file manager Created with: gclient setdep -r src/third_party/catapult@788d15f52867 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:982208 Change-Id: Ieb924d5fd330cc75976b6a6c2764e1a25506a2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854759Reviewed-by:
-
Christopher Thompson authored
This will make all sites be treated as "control" (no warnings shown) when the control site config has not yet been loaded. This will prevent control sites from accidentally showing the warnings, at the expense of occasionally not showing warnings on non-control sites near browser startup time. Bug: 1011089 Change-Id: I32ebb7affc0d0a4bc2a3f6b280c9e5943f9118eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845488 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#704904}
-
Antonio Gomes authored
This CL wraps up Onion souping of webrtc_media_stream_track_adapter_map.cc|h that happened in [1], but was blocked on [2] - now fixed. [1] https://crrev.com/c/1816780 [2] https://crrev.com/c/1816789 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: If134aed18197306d43cbdfa18430b9aab11e6fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816796 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#704903}
-
Tommy Steimel authored
This CL adds a ScopedFeatureList to the MediaDialogView interactive browser tests to ensure that Global Media Controls are enabled. This fixes an issue where the tests were failing on official builds. Bug: 1012549 Change-Id: I8c3fcb815811353f059f988bdffe0c336059f005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854860 Commit-Queue: Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#704902}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/847b3f98194e..586f2bea5b1f Created with: gclient setdep -r src-internal@586f2bea5b1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib34ddcf30f544c7dbd0b57c66c31cb8b7fbedc53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854758Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704901}
-
Kyle Horimoto authored
Each button on the keypad includes space for a number as well as the letters which represent the numbers (e.g., "ABC" for 2, "DEF" for 3). However, since 1 does not have any associated letters, its alignment was incorrect and noticeably different from the rest of the buttons. This CL fixes this alignment issue by aligning the number to the top of the button and the letters to the bottom of the button. Fixed: 1004974 TBR: stevenjb@chromium.org Change-Id: I9be7be402b853cbf6ba76985151f77a0696ac13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854638Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#704900}
-
Hiroki Sato authored
Some member functions are unnecessarily declared as protected, and they should be private. Also this CL fixes a lambda function from by-copy capture to by-reference capture. Bug: None Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*:ArcAccessibilityHelperBridgeTest.*" Change-Id: I183174a922b6d57ea3b41a04053785b936b655b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850687 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#704899}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f1f2e8606a69..c9af0e8a6ace git log f1f2e8606a69..c9af0e8a6ace --date=short --no-merges --format='%ad %ae %s' 2019-10-10 jclinton@chromium.org Remove excelsior temporarily to improve LCQ runtimes Created with: gclient setdep -r src/third_party/chromite@c9af0e8a6ace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie63ec2d1da58c780ef30ad537ed846efb8aa3dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854698Reviewed-by:
-
Moe Ahmadi authored
Remote zero-prefix suggestions are supported only when Google is the default search engine and the user is signed in (based on the existing experiments). This CL disallows remote zero-prefix suggestions when those conditions are not met. Bug: 996516,1012340 Change-Id: I7f077a79f85c0a72523fd307afe58318ed63a372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848052 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#704897}
-
danakj authored
Only the main frame RenderWidget should have modified values from the emulator, so only it should be able to see it. In particular, popups and child frames should not see the emulator. R=avi@chromium.org Bug: 419087 Change-Id: I34cca337c8b9590824f681cf32475ba0a67c78b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850573 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
- 10 Oct, 2019 15 commits
-
-
Thomas Guilbert authored
An empty directory was accidentally committed in 0f14062b... as part of the dav1d roll. This CL cleans up the mistake. Bug: 1010547 Change-Id: I29fd4793b817d64adf9832df67f7a82a6dfde1cf TBR: sky@chromium.org Change-Id: I29fd4793b817d64adf9832df67f7a82a6dfde1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841666 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#704895}
-
Julie Jeongeun Kim authored
This CL converts UserId from user_id.mojom to new Mojo types using ReceiverSet and PendingReceiver. Bug: 955171 Change-Id: I15a7b25d0debc781387f8f3dbc9e9ce637fdb6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849746Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704894}
-
Julie Jeongeun Kim authored
This CL converts OriginPolicyManagerRequest and OriginPolicyManagerPtr to new Mojo types using PendingRemote, Remote, PendingReceiver, and ReceiverSet. Bug: 955171 Change-Id: I370ef0d56a0fee3d358233f49d85f31e7233e0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846630Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#704893}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e9b892b. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5e8d81bbd056fc244496527fe6fbebbb4e0592af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853950Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704892}
-
danakj authored
Each RenderWidget/local root should have its own scope for the ScreenInfo, since emulation causes the ScreenInfo to change only for the main frame. In the future if all widgets get the emulated ScreenInfo, the updates should propagate through the VisualProperties update waterfall which requires going through and storing the values on RenderWidget. R=dcheng@chromium.org Bug: 419087 Change-Id: Iaa333665acf4dc9990d92105ce8631377e0fd93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852423Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Emil A Eklund authored
Bug: 1011885 Change-Id: Iab49fc210c341602897b5e2bf07d56e257adb100 Tbr: ikilpatrick@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853884Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#704890}
-
dpapad authored
- Fix newly found JSC_HIDDEN_INTERFACE_PROPERTY_MISMATCH, as a result of the interface checking overhaul at [1] - Fix/suppress newly found JSC_CONSTANT_PROPERTY_REASSIGNED_VALUE errors. This is in preparation of rolling a newer compiler version at a later CL. [1] https://github.com/google/closure-compiler/commit/86acbd5e3ec78f08a1804df5f1efbea129d29c0e Bug: 1012840 Change-Id: I8c356c9d2d3df03120f04614eafa555de488c8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850312 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#704889}
-
Michael Liao authored
Re-upload of https://chromium-review.googlesource.com/c/chromium/src/+/1636250 This is a shared control between Timeline, Network, Memory, JS Profiler and Layers tools 1. This PR adds the ability to use keyboard to navigate sliders in the Overview grid. - Can tab into the sliders - Can use left and right arrow keys to navigate the grid sliders (step by 2 pixels) - Can use Ctrl + left and right arrow keys to navigate the grid sliders faster (step by 10 pixels) Gif: https://imgur.com/Im7m6su Bug: 963183 Change-Id: I64ec60864165d9cca6e7a76c6849ed1cf1beee61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676677Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Liao <michael.liao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704888}
-
Chris Harrelson authored
This is necessary to make sure the values get through to the compositor thread. It regressed accidentally in earlier CLs. Bug: 1013000 Change-Id: Ia6de23a10180abb5e41fc8d48f790359f826c6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854218Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#704887}
-
siyua authored
Did some manual testings to make sure it is working correctly. Bug: 991037 Change-Id: Icceddefdee99f0ba252f5ce161e4b42813ee1c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848751Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#704886}
-
Haiyang Pan authored
This would help local development with emulator Bug: 922145 Change-Id: Ie107381b80e3c0acae1145cf4078a327e38ffa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849434Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#704885}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3481902904a9..6a1d77869d77 git log 3481902904a9..6a1d77869d77 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 ehmaldonado@chromium.org gsutil: Bump asn1crypto version to 1.0.1 Created with: gclient setdep -r src/third_party/depot_tools@6a1d77869d77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1012612 Change-Id: I965e614a9ae1ddc5dfeab2bef26e7db27ff663bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854363Reviewed-by:
-
Brandon Wylie authored
The current histogram that's in place doesn't fit our needs here. Bug: 1001839 Change-Id: Ie1a0e897c86bfa88fbb5eb901fb7f57c7f4b1bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846249Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704883}
-
Zoe Clifford authored
String parking can be fairly expensive in terms of CPU, which makes it undesirable for certain headless use-cases, such as those with many short-lived pages, or where RAM is more plentiful than CPU. The option to disable string parking was removed in [1]. This CL re-adds a similar option so it may be disabled once more. (Google Internal) screenshot of CPU profiling: https://screenshot.googleplex.com/cFXiZq1ydBN [1] https://chromium-review.googlesource.com/c/chromium/src/+/1697649 Change-Id: Ib05e79a009fb70565011bd8aa9ba6238c6a8c617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820023 Commit-Queue: Zoe Clifford <zoeclifford@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d0704ce5c6a1..d62ac3f0b830 git log d0704ce5c6a1..d62ac3f0b830 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 kcwu@google.com Use fake clock for replay fuzzing Created with: gclient setdep -r src/third_party/webrtc@d62ac3f0b830 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:959836,chromium:1009073 Change-Id: Id67092bd1507ca2c61443a8db8bdd8b2ac3a2337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854377Reviewed-by:
-
