- 14 Dec, 2020 40 commits
-
-
Kenton Lam authored
Uses generate_grd and grit rules to create and bundle the necessary resource files. Functionality is equivalent to existing code. Bug: 1156851,1156859 Change-Id: I0724137a3f6cffbc5d44539e5515b335f702f447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586289Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#836828}
-
Daniele Castagna authored
|gpu_memory_buffer_factory_| weak pointers are checked on the IOThread. Weak pointers should be invalidated on the same thread that checks them. This CL moves the destruction of |gpu_memory_buffer_factory_| on the IOThread to avoid possible use after free issues. Bug: 1152645 Change-Id: I0d42814f0e435a3746728515da1f32d08a1252cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563077 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#836827}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/12c78cbc820a..43c39a1ba42a 2020-12-14 rharrison@chromium.org Re-enable disabled unit tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I14f5ec40c33cac0d1ffde15e945cce5f3982a76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591147Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836826}
-
Bruce Dawson authored
Due to an OS bug shell32.dll may get unloaded while still in use. Pinning shell32.dll avoids this and the associated crashes with no downside. This is an expansion of the fix in crrev.com/c/2505835 Bug: 1076771 Change-Id: I89153998a5dabb345db0435877201de771a60b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588012Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#836825}
-
Mark Yacoub authored
This is a reland of 631cb004 Original CL has been reverted due to SkiaRenderer not handling recreating buffers. The fix has been merged (crrev.com/c/2581693), so this should be good to reland again. Original change's description: > Fallback to Linear Modifiers if Preferred Modifiers fail. > > Test-Modeset with preferred modifiers. > If it the test passes, save the preferred modifiers to use for full modeset. > If it fails, try testing with linear modifiers for every controller. > Use empty modifiers list if the platform doesn't support preferred modifiers list. > > This enables us to launch Intel Rendering Buffer Compression. > http://go/cros-intelrbc > > BUG=979736,1082882 > > TEST: RBC enabled on (4K eDP with 4K external) and (4K eDP and 2 external monitors), zork, and nautilus > Change-Id: I7698d2cc9f13e5293eb0f6579dee775314988037 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567263 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Cr-Commit-Position: refs/heads/master@{#834389} Bug: 979736 Bug: 1082882 Change-Id: I90a4c93c5318da9ba252d126629c99173895e6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585813 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#836824}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/778b2c216924..54174aefa84c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id6cc008f4edd71ce2a9e45781f5d648f2ef36dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590491Reviewed-by:
-
Fabrice de Gans-Riberi authored
This adds a //net-based implementation of the Open Screen UdpSocket interface. Its main use is for unit tests that do not have or require the network service. Bug: 1110490 Change-Id: Ic542c3c29d05b5c58d36efb6fd31d0eeac3cefe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580908Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Jordan Bayles <jophba@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#836822}
-
Edward Lesmes authored
Presubmit check added in crrev.com/c/2582566 Bug: 1113033 Change-Id: I09802343bd11d3f5f044cda4cea3aa8e58c8c398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583464 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#836821}
-
Josh Santana authored
If a user decides to check "Always Translate" on the Bubble UI, it will now automatically translate the page upon them doing so, instead of them having to also click on their target language. Bug: 1156275 Change-Id: I2d7aa033d575249d98bb95c90e510fd0dd5e332e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582534Reviewed-by:
Josh Simmons <jds@google.com> Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Joshua Santana <joshsantana@google.com> Cr-Commit-Position: refs/heads/master@{#836820}
-
Ian Wells authored
Bug: 1152187 Change-Id: Ic0b044b6c1318d34b0107c1ec37c04aa2b0450ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580780 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#836819}
-
Scott Lee authored
result_adapter is chromium-specific tool that reads the test outputs with gtest/json format and sends them to ResultDB. It was previously deployed to Swarming bots via pool config, but this CL adds it to src.DEPS, so that - swarming pool.cfg no longer have to deploy a chromium specific cipd pkg, and - result_adapter becomes available for local runs in dev's workstation. Change-Id: Ifce0f243162c6aa0f76539fcda1446cfcac2f88d Bug: 1084332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586748Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
-
Nick Burris authored
* Create ExternalAuthGoogleDelegate, owned by ExternalAuthUtils, which will be used to implement isGoogleSigned downstream, rather than doing so with an overriding subclass. * This is patch 1/5 for providing ExternalAuthUtils as a singleton instead of from AppHooks. Change-Id: I13c8d972f8ca1a4d2dac1bdda4ad8911ae8c275b Bug: 1154371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587429 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#836817}
-
Trent Apted authored
This DCHECK is causing tests in components unrelated to notifications to be flaky. Change it to DLOG_IF(ERROR.. so that those components can retain their test coverage. Bug: 859061, 988160 Change-Id: I01a5cfeccc9907c64f7afc9d9235a1ad0cb6179e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584433Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#836816}
-
Yao Xiao authored
What: Rename publicly_routable field in the history APIs to floc_allowed. The database schema is left unchanged to save the migration cost. Updated the comment for VisitRow::floc_allowed. Why: This bit is expected to be used only for floc. We've decided to incorporate another opt-out status, and may introduce more status in the future. Therefore it makes sense to rename to floc_allowed. Bug: 1157761 Change-Id: I9aecb50287e7953754eb05aa2d7993a6092639e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586232Reviewed-by:
-
Jan Grulich authored
Current scenario when PipeWire desktop capturer is used: Chromium picker dialog is created with screen and window capturer. Each capturer makes an xdg-desktop-portal call, showing another picker dialog. Once user confirms both pickers on xdg-desktop-portal side, yet another picker is shown as a new capturer is created for the web page itself. With this change: Chromium picker dialog is created, but only screen capturer will be created as with xdg-desktop-portal the picker will handle both screens and windows. Also in the chromium picker, the "window" tab creating window capturer expects a list of windows and doesn't show previews, but we need actually to behave exactly like the "screen" tab and show preview of selected window. Then again, yet another picker from xdg-desktop-portal is shown as a new capturer is created for the web page itself. Bug: chromium:1157006 Change-Id: I39eafc72eb46da7868d1114b5c106030c22787a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578840 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836814}
-
Greg Thompson authored
Switch to using a p-link and drop the language query param. BUG=1102713 Change-Id: I782b331d3baae302518b54535e1fcab149e6c549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585087Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#836813}
-
Abigail Klein authored
Give the toolbar accessible node data so that it becomes a group in the accessibility tree. This improves the experience of navigating the chrome for screen reader users: users can treat the toolbar as a group and interact with it, or skip over it if they prefer. Previously, users had to navigate through every button in the toolbar, slowing them down. Bug: 1097760 Change-Id: Ia7aaed4d74bf081c2b41e4142d732d8b56563afa AX-Relnotes: Make the toolbar an accessible group. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588893 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#836812}
-
Harry Cutts authored
The Yubikey 4 presents as a keyboard to type in OTP codes, but shouldn't prevent the virtual keyboard from showing up. Vendor and Product IDs from https://crbug.com/1011418#c13. Bug: 1011418 Test: none (I don't have the device) Change-Id: I852577679f89ca5613d6120dd0bafdf103554b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590506Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#836811}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c24141ebe089..a4d2246a2f93 2020-12-14 liberato@chromium.org Add freezing / roughness to media telemetry tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: Ib3ed207f4aedbed54e7f230ba055542f2f1bda44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590416Reviewed-by:
-
Frank Liberato authored
This lets us record the events in telemetry. Change-Id: I90348045cdca95705be99b5900376fd6e13577d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441018Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#836809}
-
Jarryd authored
Bug: 1102433 Change-Id: I65e8d1504b5ffdcd34706bba746db132692f2d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589008 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#836808}
-
Leonid Baraz authored
Writes the key to the file, parses it from the file during initialization. Encryption is controlled by base::FeatureList; if encryption is enabled, fail Storage initialization. Later on we will instead send Upload with no records and only need_encryption_key flag and reject Enqueue until it is responded. Bug: b:170054326 Change-Id: I343b17f9363e11b62e6ab1f69148a7e9e8e0d4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586086Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#836807}
-
Scott Violet authored
This removes the cct extra header when in incognito mode. BUG=1158518 TEST=doesNotSetHeaderWhenIncognito Change-Id: I43724d127aa6971b686b89293ec8efea146dffdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590705Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#836806}
-
cfredric authored
These functions will eventually be used to compute SameParty-ness by the SameParty cookie implementation. Bug: 1143756 Change-Id: Ib9ac724c4a3d6053c0ed6886e8dc0acdefc050f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586148 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#836805}
-
Aleks Totic authored
Several data structures do not byte align, and cannot be compared with mem functions. Bug: 1158513 Change-Id: I31a0f8b80c17268e1b5661aaef9d07a5854b2e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590907 Auto-Submit: Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#836804}
-
Jesse Doherty authored
This histogram value is used as part of a high level guiding metric. We're trying to consolidate these metrics as user actions to improve query speeds and enable new analysis. Bug: b/161525144 Change-Id: I3564e5555f37ecd0c2eb73a9a08adc4d30b8566b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575605Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#836803}
-
Cheick Cisse authored
Create Open javascript action and set up histograms for contextMenu actions Bug: 1140387 Change-Id: I836eff307c6de1a8b233c3018a9856799bd43513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584646 Commit-Queue: Cheick Cisse <cheickcisse@google.com> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#836802}
-
Pavol Marko authored
Remove all references of ACCOUNT_TYPE_SESSIONLESS_USER from SessionManagerClient, in preparation of removing this account type from session_manager. The only user of this account type was PreSigninPolicyFetcher which was removed in CL:2513205 Bug: 832127 Change-Id: I3b8e8a9fdfb38c5cc925a1c77dafc3a96297b054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513584 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#836801}
-
Shengfa Lin authored
ChromeDriver python tests sometimes encounter timeout while launching browsers. Currently, ChromeDriver would try to re-launch browser again with max retry of 3 for all tests. However, the original browser might still be launching after the retry/retries. This change is to terminate/kill the original browser before the retry. There are two benefits: 1. If the original browser is terminated/killed before retry, then we will not see the log from it later in ChromeDriver log. This can avoid confusion. 2. It reduces resource consumption with less concurrent browsers running. This is in hope to reduce test flakiness. Change-Id: Ie31c155398e1c4ca19d3697e6f25f853323191ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586972 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#836800}
-
Theo Johnson-kanu authored
- Before this CL maximum delay before rotating background advertisement was 15 minutes. This CL lowers that time to 14:30 minutes or 870 seconds. Bug: 1157171 Change-Id: I1866f843ace4076ac2af2a6998f9fbeb492afe64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588300 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#836799}
-
Leonard Grey authored
Bug: 1152274 Change-Id: I179c720aa3b384c243cf61c3186fae17f8acfc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585691Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#836798}
-
Stephen McGruer authored
Bug: 1158023, 1048761 Change-Id: Iddb98f4e8f346e6bf2b2249a14a5b1c6f1eb2f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590424 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#836797}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ib01124680727235df66644f8a6dcbab7d4b51f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590391Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836796}
-
Phillis Tang authored
On WebAppInstallFinalizer::FinalizeInstall, if there is an existing app but the install is user initiated, overwrite user controllable fields like user_display_mode. Bug: 1124300 Change-Id: I011fb0f9306b89d6de76256d3d6c7b197c310171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583202 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#836795}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e2eec62f. With Chromium commits locally applied on WPT: ced49c96 "[AspectRatio] Correctly handle abspos replaced elements with aspect-ratio" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-conditional NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I173630eff103d7f1d2508694fea1abd75d07741c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590017Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836794}
-
Peter Kasting authored
The existing code bases the decision on whether the toolbar button icons have a custom color, which causes accessibility problems. Bug: 1153079 Change-Id: I0f9996891a7327ffed3d45b77944fa33481b8b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587578 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#836793}
-
Side Yilmaz authored
This CL make ToolbarButtonInProductHelpController use the correct profile instead of using always regular profile. Bug: 1048632 Change-Id: Icde76cb9e023c8159b44611f943084080435a884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567227Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#836792}
-
Sven Zheng authored
This is a reland of efe87dc0 Original issue was fixed in crrev.com/c/2584633 Locally tested Lacros can build with these gn args. Original change's description: > [Lacros] Use cfi and thin_lto for Lacros official build > > CFI and ThinLTO were disabled on the simple chrome workflow > because they increase build time quite a bit. > But for official build, then should be enabled. > > Bug: 1157567 > Change-Id: I33a9eac37221f31da9a6725b19992d5daded72dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586085 > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Sven Zheng <svenzheng@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835956} Bug: 1157567 Change-Id: Ib8d009f1e0e8efe8b8c3033086c9df4b6d596175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590075Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836791}
-
Trevor Perrier authored
This CL updates the language on two error messages in translate_prefs.cc Bug: 1028966 Change-Id: Id15a6886e257007988763b4e557ee5da02b1db68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587608Reviewed-by:
-
Andrey Kosyakov authored
Bug: 1128206 Change-Id: I7bc10beb585f07b6f49e61faae9cd8ab35eaa5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587606Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#836789}
-
