- 01 Dec, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f1e2bbd8..4f7b9247 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8c5afb969db5692a795cb9696612c6f9fe53c4c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567797Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832317}
-
Alice Wang authored
This CL adds a new flag param for web sign-in flow and put the text |No thanks| behind the flag. Bug: 1153253 Change-Id: I1403c3790cc954a24d2dce2f9cfacb7fd8fa7a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563269 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#832316}
-
Bartek Nowierski authored
Change-Id: Iad90f5b80ec9effdb9737568ef83a8e8676ae31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563382 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#832315}
-
Changhao Han authored
DevTools frontend CL: https://crrev.com/c/2557071 Bug: chromium:1152391 Change-Id: I7d5fc0e8a8ca4249a7ee9c01ba427771ddfb7725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566799 Commit-Queue: Changhao Han <changhaohan@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#832314}
-
Wei Lee authored
Bug: b/172339594 Test: Check the icon is updated for both platform app and SWA version Change-Id: If9b779f2164c2f47e123a670b99720e2c847a448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567238 Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#832313}
-
Azeem Arshad authored
This CL fixes issue with GetCurrentAppUrl method in AndroidSmsAppManagerImpl. This method is used in a few different places to determine the url of the currently installed app. This method currently loops through migration domains in order and returns the first installed app. This logic fails when the user may have manually installed apps from non-preferred domains. This causes other related code that uses this method to use the incorrect url. Fixed this by always checking for preferred domain first. Fixed: 1154053 Change-Id: I2c93a7486ad23a135787ce1a7a8f3faacf4c6b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566791Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#832312}
-
Yuki Shiino authored
idl_type.py - Adds new_union_definition_object to help implement NewUnion. blink_v8_bridge.py - Adds member_ref_t to represent an input/output type to/from a member variable. Example) member_ref_t func(member_ref_t new_value) { member_var_ = new_value; return member_var_; } - Adds clear_member_var_expr to clear the content of a member variable. These will be used in https://crrev.com/c/2522861 . Bug: 839389 Change-Id: I738f5a3a18acbbcd09ff4e2fd6b235a8845d43ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563520Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#832311}
-
Maxim Kolosovskiy authored
Button titles scraping for unowned forms might be heavy. So, it should be enabled only in Dev and Canary. Before this CL, channel-based filtering was implemented with the AutofillFieldMetadata feature. As the experiment spans for many years, it is better to hardcode the behavior on the client side. Different behaviour in different channels is to be deprecated once we deprecate the old metadata and use the rich metadata pipeline. Bug: 1111809 Change-Id: I0cd31b4961338a2b07b10c37164b6bc75f8d8808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526083Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832310}
-
Maksim Moskvitin authored
This CL moves trusted vault crypto functions to a dedicated header, because they were used in multiple files and it leads to code and constants duplicates. Bug: 1113598 Change-Id: I5450a1ec0f9836471c5e5d3669e7cd2173527d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565510Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#832309}
-
Francois Beaufort authored
As WriteOnRequestCompleted is always called whether the push operation is cancelled successfully or not, this CL removes the unused cancelled callback. Bug: 1151857 Change-Id: I5f5bb163e52afe2f9b163a043fa25eb5def9cc8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554607 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#832308}
-
Denis Kuznetsov authored
Bug: None Change-Id: Ie5bd6620ca391f50a1db48657a249cad5400edea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564759Reviewed-by:
Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832307}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d96af00c9286..8f303e8141bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tschumann@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1112738 Tbr: tschumann@google.com Change-Id: Ifd6ed7afe74f6b301b60e44e3ab8e05d3430e000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567491Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832306}
-
Anastasiia N authored
Add primary account description with a link pointing to Sync Settings. Show management status for supervised users. Screenshots: http://screen/8FKJx5YBtEY4X6Y, http://screen/5EWijZQ5sCaUJMf (managed account), http://screen/63ivfWWtMvpKn8D (child account) Bug: 1144113 Change-Id: I15cb13ac6763882e671ac57c13bd81825b61a8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549763 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#832305}
-
Olesia Marukhno authored
This suite tests the Views bubble with the Cocoa browser window, but we haven't supported that configuration in over a year. Bug: 1148277 Change-Id: I5d4ceda74d7c15ae0df9eaa619b29e50a4a934ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550812Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#832304}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/42433abb9596..e644010395ee 2020-12-01 primiano@google.com install-build-deps: add gn+ninja+clang-format prebuilts for windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879 Tbr: perfetto-bugs@google.com Change-Id: I6e137e0e2da51d0fd9be800631dbdbb6c2ad4edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832303}
-
Francois Beaufort authored
This CL removes the unused callback of NFC client CancelWatch method and cleans some stuff. This has no functional changes. Bug: 1151857 Change-Id: I66e96efd23ec72330410b39e9c19e7f68d1431b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557083 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ec8113a86a79..9cfe927efca2 2020-12-01 szuend@chromium.org Add Trust Token tab for requests in the network panel 2020-12-01 bmeurer@chromium.org Preserve absence of column number when persisting breakpoints. 2020-12-01 alexrudenko@chromium.org [DarkMode] turn off legacy patching for imagePreview.css 2020-12-01 jacktfranklin@chromium.org [Dark Mode] migrate sources/sourcesPanel.css 2020-12-01 alexrudenko@chromium.org Use deviceEmulationFactor to position grid labels 2020-12-01 mathias@chromium.org [Dark Mode]: migrate accessibility/accessibilityProperties.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1055327,chromium:1126824,chromium:1151864,chromium:1152736,chromium:1153123 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9111a48dbbdfb90f617f0ff6428a76c23b2c18dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567811Reviewed-by:
-
Francois Beaufort authored
This CL removes the unused method CancelAllWatches() that used to cancel all watch NFC operations. It also removes one duplicated web platform test that was referencing obsolete NDEFScanOptions id. Change-Id: I1a702cae22b7525a9229da818bec91255a273f4b Bug: 520391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554575Reviewed-by:
-
Yoav Weiss authored
This is a reland of [1], which got reverted in [2] due to a mix or regressions and progressions on the bots. I'm now re-attempting to land this with a Finch trial. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1953204 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2023497 Bug: 788757 Change-Id: I5193d6a00dae358c047a87478abfadbccccb2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560124Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#832299}
-
Sam Sebree authored
[Controls Refresh] Implement test coverage for dark mode scrollbars are not dynamically updated bugfix Due to time constraints, the following CL was landed without full test coverage: https://chromium-review.googlesource.com/c/chromium/src/+/2522563/7 This CL adds proper test coverage for the change. Bug: 1148004 Change-Id: I693c7dcb3d1d9c250e730eba1f63212f9caf4349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564600 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#832298}
-
Jasmine Chen authored
This CL makes VmPermissionService pass tokens to CameraHalDispatcher for client authentication. PluginVm. Bug: b/170075468 Test: build and deploy simplechrome, packages and verify camera works in Change-Id: I8d51fb4ca6f82cc5648125fe8552a6f04a99ef5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532477 Commit-Queue: Jasmine Chen <lnishan@google.com> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#832297}
-
Alex Rudenko authored
The order of transformation makes a difference when device parameters such as deviceScaleFactor don't equal 1. Bug: 1151864 Change-Id: I7d0b5fc2a19b5d1ab18053068b190aff7c7f2079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563477 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#832296}
-
Manuel Rego Casasnovas authored
If the bottom-down corner of an element's overflow rect is before the top-left corner of the containing block, we cannot reach it with scroll and it shoulnd't be added to overflow. But if that happens only in one axis but not in the other, we still need to add it to the overflow. This patch changes the return condition to be an OR instead of AND. The test is passing without this patch, but this has caused regressions before LayoutNGLayoutOverflow was enabled and we were avoiding to compute the overflow of positioned elements twice (r809272). BUG=1150774 TEST=external/wpt/css/css-position/positon-absolute-scrollable-overflow-001.html Change-Id: I84afd63178ae23d07b14e93add78295c2e737a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562845Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#832295}
-
Sean Harrison authored
Add an additional pref to indicate whether the device in question has the privacy sandbox settings UI available. Modify the 2 existing prefs to be syncing. Create an OWNERS file for chrome/browser/privacy_sandbox, and add some members of the chrome friendly settings team to it. Bug: 1152336 Change-Id: Ie39a763a703fc2c2ee092d14513fca31784037ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565572Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#832294}
-
Francois Beaufort authored
This CL removes all code related to the ended origin trial for Web NFC. See "Changes done after Origin Trial (OT)" section at https://github.com/w3c/web-nfc/blob/gh-pages/EXPLAINER.md Bug: 520391, 1131141 Change-Id: Id34926a0db53462271d88572204cb50a3b4a1bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554598 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
dpapad authored
polymer_modulizer() will process a commented out HTML import statement and convert it to a non-commented JS import statement. For example: <!-- <link rel="import" href="bar.html"> --> will become import './bar.m.js'; Note this CL is only adding new test cases, as the feature itself was already (accidentally) working. This feature is meant to be leveraged in cases where an HTML import does not actually exist in the Polymer2 version of the code, which is happening for some files in FilesApp's case. Fixed: 1152687 Change-Id: Id3a38a1753bdb4a0e7edbfb8d4deacc542d1c489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560805Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#832292}
-
Harald Alvestrand authored
This uses the function for creating a PeerConnection that returns an error, rather than returning a null pointer only on error. This allows to differentiate what went wrong when construction failed, such as when failing to parse an ICE server URL. Bug: webrtc:12238, chromium:1044901 Change-Id: I8b634ddb002fb6123b3b7c8e3109661adcb98e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563600 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#832291}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ccd0b7e15e47..df873e5fa6d3 2020-12-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2232da5c to db49fa80 (475 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ib77663bb384f4d385d419ccac27d7b4acd22688d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567665Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iec1488062d71d9275649ef0be4915b0620648008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567668Reviewed-by:
-
Francois Beaufort authored
This CL replaces NotAllowedError with InvalidStateError DOMException when Web NFC interfaces are used in a non top-level browsing context. Spec: https://github.com/w3c/web-nfc/pull/610 Bug: 520391 Change-Id: I1aba5440d34664f65b321f8425609cc7e74488f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560267 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
Peter Marshall authored
This was going to be used for HaTS surveys in the DevTools frontend but we ended up going with a different implementation where we share code with the browser implementation, so we don't need our own API key anymore. This was never used as it was just added in preparation. R=msarda@chromium.org Bug: 1112738 Change-Id: Ibb92f40bdb1bad23b90320c5021c642961040e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560499 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a827aa2c29aa..a6a7e46e5451 2020-12-01 shaobo.yan@intel.com Enable CopyTextureForBrowserTests on Vulkan/Metal Backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Id1a3934ccf9aa65882a5b1085036fd67708d89d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567662Reviewed-by:
-
Anastasiia N authored
Show device account separate from secondary accounts on Account Manager page in Settings. Screenshots: http://screen/9i9gfgQEoNQVHW2, http://screen/9H2JVQ8iNG7v2ZM (child), http://screen/UDEYqQmEoLXLXcb (managed). Bug: 1144113 Change-Id: Ie1773486fd46c7149ab5a14c6ca16e496a1bc259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547291Reviewed-by:
-
dpapad authored
Upon entering Presentation mode: - Disable scrolling and hide scrollbars. - Disable zooming with ctrl+wheel and pinch gestures. - Force fit-to-height. - Next/previous page can be shown using the left/right keyboard arrows. The following known issues - Zooming is still possible with ctrl+/- - Rotating is still possible via ctrl]/[ - Using the scroll wheel does not update to the next/previous page will be addressed in a follow up CL. Bug: 1148478 Change-Id: I8b0e3b9ea6c3ed6738bc07f313935c7ea4d770a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539741 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#832284}
-
dpapad authored
Part 3 affects a subset of files that need preprocess="true" and not flattenhtml="true". Specifically files affected in this CL use <if> statements, but no <include> statements. Bug: 1152343 Change-Id: I7bc674ad5085738299bf4c6d30702afeeb48902d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565185 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
Antonio Sartori authored
This CL stores the raw values of the parsed Content Security Policies directives into the mojo types. This is yet another step to align the mojo types to Blink's CSP implementation, where the raw values are used for reporting and for console messages. Bug: 1021462,1149272,1149926 Change-Id: Iee34cba2fad3a98a483a5e0e9898ce90a5754ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546541 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#832282}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/56dbd799f56d..ec8113a86a79 2020-12-01 mathias@chromium.org [Dark Mode]: migrate accessibility/axBreadcrumbs.css 2020-12-01 mathias@chromium.org [Dark Mode]: migrate accessibility/animationTimeline.css 2020-12-01 andoli@chromium.org Migrate elements/ extensions of type 'setting' 2020-12-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103,chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2b870b1cedf178f66af4ad9d1a32b234c47a7985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567660Reviewed-by:
-
Peter Marshall authored
Bug: 1112738 Change-Id: I4bba96de7a669797ee32d0b6fab7b9d5501dc6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560099Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#832280}
-
Morten Stenshorne authored
We do not even attempt to honor orphans or widows requests during the initial column balancing pass (since we have no idea which column is going to get which content). Detect unappealing break points during layout instead, and stretch the columns if possible when this happens. This is different from the legacy fragmentation engine, which does this during the initial column balancing pass, but this approach doesn't work so well, since we'll have no idea which lines end up in the same fragmentainer, and the lines may have different heights; see crbug.com/1013151 Also stretch if possible if we violate any break-{after,before,inside}:avoid rules. Note that it was already working for break-inside:avoid, but not for break-after or break-before. css/css-multicol/balance-orphans-widows-000.html also passes without this fix, but it fails in the legacy engine, due to column over-stretching described in crbug.com/1013151 css/css-multicol/balance-break-avoidance-000.html also passes without this fix, but I couldn't find any test like this (break-inside:avoid and how it affects column balancing), so here it is. Bug: 1013151, 1066380, 829028 Change-Id: Ic4fca68644864b8209d49fa5f0d62d6079e6c0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566810 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: -
Harvey Yang authored
As InitTabletPowerButtonMembers should be called in tablets and convertibles, and clamshells won't get any accelerometer samples, the logic can be simplified to trigger it when receiving on the first accelerometer sample received. BUG=b:174124714 TEST=unit tests Change-Id: I0d0df6cffd668832f1fd7e9449335a6605f65ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557939Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#832278}
-
