- 24 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a629d81faa7a..ae003f552e4e 2020-11-24 heiserya@google.com Telemetry-on-lacros fixes: If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1149629 Tbr: oysteine@google.com Change-Id: Ie2341fb8e08ba6b6655f73d8c97e9b911ad748d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558999Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830748}
-
Yi Gu authored
The test has been flaky on all platforms: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=accessibility/aom-click-action.html TBR=aboxhall@chromium.org NOTRY=True Bug: 1134459 Change-Id: I795f7a7b21eef84a24d5b56e42240604e863ff8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559375Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830747}
-
Liquan (Max) Gu authored
This change is to make shouldSkipShowingPaymentRequestUi ready to be moved into PaymentRequestService so that WebLayer and Chrome can share the logic. Changes: * made the following methods static: - shouldSkipShowingPaymentRequestUi - onlySingleAppCanProvideAllRequiredInformation * adds PaymentUiService#getPaymentAppsInPaymentAppList. Bug: 1025619 Change-Id: I50c0b91b8f2b9ec0886ff43d1978a58d887a5f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556903 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830746}
-
Daniel Cheng authored
Change-Id: Ifed7f2588cbd1dd57af399436e47b01fc5135c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125432 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830745}
-
Gavin Williams authored
On completion of a scan job, return the file path of the last scanned file to the Scanning App. Will be used to open the Files app. Bug: 1059779 Change-Id: Ia3d33155daf472fc65fa2a959c068caddb3bff2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545743Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#830744}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c5dd5d863c4..64e80769c4c7 2020-11-24 ehmaldonado@google.com [owners] Sort owners by distance If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Ibae732973b737f07a1a24487391f906c5c918557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559134Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606218923-28e4a6cb560c6a9acc44daf784662f70e5c57403.profdata to chrome-win64-master-1606229875-9be2cd912654833e55877c29390e1b8095877a20.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id21803f250b1732496a7e83ff927510fdd70b79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558770Reviewed-by:
-
Dave Tapuska authored
All methods have been moved into the base object so now we can construct WebFrameWidgetImpl always. This is steps 6-8 in https://goo.gl/7yVrnb. Eventually WebFrameWidgetBase will be colapsed with WebFrameWidgetImpl. BUG=1097816 Change-Id: I364266758390c3b51e12ca5accd74df547ba2d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552551 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830741}
-
Xinghui Lu authored
Bug: 1097310 Change-Id: I5e91dbe8623f796a132671eb23a7a4ef9ce26ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558758 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#830740}
-
Richard Chui authored
This CL introduces animations that change the opacity of the cature bar while in region mode. The opacity is changed based on where the cursor is hovering, and whether or not the selected region intersects with the capture bar. Test: manual, added new test Change-Id: I730617c5ce311309353ededc3850be53ec538dca Fixed: 1150079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545610Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Richard Chui <richui@chromium.org> Cr-Commit-Position: refs/heads/master@{#830739}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Icc41f410f1e81b79d76a80a2653fbc54d4a23890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532994 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830738}
-
Taylor Bergquist authored
The NTB's insets are no longer horizontally symmetric, so they need to be flipped when hit testing. Bug: 1148176 Change-Id: I1d61592221e9b825927a8f16d93c7640642a9bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547310Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#830737}
-
Nick Burris authored
The google_pay drawable will soon be used by the downstream payments component, so the resource first needs to move into components. Bug: 1150971 Change-Id: Ib69b7781b7afe17114a35b25e1e048b2b71bcece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555505Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#830736}
-
Jeffrey Kardatzke authored
BUG=b:153111783,chromium:1152523 TEST=Fuzzer passes Change-Id: I27f353116d6703b065cecef527c24487f627f67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558788 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#830735}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f66650677465..b1da4494cc50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yigu@google.com,ezemtsov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1139098 Tbr: yigu@google.com,ezemtsov@google.com Change-Id: Ie2055e1ee7d598c0c4d6e3d56facfa68a50525de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558839Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830734}
-
Shuran Huang authored
There will be a follow up CL to replace the current use cases of FromOrigin(). Bug: 1145294 Change-Id: I606d75901f8c4012df285d14627533bbf5dfc20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557224 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#830733}
-
Joel Hockey authored
TBR=jamescook@chromium.org Bug: 1152128 Change-Id: Iaa85708fe65d89099013859416fef2155a04c6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557764 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#830732}
-
Igor Ruvinov authored
Add check for various local sync proto file issues (access, memory, file in use, file/path not existing) prior to serialization. Implement UMA histogram logging and improve debug logging to better communicate errors encountered during opening of the file. Bug: 1049091 Change-Id: I0658e40d0e3a16cc171a3e1523e211151d569315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552888 Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#830731}
-
Erik Staab authored
We're only testing arm64 binaries now and have additional capacity. Bug: 1139038 Change-Id: Id1a5f9d03276f24173af2c42b5abd99db46d9fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557227Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#830730}
-
Alex Ilin authored
This CL makes the following updates to the chrome.identity documentation: - getAuthToken(): clarify that the grantedScopes callback parameter is available since Chrome 87, instead of vague "in future versions of Chrome" - clearAllCachedAuthTokens(): improve list formatting Bug: 1100535, 1125847 Change-Id: I687a27a62e90953647a441e585a69a50f77537b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556522Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830729}
-
tby authored
Now that keys and IDs are associated with projects, not events, the documentation and method signatures in key_data is out of date. I've also changed the name of HashForEventId to HmacMetric, since it was a bit cryptic. Note that HmacMetric still operates on the values of an event, not a project. Bug: 1148168 Change-Id: I4bc8e6360917f4b4f141aaad9a11e5485954871f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554193Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#830728}
-
Alex Turner authored
Scripts can contain a 'sourceURL' to act as the identifier for debugging tools. However, resources fetched with an ad script at top of stack are not tagged as ads when that ad script has a sourceURL. This is because ScriptAtTopOfStack() checks GetScriptNameOrSourceURL() and the sourceURL takes precedence when present. This sourceURL is then compared to the actual resource URLs stored in known_ad_scripts_, resulting in no match. We thus switch to using GetScriptName() instead, which will return the expected resource URLs. We additionally add tests for this case. See crrev.com/c/2550504 for avoiding performance impacts. Bug: 1127391 Change-Id: I9ad24cbfbeaca952c9a2dec951337b6bbe574439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551259 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
-
evliu authored
This CL extends the expiration of the WebVTT histogram metrics, which will be useful gauging the usage of WebVTT on the web and prioritizing future investments in the area. Bug: 1140006 Change-Id: I7d91609685518aed61140535766aa8cf77b16bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542772Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#830726}
-
Mikel Astiz authored
No behavioral differences: these appear to be old occurrences that predate the broad adoption of std::unique_ptr in the codebase. Change-Id: I28ff0e7ac91c8545b3b3cea748ba0681366b48a9 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556943 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#830725}
-
Kushagra Sinha authored
Bug: 1129543 Change-Id: Iff72bf9198d628da3c5a13cea5961a98b15a009e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505140 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#830724}
-
Curt Clemens authored
Remove a line that sets |selectedShareTarget| null on the discovery page so that the selected share target is preserved on the confirmation page. Adjust margins and fix vertical centering of content on the confimation page. Allow the content to expand horizontally instead of fixing the width. Screenshot: https://screenshot.googleplex.com/B7Dc6rZPPSHkTip.png Bug: b/163036847 Change-Id: Ie41d7a18026f72c621c7f5801f16f5c09dabdb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555803 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#830723}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I9ecce601b7842c1a7a38a78c08511ca39cf1499f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559001Reviewed-by:
-
Alexander Surkov authored
ui/base/buildflags defines accessibility flags which makes content accessibility_buildflags excessive Bug: 1133330 Change-Id: I0a48e4320b17e01c2642817dff5eb2550e9186bf AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547203 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830721}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/6cd6f7462c49..12ed862c7ef2 2020-11-24 bclayton@google.com Add fuzzer instrumentation when building fuzzers 2020-11-24 dneto@google.com spirv-reader: Add a disassembler helper 2020-11-24 bclayton@google.com reader/wgsl: Abort after raising too many errors 2020-11-24 bclayton@google.com ast/module: Additional documentation for type methods 2020-11-23 bclayton@google.com writer/spriv: Add an assert that functions_ is not empty 2020-11-23 bclayton@google.com fuzzers: Add dictionary 2020-11-23 bclayton@google.com Improve error message when suffixing float with f 2020-11-23 bclayton@google.com Add create<T>() method to Module for types 2020-11-23 bclayton@google.com Move TypeManager from tint::Context to ast::Module 2020-11-23 bclayton@google.com Move type_manager to the ast dir/namespace 2020-11-23 dneto@google.com spirv-writer: Fix phi for short-circuiting operators If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I2a8b484a7f71e7eefbfdbf66cf521aa0b4ee4c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558990Reviewed-by:
-
Alexander Hendrich authored
Instead of mapping the device policy to a pref in local state and then having extra handlers for it, we can simply remap the device policy value to the equivalent user policy (WebUsbAllowedDevicesForUrls) for the sign-in profile using LoginProfilePolicyProvider. No idea why I chose to use local state back then. Bug: 1151344 Change-Id: I57cc39345fa9ec7a1138370212f3ddd4b334e423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552408 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830719}
-
Hiroshige Hayashizaki authored
This is to unify the behavior of classic script evaluation code paths, because other callers of ExecuteScriptAndReturnValue() (for isolated worlds and workers) don't have corresponding `EscapableHandleScope`s. This CL is unlikely to affect GC performance, because: - The `EscapableHandleScope` was originally introduced in https://codereview.chromium.org/314953005/ that is not performance related. - ClassicScript::RunScript(), which is the primary caller of EvaluateScriptInMainWorld(), has already a `HandleScope` covering the same region. Particularly, script evaluation via `<script>` shouldn't be affected by this CL. Bug: 1111134 Change-Id: I599042b8172b393f4108317c5c349d256784a20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544078Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#830718}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/751250705016..bc75ebb1afc4 2020-11-24 johnstiles@google.com Fix crash with boolean vectors in is_constant<T>. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: adlai@google.com Change-Id: I0998f87399f5ecc3841302f3e09d8aedb3fe45cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558773Reviewed-by:
-
Collin Baker authored
Some IPH promos want to customize their text at runtime, based on where it's showing. For example, a PWA install promo may want to include the app's name to be more clear to the user. This CL adds the infrastructure required. While it is a work in progress, this adds support for filling one placeholder in a string resource with a provided string. In the future, including icons in promo text is desired. The infrastructure in this CL is a step toward this. Bug: 1143971 Change-Id: Ica58bc92c59498b18fa1e988e1c3b1f1725bf413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551573 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#830716}
-
Eugene Zemtsov authored
More tests that are flaking on Win7 32. Failure examples: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/66823 https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/66824 TBR: dschuff@chromium.org Bug: 1059468 Change-Id: If7acfba0252f1dacf39b81826bba261e7ed28111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558841Reviewed-by:
Eugene Zemtsov <ezemtsov@google.com> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#830715}
-
Gordon Seto authored
Add UI for informing when an activation code is invalid in the activation code page. Screenshot: https://screenshot.googleplex.com/3gLCppUSwZbqovc.png Bug: 1093185 Change-Id: Ieb9959cdbd0dd754454eaa69d5c5f4ac5453c8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555917 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Sophey Dong authored
This is a reland of 974e1b68 Original change's description: > Remove enable-send-tab-to-self-omnibox-sending-animation flag. > > This bug fix has been launched since M84. > > Bug: 1124205 > Change-Id: I99dd4b7edbab9443c10169144f5ecf3b115c74f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391508 > Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> > Commit-Queue: Sophey Dong <sophey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819562} Bug: 1124205 Change-Id: I52065dc2e1dd4938a3bd7efc5232fc5959a203ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542733Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#830713}
-
Daniel Libby authored
These need to be updated, same as the Win10 baselines in crrev.com/c/2529950. Bug: 1151844 Change-Id: Ibaf1f2bb084bc4c9295e6dc74370c9939fd63207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556013Reviewed-by:
Alex Keng <shihken@microsoft.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#830712}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/35f663e4..3b5297a4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I333255238abe114c30fbe0c2a9179e753c1b8706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558893Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830711}
-
Nina Satragno authored
Fix a bug where trying to set a new PIN on a security key shows the update PIN dialog instead. Attempting to use that dialog results in a CHECK, since a PIN that is not set in the first place can't be changed. Fixed: 1152548 Change-Id: I375b4b550009726fe3ec865400443871cda1ea2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558916 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#830710}
-
Ivo Creusen authored
This is a useful metric that is in active use. Change-Id: I2d8cacbe5aa1fe30ffa71826841d18342d4f4695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558417Reviewed-by:
-
