- 14 Nov, 2019 40 commits
-
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/chrome_content_browser_client_unittest.cc This CL was uploaded by git cl split. Bug: 1018667 Change-Id: I08e044ff1aac9d05677a3041f5f757dca61124ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916870 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#715255}
-
Marc Treib authored
It didn't actually initialize anything, it was just used to pass in the user agent string. Might as well pass that into the ctor, and remove some plumbing. The original reason for this two-step initialization was apparently to move construction of the Sync user agent string off the UI thread. However, (a) even before this CL, the user agent string was in fact constructed on the UI thread, and (b) nothing in MakeUserAgentForSync looks like it could actually block. Bug: 951350 Change-Id: I691f85468988d27187dbfc9088020e10a875fd79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913258 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715254}
-
Alex Chau authored
- Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1905946 - Was reverted due to a flaky test, test is now disabled: https://crbug.com/1023950 - Disabled ClickToCall/SharedClipboard SyncTurnedOff browser test when UnidoOnSignIn is on as it no longer applies - Disabled Sharing registration when device is in local sync mode if deriving VAPID key as derived key is not available in local sync mode - Add DeviceInfo to allowed type in transport mode in sync_integration_tests when UnidoOnSignIn is on TBR=holte@chromium.org Bug: 1009516 Change-Id: Ia9be25489dd2e874754f3eb4527321f757468e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913403 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
-
Sam Zackrisson authored
This improves the WebRTC audio processing module adaptation on mono signals even when being played out on more than one speaker. Tested: made appr.tc calls with all combinations of mono/stereo audio, multi-channel feature flag on/off, APM in audio service enabled/disabled: verified that (locally modified) log statement for entering multi-channel is printed, verified that aecdump recordings have the right content, verified that not too much processing happens before stereo is detected Bug: chromium:1016708, chromium:1023337 Change-Id: Ia6827f26e01dba6779ab356687f7920ce9fa8703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906210Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#715252}
-
Gauthier Ambard authored
This CL makes sure that the SectionInfo variable isn't store in the "more" callback on the NTP. This is because the SectionInfo can be recreated for example when disabling/enabling the content suggestions. Bug: 1023793, 1024172 Change-Id: I8edb799baedb3d1dd811a57db77d07298d97533e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913257Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#715251}
-
Sylvain Defresne authored
With https://crrev.com/c/1912239, //third_party/breakpad no longer has any dependency on //third_party/google_toolbox_for_mac (it no longer uses GTMLogger), so remove the deps. Add missing reference to "sqlite3" on //ios/third_party/firebase that was previously pulled transitively via google_toolbox_for_mac. Bug: 1012115, 1024322 Change-Id: I963470cd5a327edb2562a873fcc283eb46b2af6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913414 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#715250}
-
Dominique Fauteux-Chapleau authored
Since testing special DM token values like INVALID_DM_TOKEN may require manually setting the DM token this makes it safer, otherwise the editor might add extra useless whitespace and mess with testing. Change-Id: I50ceafe7fa03d39c0ea8e24f80418805f3d8639a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913871Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#715249}
-
Gauthier Ambard authored
Bug: 991608 Change-Id: I7f5c8481309bf2f3be8d98586746d7db1e43f4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914387 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#715248}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ae55a94ff52c..515f9bebd1f8 git log ae55a94ff52c..515f9bebd1f8 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src ab3cdcaef56e..3da910d55f20 (3 commits) Created with: gclient setdep -r src/third_party/angle@515f9bebd1f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: Ic93e03b0559a1bf5d701b1ffd94e99379e9e8d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715247}
-
Asanka Herath authored
This CL inches closer to merging the NTLM and Negotiate handlers which basically implement the same logic under different names. Servicification of Negotiate handling will then not have to deal with NTLM and Negotiate authentication schemes separately. R=mmenke@chromium.org Bug: 991265 Change-Id: I167d4fb5856f65319fe7c21636e6e4db61aa46a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907151 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#715246}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/06d9a50ca1e5..9129fad98516 git log 06d9a50ca1e5..9129fad98516 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 lalitm@google.com trace_processor: add special handling of constraints on sorted cols Created with: gclient setdep -r src/third_party/perfetto@9129fad98516 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I68c7b2bb65dc934da9f4dd40ea0ae5493ebf4aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916625Reviewed-by:
-
Gauthier Ambard authored
Those tests should follow the style guide. Bug: 1023877 Change-Id: I81ba3f106426fd04d0ad256cc90b7c2dc8325d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916859 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e7498a38. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I8d04fb94f036de323034ca3859ac0f4712704505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916640Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715243}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dda10ea5191d..c49e3c72fe42 Created with: gclient setdep -r src-internal@c49e3c72fe42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic681dd18ae25c3dbd24f03049aceee61886baf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916624Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715242}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/00fc2231f697..f6fc149b0b16 git log 00fc2231f697..f6fc149b0b16 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 khokhlov@google.com Reland "Remove had_failures from benchmark metadata" Created with: gclient setdep -r src/third_party/catapult@f6fc149b0b16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:990304 Change-Id: Ib92d5b9838eafa38065661b6be9ab6138d96f7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916621Reviewed-by:
-
Mathias Carlen authored
Before this patch, empty strings would be filtered before sent to the UI. The result of that was some tell_actions with single space ' ' messages to clear the status bar. This patch removes that constraint and empty strings will just remove the status message shown. As I drive by there's now a unittest for the tell action, even if that's going the wrong way in the stack ... R=arbesser@google.com Bug: b/143757287 Change-Id: I843a0cf36e246c4480de4ffa8fe59709ef576bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911211 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#715240}
-
Robbie Gibson authored
When the animation is on, there is a bug where if the user swipes left-to-right to go to the next Voiceover view during the animation, the Voiceover cursor ends up on view from the previous tab grid page, instead of the next tab grid page. This happens because the previous tab grid page's views are still accessible during the animation. To prevent this, the animation can be turned off when Voiceover is enabled. This means that when the user selects a new tab, the views immediately update. Bug: 978673 Change-Id: Id4b64f391614b8719e3f5d5d2e924df7d8983123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906348 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715239}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I21a695d9ca8a5cf376d14e10165c29dcd50fc1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916622Reviewed-by:
-
Martin Robinson authored
Instead of returning the previous text selection extents for unfocused text inputs in the ATK API, return an empty selection which matches what the visual selection shows. Bug: 1015354 Change-Id: I767f44dc52df3e4de579f6c4e6a027d72630d60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886811 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#715237}
-
Shivani Sharma authored
To experiment split cache/network stack using etld+1 this CL adds support to the Network Isolation Key to replace origins with scheme://registrable-domain. It also adds a new feature which controls whether etld+1 will be used or not. Added browser and unit tests. Bug: 1018718 Change-Id: I02adf6bbb679154c99cf4b7a1ae10ba46da00067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913062Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#715236}
-
Mike West authored
This reverts commit f5946a0a. Reason for revert: `LocalNTPJavascriptTest.RealboxTests` has failed every ChromeOS ASAN run (https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29) since this patch landed, starting in https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36112. Original change's description: > Local NTP, Realbox: fix navigation to chrome:// URLs > > Partially borrowed from https://crrev.com/c/1836021 by Archana Simha <archanasihma@chromium.org> > > Bug: 1020025 > Change-Id: I7de22a41d872ec624f25d1633782d27448988c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893824 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715106} TBR=dcheng@chromium.org,nasko@chromium.org,dbeam@chromium.org,bokan@chromium.org,mahmadi@chromium.org Change-Id: I7552853a29abc63c667e949f9147bd76ad4e9d69 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916861Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#715235}
-
Rune Lillesveen authored
We would like to return empty styles for elements which are connected but not part of the flat tree. That is, shadow host children which are not slotted or any nodes in its flat subtree. Bug: 831568 Change-Id: Ifd6ab89196a83571044ca995198e3e31c904304e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916460 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#715234}
-
nancy authored
Use the unified time format function to show the time limit in the app pause dialog. For example, hour = 1 minute = 1 Show: You can use it for 1 hour and 1 minute tomorrow. hour = 11 minute = 59 Show: You can use it for 11 hours and 59 minutes tomorrow. hour = 10 minute = 0 Show: You can use it for 10 hours tomorrow. hour = 0 minute = 10 Show: You can use it for 10 minutes tomorrow. hour = 0 minute = 0 Show: You can use it for 0 seconds tomorrow. BUG=1011235 Change-Id: I27619b2b7f999c68eabff6a337e9d54eb661db86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913360 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#715233}
-
Trent Apted authored
This is a better fit for layering/encapsulation/ownership. The tradeoff is some "slippage" in resource_ids. Bug: 996088 Change-Id: I6b5f03460c01e979da018dec757f88452a42adbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913284Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#715232}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0cbfc427a7df..06d9a50ca1e5 git log 0cbfc427a7df..06d9a50ca1e5 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 lalitm@google.com trace_processor: fix sort setting flags on correct columns 2019-11-13 treehugger-gerrit@google.com Merge "processor: Ignore track events with absolute 0 timestamp" 2019-11-13 lalitm@google.com trace_processor: add benchmarks for sorted columns Created with: gclient setdep -r src/third_party/perfetto@06d9a50ca1e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627,chromium:135177627 Change-Id: I734f1e09c24e18070eb74246507e28290370a18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916620Reviewed-by:
-
Stefano Sanfilippo authored
Change-Id: I20ce9961645deb44bab857d69a1c641600646d65 Bug: 940927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911206 Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Auto-Submit: Stefano Sanfilippo <ssanfilippo@chromium.org> Cr-Commit-Position: refs/heads/master@{#715230}
-
v.paturi authored
Inline SVG images do not have an Image object associated with them, so they do not go through the regular dark mode image classification that non-inline SVG images would. With the current design, the shapes belonging to the same image might receive different classifications in dark mode. So until there is a way to properly classify an inline SVG image by considering all its individual shapes, do not invert any part of that image. Bug: 963998 Change-Id: Ib946c3c1ff7cdce08d2f5af9cca8542ccb9c91fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893111Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Commit-Queue: Varun Chowdhary Paturi <v.paturi@samsung.com> Cr-Commit-Position: refs/heads/master@{#715229}
-
Patrik Höglund authored
This converts the old RESULT lines to the new perf test reporter. It would be hard to port the result reporter to WebRTC, so let's keep the WebRTC code ignorant of that. Bug: chromium:1874811 Change-Id: I524fd3f24fa2739043e4facfa93cb1300a22a5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899865Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#715228}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c2f0287a28a4..ff11d441ccdf git log c2f0287a28a4..ff11d441ccdf --date=short --no-merges --format='%ad %ae %s' 2019-11-14 kevinptt@chromium.org Drallion: sign factory install shim Created with: gclient setdep -r src/third_party/chromite@ff11d441ccdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4594be3af1b2d64ca74ce0e5fd9a3f477c0a942f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915825Reviewed-by:
-
Alexander Hendrich authored
This CL modifies the protected interface class check in WebUSB to make an exception for HID devices when the request is originating from the first-party Imprivata extensions (login screen and in-session extensions, both in dev/prod versions). BUG: 995294 Change-Id: If436bb1b8d19a74c47cb060cbda8e0e3a061531f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908544Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#715226}
-
Kuo Jen Wei authored
Fix width, height of video resolution option get swapped incorrectly by crrev.com/c/1874996. Bug: None Test: Verify the text of video resolution options. Change-Id: I575f26da394be89486c5af8db890623897c9f363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916181 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#715225}
-
Cherie Cheung authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ce25839e00e5..637fb0e5d071 $ git log ce25839e0..637fb0e5d --date=short --no-merges --format='%ad %ae %s' 2019-11-12 cherieccy system_api: Add |rootfs_writable| field to StartArcVmRequest. Created with: roll-dep src/third_party/cros_system_api TEST=Build is successful Bug: b:144154973 Change-Id: I609f60d321b334c9d82cdb7b8845d206f91ed92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915652Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Chirantan Ekbote <chirantan@chromium.org> Commit-Queue: Cherie Cheung <cherieccy@chromium.org> Cr-Commit-Position: refs/heads/master@{#715224}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cca19d9bd441..dda10ea5191d Created with: gclient setdep -r src-internal@dda10ea5191d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8114099d83fef3d79dc1e33d1d169c1983464e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915823Reviewed-by:
-
Bret Sepulveda authored
Unlike ToolbarActionsBar, ExtensionsToolbarContainer assumes the ToolbarActionsModel always exists. When the feature flag was enabled, this would crash any test that creates a BrowserView. To fix this, TestWithBrowserView initializes ToolbarActionsModel. Bug: 984654 Change-Id: I69df818c72f898dbf2e2bb7c80d3ac5bcc096c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901076Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#715222}
-
Olivier Robin authored
Starting with iOS 13, sourceApplication is only set when openURL is called from an application with the same team identifier. Oddly, it is also nil when calling from extension. Bug: 1020228 Change-Id: I9876647c30350e2242d20da2ab045805a9864932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903349Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715221}
-
Jan Scheffler authored
This patch adds a test to check that all loaded css files are shown in the coverage list view even when not (yet) covered at all. Fixed: chromium:949045 Change-Id: Idda4df73866590010d59f84cd4193c051fe1cc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903359Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#715220}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b52f05868c9..ae55a94ff52c git log 1b52f05868c9..ae55a94ff52c --date=short --no-merges --format='%ad %ae %s' 2019-11-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 88632cac30e1..b2407dd746de (3 commits) Created with: gclient setdep -r src/third_party/angle@ae55a94ff52c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: I555fec9c9e5ad84397a05e245ea3fbdcc4c546d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916140Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ab3cdcaef56e..3da910d55f20 git log ab3cdcaef56e..3da910d55f20 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 dneto@google.com Avoid uninit warning in GCC (#3044) 2019-11-13 bclayton@google.com utils/vscode: Add SPIR-V language server support 2019-11-13 bclayton@google.com utils/vscode: Add go language server packages. Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3da910d55f20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cnorthrop@google.com Bug: None Change-Id: Ie5023c33ec6f0df4407a634a29375fd7209bfc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916139Reviewed-by:
-
Marc Treib authored
- Add treib@ as new main POC while melandory@ is out. - Remove (comment out) previous owner pavely@. - Reduce duplication: Have chrome/browser/invalidation/OWNERS and ios/chrome/browser/invalidation/OWNERS refer to the "main" owners file instead of explicitly listing the same people. Bug: none Change-Id: I80524388818c26884c07928422b74d70e026076f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913404 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#715217}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/32f02045f037..c2f0287a28a4 git log 32f02045f037..c2f0287a28a4 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 bhogeswararao@google.com gwifi GroupEntry line length alignment. 2019-11-14 cjmcdonald@chromium.org Delete parallel_emerge_old Created with: gclient setdep -r src/third_party/chromite@c2f0287a28a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8e4bcb83c04637f2f1aea238a82a474c141c30f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915679Reviewed-by:
-
