- 24 May, 2019 40 commits
-
-
Andrew Grieve authored
--local-output prevents bug reports being generated when things go wrong (annoying for local dev), and causes html report to be generated locally (often not necessary, but sometimes useful) Change-Id: Ib089f3a496569904df4ccc5486fbf0e5403e428d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627527Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#663056}
-
Roman Sorokin authored
On Linux CFI TBR=takumif@chromium.org Bug: 966827 Change-Id: Ib18260b9a2efb5b63dd671ef9a94d0e76418b42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628713Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#663055}
-
Roman Sorokin authored
On Android CFI TBR=kinuko@chromium.org Bug: 966820 Change-Id: I2726d8e6e2a5c39ab683e682558b0198a1efbb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628730Reviewed-by:
-
Morten Stenshorne authored
Avoid false positives from DefinitelyNewFormattingContext(). If an OBJECT element ends up using its fallback content, we cannot claim that it's going to establish a new formatting context, just by looking at the element type. Then the OBJECT behaves just like any generic element. Always reporting that an OBJECT establishes a new formatting context, allowed the parent to use LayoutNG, although the OBJECT had children (e.g. a RUBY element) that require legacy layout. Letting NG and legacy cooperate in the same block formatting context is something we don't support. Bug: 966363 Change-Id: Ica9247e9936eb1dbdfc8dabdc96cdb2afdad5bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628711 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#663053}
-
Alexander Timin authored
With great power comes great responsibility. R=rkaplow@chromium.org Change-Id: I214f6eecf652d61eb62db903f341724be28ee1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627037Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#663052}
-
Morten Stenshorne authored
When we're not fragmenting, we shouldn't touch any of the fragmentation related values in the container builder. Added DCHECKs that would fail without this fix (and that will catch any similar problems in the future at an earlier stage). Bug: 966369 Change-Id: I8f6300435e211086fea8ea381912ad595e9a91ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628707 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Robbie Gibson authored
We want to check that the view is showing some icon in tests. This exposes a readonly property for that case. Bug: 963894 Change-Id: I2649ad4d4615cb41b4589cab6142978f747b97cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627375Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#663050}
-
Nick Harper authored
Removal requested via email and validated via DNS. Change-Id: I15c1dda89d2000084067ba5028da90c4de001293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625791 Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#663049}
-
sczs authored
- Never For This Site button has no longer a bold font. - Removes the separator between Save and Never For This Site cells. - Adds highlighting to these 2 buttons by making the Cell button UIButtonTypeSystem. Bug: 945478 Change-Id: If39e270a06a87d9631b9604946e8a2a91d3251bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627240Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#663048}
-
Jit Yao Yap authored
See the bug for the intended use case. Bug: 946980 Change-Id: I54a3750a63be1a169971ac545d73989aaab40ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611932 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#663047}
-
Caitlin Fischer authored
Bug: 957426 Change-Id: I15acd48fab75d670ff74c8855697db201119d5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623126 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#663046}
-
David Jean authored
Put a better fix for cross service request (incognito / normal). Test open in current or new tab. Test cross requests. Bug: 907527 Change-Id: I9e3032e1510ffeaf691506383b3baf14d956eab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625995 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#663045}
-
Arnaud Mandy authored
This change implements the controller management logic in DeviceOrientationEventPump and removes the dependency on PlatformEventDispatcher. Bug: 873761 Change-Id: I4546ad799160b5c941aac07d278ec74e81d98bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607807 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#663044}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/785b71d8..aabc54e8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If10175b26bb8e92f5b0bdcbc175411011b9dffe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626333Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663043}
-
Devlin Cronin authored
There are a few targets we can get to trivially pass gn check from //extensions/browser. Add them. Bug: None Change-Id: If8c18b57300d1c8a8246a85bcbfbfdec43b7a9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625859 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#663042}
-
Max Moroz authored
This change should've been uploaded as https://crrev.com/c/1623505, but somehow uploading failed on my end and I haven't noticed it back then. TBR=adetaylor@chromium.org Change-Id: I75eae549d6a8976e9ad8dcd550e065b22bf7211a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626334Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#663041}
-
Jihwan Marc Kim authored
So far, scroll stops if focused child node is removed while scrolling parent node. This is because the event handler passes the |MousePressNode|. If focused child node(|MousePressNode|) is removed, it will be null and scrollable area changed to document. |LogicalScroll| finds scrollable area from |MousePressNode|. If we save this scrollable area node, we can get one more chance to find proper node to scroll. Bug: 493078 Change-Id: I6e81ca0a0d15e0def66c8457840ca9e1343e8dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611620 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#663040}
-
Dominik Röttsches authored
This reverts commit 0e244ee9. Reason for revert: Causes flakiness in FontUniqueNameBrowserTest.ContentLocalFontsMatching Original change's description: > Share DWriteFontProxyImpl TaskRunner to DWriteFontLookupTableBuilder > > Preparation for a follow-up CL that actually making queries for the font > lookup table asynchronous. In that CL, DWriteFontLookupTableBuilder > needs the task runner to run the Mojo message callback on the same task > runner on which DWriteFontProxyImpl received it. > > Move scheduling the lookup table construction to > common_browser_interfaces.cc which is still around the same time in > startup as before, but makes it much easier to share the same task > runner. > > Bug: 960263, 889864 > Tbr: avi > Change-Id: I8be6d4a4d29014967d38f20ccf8a94948a7b8a1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626865 > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663021} TBR=avi@chromium.org,rockot@google.com,fdoray@chromium.org,drott@chromium.org Change-Id: Ie88de224e40862a3fa62618c553501e51aa29599 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 960263, 889864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628712Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#663039}
-
Vadym Doroshenko authored
This CL contains only text fixes: 1.Filling correct FormData 2.Tests that are not applied for the new parser left to be run with the old parser. 3.ProvisionallySavePassword -> OnPasswordSubmitted 4.Some minor implementation dependent changes in number of calls. Bug: 831123 Change-Id: I2fe77c002fd7756ca583dc8f753dc89a42650345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602637Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#663038}
-
Philipp Hancke authored
Modifies the SDP to pass an different fingerprint from the one that is used which results in a DTLS failure/alert as the fingerprint does not match the certificate. Bug: none Change-Id: Ice8adf70f57e7da02fc014bb43b0c78841bfd9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627362 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#663037}
-
Xi Han authored
In this CL, we update the flag to enable running PrefetchBackgroundTask in reduced mode. Bug: 933358 Change-Id: I43a063cd47da9003b911825a1646464237645b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622872 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#663036}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/21aa9632410d..111b91377eec Created with: gclient setdep -r src-internal@111b91377eec The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=yukishiino@google.com,lgrey@google.com,masonfreed@google.com,rsorokin@google.com Change-Id: Id2d72fcacaafcad8ce8571fd8dfdcaa95479e786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628454Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663035}
-
Ramin Halavati authored
TestingProfile::GetProfileType() returned GUEST_PROFILE for the regular profile of a guest session. This behavior was different from that of the ProfileImpl and OffTheRecordProfileImpl. Bug: 947933 Change-Id: I0323587abecd9c4f07d5e320cacf651ef01c1c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627365Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#663034}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f3db34d06074..ce723234bacf git log f3db34d06074..ce723234bacf --date=short --no-merges --format='%ad %ae %s' 2019-05-24 ilnik@webrtc.org Revert "VP9 screenshare: Don't base layers frame-rate on input frame-rate" 2019-05-24 ilnik@webrtc.org VP9 screenshare: Don't base layers frame-rate on input frame-rate Created with: gclient setdep -r src/third_party/webrtc@ce723234bacf The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4d935ac52fca5ec78631417680d08884ebb3f2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628452Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663033}
-
Maksim Moskvitin authored
This CL implements GetData() modulo we have no support for some NigoriSpecifics fields yet. GetData() implementation should unblock implementation of SetEncryptionPassphrase(), since it allows to obtain EntityData from current in-memory state. Bug: 922900 Change-Id: I739935a10be2637c09406a8deb4d1df50cc57013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622805 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#663032}
-
Friedrich Horschig authored
This is a reland of 2385ddd3 Original change's description: > [MFill Android] Retrieve addresses for sheet on native side > > This class adds the Address controller that collects data for the manual > fallback sheet on Android. > It does work similar to https://crrev.com/c/1599927, and the existing > PasswordAccessoryController. All three classes should be fairly similar > in behavior. > > The interface leans on the draft implementation of the bridge which > currently pulls data and might need changing to pushing data - I am open > for suggestions. > > Bug: 962548 > Change-Id: Id4c593a7af9eda815be16a85354bcfe241bc731f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614200 > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662658} TBR=tmartino@chromium.org Bug: 962548 Change-Id: I67a78eb3c8097ba7783f3c6f369f491be337bef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628609Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Matthew Cary authored
Change implementation of webrtc::SharedMemory to use base::UnsafeSharedMemoryRegion. Should not change any functionality outside of changing a read-only mapping of shared memory to be a const mapping, as the former is no longer supported by the chromium shared memory API. Remoting: upgrade remoting/host shared memory to new API. Bug: 795291, 961119 Change-Id: Iff24e1a6fd780d6f6b1618f20a588dbd596541f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602502 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#663030}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d68aff6c7482..de15ed370d53 git log d68aff6c7482..de15ed370d53 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 27ec91958501..66e46037d74f (1 commits) 2019-05-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src d9c00e1d2de1..b8fe7211c465 (5 commits) 2019-05-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-headers/src 9674a1a54754..7f4277e21b52 (1 commits) Created with: gclient setdep -r src/third_party/angle@de15ed370d53 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: I28f4047487376a5d291b2d9c9e41766a878a52d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628670Reviewed-by:
-
tzik authored
Mojo interfaces for WebLocks API used to use the default TaskRunner instead of the frame-associated one. That causes a test failure on an upcoming change for per-site EventLoop. This CL updates the interface set up to use per-frame TaskRunner. Bug: 961186 Change-Id: Icf75d959edc7817a445636d56ec8ffece5b1ceae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626201 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#663028}
-
Pâris MEULEMAN authored
This CL adds tests to Oauth2TokenServiceDelegateAndroid to improve overall coverage and remove the need of the java Oauth2TokenService.OAuth2TokenServiceObserver. This was part of https://crev.com/c/1602715 Bug: 960281 Change-Id: Ie3027682128d6a1bc6acea3bab1b49b3d59989eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609839 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#663027}
-
Tobias Sargeant authored
If an exception is thrown in onRenderProcessGone, then it should be propagated back to the UI thread message loop so that it is observable by the application/debuggerd as something other than a native crash. Bug: 592556 Change-Id: I28b6792c4503347092ce4e79370b20de87c51114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585881 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#663026}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff5c0bfd8dc2..21aa9632410d Created with: gclient setdep -r src-internal@21aa9632410d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=yukishiino@google.com,lgrey@google.com,masonfreed@google.com,rsorokin@google.com Change-Id: I05621967ceb088d24c9f0921ec70e5bdd0c9db08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628669Reviewed-by:
-
Clemens Arbesser authored
Previously, a single callback was invoked, no matter whether the user cancelled or confirmed the dialog. This made it impossible to distinguish the successful edit of a previously complete item from a cancelled edit, because in both cases, the callback was invoked with the same argument. This CL also fixes a bug in Autofill Assistant caused by this behavior: cancelling the edit of a complete item should not auto-select that item (see b/132077559). Note: the Chrome PR does not have the same problem, because the 'edit' icon is only available for the currently selected item. Thus, it is impossible to edit a currently unselected item. There is a similar issue for incomplete items, which is out-of-scope for this CL (see bug for details). Bug: b/132077559 Change-Id: I3ef79397a7be902b6e616c984e7770d6ce6fc9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603059 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#663024}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bffe9927..785b71d8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I064ec4543d342926b8613415d28ffe6c10e13c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628648Reviewed-by:
-
Henrik Boström authored
This exposes RTCAudioSourceStats and RTCVideoSourceStats, which are the RTCMediaSourceStats dictionaries, to JavaScript. Implementation in WebRTC here: https://webrtc-review.googlesource.com/c/src/+/137804/ This CL also re-enabled WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise and external/wpt/webrtc/RTCPeerConnection-track-stats.https.html which were temporarily disabled due to blocking the WebRTC CL from rolling. Bug: webrtc:10453 Change-Id: I1c97a9798301c48437982fb656a1bdf5fbcabb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621912 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#663022}
-
Dominik Röttsches authored
Preparation for a follow-up CL that actually making queries for the font lookup table asynchronous. In that CL, DWriteFontLookupTableBuilder needs the task runner to run the Mojo message callback on the same task runner on which DWriteFontProxyImpl received it. Move scheduling the lookup table construction to common_browser_interfaces.cc which is still around the same time in startup as before, but makes it much easier to share the same task runner. Bug: 960263, 889864 Tbr: avi Change-Id: I8be6d4a4d29014967d38f20ccf8a94948a7b8a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626865 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#663021}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/316f3ac13b51..f3db34d06074 git log 316f3ac13b51..f3db34d06074 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 srte@webrtc.org Revert "Cleanup of video packet overhead calculation." 2019-05-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8b25075e..8ae1a64b (662811:662926) Created with: gclient setdep -r src/third_party/webrtc@f3db34d06074 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie941b7032f76d31ae925edffedbddedc6b8fd9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628345Reviewed-by:
-
Simon Zünd authored
The web-test "non-fast-scrollable-region-nested.html" layout test passes a DOMRectList directly to Array#sort. This CL spreads the DOMRectList into an actual JSArray, making it sortable. R=adamk@chromium.org Bug: v8:8714 Change-Id: Iaa380a7522a3e65f922e42720f278c0236305c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627386 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#663019}
-
Maksim Moskvitin authored
Once client received default NigoriSpecifics during initial sync it should fill NigoriSpecifics with keystore Nigori and commit changes to the server. This CL adds integration test for this case. Bug: 922900 Change-Id: I6bd3443fb699aeeb3609183377204a75b76fa6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609823 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Pâris MEULEMAN authored
This CL extends the java |SigninManagerDelegate| interface and its android implementation |ChromeSigninManagerDelegate| with |isGooglePlayServicesMissing| and |canUseGooglePlayServices|, removing |ExternalAuthUtils| and |UserRecoverableErrorHandler| dependencies from |SigninManager|. Bug: 963400 Change-Id: I5faadf64e9e1565ca3eb458ae02ed8085e1f17bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613085Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
