- 18 Feb, 2016 40 commits
-
-
yuzus authored
In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} Review URL: https://codereview.chromium.org/1637813002 Cr-Commit-Position: refs/heads/master@{#376103}
-
samli authored
Keyframe rules injected via CSSOM have no associated source range. BUG=586085 Review URL: https://codereview.chromium.org/1697973002 Cr-Commit-Position: refs/heads/master@{#376102}
-
patricialor authored
MacViews: Fix views_unittests MenuButtonTest.{ActivateDropDownOnMouseClick,DraggableMenuButtonActivatesOnRelease} Tests added in r301015, regressed in r363547. They fail on Mac because a non-simulated cursor position is detected during button creation, where button states are initialized, thus not detecting a hover state. the ui::test::EventGenerator is used to simulate cursor position, but isn't created until after the button widget, which means an unexpected cursor position is detected between the time of widget creation and EventGenerator creation. Additionally, using the set_current_location() method does not trigger mouse events, which means the button's hover state is never detected. Fix is to create the EventGenerator object before button creation so that when mouse events are triggered the hit tests will detect mouse hover states. BUG=579380 Review URL: https://codereview.chromium.org/1670473002 Cr-Commit-Position: refs/heads/master@{#376101}
-
dtseng authored
- kbexplorer script now is blacklisted for classic - we now can actually handle the ctrl key in js (stop speech). Do that. Nicely, this let's us get the ctrl key and speak it in the kbexplorer (it probably just stopped speech in the past, so spoke nothing) - keys now just go through the background page - all keys speak TEST=ChromeVox+o, k. Press some f-keys (back, forward, etc) are read. Press modifiers ctrl, alt, search, shift; verify they are read (queued). Press letters, numbers, shifted keys. BUG=none Review URL: https://codereview.chromium.org/1702913002 Cr-Commit-Position: refs/heads/master@{#376100}
-
halliwell authored
This reverts https://codereview.chromium.org/1477483003/ which was intended to fix a problem where media playback in browser tests triggers metrics events that DCHECK on invalid session ID. Previous attempt set a dummy session ID, but this could mask bugs if we ever failed to set session ID correctly. Instead, explicitly only set the dummy ID for running browser tests. BUG= Review URL: https://codereview.chromium.org/1510973007 Cr-Commit-Position: refs/heads/master@{#376099}
-
scottmg authored
This won't affect Stable based on https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_crash_reporter_client.cc&l=182 . R=mark@chromium.org,siggi@chromium.org BUG=587139, 586622 Review URL: https://codereview.chromium.org/1707203002 Cr-Commit-Position: refs/heads/master@{#376098}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/134ad3e5b097..e2412d5738e4 $ git log 134ad3e5b..e2412d573 --date=short --no-merges --format='%ad %ae %s' 2016-02-17 cblume Adding direct access to SkMipMap levels. 2016-02-17 mtklein try plain-old code for sk_memset16/32 now that NEON is compile-time 2016-02-17 msarett Speculative fix for Google3 iOS build 2016-02-17 msarett Return the proper error code in SkBmpRLECodec 2016-02-17 jvanverth Add GrGpu support for Vulkan command buffer flush GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705133002 2016-02-17 robertphillips Mark existing image filter entry points that will be going away with Deprecated GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709753002 2016-02-17 mtklein Don't you just feel bad every time you type 'delete'? 2016-02-17 brianosman Further reduction of GPU workload in shapes benchmarks. Hopefully this squelches the random crashes on Mali 400. 2016-02-17 bungeman Move SkTArray to include/private. 2016-02-17 msarett Delete KTX tests to fix Android build 2016-02-17 halcanary bin/sync-and-gyp: better error checking 2016-02-17 iroth Enable GL interfaces for iOS build 2016-02-17 caryclark add last move to serialized path CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=tomhudson@google.com Review URL: https://codereview.chromium.org/1708063002 Cr-Commit-Position: refs/heads/master@{#376097}
-
shans authored
to the property name. Prior to this patch, multiple calls to inline style setProperty with the same custom property name cause multiple entries to be created in the StylePropertySet. This causes inline style getPropertyValue calls to return the wrong value. Review URL: https://codereview.chromium.org/1697233003 Cr-Commit-Position: refs/heads/master@{#376096}
-
azurewei authored
Implement chrome.input.ime.setComposition and chrome.input.ime.commitText APIs on Linux and Windows platform. This cl makes ui::InputMethodBase inherits from ui::IMEInputContextHandlerInterface, thus we can implement functions CommitText() and UpdateCompositionText() once for Linux and Windows. Make InputImeKeyEventHandledFunction::Run() calls the new added InputMethodBase::KeyEventHandler() in to set |handling_key_event_|, which indicates whether the IME extension is handling key event. And when |handling_key_event_| == true, we should not setComposition and commitText until it's done to run the callback. Add helper function UpdateCommitText() and CommitTextToInputContext() in InputMethodEngineBase, which will be override in chromeos::InputMehtodEngine and input_method::InputMethodEngine to implement the API on different platforms. BUG=517773 TEST=None Review URL: https://codereview.chromium.org/1657593007 Cr-Commit-Position: refs/heads/master@{#376095}
-
michaelpg authored
BUG=388460 Review URL: https://codereview.chromium.org/1710673002 Cr-Commit-Position: refs/heads/master@{#376094}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24a43392..7cf41d49 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1708733003 Cr-Commit-Position: refs/heads/master@{#376093}
-
dpranke authored
This will hopefully prevent some wasted time until the underlying problem is fixed. R=kbr@chromium.org, skobes@chromium.org BUG=539509 Review URL: https://codereview.chromium.org/1708973002 Cr-Commit-Position: refs/heads/master@{#376092}
-
scottmg authored
badfacccee01 win: Add support for capturing unloaded modules R=mark@chromium.org BUG=587141, crashpad:89 Review URL: https://codereview.chromium.org/1704203004 Cr-Commit-Position: refs/heads/master@{#376091}
-
hayato authored
This is a proof of concept to support *slotchange* events at the end of a microtask. The spec discussion is here: https://github.com/w3c/webcomponents/issues/288 Because slot elements are guarded by ShadowDOMV1 flag, this new events will be seen only when the flag is enabled. BUG=531990 Review URL: https://codereview.chromium.org/1695163003 Cr-Commit-Position: refs/heads/master@{#376090}
-
amistry authored
If the wait set is being woken on one thread and have an awakable added on another (i.e. during MojoWait on the wait set), it is possible for the awakable to be added after checking the signals state, but before adding to the awakables list. In this case, the added awakable won't get woken up. The fix is to ensure that checking the signals state and adding to the awakables list is an atomic operation. Review URL: https://codereview.chromium.org/1708953002 Cr-Commit-Position: refs/heads/master@{#376089}
-
kcarattini authored
BUG=543161,561867 Review URL: https://codereview.chromium.org/1700943003 Cr-Commit-Position: refs/heads/master@{#376088}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#376087}
-
estade authored
BUG=none Review URL: https://codereview.chromium.org/1711493004 Cr-Commit-Position: refs/heads/master@{#376086}
-
loyso authored
BUG=577016 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1698213002 Cr-Commit-Position: refs/heads/master@{#376085}
-
kozyatinskiy authored
Method document::updateLayoutTree creates ScriptForbiddenScope. An HTML plugin can be reattached while updating layout tree. Pepper plugin can be destroyed while reattaching and executes some scripts. This execution produces crash on ScriptForbidden assert. BUG=550427 R=pfeldman@chromium.org,dcheng@chromium.org,dgozman@chromium.org Review URL: https://codereview.chromium.org/1693003002 Cr-Commit-Position: refs/heads/master@{#376084}
-
suzyh authored
The KeyframeEffectOptions interface definition used DOMStrings instead of enums for the "fill" and "direction" members, which differs from the spec: http://w3c.github.io/web-animations/#the-animationeffecttimingproperties-dictionary This patch converts them to the specified enums. BUG= Review URL: https://codereview.chromium.org/1711543002 Cr-Commit-Position: refs/heads/master@{#376083}
-
nolan.robin.cao authored
Add a layout test case for Cache.matchAll() without parameters. BUG=578708 Review URL: https://codereview.chromium.org/1706863002 Cr-Commit-Position: refs/heads/master@{#376082}
-
wuchengli authored
Now that all platforms support V4L2_EVENT_SRC_CH_RESOLUTION, we can always check V4L2_EVENT_SRC_CH_RESOLUTION bit on resolution change. BUG=chrome-os-partner:44431 TEST=Play resolution change video on nyan-big. Review URL: https://codereview.chromium.org/1696303003 Cr-Commit-Position: refs/heads/master@{#376081}
-
sbc authored
Reland of [NaCl SDK] Add initial support for building the SDK with gn (patchset #1 id:1 of https://codereview.chromium.org/1693213002/ ) Reason for revert: clang/win compile failures was fixed: https://codereview.chromium.org/1706613002 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_clang_x64_dbg Original issue's description: > Revert of [NaCl SDK] Add initial support for building the SDK with gn (patchset #6 id:100001 of https://codereview.chromium.org/1693053002/ ) > > Reason for revert: > Doesn't build with clang/win and looks nontrivial to fix: > > https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/builds/3655/steps/compile/logs/stdio > > FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c ../../native_client/src/trusted/validator/driver/ncval.cc /Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj /Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb > ../../native_client/src/trusted/validator/driver/ncval.cc(359,36) : error: ISO C++11 does not allow conversion from string literal to 'char *' [-Werror,-Wwritable-strings] > while ((opt = getopt(argc, argv, "vd")) != -1) { > ^ > > (and i'm guessing several more) > > Original issue's description: > > [NaCl SDK] Add initial support for building the SDK with gn > > > > build_sdk.py still uses gyp. I have a followup CL to > > convert that to gn. > > > > BUG=585999 > > TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,sbc@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=585999 > > Committed: https://crrev.com/b78379a22336ce66dac20778db7964e40faa9180 > Cr-Commit-Position: refs/heads/master@{#375349} TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585999 Review URL: https://codereview.chromium.org/1705923002 Cr-Commit-Position: refs/heads/master@{#376080}
-
joedow authored
This change fixes a DCHECK on linux when the host is run without specifying a socket name. Typically the host has a name passed in as an argument however it is not required and may be skipped for a number of reasons. The fix here is to skip the creation of the GnubbyExtension if a socket name is not passed in. The net effect of this is that if a CRD client passes a gnubby-auth extension message, the ClientSession will look for a registered extension to handle the message (which won't exist) and the message will be ignored. BUG=587622 Review URL: https://codereview.chromium.org/1710653002 Cr-Commit-Position: refs/heads/master@{#376079}
-
servolk authored
This CL implements parsing of avc1/avc3 codec ids from the mime type string. Compared to the previous implementation (ParseH264CodecId in mime_util.cpp) this one handles all H.264/AVC codec profiles defined in the ISO standard and implements handling of constraint set flags 0 through 2. BUG=456408 Review URL: https://codereview.chromium.org/1677563003 Cr-Commit-Position: refs/heads/master@{#376078}
-
newt authored
BUG=583477 Review URL: https://codereview.chromium.org/1707103004 Cr-Commit-Position: refs/heads/master@{#376077}
-
rune authored
- Only non-functional :host has no selector list. - Removed misplaced specificity comment. R=kochi@chromium.org Review URL: https://codereview.chromium.org/1707643002 Cr-Commit-Position: refs/heads/master@{#376076}
-
mstensho authored
Looks like MultiColumnFragmentainerGroup::calculateMaxColumnHeight() isn't going to be the only place where we need this functionality. No functional changes intended. R=leviw@chromium.org Review URL: https://codereview.chromium.org/1696713003 Cr-Commit-Position: refs/heads/master@{#376075}
-
kojii authored
Using update-w3c-deps in Blink 505cf01d. TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,cbiesinger@chromium.org BUG=586413 Review URL: https://codereview.chromium.org/1703343002 Cr-Commit-Position: refs/heads/master@{#376074}
-
hirono authored
Chrome browser opens Files app as a file saving dialog. The caller of saving dialog has a special handling for drive paths, but it does not handle other non-native paths (e.g. FSP, MTP) The CL lets Files app know which types of paths are handled by caller and hide volumes that are not supported by caller. BUG=581984 TEST=Check with standalone Files app, save dialog, open dialog Review URL: https://codereview.chromium.org/1701163003 Cr-Commit-Position: refs/heads/master@{#376073}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c152be3c..24a43392 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1708023002 Cr-Commit-Position: refs/heads/master@{#376072}
-
dbeam authored
R=michaelpg@chromium.org BUG=586579 Review URL: https://codereview.chromium.org/1700273003 Cr-Commit-Position: refs/heads/master@{#376071}
-
chrome://downloadsestade authored
BUG=582688 Review URL: https://codereview.chromium.org/1705613002 Cr-Commit-Position: refs/heads/master@{#376070}
-
ochang authored
https://pdfium.googlesource.com/pdfium.git/+log/53520a1..1e1d3b0 BUG=587620 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1711573002 Cr-Commit-Position: refs/heads/master@{#376069}
-
watk authored
This CL enables SurfaceView fullscreen video with the unified media pipeline in cases where we use the AVDA deferred rendering strategy today. * There's a new media interface called SurfaceManager with two methods: CreateFullscreenSurface() and NaturalSizeChanged(). * SurfaceManager is implemented by RendererSurfaceViewManager, which is a RenderFrameObserver, and BrowserSurfaceViewManager, which is created for each RenderFrame by MediaWebContentsObserverAndroid. * BrowserSurfaceViewManager creates a ContentVideoView in response to a CreateFullscreenSurface message, and registers it in a surface map that the decoder can look up in the GPU process. * WMPI interacts with SurfaceManager on behalf of the decoder. It passes GpuVideoDecoder a callback for requesting surfaces which it calls before initializing VDAs. * In response to the callback, if the player is in fullscreen WMPI will pass the request to the SurfaceManager which will return the surface id to GVD. If the player is not in fullscreen WMPI will return a null surface id. * When GVD gets a surface id back it completes its initialization by calling VDA::Initialize with the surface id and the VDA will render to the given surface. * WMPI records that it got a surface request callback so that it knows that future fullscreen transitions will require a restart of the decoder in order to switch surfaces. * A future CL will allow us to switch the surface dynamically without requiring a restart. BUG=533630 Review URL: https://codereview.chromium.org/1655083002 Cr-Commit-Position: refs/heads/master@{#376068}
-
tkent authored
This CL has no tests. We're not sure if this CL makes user-visible behavior changes. The purpose of this CL is to reduce ClusterFuzz crashes in the future. This CL also updates comments in EditingState.h. We can't remove NoEditingAbortChecker and ASSERT_NO_EDITING_ABORT. BUG=586846 Review URL: https://codereview.chromium.org/1703903002 Cr-Commit-Position: refs/heads/master@{#376067}
-
sammc authored
Also reimplement mojo_wait_for_incoming_message using mojo.support.asyncWait. Review URL: https://codereview.chromium.org/1698933002 Cr-Commit-Position: refs/heads/master@{#376066}
-
lukasza authored
Presence of OOPIFs introduces a delay into loading of cross-origin media and exposes a race in the http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html test. To get rid of the race, we should wait until media has actually started to load, before posting / reporting that the test is "done". BUG=582541 TEST=The affected test passes when run 100 times with and without --site-per-process flag. Review URL: https://codereview.chromium.org/1703333002 Cr-Commit-Position: refs/heads/master@{#376065}
-
ben authored
BUG= Review URL: https://codereview.chromium.org/1701933004 Cr-Commit-Position: refs/heads/master@{#376064}
-