GitLab

Both the infobar and the infobar container were making use of various infobar
constants that were declared in components/ but (usually) defined in chrome/.
This was a symptom of having put code in the component that really probably
belonged in the embedder.

This CL hoists the relevant logic to a new cross-platform
InfoBarContainerDelegate class defined on the chrome side, which implements some
of the methods of InfoBarContainer::Delegate.  Platforms then subclass this to
implement the remaining, platform-specific bits.

This means that the constants in question now live solely in chrome/, avoiding a
bunch of link-time nastiness when trying to build the components code
separately.

BUG=382924
TEST=none
TBR=finnur

Review URL: https://codereview.chromium.org/793783003

Cr-Commit-Position: refs/heads/master@{#308046}

Background: In a subsequent CL we'll want to plug the scanner into the progress center (as a "task" I believe) so the user can see that there is some activity going on. This is one reason why we don't just gather up all the files in a single swoop, but do some acrobatics to handle each file individually.

* Update MediaScanner to be non-reusable (1 instance per scan).
* Add separate MediaScanner and ScanResult interfaces.
* MediaScanner now tracks scan duration (which will be reported in a subsequent UMA).
* MediaScanner now gathers local storage requirements so that cloud import can report insufficient storage to user...and prohibit import.

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/795833002

Cr-Commit-Position: refs/heads/master@{#308045}

Fix a bug just introduced in https://crrev.com/bfea6ecef56cba8beb9816e8e9674a9dc456b20e.

BUG=438005

Review URL: https://codereview.chromium.org/788073003

Cr-Commit-Position: refs/heads/master@{#308044}

BUG=431868

Review URL: https://codereview.chromium.org/800613002

Cr-Commit-Position: refs/heads/master@{#308043}

Instead internalize them into AlgorithmImplementation.

Review URL: https://codereview.chromium.org/794873002

Cr-Commit-Position: refs/heads/master@{#308042}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0bde23c..c996f78

TBR=rtoy@chromium.org,lushnikov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/800573003

Cr-Commit-Position: refs/heads/master@{#308041}

BUG=441456

Review URL: https://codereview.chromium.org/797693003

Cr-Commit-Position: refs/heads/master@{#308040}

After selecting text in textbox. right click make context menu to
came, then selecting 'S' it switchs focus highlight between
'Spell-checker options' and 'Search Google for "..."
as both have 'S' as associated key.

Have made "O" for spell-checker options and "S" for Search.

BUG=226234

Review URL: https://codereview.chromium.org/794093004

Cr-Commit-Position: refs/heads/master@{#308039}

This reverts commit 6d6a279a.

Turned out that this CL is not necessary.

BUG=424866
TBR=aelias@chromium.org

Review URL: https://codereview.chromium.org/784503002

Cr-Commit-Position: refs/heads/master@{#308038}

BUG=none
TEST=playback!

Review URL: https://codereview.chromium.org/796143003

Cr-Commit-Position: refs/heads/master@{#308037}

This might-maybe-hope-not crash, and so has debugging statements.

BUG=407376
TEST=no crashing, we hope
TBR=rsesek@chromium.org

Review URL: https://codereview.chromium.org/795233002

Cr-Commit-Position: refs/heads/master@{#308036}

Make it clear there are many of them floating around. Follow-up to comment in
https://codereview.chromium.org/795773002/

BUG=none

Review URL: https://codereview.chromium.org/802563002

Cr-Commit-Position: refs/heads/master@{#308035}

Added a GetPermissions() method to APIPermissions, which returns the
PermissionIDSet for that API permission. This will be used for the new
permission messages system, which can generate
CoalescedPermissionMessages from these permissions.

BUG=398257

Review URL: https://codereview.chromium.org/795543002

Cr-Commit-Position: refs/heads/master@{#308034}

This CL adds:
 1) A DisplayLayoutManager interface which will be implemented within
 DisplayConfigurator in a followup CL. This is in charge of providing
 enough information to the task to pick the correct display state.
 2) A task that will query to update the display list, pick the correct
 display state via DisplayLayoutManager then configure the displays
 via the ConfigureDisplaysTask.
 3) Basic unittests to validate the task. These are only basic since
 the DisplayConfigurator unittests are performing the same tests. Ideally
 the DisplayLayoutManager code in DisplayConfigurator could be extracted
 in its own class such that these unittests can re-use that logic.

BUG=429746
TBR=spang@chromium.org

Review URL: https://codereview.chromium.org/788423002

Cr-Commit-Position: refs/heads/master@{#308033}

We don't separate unittests from the code they test, they usually live
near the implementation, e.g.:

chrome/browser/foo.h
chrome/browser/foo.cc
chrome/browser/foo_unittest.cc

BUG=None
TEST=unit_tests
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/802483003

Cr-Commit-Position: refs/heads/master@{#308032}

BUG=349250
R=tapted@chromium.org

Review URL: https://codereview.chromium.org/799713002

Cr-Commit-Position: refs/heads/master@{#308031}

We are changing the interface between Chrome and one of
the PNaCl translator nexes so that it uses the NaCl IRT
more (which is a more stable interface). However, this
means that we are not testing the old interface between
Chrome and the PNaCl translator nexe anymore on the chrome
waterfall, so the old interface may get broken. Bump the
min PNaCl version to try and get more users onto using the
new nexe, which uses the newer interface.

The new nexe also brings in a PNaCl translator based on
LLVM 3.5, so having that match the SDK (using LLVM 3.5)
is better for debugging (developer-only unstable debug
metadata has changed between 3.4 and 3.5).

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3914

Review URL: https://codereview.chromium.org/789273002

Cr-Commit-Position: refs/heads/master@{#308030}

We were returning an empty string for AXARIALive for nodes
inside of a live region, and that was confusing VoiceOver.

BUG=440934

Review URL: https://codereview.chromium.org/795363002

Cr-Commit-Position: refs/heads/master@{#308029}

Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet.

BUG=334090
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/796693003

Cr-Commit-Position: refs/heads/master@{#308028}

BUG=439638

Review URL: https://codereview.chromium.org/797693002

Cr-Commit-Position: refs/heads/master@{#308027}

app_id, session_id and sdk_version, which are used by MediaPlay/MediaPause
events.

BUG=

Review URL: https://codereview.chromium.org/786233003

Cr-Commit-Position: refs/heads/master@{#308026}

If the reader of the stream is aborted before the stream is registered,
StreamRegistry::RegisterStream() should fail to reduce the memory consumption.
So this change introduces StreamRegistry::RegisterReaderAbortedStream().

We will use this method in this situation:
 - The request from the page is sent to the ServiceWorker.
 - The ServiceWorker creates a Stream and starts uploading the data to the browser process with it.
 - The browser process receives the stream URL in ServiceWorkerHostMsg_FetchEventFinished.
   But it didn't receive StreamHostMsg_StartBuilding yet.
 - The page stops the loading the resource.
  -> Call this method in the browser process.
 - The browser receives StreamHostMsg_StartBuilding and creates a Stream and registers it to the StreamRegistry.
  -> This registration should fail.

BUG=436424
TEST=content_unittests --gtest_filter=StreamTest.*

Review URL: https://codereview.chromium.org/759823003

Cr-Commit-Position: refs/heads/master@{#308025}

BUG=429236
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/796993002

Cr-Commit-Position: refs/heads/master@{#308024}

R=dmazzoni@chromium.org
BUG=437745

Review URL: https://codereview.chromium.org/794943002

Cr-Commit-Position: refs/heads/master@{#308023}

This adds support for clipboardRead and clipboardWrite
capability grants from white-listed extensions to web
contents.

BUG=409269
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/789063002

Cr-Commit-Position: refs/heads/master@{#308022}

The logs upload loop can be broken if a log upload fails while in state
SENDING_INITIAL_METRICS_LOG.

BUG=441460

Review URL: https://codereview.chromium.org/799613002

Cr-Commit-Position: refs/heads/master@{#308021}

These files are moved in favor of less files to have in the top-level
chromeos directory.

BUG=none
TEST=builds as before

Review URL: https://codereview.chromium.org/738683002

Cr-Commit-Position: refs/heads/master@{#308020}

See https://codereview.chromium.org/796153002 for the actual fix.

BUG=403902
TBR=phajdan.jr@chromium.org
TEST=Speculative: On Windows with the display language set to one other
than English (e.g. ko, pt-BR, zh-CN, etc; just setting the default locale to
one of them does not work on Win 7 or later or using --lang=foo does not
work), start Chrome and go to ftp://ftp.vim.org. Render process should
not crash.

Review URL: https://codereview.chromium.org/798753002

Cr-Commit-Position: refs/heads/master@{#308019}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4a1d377..0bde23c

TBR=rtoy@chromium.org,lushnikov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/800683002

Cr-Commit-Position: refs/heads/master@{#308018}

This change enables the feature previously known as streamlined hosted
apps by default.

BUG=440670

Review URL: https://codereview.chromium.org/772533005

Cr-Commit-Position: refs/heads/master@{#308017}

OnSizeConstraintsChanged should be skipped if the window is a popup or child.

BUG=439038

Review URL: https://codereview.chromium.org/792303002

Cr-Commit-Position: refs/heads/master@{#308016}

This will ensure that WeakPtrs are invalidated before any other members'
destructors are invoked. This is also one of the last classes needing to
change to allow us to turn on a Clang check for WeakPtrFactory member order.
Please see the bug for more details.

BUG=303818

Review URL: https://codereview.chromium.org/795003003

Cr-Commit-Position: refs/heads/master@{#308015}

This is only used in specific circumstances in the renderer, so move it to ChildSharedBitmapManager.

Review URL: https://codereview.chromium.org/795843002

Cr-Commit-Position: refs/heads/master@{#308014}

The new ResourceManager assumes the generated resource is of type
RGBA8. Add additional type support for A8, the format used by the
overscroll effect on Android L.

BUG=426939

Review URL: https://codereview.chromium.org/798783002

Cr-Commit-Position: refs/heads/master@{#308013}

Partial revert of the following patch:
https://codereview.chromium.org/675313002/

BUG=436689
TBR=tedchoc@chromium.org

Tbr since code-review is broken and Ted gave me the LGTM.

Review URL: https://codereview.chromium.org/797833002

Cr-Commit-Position: refs/heads/master@{#308012}

* Moves some functions that deal TabState filenames to TabState
  from TabPersistentStore downstream.

* Moves DOCUMENT_SCHEME from IntentHandler.java to UrlConstants.java
  with similar schemes.  Note that the DOCUMENT_SCHEME doesn't include
  the "://" string like the other Java scheme constants; this is because
  the Document classes use a real Uri parse to parse the scheme instead
  of doing a plain old TextUtils.equals() comparison.

BUG=415747

Review URL: https://codereview.chromium.org/796113003

Cr-Commit-Position: refs/heads/master@{#308011}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/791353002

Cr-Commit-Position: refs/heads/master@{#308010}

The new methods are meant to replace similar functions from kill.h

BUG=417532

Review URL: https://codereview.chromium.org/791503002

Cr-Commit-Position: refs/heads/master@{#308009}

BUG=438474
TEST=as in bug; no crash
TBR=thestig@chromium.org,atwilson@chromium.org

Review URL: https://codereview.chromium.org/790423002

Cr-Commit-Position: refs/heads/master@{#308008}

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/783393002

Cr-Commit-Position: refs/heads/master@{#308007}