- 08 Jul, 2020 40 commits
-
-
Andrew Grieve authored
This reverts commit e0f5a1c0. Reason for revert: Breaking downstream builder: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8875332406729172240/+/steps/compile/0/logs/raw_io.output_failure_summary_/0 Original change's description: > Reland "Android: Bump default target_sdk_version 24 -> SDK used to compile" > > This reverts commit fb07fcff. > > Reason for reland: Not changing target_sdk_version for angle tests > > Original change's description: > > Revert "Android: Bump default target_sdk_version 24 -> SDK used to compile" > > > > This reverts commit b7fb15b1. > > > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1099849 > > > > Original change's description: > > > Android: Bump default target_sdk_version 24 -> SDK used to compile > > > > > > Why do this? > > > * It's best practice to target the latest sdk, so this makes for a > > > better default. > > > * Many targets were neglecting to ever update this value > > TBR=boliu@chromium.org,torne@chromium.org,agrieve@chromium.org,behdadb@chromium.org > > Bug: 1099849 > Change-Id: I95f36a2b88d2e7ad1d90222f25192c9a915550ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280981 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786275} TBR=boliu@chromium.org,agrieve@chromium.org,behdadb@chromium.org Change-Id: If60966b54d37bfa2c5326bcad0f36819f1c47023 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288092Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#786357}
-
Ayu Ishii authored
This change updates SetCanonicalCookie to return CookieAccessResult instead of CookieInclusionStatus. This is one of many steps to consistently use CookieAccessResult so CookieStore will eventually be able to return EffectiveSameSite for SameSite across all its endpoints. Bug: 1092695 Change-Id: I38ae51fee78ba6a88c05447ec7516ff20e4bfe97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264511Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#786356}
-
Andreea Costinas authored
When the System-proxy service in CrOS sends an AuthenticationRequired signal for a specific protection space (proxy url, scheme, realm), the SystemProxyManager inside the Browser looks for the credentials added by the user. If found, it will send the credentials and protection space to System-proxy via dbus. If no credentials are found or no user has signed in yet, it will send the protection space with empty credentials to signal that the request was processed. BUG=1042642 TEST=unittest, tested on DUT Change-Id: Id427d962d22171a41586f51d2936a73bfe8694e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246163Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#786355}
-
Evan Stade authored
Bug: 1071603 Change-Id: If1dd2c1cd005aebcd27cac1a3c80d43f7586d473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287382Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#786354}
-
ssid authored
BUG=1102412 Change-Id: I558cbc1b94791354d1b133bf59f5fcb57722387c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286471Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#786353}
-
Sylvain Defresne authored
This is a reland of aafd725a Original change's description: > [ios] Add --landmines-path to build/landmines.py script > > Chrome on iOS has some internal landmines and uses a forked version > of build/landmines.py for that to allow using a separate landmines > file. > > Add a --landmines-path parameter to build/landmines.py script in > order to remove the forked version and instead use the shared one. > > Bug: 1033067 > Change-Id: Iac668c5877ae181442078cda7ce8e727f91104b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283582 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786218} Bug: 1033067 Change-Id: Ice49ba16caf21045e0b513fb4b55cf198d3f0d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287477Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#786352}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c103a111af91..9ea6876dcac5 2020-07-08 treehugger-gerrit@google.com Merge "Port the scroll flow breakdown into a trace processor metric." 2020-07-08 lalitm@google.com tp: hook up /query http method to new query serialization logic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I83e5aba6ea2e4fae47ad27ed87cc4eefe92eacaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287786Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786351}
-
Lukasz Anforowicz authored
Trying to assign a string literal to a |char*| pointer results in the following compilation error: error: ISO C++11 does not allow conversion from string literal to 'char *' [-Werror,-Wwritable-strings] This CL: *) Avoids (char*)"string literal" casts *) Changes the type of corresponding fields from |char*| to |const char*| Bug: 1080832 Change-Id: Ie92eed766acec232a9e6b971f5f5d5569914dba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287911 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786350}
-
Caitlin Fischer authored
We wish to know whether a request to which variations headers will be appended is from a frame whose top-level domain is a Google-owned web property, e.g. YouTube, DoubleClick, etc. In order to determine this context for a subframe-initiated subresource request on the renderer side (e.g. a request to DoubleClick from an ad on foo.com), we cannot use ResourceRequest::TrustedParams because they are not populated. It is, however, possible to determine the context in the renderer and to pass it along to the code that appends headers. Bug: 1094303 Change-Id: I6d62b1ba52425a9b0d80d56b20326e23b6949263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276231 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#786349}
-
Justin DeWitt authored
This cannot be done in a single CL, so adding the new API to AppHooks and deprecating the old. After a chrome-internal roll we can remove the deprecated one. Change-Id: Ie848c5cb3066b531e02fe57c1824030981b907c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285471Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#786348}
-
Danila Kuzmin authored
R=raleksandrov@google.com Bug: 1097010 Change-Id: If875d3432637a6aba452039d0374467276705381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266612Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#786347}
-
Rulong Chen（陈汝龙） authored
We should contain Referrer header when a download is triggered via anchor tag with download attribute. Bug: 455987 Change-Id: I599abab8192095c7d4e6703807fa936b6c8e2024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262023 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#786346}
-
Nico Weber authored
Describes both building for and on arm macs. Bug: 1098899,1103236 Change-Id: Iac5becb22ba07453765b10c854b47182d96c98e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287899 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786345}
-
Shengfa Lin authored
If user data needs to be saved after shut down, call Chrome DevTools Protocol browser.close. If browser.close failed, call KillProcess. Do not call closeWebview when only one window left. Bug: chromedriver:3370 Change-Id: I9022500332e0f971d9535ae2117c88f577144c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283057Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#786344}
-
Ted Choc authored
For simple boolean equality checks, this converts those to the Callable<Boolean> syntax, for all other checks, these are converted to Criteria.checkThat(...) BUG=1071247 Change-Id: I4f63fed847337867bb161b8b93bcd3e5a4e781ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286151 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#786343}
-
Xiaohan Wang authored
Close() is confusing as people might relate to MediaKeySession::close(). Also, the current names are not consistent with what we use in other parts of the stack, making code search harder. This CL renames the methods to make it consistent with what use everywhere else. Tbr: dcheng@chromium.org Change-Id: Ia9dd8c17ac11b9276efc0f4133f6002dea2a524c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277339Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#786342}
-
Toni Barzic authored
BUG=1101315 Change-Id: I650582530cb48a209b489777325f672714bec041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284149Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#786341}
-
Li Lin authored
Also changed to check the threshold with character size instead of byte size. Bug: b/160639930 Test: unit tests Change-Id: I0cefba23ef46ce7bda7ccb57adf3c46481f0d389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285509Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786340}
-
Evan Stade authored
Regressed in 7bb74836 due to an inverted condition. Bug: 1098217 Change-Id: I7e5cc46994e7df4ac66a1bbc2681af679d1ce736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283938Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#786339}
-
Victor Costan authored
This is split off from https://crrev.com/c/2286475 to facilitate reviewing and any follow-up debugging. Change-Id: Ie2a3a9fdd8f7e1d714c3e642ee18cb3fe5e53ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285926 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#786338}
-
Clark DuVall authored
This change automatically grants location permissions to the default search engine in WebLayer. For now, the DSE is hardcoded to https://www.google.com and cannot be changed. If more complex logic is needed in the future, it should be possible to share Chrome's DSE permission logic. See go/weblayer-search-permissions for more background. The permission in site settings will link to the client app's settings, similar to how notification permissions work for TWAs. The code to set up the preferences was refactored so it can be shared. Bug: 1063433 Change-Id: I1933e0b788d981d0aa0535ece9b4386afc37b619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283058 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#786337}
-
Evan Stade authored
Bug: 1071603 Change-Id: Id09d23f85aa3cca1dc7b42b49cf01995ce3cd2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287950Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#786336}
-
Wei Li authored
Fix and re-enable a couple tests for ink drop ripple. Add unit tests for ink drop mask. Bug: none Change-Id: Ifa9f350f73fed05016982f7de03db5b8e3632361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272132 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#786335}
-
Anders Leino authored
The issue is suspected to be fixed: http://anglebug.com/3935#c33 Bug: angleproject:3935 Tbr: kbr@chromium.org Change-Id: I0d7fd0e51070d45b77b1577c62b479f62e8a0b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283327Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#786334}
-
Peter Kotwicz authored
The Mobile.Splash.HideSplashWhenFinishing UMA histogram is hit thus the cause for the https://bugs.chromium.org/p/chromium/issues/detail?id=1096171 NullPointerException is likely solely SplashController#hideSplash() being called while the activity is finishing. This CL: - Removes Mobile.Splash.HideSplashWhenFinishing histogram - Reverts code added in https://chromium-review.googlesource.com/c/chromium/src/+/2259483 which handles a different theory of how ChromeActivity#getCompositorViewHolder() can be null BUG=1101637 Change-Id: I598d0145ce1e456d35884ea7eb1eb18cef914a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283247Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#786333}
-
Adam Langley authored
This reverts commit c6728c24. The credential is optional in the response when there's a single entry in the allowlist. Normally we wouldn't be sending silent requests in that case, but it can happen if the allow list had more entries before filtering or if there's an appid extension. This is a clean revert for merging purposes. Test changes and a fix will come later. BUG=1102777 Original change's description: > device/fido: only send the single matching credential ID. > > When prelighting credential IDs for getting an assertion, only send the > matching credential ID on the following up=1 request, rather than the > whole matching batch. > > Change-Id: I41534e82306b82c2332b44deb6466a9ee46c2905 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250893 > Commit-Queue: Adam Langley <agl@chromium.org> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#780525} TBR=agl@chromium.org,martinkr@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I3779623933af956f2cd8ade9200d7e7165cc55fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287384Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#786332}
-
Lei Zhang authored
Add dependencies and friends to make gn check pass. While enabling the "//pdf/*" entry in //.gn, trim some excess blank lines in that file. Bug: 1100400 Change-Id: I00fb6e80a48a778ae79531e8c2a328b92e041702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285325 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#786331}
-
Lukasz Anforowicz authored
Before this change, tests of raw output of the rewriter (i.e. tests run without passing --apply-edits to tools/clang/scripts/test_tool.py) might need to encode the full, absolute path in the test expectations. This meant that the tests wouldn't work on another developer's machine (where Chromium repo might be in a different location). After this change: - tools/clang/rewrite_raw_ptr_fields/tests/gen-*-expected.txt expectation files use paths delative to the rewrite_raw_ptr_fields/tests/ directory (rather than hardcoding a value of .../lukasza/src/chromium4/src/tools/clang/rewrite_raw_ptr_fields/tests - tools/clang/scripts/test_tool.py normalizes paths in the raw output (only if invoked without --apply-edits) to make the paths relative to the tests directory Bug: 1069567 Change-Id: I03c54374bb861904e439e677a271b0dec1502b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282888 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#786330}
-
Guillaume Jenkins authored
Rather than having parent objects pass concrete delegates to their members, the idea of this change is to have one factory object that will create platform-specific delegates for all the enterprise reporting classes. That way, only the factory needs to be passed around, and each reporting class can use it to get the delegate they need. This helps encapsulation because delegates of parent objects don't need to know about their children and their delegates. For now, the concrete factory's life cycle is owned by ReportGenerator because BrowserReportGenerator is the only one using it so far. But over the course of the next few CLs, the factory will be owned by objects higher and higher in the ownership hierarchy, until it's owned by CBCMController. Bug: 1091916 Change-Id: I7eec88ab1b1fb1bbc4c24ab198cc91637b836093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281031 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786329}
-
Alexander Cooper authored
The VR Testapp was used to test the VR Browser, which is no longer supported, or possible to enter. As a result, this is effectively all dead code, and thus can/should be removed. Change-Id: Ibfb47a4cd6b1d7a2fccc290a82c85a2cdeb35dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285397Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
-
Andrew Grieve authored
We should not rename libraries when not using crazy linker. Bug: 1103107 Change-Id: I24431c2818b596cd95b198d08b9670ba1750a380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287891 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786327}
-
Victor Hugo Vianna Silva authored
The sole purpose of these APIs is to propagate the unsynced credentials computed in PasswordSyncBridge up to ManagePasswordsState, which will then own them until the user decides to save or discard. So this CL modifies the APIs to a pass-by-value/move scheme. This spares 2 copies: when posting the task to UnsyncedCredentialsDeletionNotifier; and when storing the credentials in ManagePasswordsState. Bug: None Change-Id: Ic2f0dc191700b55d74b199b130a55d71f61150a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283751Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#786326}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: I398fbf56c8d8201e665862d12b4dddece5691a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285915Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786325}
-
Alexander Dunaev authored
Running the drag loop in DesktopDragDropClientOzone::StartDragDrop caused issues in the X11 platform implementation. The platform needs to capture and dispatch events properly, which is typically handled by |X11WholeScreenMoveLoop| that runs its own run loop. This CL moves the drag loop to the platform level. Two existing Ozone platforms are affected: changes to Wayland are trivial, and X11 gets some code that duplicates a few bits of |DesktopDragDropClientAuraX11|. This is temporary and will be fixed soon when we finally obsolete the non-Ozone path and get rid of |DesktopDragDropClientAuraX11|. Also, a few minor things are fixed that had been proposed earier in CLs based on the previous approach: 1. The drag image is now created only on platforms that need it [1] 2. The ui::XDragDropClient is documented [2] [1] https://crrev.com/c/2264553 [2] https://crrev.com/c/2262612 Bug: 1014860 Change-Id: Iec8aa145a23e1002df06a788bbc8ecb73d04ec63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267378Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#786324}
-
Maria Kazinova authored
This test requires a PasswordController instance to handle set up for renderer ids with the proper timing. Bug: 1101971 Change-Id: Ifd97be2e8bcdbcef137f4d5b3c65a956c50ff469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283334Reviewed-by:
-
dpapad authored
This in in preparation of removing the Polymer1 core library from the repository. Bug: 1102485 Change-Id: I95ec3992b89a32489a957efaf26aef17d0808222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283922Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#786322}
-
Alex Gough authored
Change-Id: I17c60ddb3294cc16dd41ff54d86ca95a741aff61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284209Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#786321}
-
Emily Stark authored
This is a reland of 65ac9625 Original change's description: > Clean up steady-state scheme/trivial subdomains elision flags > > These flags are enabled by default and expired since M76. > > I'm cleaning these up now because I'm starting to think about > uneliding scheme/trivial subdomains on hover (for the omnibox UI > simplified domain field trials), and it'll be simpler code if we don't > have to reason about these expired flags in both enabled and disabled > states. > > Bug: 797354 > Change-Id: I766a30c2f886ae1d651c2bf8eed0bc094664bde7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277880 > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785962} Bug: 797354 Change-Id: I0acc00e958e89263ac94a6a58155a9cf717fa48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285515Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#786320}
-
Sylvain Defresne authored
This reverts commit 15168c9b. Reason for revert: Xcode display errors when running EG2 tests (see https://crbug.com/1103230). Original change's description: > [ios] Enable New Build System in generated Xcode project > > Since gn now generates a project that wraps the invocation > of ninja in a script converting relative paths to absolute > paths, there is nothing blocking the use of the New Build > System. > > Bug: 852522 > Change-Id: I9b4ca343dc9434efb64a3866ca88d6b7c4065760 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276281 > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785343} TBR=sdefresne@chromium.org,olivierrobin@chromium.org Bug: 852522, 1103230 Change-Id: I5f8825ebd8b08bd89f0013ac278295632a83e3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287548 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#786319}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/1402ed576596..fdad1302b17b 2020-07-08 bclayton@google.com Remove pushing / popping -fPIC for glslang (#1098) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I8973c3be09724e7932c111ed00151d62e6b972de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287778Reviewed-by:
-
