GitLab

Revert 151036 - Speculative revert to see if this change introduced a performance regression on Mac intl perf bots.

If this change was responsible for this regression, it may also have been responsible for 

http://crbug.com/133762
http://crbug.com/138260
TEST=mac intl perf bot drops:
http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl1/report.html?history=150&rev=-1
Review URL: https://chromiumcodereview.appspot.com/10837192

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831308

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151482 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129203
TEST=Run chrome with --force-device-scale-factor=2, open an incognito window, extension icon is sharp.


Review URL: https://chromiumcodereview.appspot.com/10828287

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151481 0039d316-1c4b-4281-b951-d872f2087c98

Add --remote-debugging-port back to content_shell since nduca mentioned he wants to use it with Android.

BUG=90445
Review URL: https://chromiumcodereview.appspot.com/10829303

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151480 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139822
TEST=Menu item sizes are the same size and match the spec except for touch layout separators.


Review URL: https://chromiumcodereview.appspot.com/10829283

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151479 0039d316-1c4b-4281-b951-d872f2087c98

when moving to a new parent.

I had to update a couple of test expectations.

BUG=137342
TEST=covered by tests
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831297

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151478 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=nduca


Review URL: https://chromiumcodereview.appspot.com/10823296

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151476 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jamesr@chromium.org
BUG=141439

Review URL: https://chromiumcodereview.appspot.com/10824290

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151475 0039d316-1c4b-4281-b951-d872f2087c98

This is part of Chrome for Android upstreaming.

This was causing an unnecessary diff with downstream.

BUG=136750


Review URL: https://chromiumcodereview.appspot.com/10828302

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151474 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151473 0039d316-1c4b-4281-b951-d872f2087c98

r151471 - Add 'License Android Compatible' field to openssl license metadata

TBR=jnd
BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10830306

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140187


Review URL: https://chromiumcodereview.appspot.com/10855122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151470 0039d316-1c4b-4281-b951-d872f2087c98

The samples are now disabled on API pages. This should make the server run
faster.

BUG=142011


Review URL: https://chromiumcodereview.appspot.com/10836223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151468 0039d316-1c4b-4281-b951-d872f2087c98

The class implementation is all to do with UI, and has dependencies on
GTK UI code, so this seems a more appropriate home for it.  Moving it
to its rightful home also removes a couple of unwanted includes from
chrome/browser/autofill/DEPS.

TBR=ben@chromium.org
BUG=140037

Review URL: https://chromiumcodereview.appspot.com/10828259

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151467 0039d316-1c4b-4281-b951-d872f2087c98

Just a quick fix to get the linux swarm machine able to compile again.

NOTRY=true
BUG=


Review URL: https://chromiumcodereview.appspot.com/10855131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123750


Review URL: https://chromiumcodereview.appspot.com/10832290

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151465 0039d316-1c4b-4281-b951-d872f2087c98

in chrome. Hopefully other .gypi sharing can follow.
Review URL: https://chromiumcodereview.appspot.com/10854130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151463 0039d316-1c4b-4281-b951-d872f2087c98

For most directories, we use a regex of whitelisted licenses to parse the 'License' field from the metadata. In some case, for example, where a custom license is used, we rely on a new 'Android Compatibility' field.

This functionality will be used by the snapshot tool, which will exclude these incompatible directories from the snapshot in the Android tree.

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10829272

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151462 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151461 0039d316-1c4b-4281-b951-d872f2087c98

TBR=enne@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10823307

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151460 0039d316-1c4b-4281-b951-d872f2087c98

1280x800 is resolution of chromebook screens. For clients with higher
resolution 1280x800 is still better because of most modern screens
have 16:10 aspect ratio.


Review URL: https://chromiumcodereview.appspot.com/10836226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151459 0039d316-1c4b-4281-b951-d872f2087c98

Previously JingleThreadWrapper required a MessageLoop. In NaCl
we don't have MessageLoop for the main plugin thread, but have a task runner.
This CL allows to use JingleThreadWrapper on the main NaCl thread.

BUG=134216
TBR=tommi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10823224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151458 0039d316-1c4b-4281-b951-d872f2087c98

CHECK() messages get stripped out in official builds.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10826290

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151457 0039d316-1c4b-4281-b951-d872f2087c98

This picks up a style fix
(https://code.google.com/p/seccompsandbox/source/detail?r=187)

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10837232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151456 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:142580
TEST=manually check if trashed file doesn't appear in file browser.

Review URL: https://chromiumcodereview.appspot.com/10834304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151455 0039d316-1c4b-4281-b951-d872f2087c98

If negotiated protocol is SPDY/3 or later, well defined name of SYN_STREAM and
SYN_REPLY must be colon prefixed name.

BUG=42320
TEST=net_uinttests


Review URL: https://chromiumcodereview.appspot.com/10843050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151453 0039d316-1c4b-4281-b951-d872f2087c98

Only track http and https in duplicate resource handler metrics. Specifically, exclude data and blob urls because they can be generated by content. This avoids a slow leak with generated URLs.

R=gavinp@chromium.org,frankwang@google.com
BUG=114570

Review URL: https://chromiumcodereview.appspot.com/10824236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142336


Review URL: https://chromiumcodereview.appspot.com/10832273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=gman@chromium.org
TBR=nfullagar@google.com

Review URL: https://chromiumcodereview.appspot.com/10829307

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151450 0039d316-1c4b-4281-b951-d872f2087c98

Sometimes the next perf test would try to start the http server,
but the port wouldn't be available. This matches what we do on Linux.

In the long run, we should use a random port to avoid having to wait.

BUG=29228


Review URL: https://chromiumcodereview.appspot.com/10834299

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151449 0039d316-1c4b-4281-b951-d872f2087c98

Changes to the UI to bring it closer to the mocks:
- Add cookies section to Permissions tab, and add "Cookies" and "Permissions" headers.
- Change identity status text to green when the site identity is verified.
- Add permission icons to the Permissions tab.

BUG=135407

Review URL: https://chromiumcodereview.appspot.com/10831280

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151448 0039d316-1c4b-4281-b951-d872f2087c98

This is part of Chrome for Android upstreaming.

It affects how long our side of an idle TCP socket can know the other end has
closed the connection. The default value is 2 hours which is too long. We
should use the same values on Linux.

BUG=136750


Review URL: https://chromiumcodereview.appspot.com/10831286

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136519
TEST=browser_tests --gtest_filter=SystemInfoCpuApiTest.*


Review URL: https://chromiumcodereview.appspot.com/10830240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151446 0039d316-1c4b-4281-b951-d872f2087c98

Get ChangeList using Drive V2 API and then converts to
DocumentFeed.  This is not optimal but change can be minimal
to make file list appear in FileBrowser UI, which makes
other development/debugging/refactoring easier.

This depends on the change in
https://chromiumcodereview.appspot.com/10837201/
for GetKind() function.

BUG=chromium:127728
TEST=specify "--enable-drive-v2-api" and open file browser (Ctrl-M), then go to drive folder and see if file listing works.

Review URL: https://chromiumcodereview.appspot.com/10837201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151445 0039d316-1c4b-4281-b951-d872f2087c98

- Adding 'offset' value in the preference and set to display controller
- Allow offset in Options UI too
- Redesign the Options UI a bit: now it has "apply" button rather than just applying on mouse-up, and remove 'ok' button.  See crbug.com/130385#c26 for the mock.

R=ben@chromium.org
BUG=137516,130385

Review URL: https://chromiumcodereview.appspot.com/10836046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151444 0039d316-1c4b-4281-b951-d872f2087c98

of DownloadFileImpl by DownloadItemImpl.

BUG=123998
R=benjhayden@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10799005

TBR=rdsmith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827314

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151443 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138013


Review URL: https://chromiumcodereview.appspot.com/10830282

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134748


Review URL: https://chromiumcodereview.appspot.com/10854123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151439 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151438 0039d316-1c4b-4281-b951-d872f2087c98

The modification is not needed anymore, because for dirty files
we always look up metadata from the local cache file (r148712).

Besides, this patch renames OnXXXForCloseFile to CloseFileAfterXXX,
to match the recent convention.

BUG=142466
TEST=existing tests, in particular:
 browser_tests --gtest_filter='RemoteFileSystemExtensionApiTest.RemoteMountPoint'
 unit_tests --gtest_filter='GDataFileSystemTest.OpenAndCloseFile'

Review URL: https://chromiumcodereview.appspot.com/10830298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151437 0039d316-1c4b-4281-b951-d872f2087c98