- 09 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f87536c9de24..4e1d6ce38422 git log f87536c9de24..4e1d6ce38422 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 danilchap@webrtc.org Rename java VideoCodecType to VideoCodecMimeType 2020-03-09 phoglund@webrtc.org Purge phoglund from most OWNERS files. 2020-03-09 brandtr@webrtc.org Add |rids| and |mid| printout to RtpConfig::ToString(). 2020-03-09 ilnik@webrtc.org Wire up internal libvpx VP9 scaler to statistics proxy Created with: gclient setdep -r src/third_party/webrtc@4e1d6ce38422 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2aa7a3f27f170784408bfc6e03015d4961d31d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748363}
-
Daniele Castagna authored
Unfortunately David left the team more than a years ago. Having his username in OWNERS files causes some confusion sometimes (crrev.com/c/2090605). This CL removes David from the OWNERS files. Change-Id: I09de963f21821e60f1ded2aa4a2cc1ddbbdfa4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093020Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#748362}
-
Nicolas Ouellet-Payeur authored
Roll the changes to traffic_annotation_auditor.exe from these CLs: https://chromium-review.googlesource.com/c/chromium/src/+/2070818 https://chromium-review.googlesource.com/c/chromium/src/+/2079202 The auditor now requires chrome_settings_full_runtime.proto to be generated from policy_templates.json. Also update BUILD files to so that it's generated when building Chrome (for developers who run the auditor locally) Bug: 1046869, 1048178 Change-Id: I4dcddd031b3d242c2326fea50eaf548603b5f627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079648 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#748361}
-
Bettina authored
Bug: 1026006 Change-Id: I4f1329df285d044263d52c32447fdab730810cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092181Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#748360}
-
Anqing Zhao authored
On CrOS, the crash reports submission records are stored in a local file: /var/spool/crash/uploads.log. These related infos are uploaded to the crash server periodically. Although our users cannot access to the crash details directly, they still have the requirement to aggregate the crash numbers and causes. This change is to collect required data from local logging file and submit them to the DMServer by using CrashReportInfo proto. Bug: 1040078 Change-Id: I2733364dcbc681af3cdd90ef6d9ef165b991c0dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011852 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#748359}
-
Andrew Grieve authored
This will let GN validate that deps are not missed. Note: deps->public_deps needed in order to appease GN's "do you depend on the targets that produce your inputs" check (you can directly depend on them, or indirectly when listed as public_deps). Bug: 1054892 Change-Id: I25ee07e95cf7744428c95cc19141b3ab4c0d5bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090030Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#748358}
-
Sam Bowen authored
* Add a validator that removes properties that are not the right type. * Add double, time, and timedelta types in the document metadata mojo structure. * Use the new mojo types in document metadata extractor. Downstream clank will not be able to read fields parsed into the new type, but will just skip over them. We should consider updating support there. http://cs/clank/java/src/com/google/android/apps/chrome/icing/AppIndexingReporterInternal.java?l=133 Bug: 1044250 Change-Id: Icfd7f0db74abf7bd1261b30dc416c94a7a23b4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062907Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#748357}
-
edchin authored
This CL adds iOS where pertinent to the chrome flag ownership doc. Bug: 1058614 Change-Id: I6d6af5afb2b3948c59524bde180a9b1a12ac6fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095144Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748356}
-
Nasko Oskov authored
This API is no longer used and the bug it references is closed. Bug: 768526 Change-Id: I6570ce4531c7cccd47ab21e26ad7d570d10e6c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091939 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#748355}
-
Owen Min authored
Request extension is a multi-steps process. The policy may be updated during the requests. If policy is updated to whitelist or blacklist an extension right before a user confirms the request dialog, we will show the request approved/rejected notification immediately. Bug: 1006899 Change-Id: I0f41774b8c1a89dd9b34465f8237320bdddc6dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089996 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#748354}
-
Evan Stade authored
The beforeunload timer in RenderFrameHostImpl may take a long time to actually run if there are other tasks queued before it in the ui thread task runner. This change allows sudden termination in the case where the user tries to close a tab, the timeout fails to fire quickly, and the user tries to close the tab again. This also skips the close event if beforeunload has already timed out (not allowing the renderer another chance to time out). This allows the user to close, in relatively short order, tabs that run the following: while (true) console.log("bar"); Whether that's in a general context, in the beforeunload handler, or both. Bug: 1056257 Change-Id: Idf1242dab5f06e347cf5fc2ca1019255f0da774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092123Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#748353}
-
Marijn Kruisselbrink authored
The ChooseFileSystemEntriesType enum values were changed from camel-case to dashDelimited in M81. In M82 we only want the new dash-delimeted version available, so remove the legacy ones. Bug: 1020715 Change-Id: Id36e8d1009a53039404859c26c8508a5843c7624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095138 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#748352}
-
Clark DuVall authored
Moves over the tests and puts everything in the permissions namespace. ChooserContextBase was originally moved to //components/permissions in http://crrev.com/c/2083454. Bug: 1052375, 1025609 Change-Id: Id44a8f9468a9db6ec3fdd04896f3c97f960d112f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092156Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#748351}
-
Saurabh Nijhara authored
Screen This CL makes the the update required screen use the checking- downloading-update polymer element so that the UI for this process remains in sync with the Update Screen which also uses the same element. A new property for controlling the download message in the dialog is added in the element as it is different for the UpdateRequiredScreen as per the UI mocks. Bug: 1048607 Change-Id: I9a9c26f10eff2b64602ffb59b1da1f61d4278b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078575 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#748350}
-
Adrienne Walker authored
This function collides with the quota StatusCallback, so rename it to avoid any issues and to make the move cl easier to read. Bug: 1015214 Change-Id: I4f82b843ccd27561ed1fb27e76a38b72cf0d2d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092931 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#748349}
-
Raymond Toy authored
This replaces PipelineStatusCB with PipelineStatusCallback in the last places except for error_cb_, which seems like it can be called more than once in a test. Bug: 1007799 Change-Id: Ib60a01634267ea4f5313b8ac8f495925a6f3d989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993423Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#748348}
-
Friedrich Horschig authored
With this CL, the leak icon will change between four states that depend on the leak check status: * a checkmark if the check was completed without finding leaks * a triangle if the check was completed but leaks were found * a loading spinner while the leak check is running * an exclamation if the check can't be completed because of an error Screenshots at the linked https://crbug.com/1047726#c31 Bug: 1047726 Change-Id: I27a9ed3f3df18ce2fe8f32de2a7c16bf4cd07f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087342 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#748347}
-
Nate Chapin authored
Bug: 979017 Change-Id: I5011e209ed57110a33ae7a49b2dc083815abc8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091637 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#748346}
-
Jonathan Ross authored
This reverts commit 00861a81. Reason for revert: Speculating that this is causing continuous GPU crashes on Vulkan: Android: https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20SkiaRenderer%20Vulkan%20%28Pixel%202%29/8818 Windows: https://ci.chromium.org/p/chromium/builders/ci/Win10%20FYI%20x64%20dEQP%20Release%20%28NVIDIA%29/6153 Original change's description: > VulkanSwapChain: Use VK_KHR_incremental_present for better performance. > > Bug: 1059598 > Change-Id: I4ec9ae96b97606d4e64d6ce8874471b00586def8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094235 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748280} TBR=penghuang@chromium.org,vasilyt@chromium.org Change-Id: I40c693b901282f3e7ed300f6e55249906e8a8559 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094547Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#748345}
-
Bo Liu authored
As mentioned in the bug, when renderer does not produce a frame, ChildFrame will not update layer_tree_frame_sink_id in WaitOnFutureIfNeeded, so it's kept at 0u. Then this messes up HardwareRenderer::last_committed_layer_tree_frame_sink_id_ tracking which can lead to resources incorrectly not returned in HardwareRenderer::ReturnResourcesToCompositor. Not only positive values are valid frame_sink_id, so it is safe to use 0u as a sentinel value. See g_next_layer_tree_frame_sink_id in render_thread_impl.cc. So avoid updating HardwareRenderer if the id is invalid. Bug: 1059869 Change-Id: Ibcec3d474ab09f360d4b16c1ca20e46527603565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094471Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#748344}
-
Jeremy Roman authored
This works around issues with mojom dependencies by removing a path by which certain tricky source files could end up requiring a mojom generated dependency. These headers are often included and don't actually need more than a forward declaration of BlinkTransferableMessage to build. Bug: 1059367 Change-Id: Iaee2c3c146f24977f3e0b8db52c2a59425824b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095205 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#748343}
-
Josh Nohle authored
Add functions to print CryptAuth protos in JSON format. Use these for verbose logs throughout the v2 DeviceSync flow. Note: cryptauth_logging.h is included in the enrollment and device managers to allow for better printing of the InvocationReason. Manually tested to verify formatting. Bug: 951969 Change-Id: Icb9540541f6a080f7bd6f1e661c124eb610dcc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091707Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#748342}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ebcfc4bfc670..cdb673f91738 Created with: gclient setdep -r src-internal@cdb673f91738 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044639,chromium:1049638 Tbr: jbudorick@google.com Change-Id: I06b5bba8d21700418ac669adbe8d24ae7d8ad651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095417Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748341}
-
Kevin McNee authored
This test is flaky under MSAN. Tbr: alemate@chromium.org Bug: 1031545 Change-Id: Ie22aff087919b8f7c4f74d06710b500734d6766a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095405Reviewed-by:
-
Mustafa Emre Acer authored
Background (taken from crbug/583195): translation_expectations.pyl contains the list of translatable grd files and the languages they're expected to be translated into. It's used internally during the translation process to determine which grd files should be copied to google3 for translation, etc. Each repository with grd files (desktop, Android, iOS) has a translation_expectations.pyl file, which must list every grd file that contains strings. translation_expectations.pyl isn't used at all when building (neither locally nor on the bots), so there's no indication to developers if translation_expectations.pyl needs to be updated (e.g. because a grd file was added) or is malformed. Instead, an error will occur much later when the weekly translation run happens, causing unnecessary back-and-forth between TPMs and developers and introducing delays. This happens every few weeks. This CL adds a presubmit that checks if the contents of the translation_expectations.pyl matches the list of .grd files in the repository. The presubmit only runs if a .grd or .grdp file is modified, so in most cases it's a no-op. It lists the names of missing and unlisted files in the warning. Bug: 583195 Change-Id: I5013311dac5db1f0578f59022832dc8e33c1ee37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464078Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#748339}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f291e9f01a9c..c598caf81aa3 git log f291e9f01a9c..c598caf81aa3 --date=short --first-parent --format='%ad %ae %s' 2020-03-08 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-07 sanikak@chromium.org auto_updater: update _GetPayloadSize method to ssh into devserver 2020-03-07 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-06 saklein@chromium.org image_test: Remove special case check. 2020-03-06 kimjae@chromium.org image_test: Allow /opt/pita/* -> /run/* 2020-03-06 saklein@chromium.org flash_ap: Python 3 compatibility fix. 2020-03-06 ayatane@chromium.org cros_update: Allow Python 2 again for real Created with: gclient setdep -r src/third_party/chromite@c598caf81aa3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I5e2bd8c791513707261c564eb8368ec3cb3df5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094614Reviewed-by:
-
Ana Salazar authored
Because we are scaling the icon bounds to animate long press gestures, some values might be incorrectly rounded. Change the method that calculates the bounds with scale to use floating values and then Round the resulting rect to adapt to grid layer. Also, include the icon shadows for scaling. Bug: 1050730 Change-Id: Ief19fcf0d2894f570a77047f8209e53eeb461b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086317Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#748337}
-
Sujie Zhu authored
Add base::string16 nickname to credit card class. Also update Compare() function (which is used in sync bridge to calculate the diff between existing cards and new synced cards) to ensure that any updates on nickname will be stored in autofill table. We use base::string16 type because it's a UI string. The follow up will be: 1. update masked_credit_card table schema with nickname column 2. store the nickname from sync response. Bug: 1059087 Change-Id: Ib01e30aa905559aee90608ddda702218d361d58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091716 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#748336}
-
Avery Musbach authored
Bug: None Change-Id: I57b77195bafd94aa6f0c06d7d9fa8a5a8ce1b189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095206Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#748335}
-
Alain Michaud authored
Reason for revert: The flag has never been used and the underlying fix is being replaced by an upstream bluez fix which does not rely on this interface. Bug: 942089 Originally Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652709 Change-Id: I52e6c4f3762f248bdc94383ee5b7f39935db6881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948095Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Commit-Queue: Alain Michaud <alainm@chromium.org> Cr-Commit-Position: refs/heads/master@{#748334}
-
Nate Fischer authored
This guards stability metrics behind kWebViewWakeMetricsService. While not directly related, AwStabilityMetricsProvider has the same effect as enabling this flag because it logs a "user action" for every page load. This puts the entire metrics provider behind the off-by-default flag, to avoid any accidental UMA volume increase until we've found a path forward for launching that feature. Bug: 1058684 Test: None Change-Id: I0937a1d44aaf4d0c54dee8dfe4644c2216d77891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095196 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#748333}
-
edchin authored
We're bringing Chrome Flag Ownership to iOS go/chrome-flags-ios More about flag ownership here: https://chromium.googlesource.com/chromium/src/+/master/docs/flag_ownership.md This CL adds flags used in iOS with these owners: ewannpv@ gambard@ olivierrobin@ sczs@ thegreenfrog@ Note that the unit test to enforce flag ownership in iOS is not yet enabled. It will be enabled once all iOS flags have been added to flag-metadata.json. Change-Id: Ia37ba495a6e235ed7ac0f2591b261d8c45be377b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092811Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Adrienne Walker authored
Bug: 1015214 Change-Id: Ib10ceee07159d4086526f1dc3c36f45f1b49f488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090175Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/532be50b761b..be6cd5188880 git log 532be50b761b..be6cd5188880 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 rharrison@chromium.org Rolling 5 dependencies Created with: gclient setdep -r src/third_party/dawn@be6cd5188880 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I24b3d3bdbd689f0fa4c3799d36510d4815db68d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095323Reviewed-by:
-
Adam Langley authored
Not currently wired up from anywhere, full of TODOs, and not yet plumbed into the GMS FIDO APIs and thus non-functional. BUG=1002262 Change-Id: I65a01b6cf38ce9897dc83310f3af6c6b3c0c6e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079613Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#748329}
-
Scott Violet authored
This reverts commit c00d0991. Reason for revert: This is causing dependency errors on some chromeos bots. See https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3850 : Step _generate_buildfiles failed. Error logs are shown below: ERROR Unresolved dependencies. //chrome:angle_vulkan_symbols(//build/toolchain/linux:clang_x64) needs //third_party/angle/third_party/vulkan-headers/src:libvulkan(//build/toolchain/linux:clang_x64) Original change's description: > Enable GL_TEXTURE_2D for IO-Surface-backed textures on SwANGLE > > GL_ANGLE_rectangle_texture is unavailable on Swiftshader's Vulkan > frontend, so SwANGLE on Mac uses 2D textures instead. > > Bug: chromium:1015454 > Change-Id: Id99850fbfae798b33eaff4f3a285deb043b4ae7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056931 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > Cr-Commit-Position: refs/heads/master@{#748322} TBR=avi@chromium.org,dcheng@chromium.org,ccameron@chromium.org,geofflang@chromium.org,kbr@chromium.org,jonahr@google.com Change-Id: I46797fd879c66b3af00eeafd5264657223a6c20a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1015454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095406Reviewed-by:
-
Greg Thompson authored
BUG=1043624 R=zmin@chromium.org Change-Id: I85d61ae1e6d937011661c54ff227ead8962a971a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093593Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Kevin McNee authored
Mark http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces-worklet-scope.html flaky Tbr: majidvp@chromium.org Bug: 1059123 Change-Id: I5a00a50b719b5b025c9d66420c82025ebd81d88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094251Reviewed-by:
-
Tom Anderson authored
The flag was set iff is_desktop_linux, so remove it to reduce some complexity. R=sky BUG=None Change-Id: I4948debfa1eafa33532689c7d3f847a1b0cb9a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092875 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Oriol Brufau authored
It seems that r713066 made this test fail in legacy (not in LayoutNG). Now it has been fixed as a side-effect of r745012. Just adding it to WPT to avoid future regressions. BUG=1051086 Change-Id: I83a6db87cd5f5d5a64046681b5e8a5f31cf0998c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093227Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#748324}
-
