1. 28 Mar, 2011 12 commits
    • sergio@webkit.org's avatar
      2011-03-28 Sergio Villar Senin <svillar@igalia.com> · 07db218d
      sergio@webkit.org authored
              [GTK] Fullscreen tests failing after r82084
              https://bugs.webkit.org/show_bug.cgi?id=57219
      
              Skipping some fullscreen tests failing since r82084
      
              * platform/gtk/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82094 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      07db218d
    • mjs@apple.com's avatar
      2011-03-28 Maciej Stachowiak <mjs@apple.com> · c1ab2f17
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Assigning location.path to something that doesn't start with / mangles the authority
              https://bugs.webkit.org/show_bug.cgi?id=57209
              <rdar://problem/9195132>
              
              Tests: http/tests/uri/assign-path-with-leading-slash.html
                     http/tests/uri/assign-path-without-leading-slash.html
      
              * platform/KURL.cpp:
              (WebCore::KURL::setPath): If the new path does not have a leading slash, add one.
      2011-03-28  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Assigning location.path to something that doesn't start with / mangles the authority
              https://bugs.webkit.org/show_bug.cgi?id=57209
              <rdar://problem/9195132>
      
              * http/tests/uri/assign-path-with-leading-slash-expected.txt: Added.
              * http/tests/uri/assign-path-with-leading-slash.html: Added.
              * http/tests/uri/assign-path-without-leading-slash-expected.txt: Added.
              * http/tests/uri/assign-path-without-leading-slash.html: Added.
              * http/tests/uri/resources/assign-path-landing.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82093 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c1ab2f17
    • yutak@chromium.org's avatar
      2011-03-28 Yuta Kitamura <yutak@chromium.org> · 14a32605
      yutak@chromium.org authored
              Unreviewed, add Chromium test expectation for fast/text/justify-ideograph-leading-expansion.html.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82092 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      14a32605
    • rniwa@webkit.org's avatar
      2011-03-28 Ryosuke Niwa <rniwa@webkit.org> · 3dcf54c4
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Extract functions to update logical width from computeInlineDirectionPositionsForLine
              https://bugs.webkit.org/show_bug.cgi?id=57213
      
              Extracted updateLogicalWidthForLeftAlignedBlock, updateLogicalWidthForRightAlignedBlock,
              and updateLogicalWidthForCenterAlignedBlock from computeInlineDirectionPositionsForLine.
      
              They are used to update logical widths, logical left, and total logical width for left,
              right, and center aligned blocks.
      
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::updateLogicalWidthForLeftAlignedBlock):
              (WebCore::updateLogicalWidthForRightAlignedBlock):
              (WebCore::updateLogicalWidthForCenterAlignedBlock):
              (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82091 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3dcf54c4
    • evan@chromium.org's avatar
      2011-03-28 Evan Martin <evan@chromium.org> · 0b2ef2a8
      evan@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Refactor duplicate code in HTMLTextElement
              https://bugs.webkit.org/show_bug.cgi?id=57215
      
              * html/HTMLTitleElement.cpp:
              (WebCore::HTMLTitleElement::childrenChanged):
              This method did an equivalent loop to the text() method on
              the same object.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82090 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0b2ef2a8
    • yutak@chromium.org's avatar
      2011-03-28 Yuta Kitamura <yutak@chromium.org> · 8d964ac2
      yutak@chromium.org authored
              Unreviewed, update Chromium test results for plugins/plugin-javascript-access.html.
      
              * platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
              * platform/chromium-win/plugins/plugin-javascript-access-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82089 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8d964ac2
    • ukai@chromium.org's avatar
      2011-03-27 Fumitoshi Ukai <ukai@chromium.org> · c070063b
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              Don't call WebSocket::didClose() more than once.
              https://bugs.webkit.org/show_bug.cgi?id=57081
      
              If WebSocket close() is called, and connection is established, then
              it will call didClose() that resets m_channel to 0.
              After that, when connection is closed, WebSocketChannel will call
              didClose for the WebSocket instance.
      
              * http/tests/websocket/tests/close-unref-websocket-expected.txt: Added.
              * http/tests/websocket/tests/close-unref-websocket.html: Added.
              * http/tests/websocket/tests/hanging-handshake_wsh.py: Added.
      2011-03-27  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Don't call WebSocket::didClose() more than once.
              https://bugs.webkit.org/show_bug.cgi?id=57081
      
              If WebSocket close() is called, and connection is established, then
              it will call didClose() that resets m_channel to 0.
              After that, when connection is closed, WebSocketChannel will call
              didClose for the WebSocket instance.
      
              Call WebSocketChannel::disconnect() before m_channel = 0 to make sure
              WebSocketChannel suppress the second didClose().
      
              Test: http/tests/websocket/tests/close-unref-websocket.html
      
              * websockets/WebSocket.cpp:
              (WebCore::WebSocket::didClose):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82088 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c070063b
    • aestes@apple.com's avatar
      2011-03-27 Andy Estes <aestes@apple.com> · 5a95a5f2
      aestes@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Correctly get a plug-in's MIME type when it uses WebPluginMIMETypesFilename
              https://bugs.webkit.org/show_bug.cgi?id=57205
              
              If the plug-in's Info.plist uses WebPluginMIMETypesFilename to specify
              plug-in MIME types, WebKit has to check for a property list file in
              ~/Library/Preferences for the MIME type dictionary.
      
              * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
              (WebKit::getMIMETypesFromPluginBundle): If the bundle's Info dictionary
              has the key WebPluginMIMETypesFilename, open the property list
              specified by that key's value and return the MIME type dictionary from
              there. Otherwise, return the MIME type dictionary specified by the key
              WebPluginMIMETypes.
              (WebKit::getPluginInfoFromPropertyLists): Call
              getMIMETypesFromPluginBundle().
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82087 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5a95a5f2
    • yutak@chromium.org's avatar
      2011-03-27 Yuta Kitamura <yutak@chromium.org> · 2c902848
      yutak@chromium.org authored
              Unreviewed, add Chromium test results for fast/blockflow/fallback-orientation.html.
      
              * platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.checksum: Added.
              * platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.png: Added.
              * platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.checksum: Added.
              * platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.png: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82086 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2c902848
    • abarth@webkit.org's avatar
      2011-03-27 Adam Barth <abarth@webkit.org> · 1dd689c0
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Fix script-src redirect handling
              https://bugs.webkit.org/show_bug.cgi?id=57196
      
              Test both allow => disallow and disallow => allow redirect cases.
              Previously, we had incorrect expectations for one of the redirect
              cases.  Also, I've updated the policy syntax to match the default-src
              syntax.
      
              * http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
              * http/tests/security/contentSecurityPolicy/script-src-redirect.html:
      2011-03-27  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Fix script-src redirect handling
              https://bugs.webkit.org/show_bug.cgi?id=57196
      
              Resource-loading requirements in CSP apply to each hop in the redirect
              chain.  To make that work properly, we need to move enforcement into
              the loader.  Fortunately, we already have a choke-point in the loader
              for enforcing this kind of policy.
      
              * dom/ScriptElement.cpp:
              (WebCore::ScriptElement::requestScript):
              * html/parser/HTMLDocumentParser.cpp:
              * html/parser/HTMLDocumentParser.h:
              * html/parser/HTMLScriptRunnerHost.h:
              * loader/cache/CachedResourceLoader.cpp:
              (WebCore::CachedResourceLoader::canRequest):
              * page/ContentSecurityPolicy.cpp:
              (WebCore::ContentSecurityPolicy::allowScriptFromSource):
              * page/ContentSecurityPolicy.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82085 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1dd689c0
    • jer.noble@apple.com's avatar
      2011-03-27 Jer Noble <jer.noble@apple.com> · b13ab418
      jer.noble@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Full Screen: disable keyboard access by default
              https://bugs.webkit.org/show_bug.cgi?id=56684
      
              Pass whether keyboard access was requested up to ChromeClient when asking
              if fullscreen mode is supported.
      
              * dom/Document.cpp:
              (WebCore::Document::webkitRequestFullScreenForElement):
              * page/ChromeClient.h:
              (WebCore::ChromeClient::supportsFullscreenForElement):
      2011-03-27  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Full Screen: disable keyboard access by default
              https://bugs.webkit.org/show_bug.cgi?id=56684
      
              Take into account whether keyboard access was requested when deciding whether full
              screen mode is supported.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::supportsFullScreenForElement):
              * WebView/WebView.mm:
              (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
              * WebView/WebViewInternal.h:
      2011-03-27  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Full Screen: disable keyboard access by default
              https://bugs.webkit.org/show_bug.cgi?id=56684
      
              Take into account whether keyboard access was requested when deciding whether full
              screen mode is supported.
      
              * UIProcess/WebFullScreenManagerProxy.cpp:
              (WebKit::WebFullScreenManagerProxy::supportsFullScreen):
              * UIProcess/WebFullScreenManagerProxy.h:
              * UIProcess/WebFullScreenManagerProxy.messages.in:
              * WebProcess/FullScreen/WebFullScreenManager.cpp:
              (WebKit::WebFullScreenManager::supportsFullScreen):
              * WebProcess/FullScreen/WebFullScreenManager.h:
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::supportsFullScreenForElement):
              * WebProcess/WebCoreSupport/WebChromeClient.h:
      2011-03-27  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Full Screen: disable keyboard access by default
              https://bugs.webkit.org/show_bug.cgi?id=56684
      
              Accept the withKeyboard parameter to supportsFullScreenForElement.
      
              * DumpRenderTree/mac/UIDelegate.mm:
              (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82084 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b13ab418
    • paroga@webkit.org's avatar
      2011-03-27 Patrick Gansterer <paroga@webkit.org> · 7ecd9f4b
      paroga@webkit.org authored
              Reviewed by David Levin.
      
              check-webkit-style should check ChangeLog for a valid bug number
              https://bugs.webkit.org/show_bug.cgi?id=57184
      
              * Scripts/webkitpy/style/checker.py:
              * Scripts/webkitpy/style/checker_unittest.py:
              * Scripts/webkitpy/style/checkers/changelog.py: Added.
              * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@82083 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7ecd9f4b
  2. 27 Mar, 2011 28 commits