- 23 Jun, 2020 40 commits
-
-
Kenneth Russell authored
These are converted to RGBA16F format, which WebGLImageConversion didn't handle, and the calling code didn't detect that failure. In WebGLImageConversion, handle unpacking half-float data to 32-bit floating-point, as well as all packing conversions to the supported texture upload formats. Expand comments describing the needed conversions and remove old incorrect FIXMEs. Tested thoroughly with the enhanced image_bitmap_from_blob WebGL conformance tests in https://github.com/KhronosGroup/WebGL/pull/3100 . All versions of the test (2D/3D, all texture upload formats) pass in Chromium with this fix. Bug: 1058160 Change-Id: I6bf4e5b9370cbd471e02030858ca1e93c7b88af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253372 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#781140}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3b5a5e5b9d33a8e360c0160a9d42a5806c412eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258962Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781139}
-
Takashi Toyoshima authored
This change removes the last TODO in the cors-and-webview-api.md. file:///android_asset/ and file:///android_res/ are almost same with other usual file:// URLs, but still can be accessible even if AllowFileAccess is set to false. Test cases mentioned in the doc are also added to ensure legacy and current CORS behaviors. TEST=./out/a/bin/run_webview_instrumentation_test_apk -A Feature=CORS Bug: 1035366 Change-Id: I5bdb7c54e261136d099944ed3690e6892fe72c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253262 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781138}
-
Brian Sheedy authored
Deduplicates the Skia Gold code used by the Android instrumentation tests and the GPU Telemetry-based pixel tests, as they were effectively identical with only a few differences. This is accomplished by moving the majority of the code to //testing/skia_gold_common and having each test harness extend the abstract classes as necessary. Bug: 1093994 Change-Id: Icef9f22d896a82672f3c64a26d38c026bf6bd02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253147Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781137}
-
danielng authored
Updating the port forwarding UI to guidelines suggested by UX. This includes updating the port forwarding dialog in regards to error handling, adding a toast when activating a port fails and also includes adding tests for the updated features and revamping some of the older tests to be async functions. Screenshots: https://drive.google.com/drive/folders/19BU8axWIax1f-8axva5L48jR0TRbgyXb?usp=sharing Some of the mocks: go/crostini-ports-design Test: Added browser tests, revamped others, and ran tests Bug: 848127 Change-Id: I4639df00a2e37b18a93a4436cc6636cee182c165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251617Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#781136}
-
Harry Cutts authored
This is a USB wireless gamepad in the PlayStation style, which seems to be mostly available in Japan. (Amazon: https://amzn.com/B01MXY05W0) It complies with XInput. Bug: b:159368181, chromium:1096754 Test: Connect the gamepad in "X" mode, load gamepadviewer.com, and check that pressing buttons and moving axes is correctly reflected on-screen. Change-Id: Ie0758fceb09ed6b3c701672e27a4c045a231dca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252469Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#781135}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/716bc4468192..3231e4267bf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC caseq@google.com,hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025606,chromium:1057553,chromium:1059455,chromium:1080747,chromium:1095642,chromium:1096666 Tbr: caseq@google.com,hayato@google.com Change-Id: Ia52a3ed86e405d730315f3459faa205bd4225290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258662Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781134}
-
David Bokan authored
The text fragment highlighting can be distracting for many users and the click/tap to dismiss isn't very discoverable. To make this easier on the eyes, dismiss the highlight as soon as the user starts scrolling. Bug: 1096575 Change-Id: I42f0b12e50275e7325a3647ee7a2100527602507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255780 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#781133}
-
Xiaocheng Hu authored
The function currently uses the LayoutObject of the documentElement as the layout invalidation root, which is incorrect because there can be objects not in its subtree. For example, a modal dialog. This patch fixes it by using the LayoutView, the root of the layout tree, as the layout invalidation root. Bug: 1092411 Change-Id: Ic2475fe1fc9fd9029699a410b4f03a9f3812e240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255738Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#781132}
-
Hiroki Sato authored
CL:2222068 modified ARC++ focusability and accessibility name computation so that focusable views gets name from its non-focusable descendants. We should not apply this to virtual nodes like WebView. AX-Relnotes: n/a. Bug: b:152930082 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Open Gmail app. WebView nodes (leaf nodes) correctly gets focus from ChromeVox. Change-Id: I8bc7b46f1b557aa13b4953243ebbd53425f0052f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256922 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#781131}
-
Moe Ahmadi authored
Previously, the realbox input text would remain unchanged when the suggestion group header was being focused (say by tabbing into it) despite the selection being reset. This CL makes those behaviors consistent by clearing the realbox input in addition to resetting selection when the suggestion group header geet focused. Bug: 1095719 Change-Id: I5bcabb4c455731b0002357639555d3d1452697ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258466Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781130}
-
Ian Kilpatrick authored
TBR=kojii@chromium.org Bug: 974666 Change-Id: If7e93264db3afdbeddcf4f39c427bd378bf83bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258471Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#781129}
-
Sadrul Habib Chowdhury authored
Create a trace-event at the point when UMA is reported, so that it is easier to associate the UMA with the associated frames. BUG=1095186 Change-Id: Id78695d21f3178e69c6025f580c2db49a67e3360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251300 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#781128}
-
Alexandre Courbot authored
When the decoder is reset, the frame splitter should be reset as well. BUG=b:158800859 TEST=VDAtest passes on Hana-kernelnext. Change-Id: I90cd638a4240a4f85b412f4046d8b92fd5241bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257121Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#781127}
-
John Z Wu authored
This is a prerequisite to implementing post submission leak checking for passwords. Bug: 1096281 Change-Id: I7722298bf2d32e1f83afc8a61b5068fc2469e286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250932Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#781126}
-
Chris Thompson authored
Bug: 1089465,1089466 Change-Id: Id5ad8fcf304a378de236ca999baa671a571ca395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258425 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Auto-Submit: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781125}
-
Adam Langley authored
The PRF extension will need a new structure to hold values that |GetAssertionTask| needs, but which aren't part of the getAssertion request itself. This structure will be a second argument, but RunTask doesn't currently support more than one such argument. This CL addresses that. Change-Id: I1aad401d14ab4b7d50e98cf05a63884fa590cf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255209 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#781124}
-
charleszhao authored
(1)The mojom interface is generated with the script "chromeos/services/machine_learning/public/mojom/roll_mojoms.sh" from https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2235485 (2) The handwriting_recognizer.mojom related javascript files also added to the machine_learning_internals.html. Tested: unit tests passed. Bug: 1054621 Change-Id: I1332d763ba2a84e275b9d30e27fa316561e821c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237437Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#781123}
-
edchin authored
TBR=thegreenfrog@chromium.org Bug: 1098117 Change-Id: I97907ef407f106292f7da22e35ea345344c54133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258860Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781122}
-
Curt Clemens authored
A wrapper for OauthApiCallFlow that provides convenience methods StartPostRequest, StartPatchRequest, StartGetRequest. Change-Id: Ib44cb33dbefdd5cbe4f65821aa704c4b1431b606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227862Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#781121}
-
Sam Fortiner authored
Enabling the feature MaxOverlapBoundsForFixed and update relevant test expectations. This feature is generating good performance wins on metrics (see bug for details). Bug: 1058987 Change-Id: Id753cace6795aab715c1fe52ff301705ad5d8fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256366Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#781120}
-
chrome://media-appTrent Apted authored
Language has the region code stripped out, so it can obtain improper strings. A similar approach was used for chrome://help-app in r772523. chrome://media-app needs some basic scaffolding to obtain strings in the first place, which wasn't needed in r772523. Note only the untrusted frame needs updating (there are no translated strings in the host webui). Bug: b/156549136 Change-Id: I162bff0822e282b92406c48d2bd4e3f62656f94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257458Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#781119}
-
Kevin Babbitt authored
Refactoring in preparation for making system color keywords compute to themselves. Remove the one-off flag for storing "is current color" and store StyleColor values directly - these will be flexible enough to retain system color keywords (and in the future, color-mix) through computed-value time. Adjust size assert for BorderValue. Net impact on the structure size is +4 bytes, and from what I can tell we don't store many of these. Bug: 1081945 Change-Id: I70b8868f49d1ea6647b57929f94e9d0bad5ad864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252577 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781118}
-
Christian Biesinger authored
In the short term, we will keep this as an internal value to implement the desired aspect-ratio behavior, where min-content will take the aspect ratio into account but we still need to be able to access the "real" min-content size to implement min-block-size: auto. In the longer term, CSS may add this as a length keyword with the same semantics and this prepares us for that. See also https://github.com/w3c/csswg-drafts/issues/5032 Bug: 1045668 Change-Id: I76a290748e186b900bdbc2c4f5db8db55f6ce04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255564 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#781117}
-
David Munro authored
Test: Unit tests, manual (check in logs that Cicerone was called with StartLxd) Bug: chromium:1064512 Change-Id: I97fa328acc40cc059e79ced2ea668f2eae1d53bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154640 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#781116}
-
Sophey Dong authored
Bug: 1079467, 1098052, 1098053 Change-Id: Iaf75a4b46278746572bb6212403e1efce93628be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255739Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#781115}
-
Anastasia Helfinstein authored
Migrate FocusRingManager to the paradigm of global instances, rather than being managed by the NavigationManager. Stop listening for changes to the current group's position unless it is currently displayed (i.e. for the back button). AX-Relnotes: n/a. Bug: None. Change-Id: Iba6fec2590dbec3c868f79fdbe867106f08c06bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254822 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#781114}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592848702-2ac5c9e9a06cf5eab734ce13fd14059feec74aab.profdata to chrome-mac-master-1592870283-bd79a360110f798833aeb2f02d9fe028111bb918.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I6d4a160fc2fd97dcc24582798227cca1e41854ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258666Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781113}
-
chrome://flagsJonathan Freed authored
Bug: 1069183 Change-Id: I8c8829a0a51be4994b1d35f6344580a3fb14dd71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255128 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#781112}
-
Katie D authored
AX-Relnotes: Hides background shading preview text from a11y Bug: 1097091 Change-Id: Ia1208de4f7dcaa9d09a24ad22c2e8e3dd3d6ea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258854 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#781111}
-
Adam Langley authored
While, at the moment, I don't believe we will end up asking for the authenticator's ECDH key twice, when we support the PRF extension we could. Thus add a cache and skip asking an authenticator for it twice. Change-Id: I73ecaa38447cbbe04f34c12d83f9c79bca553c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255208 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#781110}
-
Wenyu Fu authored
Adding the option for homepage promo to suppress the sign in promo when user is not signed in. Bug: 1068831 Change-Id: I854109c4623c47f98aab1faa34f94f2d55961474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252379 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#781109}
-
Alex Gough authored
This is a reland of 676d0cb1. TBR=fdoray@chromium.org Bug: 1032250 Original change's description: > Use default icons for PE files lacking their own. > > PrivateExtractIcon (underlying the icon loading service) may fail to > supply an icon for PE files that do not have one embedded and would > display as a blank area when downloaded. This change fetches the > default for the file extension prior to fetching the file's embedded > icon. It is difficult to do this only on failure as the ownership of > IconLoader means it has already been deleted when we learn about the > failure. It should be relatively cheap to fetch the default icons as > these will be cached by the OS, and this occurs in the main process. > > Tests: Added LoadDefaultIcon in icon_loader_browser_test > Bug: 1032250 > Change-Id: Ifad1c9f013d0e4fe87aaec5ec0cdeae08d06799e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242371 > Commit-Queue: Alex Gough <ajgo@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779542} Change-Id: Ie7f5e57dbbfb1ebf5d9fc588e15b1a2687212bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254823Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#781108}
-
Manas Verma authored
If a WebAuthn request is pending and another call to CreditCardFIDOAuthenticator is made, then cancel that request. Bug: 949269 Change-Id: I7061809ff873ceaf77b5cfc6f8e7e02f5c1535f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255743Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#781107}
-
Andrew Grieve authored
Speeds up android-binary-size trybot by not having to link libwebviewchromium.so in order to build monochrome's .pak files. Each link is about 8 minutes on the bot. On my speedy machine, extracting the whitelist takes < 2 seconds even without any concurrency. Tested that the whitelist matches what it was before (and the android-binary-size trybot shows this as well). Bug: 1078460 Change-Id: Idac3ba2cb64842539e2f1e2319f35d2495172a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254533Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#781106}
-
Lan Wei authored
We are using ChromeDriver to simulate user inputs in tests, and when we are doing selecting all text by pressing cmd+a on Mac and ctrl+a on other platforms, copying text by pressing cmd+c on Mac and ctrl+c on other platforms, cutting text by pressing cmd+x on Mac and ctrl+x on other platforms, and pasting text by pressing cmd+v on Mac and ctrl+v on other platforms. We are setting the edit commands in blink side in third_party/blink/renderer/core/editing/editing_behavior.cc. Bug: chromedriver:3462 Change-Id: I26ac3aa0c1b7ce518c9e977a51ca2eead369c94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218393Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#781105}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592848702-1e1967415d9c07114dc1aabb08c26a82150dd920.profdata to chrome-win64-master-1592859555-f08c66ddf994e8777f6044c180c36d7bb50b914d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5db58da92c9bef6ed55b3872e3f190b0d24e9ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781104}
-
Gang Wu authored
This CL fix the issue by 2 step 1. Resizing image for search should keep the original ratio. 2. The Thumbnail need to use rich entity size instead of favicon size. Bug: 1095702 Change-Id: I65f27ee5f485d6bad03fc0cb97c37fc1f0d6d2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250784Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781103}
-
Mansi Awasthi authored
This CL introduces a method PDFiumPage::PopulateChoiceFields() which reads choice form fields from the PDF document and stores relevant information in a vector within PDFiumPage. The CL also includes a new test file with sample choice fields and a unit test to validate the new method. Bug: 1030242 Change-Id: Ie8dc9da6c694747d8fef7721625f7690dda64124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249244Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#781102} -
Etienne Bergeron authored
Thread priority should not be modified after a test. If that is happening, it needs to be fixed in the code. This CL remove the code that disable the priority checks. NOTE TO SHERIFF: * please paste failure logs when reverting, the goal is to remove flaky tests related to thread priority. * assigned flaky test to etienneb@ Bug: 1097092 Change-Id: I7046cfa59b5269c00cdbda5ec27189e5367fa264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254522Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#781101}
-