- 01 Dec, 2017 40 commits
-
-
Darren Shen authored
Currently, when we convert a CSSUnitValue to a different unit, we essentially consult a NxN table to figure out the scale factor, where N is the number of units. An easier way is to first convert to the canonical unit, then convert from the canonical unit to the target unit. This only requires a lookup table of size N instead of NxN, greatly simplifying the code. Bug: 776173 Change-Id: Icb28386938f9cb7de4d917c72426154b8f45d6e6 Reviewed-on: https://chromium-review.googlesource.com/798930Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#520848}
-
Hiroshige Hayashizaki authored
Bug: 788828 Change-Id: I45d9450cacce9613440496493a40098352dec4c7 Reviewed-on: https://chromium-review.googlesource.com/786530 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520847}
-
Derek Cheng authored
- Rename DialMediaSinkServiceProxy to DialMediaSinkService to be consistent with Cast. - Changed the construction/destruction sequence of DialMediaSinkServiceImpl to be consistent with Cast. -- Now both always create Impl on UI thread, then post task to start / stop / delete the Impl. -- The Impl classes exposes a task_runner() method which can be used to post tasks to it. - Get rid of MediaSinkService. It serves no real purpose since MR always references the impl class directly, and we do not do any mocking with it. - Replaced the DialMediaSinkServiceObserver interface with a callback since it's only one method. -- The callback is invoked on the Impl's task_runner(). It acts as a trampoline to invoke the real callback on UI thread. - Get rid of RefCountedThreadSafe usage in Dial / Cast classes, and replaced with WeakPtrFactory where necessary. - Moved MediaSinkServiceBase to chrome/common/media_router/discovery. - CastSocketService requires that methods be invoked on its task_runner() only. -- Corresponding changes to CastChannelAPI / CastMessageHandler. - More stringent SequenceChecker / BrowserThread checks. The latter is necessitated by downstream dependencies. Bug: 784758 Change-Id: I50b4658c73ad561a642c1ff2347a5e523d3c963a Reviewed-on: https://chromium-review.googlesource.com/773378 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#520846}
-
Hiroshige Hayashizaki authored
No behavior changes. Bug: 779730 Change-Id: Iee799336a5f5f2db61d6990edfead3c31b377c50 Reviewed-on: https://chromium-review.googlesource.com/762342Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#520845}
-
Timothy Loh authored
This reverts commit d4dd5c37. Reason for revert: Causes 40+ layout tests to leak, e.g. https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/12726 Original change's description: > v8binding: Stops using the copyable ver of v8::Persistent. > > I learnt that v8::Persistent provides two variations of copying. > One actually copies, and the other actually shares the underlying > slot. > > This patch changes CallbackFunctionBase::Persistent from the > "share" version to the "copy" (= make another independent slot) > version. > > Bug: 779036 > Change-Id: I1fae7a1547af2abefa932458f398d8e2b50ecaa3 > Reviewed-on: https://chromium-review.googlesource.com/798820 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520528} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: I15cccba7606269da57e4b3c48d8e9bfa3b1c103c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 779036 Reviewed-on: https://chromium-review.googlesource.com/802715Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#520844}
-
Erik Luo authored
Also add rebased expectations in CL for reviewers. Bug: 700624, 727514 Change-Id: I25b4194786b234f36618feac3df708253a5efde9 Reviewed-on: https://chromium-review.googlesource.com/802461Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#520843}
-
Peter Kasting authored
BUG=789424 TEST=none Change-Id: If6f9a889c5b67684c7157c451ccfc3e459c9e50d Reviewed-on: https://chromium-review.googlesource.com/799850Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#520842}
-
Scott Graham authored
In order to roll GN 157d5de4..f3a5b8c1 (r514519:r520777) and pick up the following changes: 7f86d891 gn: Check if formatting a single line list to multiple reduces penalty 5accd24a Remove base::SizeToToString[16] 8f449e3d gn: Fix formatting of file containing only 2 block comments e643f226 add jumbo support when building gn itself e4963ba3 Run clang-tidy modernize-use-equals-{delete,default} on //tools 5eea716f GN: Fix references to lib_[dir_]prefix, which should be lib_[dir_]switch 8b6898fe Add option to gn bootstrap to specify the build directory 3667991e Use std::make_unique in GN code. e953738c Clarify GN nonfatal unused build arg messages. e03b10a9 Remove unneeded extern keywords in tools/gn. 976fe5f3 Add observer_list_threadsafe.cc to gn bootstrap deps 36d1a861 [CFI] Add protected memory container class TBR=dpranke@chromium.org Change-Id: I22d358ee205d68100bf6a0d8f0e8129450d89e98 Reviewed-on: https://chromium-review.googlesource.com/802677Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#520841}
-
Kenneth Russell authored
This reverts commit 252e8a49. Reason for revert: Caused http://crbug.com/790739 Original change's description: > Use DoublyLinkedList instead of ListHashSet in DocumentState > > The only operations carried out on form_controls_ are insertions, removals > and iterating through the entire list. Insertion and removal can be done > faster with a DoublyLinkedList. > > Since the nodes for the DoublyLinkedList are Oilpan objects, this CL > introduces HeapDoublyLinkedList that uses Member for the head and tail > pointers, and traces the pointers. > > This improves the performance of HTMLInputElement::InsertedInto and > HTMLInputElement::RemovedFrom by ~15%. > > Bug: > Change-Id: I5b4cd20737e0276bece2430edfb7ec9609690f04 > Reviewed-on: https://chromium-review.googlesource.com/758877 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517876} Bug: 790739 TBR=jbroman@chromium.org,haraken@chromium.org,keishi@chromium.org,adithyas@chromium.org,lfg@chromium.org Change-Id: I48ddedd7b356efa6b1f6f69c58e2022e9a0872f1 Reviewed-on: https://chromium-review.googlesource.com/802774 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#520840}
-
Kevin Bailey authored
Short-cuts provider and history URL provider unit-tests each have an AnonFakeAutocompleteProviderClient, which shares a little code with the common FakeAutocompleteProviderClient. This CL has those two classes derive from the common one, and move the common bits down. It's a follow-up to 776643. Bug: 780835 Change-Id: Ida2fc850df0c36a35a3a1898296e85aec0a28809 Reviewed-on: https://chromium-review.googlesource.com/782079 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#520839}
-
Renjie Liu authored
Call UpdateOpenTabURLs inside FeatureExtraction so we can have urls logged as well. Bug: 784232 Change-Id: I403cafbfe9f2691fdcfc7a83b0d85219c487884e Reviewed-on: https://chromium-review.googlesource.com/802655 Commit-Queue: Renjie Liu <renjieliu@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#520838}
-
Tetsui Ohkubo authored
User interaction with NotificationViewMD should fire the appropriate callback methods defined in MessageViewDelegate. Especially, with the interaction in the actions row, we should fire - ClickOnNotificationButon - ClickOnNotificationButtonWithReply This CL adds the following unit tests to test these callbacks. - TestActionButtonClick - TestInlineReply TEST=message_center_unittests BUG=789057 Change-Id: Iba71e1f928830071fe73a7e49feb44efe493c8dd Reviewed-on: https://chromium-review.googlesource.com/799592 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#520837}
-
Wei Guan authored
BUG=789375 Change-Id: I752b5eb006f43df0949374acac464793db92115d Reviewed-on: https://chromium-review.googlesource.com/795550 Commit-Queue: Wei Guan <weigua@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#520836}
-
Michael Giuffrida authored
Check whether the tab was recently audible (last 2 seconds) when logging the TabManager.TabMetrics UKM. Bug: 784639 Change-Id: I755305fecf1c13668219e972ad41312da91ca568 Reviewed-on: https://chromium-review.googlesource.com/795175 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#520835}
-
Han Leon authored
enum ServiceWorkerFetchEventResult does not have to be a common type for both browser and renderer code, this CL moves it out of content/common/service_worker/service_worker_types.h, and also removes the unnecessary IPC traits for it from content/common/service_worker/service_worker_messages.h. BUG=789854 TBR=tsepez@chromium.org Change-Id: I6bda299731b71b8b5f9c493b1a785b7f9889f45b Reviewed-on: https://chromium-review.googlesource.com/799551 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#520834}
-
Dan Sanders authored
Change-Id: I7263f9f0291b14f5bc0e4831b371465b073ebc96 Reviewed-on: https://chromium-review.googlesource.com/786639Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#520833}
-
Steven Holte authored
This relands 290a7939 which was reverted by 16af3fb6, except that it omits the changes to test that flaked. TBR=asvitkine Bug: 761524 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6d68e0a7cab7307544c4ddda5df3d153bc3d69a4 Reviewed-on: https://chromium-review.googlesource.com/802415 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#520832}
-
Sadrul Habib Chowdhury authored
Bug: 778749 Change-Id: I34f85b22f6b292c05820cf010471d8fb9f861e3b Reviewed-on: https://chromium-review.googlesource.com/789412Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#520831}
-
Naoki Fukino authored
OOBE screens has min-height:640px. If a user changed the display setting to lower resolution (e.g. 640x400), the bottom part of migration UI will be hidden. This CL make the migration UI shrinkable based on the screen resolution to make the "Update" button in the bottom always visible to the user. (See attached screenshots on the bug.) Since we don't have enough time to test it before M63 goes stable, this change applies only to the migration screen to minimize the impact. Other OOBE screens will be OK without the patch since users will see them before they can change the display resolution. Bug: 787393 Test: Manually tested on kevin by setting screen resolution to 640x400. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9d092deb556b8ca0beda6db39c35d48bff223b09 Reviewed-on: https://chromium-review.googlesource.com/800190 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#520830}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=svaldez@chromium.org Change-Id: I9de4d060616eb3f3eabe736033545eec93fc7dd6 Reviewed-on: https://chromium-review.googlesource.com/798912Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#520829}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1c7240c773aa3f71d2bb7158e8f76aa7340b0f2d Reviewed-on: https://chromium-review.googlesource.com/790010Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#520828}
-
Chris Watkins authored
This covers //net/base to //net/dns in alphabetical order. See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 Change-Id: I72d8a83ee86d833dc2caa0c3b9103689439bf443 Reviewed-on: https://chromium-review.googlesource.com/789971Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#520827}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 Change-Id: Ib4d1680c615407583a6ad72ce51634d2f444db99 Reviewed-on: https://chromium-review.googlesource.com/789742Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#520826}
-
mrefaat authored
The library Motion Interchange for Objective-C is a new dependency of the Material Components for iOS. Library description: This library defines a format for representing motion in Objective-C and Swift applications. The primary data type, MotionTiming, allows you to describe the duration, delay, timing curve, and repetition for an animation. Bug: 785248 Change-Id: I8a86c3df9832635911c284f637fe0482d774a1c8 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/802086Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#520825}
-
Nektarios Paisios authored
Facebook Messager uses a combo box role with a content editable. Since we are flattening the contents of all combo, search and text box roles, this causes a mismatch between the contents and the AXPositions for e.g. word offsets. Another problem is that we are relying on various ways to determine whether an object is a text control and if its native or not. With this patch, we unify the logic into a few simple tests that rely on Blink to tell us whether: A) An object is at the root of a text field. B) Whether the contents are richly editable. We need to present plain and rich text contents in a flattened manner on Mac and rich text contents in a non-flatten manner on Win, regardless of the method used to make them plain or rich. For example, it doesn't matter if a content editable, design mode, or the CSS style "user-modify: read-write" was used, we would still want to show the children on Win. Similarly, if the CSS style "user-modify: plain-text-only" is used we would still want to hide the children on both platforms. R=aleventhal@chromium.org, dmazzoni@chromium.org Bug: 732218 Change-Id: I7b3c56531c8f22fc7622d894d6cf40e4b896bd94 Reviewed-on: https://chromium-review.googlesource.com/734192 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#520824}
-
Dave Schuyler authored
This CL is a followup for a comment in CL 792537. There's no user facing effect of this change. This changes the calls used to hide/unhide an the dev tools in the toolbar. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7da1f779b48f942bfb708a4c574c0881269ca3ec Reviewed-on: https://chromium-review.googlesource.com/798013Reviewed-by:
Dan Beam (no longer on Chrome) <dbeam@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#520823}
-
Yuzhu Shen authored
BUG=788704 Change-Id: Iedd0fb694e88db9a492f9b670f1e1fd177120a10 Reviewed-on: https://chromium-review.googlesource.com/802402Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#520822}
-
Gyuyoung Kim authored
In VerifyCustomHandlerURL, though it should check the URL validation after removing '%s' in the given URL, it has checked it original URL even though it already removed '%s'. This CL fixes it as well as adds a new invalid URL test case to the tests. Additionally, we need to fix 2 tests of registerProtocolHandler in the protocol.html of wpt. According to the spec, If the %s placeholder is in the scheme, host, or port parts of the URL, this should throw a SecurityError exception forcibly. However, the 2 tests have been checked if it throws a syntax error. Fixed it too. Spec: https://html.spec.whatwg.org/multipage/webappapis.html#custom-handlers TEST: Add a new invalid url test to http/tests/navigatorcontentutils. external/wpt/html/webappapis/system-state-and-capabilities/the-navigator-object/protocol.html Bug: none Change-Id: I11f3c626b767b6fdc880bda157741d68d67ee001 Reviewed-on: https://chromium-review.googlesource.com/796252 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#520821}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3a945192. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6550 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts TBR=qyearsley No-Export: true Change-Id: Ifaeccc6a63d8e9b9001ad617decb59c7ca0b7fb4 Reviewed-on: https://chromium-review.googlesource.com/801856 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520820}
-
Timothy Loh authored
This reverts commit 38f08f4e. Reason for revert: Causing test failures This patch landed between https://chromium-review.googlesource.com/c/chromium/src/+/774120 and it's revert https://chromium-review.googlesource.com/c/chromium/src/+/802357. The revert was as the original patch made a test flaky, but it caused several tests to start failing on all bots (it does seem to have reverted cleanly): (sample: https://chromium-swarm.appspot.com/task?id=3a286e5fea70e510&refresh=10&show_raw=1) ProcessMemoryMetricsEmitterTest.FetchAndEmitMetricsWithExtensions PageLoadMetricsBrowserTest.NewPage ProcessMemoryMetricsEmitterTest.FetchAndEmitMetricsWithHostedApps ProcessMemoryMetricsEmitterTest.ForegroundAndBackgroundPages ProcessMemoryMetricsEmitterTest.FetchAndEmitMetrics ProcessMemoryMetricsEmitterTest.FetchThreeTimes ProcessMemoryMetricsEmitterTest.FetchDuringTrace Reverting this patch seems to fix the failures... Original change's description: > content: Fix MojoUkmRecorder setup for compositor UKMs. > > The binding of the mojo interface used for recording UKMs by the > compositor is incorrect, the interface needs to be bound to a service > using the service connector to start the connection. > > Clone the Connector and pass it to the factory used on the compositor > thread to do the binding. Its necessary to clone it for the connector > access to be thread-safe. > > R=piman@chromium.org > > Change-Id: I1e20e64a6a6500e9c548599f4893d70a028574a7 > Reviewed-on: https://chromium-review.googlesource.com/798538 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520709} TBR=holte@chromium.org,khushalsagar@chromium.org,piman@chromium.org Change-Id: If957995149909408de3b916d96151c7b906eea1a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/802934Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#520819}
-
Biao She authored
The size is set earlier as speech_result->SetSize(kVoiceSearchRecognitionResultTextWidth, 0) The removed code is creeped in after a rebase. Bug: NONE TBR: cjgrant Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8a92d8bc5b26fe9445230af9fbed95090049c33f Reviewed-on: https://chromium-review.googlesource.com/802794Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#520818}
-
Yutaka Hirano authored
Make IsThrottable return false when it's throttled by WebFrameScheduler. Bug: 785770 Change-Id: Idb075c759a10636b406505287b3a1139db54678b Reviewed-on: https://chromium-review.googlesource.com/799539 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#520817}
-
Peng Huang authored
Bug: 727775 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9a6f9c87cf7dcaddea526c79880b649d39c47492 Reviewed-on: https://chromium-review.googlesource.com/801455Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#520816}
-
rbpotter authored
Bug: 773928, 789408 Change-Id: I66009509ad601756ec0281a66fd093ee7fc96477 Reviewed-on: https://chromium-review.googlesource.com/802175Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#520815}
-
Yutaka Hirano authored
This CL implements ResourceLoadScheduler::SetPriority which re-prioritizes a pending request when RendererSideResourceScheduler feature is enabled. Bug: 785770 Change-Id: I0b001f64b5667085a020364c0a419b8f003804cf Reviewed-on: https://chromium-review.googlesource.com/798950 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#520814}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/3ebc2fd9fe64..280aff07f5fc $ git log 3ebc2fd9f..280aff07f --date=short --no-merges --format='%ad %ae %s' 2017-11-30 eakuefner [Dashboard] Fix tests when html5lib is provided 2017-11-30 simonhatch Remove original addSeriesGroup and rename addSeriesGroup2. 2017-11-30 rnephew [Telemetry] Add test Expectation file parser for TA/DA telemetry integration. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic533194b19e38b8ae6f7fb4e05cd8830641e9b09 Reviewed-on: https://chromium-review.googlesource.com/802394 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520813}
-
sczs authored
Toolbar Coordinator creates a property animator animation for expanding the location bar. ToolbarViewController expands the locationBarContainerView by changing its constraints. Bug: 784592 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I36414e22a887cd0752cbece06058bf1d67eaec18 Reviewed-on: https://chromium-review.googlesource.com/798752 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#520812}
-
Mitsuru Oshima authored
This will not change the functionality now, but will be used when caption is moved to chrome for ARC++ apps. BUG=762816 Change-Id: Ia25d13eba37b31677a265b9f3e8b09953a5dd8e5 Reviewed-on: https://chromium-review.googlesource.com/786545 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#520811}
-
Charles Harrison authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/800950 Bug: None Change-Id: If1bbf18575ca1b0562499c899960ac003a7678c9 Reviewed-on: https://chromium-review.googlesource.com/802474 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#520810}
-
Hiroshi Ichikawa authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I084dedb73e3b5ccc0d958aef88c54e0d8cf820bd Reviewed-on: https://chromium-review.googlesource.com/795492 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#520809}
-