GitLab

We are seeing frequent issues where phones are connecting to the wrong script server domain, leading to permission errors and abort. This log message should help us in debugging those issues.

Bug: 806868
Change-Id: I49c469d33e924c0cb65db2398c686b6930313098
Reviewed-on: https://chromium-review.googlesource.com/c/1482961Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#634694}

As per local run the WebViewDeviceSideStartupTest.testStrictModeNotViolatedOnStartup
test is passing, see crbug.com/933815 for details.

Verification:
 [4/7] com.android.cts.webkit.WebViewHostSideStartupTest#testStrictMode pass

BUG=933815,841556,923938

Test: run cts -m CtsHostsideWebViewTests --test com.android.cts.webkit.WebViewHostSideStartupTest
Change-Id: I5f34ce7bb867cb44a095f89c8513608bd077261e
Reviewed-on: https://chromium-review.googlesource.com/c/1482457
Auto-Submit: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634693}

Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1481910

Without this, we still get

    In file included from ../../third_party/flatbuffers/src/tests/test.cpp:18:
    ../../third_party/flatbuffers/src/include/flatbuffers/idl.h:332:25:
        warning: extra ';' after member function definition [-Wextra-semi]
      EnumVal() : value(0){};
                        ^

Also add a TODO for undoing this again at some point.

Bug: 934834,926235
Change-Id: I6ad57d7a9973dfdf6ab546daffc2f99bea284e96
Reviewed-on: https://chromium-review.googlesource.com/c/1482561Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634692}

The spec (https://fetch.spec.whatwg.org/#data-urls) states that both
base64 matching (step 11) and charset matching (step 13, then step 11.4
of https://mimesniff.spec.whatwg.org/#parse-a-mime-type) should be case
insensitive. Previously Chrome did both case-sensitive, this CL corrects
that.

Bug: 807562
Change-Id: I336a04abdbe45e41207d131984a15a9f36c1b486
Reviewed-on: https://chromium-review.googlesource.com/c/1480569Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634691}

This makes sure that errors generated in the network service when
offline will trigger the auto-fetch feature. The current tests didn't
catch the bug because they use URLLoaderInterceptor to fail the request,
which prevents the request from reaching the network service.

Bug: 929909
Change-Id: I26f532d3d44331e495cb0e1cba16276bcd0074d9
Reviewed-on: https://chromium-review.googlesource.com/c/1479584Reviewed-by: Dan H <harringtond@google.com>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634690}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d74d6a30bce..a33c0190f771


Created with:
  gclient setdep -r src-internal@a33c0190f771

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ifc355ebfc034bb7559a20bfda0104a241abac44a
Reviewed-on: https://chromium-review.googlesource.com/c/1483153Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634689}

https://dawn.googlesource.com/dawn.git/+log/fda0617505c1..87bf834109fd


git log fda0617505c1..87bf834109fd --date=short --no-merges --format='%ad %ae %s'
2019-02-22 yunchao.he@intel.com Add more validations for input state


Created with:
  gclient setdep -r src/third_party/dawn@87bf834109fd

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Iaefa5299be2c09da7c33c8de0ea5db066acd41a5
Reviewed-on: https://chromium-review.googlesource.com/c/1483152Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634688}

Bug: 883330
Change-Id: I926f9d1e568d26d3c6d0355123fa3404f0e28a68
Reviewed-on: https://chromium-review.googlesource.com/c/1483013Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634687}

Choosing Hindi because it is popular.
This keeps normalization for .pak files, but drops it for .arsc (because
its hard and not sure how necessary it is).

Binary-Size: Change in the way we measure size.
Bug: 873714
Change-Id: Ieb2c6b445307f47717495c97949e247727cc761e
Reviewed-on: https://chromium-review.googlesource.com/c/1480692
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634686}

[Sheriff] Disable some tests in ArcRobotAccountAuthServiceTest and ArcAuthServiceChildAccountTest on MSan

Several tests in these suits have become flaky
on non_single_process_mash_browser_tests
on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests

TBR=khmel@chromium.org

Bug: 934796
Change-Id: I41f8af80d207d820ba234e0854bf53fce52d93ee
Reviewed-on: https://chromium-review.googlesource.com/c/1483020Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634685}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/12a4eb908a7b..202f8887f83f


git log 12a4eb908a7b..202f8887f83f --date=short --no-merges --format='%ad %ae %s'
2019-02-22 jclinton@chromium.org Refresh PreCQ default coverage per thread on c-i-d


Created with:
  gclient setdep -r src/third_party/chromite@202f8887f83f

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: If1509cc6d0526b47f72b88331714f618e860e767
Reviewed-on: https://chromium-review.googlesource.com/c/1482939Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634684}

Error codes are apparently negative, whereas the histogram enum is
defined with positive values.

Bug: 915679
Change-Id: Ie14569dcb1283b5960f11c94321863537238dae7
Reviewed-on: https://chromium-review.googlesource.com/c/1473170Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634683}

This experiment doesn't actually seem very useful in Finch. It's better
to reuse the DRP experiment which is accessible in chrome://flags.

Bug: 934376
Change-Id: I27a5bdfa4f57fa761eaae62106113e7fc5529ba1
Reviewed-on: https://chromium-review.googlesource.com/c/1481995Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634682}

Using wpt-import in Chromium 6ff0f3bb.
With Chromium commits locally applied on WPT:
14c11107 "Implement `Sec-CH-Lang`"
df760ab0 "Don't skip past auto-height flexboxes in quirks mode."
cd40220a "Fix as=fetch preload where preload is used before response arrives"
1d89521e "[LayoutNG] Force relayout when constraint spaces change."
98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests"
f82f5505 "[LayoutNG] Fix inline-level OOFs inside a block-level context."
1a46f4bb "v8binding: Make PaintWorkletGlobalScope use IDL callback function"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: If82d0dff652b9f016e283b6735009436a7473953
Reviewed-on: https://chromium-review.googlesource.com/c/1483150Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634681}

The IntersectionObserver algorithm must run using the throttling status
that was in effect when the frame was generated. Since the IO steps
have been moved to happen later (in RunPostLifecycleSteps), we must
delay propagating throttling status.

BUG=933694,928228
R=bokan@chromium.org

Change-Id: Ic6a5fc37d3871eb30d8d1138d5c63fe8d61b53c8
Reviewed-on: https://chromium-review.googlesource.com/c/1481998Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634680}

The new icon, same as the other preview icons, is simpler and smaller.

This CL implements the UI mocks, specifically:
* New speedometer icon
* No enabled/disabled shading
* 24dp instead of 32dp

Bug: 909915
Change-Id: Icf4aed99869986b8e285a14e3179e7a054584667
Reviewed-on: https://chromium-review.googlesource.com/c/1481795Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634679}

https://chromium.googlesource.com/catapult.git/+log/0a94c0324d42..b4fdbb737c98


git log 0a94c0324d42..b4fdbb737c98 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 perezju@chromium.org [Telemetry] Clean up tracing_controller code


Created with:
  gclient setdep -r src/third_party/catapult@b4fdbb737c98

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:931236
TBR=sullivan@chromium.org

Change-Id: I03538f3a11396644509e2af97924070ecf05a82e
Reviewed-on: https://chromium-review.googlesource.com/c/1482933Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634678}

This reverts commit 8b42fd6c.

Reason for revert: Flakes https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGI0MmZkNmM5MmZiNjY2MWNmYzNlOTIzNWM4NmYwMjU2MjZkZjA4ZQw

Original change's description:
> Revert "Tracing: Move the tracing service in-process again to figure out test flakes"
> 
> This reverts commit 6b27bca8.
> 
> Reason for revert: Should be fixed with https://chromium-review.googlesource.com/c/chromium/src/+/1474309/
> 
> Original change's description:
> > Tracing: Move the tracing service in-process again to figure out test flakes
> > 
> > Effectively temporarily reverting https://chromium-review.googlesource.com/c/chromium/src/+/1412016
> > 
> > Bug: 914579, 929142
> > Change-Id: I443e41fee17f6f09ca5cf5c243dbf330bafef6f8
> > Reviewed-on: https://chromium-review.googlesource.com/c/1456871
> > Commit-Queue: oysteine <oysteine@chromium.org>
> > Reviewed-by: ssid <ssid@chromium.org>
> > Reviewed-by: Alexei Filippov <alph@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#629738}
> 
> TBR=alph@chromium.org,oysteine@chromium.org,ssid@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 914579, 929142
> Change-Id: I9585a500916c0d90b16901572823a3c7c14bbbbb
> Reviewed-on: https://chromium-review.googlesource.com/c/1477877
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: ssid <ssid@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634229}

TBR=alph@chromium.org,oysteine@chromium.org,ssid@chromium.org

Change-Id: I87f62967a2a0006b3b2f7a8c91bd44a26306643d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 914579, 929142
Reviewed-on: https://chromium-review.googlesource.com/c/1483250Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634677}

In an effort to reduce or even ban symbol shadowing, this renames
a variable to avoid such shadowing. I'm interested in prohibiting
shadowing because I think it might prevent potential jumbo problems.

The exact error this avoids is:
third_party/blink/renderer/core/svg/svg_svg_element.cc:456:28: error: declaration shadows a local variable [-Werror,-Wshadow]
      TransformationMatrix transform;
                           ^
third_party/blink/renderer/core/svg/svg_svg_element.cc:449:19: note: previous declaration is here
  AffineTransform transform;
                  ^

Bug: 923510
Change-Id: I99c001d0eb513d73bfc33d540601479a6fd7280d
Reviewed-on: https://chromium-review.googlesource.com/c/1482975
Auto-Submit: Daniel Bratell <bratell@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#634676}

The Symantec Log, Symantec 'Sirius' Log, and Symantec 'Vega' Log are
being retired with an effective date of February 16, 2019 with a
timestamp of 1550275200.

Bug: 928879
Change-Id: I8f9a3da420acdda7739662481fe505bc7c46bf3e
Reviewed-on: https://chromium-review.googlesource.com/c/1481606Reviewed-by: Andrew Whalley <awhalley@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Andrew Whalley <awhalley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634675}

R=haraken@chromium.org
CC=blink-reviews-onion-soup@chromium.org

BUG=891908

Change-Id: I554a5c747731442113973674ebdf758e111c1f35
Reviewed-on: https://chromium-review.googlesource.com/c/1483170
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634674}

Otherwise, DataTransfer retains the last document that used a JS
wrapper through
  Page->DragController->DragState->DataTransfer->...

Bug: 928781,843903
Change-Id: I92219fb9a325a8a9d0ceb7050512b22f6942c85f
Reviewed-on: https://chromium-review.googlesource.com/c/1479991Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634673}

This reverts commit 4c800eb7.

Reason for revert: Suspected of breaking PolicyPrefsTest.PolicyToPrefsMapping
on browser_tests
on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel

First failure
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20456

Original change's description:
> Add DeviceWilcoDTCAllowed device policy
> 
> Create new boolean policy to control wilco diagnostics and telemetry
> controller if it is present on the device.
> 
> BUG=b:123926018
> TEST=unit_tests
> 
> Change-Id: I8161a36424310fbabfc580d3931121dc7a5c5492
> Reviewed-on: https://chromium-review.googlesource.com/c/1456075
> Commit-Queue: Polina Bondarenko <pbond@chromium.org>
> Auto-Submit: Polina Bondarenko <pbond@chromium.org>
> Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634641}

TBR=bartfab@chromium.org,pbond@chromium.org

Change-Id: Iff0d905d9c103369822a5c88f90f877e2d289f2e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:123926018
Reviewed-on: https://chromium-review.googlesource.com/c/1483021Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634672}

These shipped in M71.

BUG=829937,383813

Change-Id: I7e221ad086b637f2031e7ad9a8092f4c38ce9a8a
Reviewed-on: https://chromium-review.googlesource.com/c/1478487Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634671}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ac7e7332..9eb6c534

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4d50befd9dd24c5817ec1c56f0602c1caf18c84c
Reviewed-on: https://chromium-review.googlesource.com/c/1483151Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634670}

https://webrtc.googlesource.com/src.git/+log/65438812ba0d..8aa00f037148


git log 65438812ba0d..8aa00f037148 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 tzik@chromium.org Add missing absl/memory/memory.h to rtc_event_generic_ack_received.cc
2019-02-22 eladalon@webrtc.org Rename "OnReceivedFrame" to "OnAssembledFrame"
2019-02-22 sprang@webrtc.org Remove VideoSender and fold code into VideoStreamEncoder
2019-02-22 eladalon@webrtc.org Create LossNotificationController
2019-02-22 jonasolsson@webrtc.org Allow IceConnectionState to become failed without ever connecting.
2019-02-22 ssilkin@webrtc.org Lower SSIM thresholds.


Created with:
  gclient setdep -r src/third_party/webrtc@8aa00f037148

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:752720,chromium:None,chromium:933786
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I044eb3aa0ebd117950114a7810d5c4d6d8cca835
Reviewed-on: https://chromium-review.googlesource.com/c/1482934Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634669}

https://skia.googlesource.com/skia.git/+log/fdd15284affe..c6461681d608


git log fdd15284affe..c6461681d608 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 reed@google.com add hinting to gm


Created with:
  gclient setdep -r src/third_party/skia@c6461681d608

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: I33655fec020758b5b91691f739baa72858e3eea8
Reviewed-on: https://chromium-review.googlesource.com/c/1482936Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634668}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6abcf043ece1..0d74d6a30bce


Created with:
  gclient setdep -r src-internal@0d74d6a30bce

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8d1cfc81fafe621478d0c921ff636619b29f08df
Reviewed-on: https://chromium-review.googlesource.com/c/1482931Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634667}

This reverts commit 2b682cae.

Reason for revert: Re-enabling the test.
According to https://crbug.com/933295, the root cause should be fixed.

Original change's description:
> Disable PolicyTest.ExtensionAllowedTypes on Linux
> 
> The test is flaky on Linux and Windows.
> linux-xenial-rel suffers the most.
> 
> TBR=pastarmovj@chromium.org
> 
> Bug: 934297
> Change-Id: I9fd2df0ed9a531bb81f9ba01627726443786e603
> Reviewed-on: https://chromium-review.googlesource.com/c/1480000
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634241}

TBR=pastarmovj@chromium.org,cfroussios@chromium.org

Change-Id: I094ad7fd410d80732bd037bda37164f4068b7891
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 934297
Reviewed-on: https://chromium-review.googlesource.com/c/1483017Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634666}

A string used in BrowserSwitcher was missing an example value for a
placeholder.

Bug: 934099
Change-Id: I92e000b6e74619108845421f47fe11b6b193d5e7
Reviewed-on: https://chromium-review.googlesource.com/c/1479845Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634665}

https://chromium.googlesource.com/external/github.com/google/cld_3.git/+log/484afe9ba743..c0e79be769c5

$ git log 484afe9ba..c0e79be76 --date=short --no-merges --format='%ad %ae %s'
2019-02-21 thakis Fix -Wextra-semi warnings.
2019-02-14 tikuta small fix for BUILD.gn
2018-12-22 wtambellini Add CMake script
2018-12-22 wtambellini Add CMake script

Created with:
  roll-dep src/third_party/cld_3/src

Bug: 926235,931596
Change-Id: I9afc9a4062e108af2707617445519abed20a695b
Reviewed-on: https://chromium-review.googlesource.com/c/1482553Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634664}

The roll to gtm 51863009 fixed these.

Bug: 386671
Change-Id: I868b7bb711dd3871af7b9d5f812dcf66c5db1439
Reviewed-on: https://chromium-review.googlesource.com/c/1482556
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634663}

Bug: 934255
Change-Id: I62a14227132236c335c4e201f7f73b5e93af716d
Reviewed-on: https://chromium-review.googlesource.com/c/1479834
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634662}

Add owners for the wake-on-wifi-packet flag, which is
aparently still being evaluated for supporting Android Doze
in ARC.

Bug: None
Change-Id: I07ca507bd6045501d8dbb97abe52c8432d241648
Reviewed-on: https://chromium-review.googlesource.com/c/1482000
Auto-Submit: Dan Erat <derat@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634661}

PTRACE_GET_THREAD_AREA is not in ptrace.h in Ubuntu 16.04 when
building for Linux without a sysroot so get it from somewhere else,
in this case asm/ptrace-abi.h.

Follow up to https://chromium-review.googlesource.com/c/1479092

Bug: 934238,933418
Change-Id: I3e1ace31a6f5a4ab65bbe712e1516d7b5fa009a5
Reviewed-on: https://chromium-review.googlesource.com/c/1481316Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#634660}

In an effort to reduce or even ban variable shadowing, this renames
a variable to avoid such shadowing. I'm interested in prohibiting
shadowing because I think it might prevent potential jumbo problems.

The exact warnings this avoids are:
third_party/blink/renderer/core/dom/element.cc:3940:35: error: declaration shadows a local variable [-Werror,-Wshadow]
        else if (const Attribute* attribute =
                                  ^
third_party/blink/renderer/core/dom/element.cc:3938:30: note: previous declaration is here
        if (const Attribute* attribute = attributes.Find(xml_names::kLangAttr))
                             ^
third_party/blink/renderer/core/dom/node.cc:2113:17: error: declaration shadows a local variable [-Werror,-Wshadow]
    const Node* node = chain[index - 1];
                ^
third_party/blink/renderer/core/dom/node.cc:2107:15: note: previous declaration is here
  const Node* node = this;
              ^
third_party/blink/renderer/core/dom/range.cc:529:36: error: declaration shadows a type alias in namespace 'blink' [-Werror,-Wshadow]
  typedef HeapVector<Member<Node>> NodeVector;
                                   ^
third_party/blink/renderer/core/dom/container_node.h:84:7: note: previous declaration is here
using NodeVector = HeapVector<Member<Node>, kInitialNodeVectorSize>;
      ^
third_party/blink/renderer/core/dom/range.cc:750:36: error: declaration shadows a type alias in namespace 'blink' [-Werror,-Wshadow]
  typedef HeapVector<Member<Node>> NodeVector;
                                   ^
third_party/blink/renderer/core/dom/container_node.h:84:7: note: previous declaration is here
using NodeVector = HeapVector<Member<Node>, kInitialNodeVectorSize>;
      ^

Bug: 925310

Change-Id: I8bc037dd1cf54baf5f6fe1ed93b1ead391313e8a
Reviewed-on: https://chromium-review.googlesource.com/c/1478876Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#634659}

This reverts commit 5760a6f2.

Reason for revert: Clashed with some other change so all Android builders died with:

[1078/8826] CXX obj/android_webview/common/aw_cookie_manager_wrapper.o
FAILED: obj/android_webview/common/aw_cookie_manager_wrapper.o 
../../android_webview/browser/net_network_service/aw_cookie_manager_wrapper.cc -o obj/android_webview/common/aw_cookie_manager_wrapper.o
../../android_webview/browser/net_network_service/aw_cookie_manager_wrapper.cc:40:43: error: reference to type 'const std::string' (aka 'const basic_string<char, char_traits<char>, allocator<char> >') could not bind to an lvalue of type 'bool'
  cookie_manager_->SetCanonicalCookie(cc, secure_source, modify_http_only,
                                          ^~~~~~~~~~~~~
gen/services/network/public/mojom/cookie_manager.mojom.h:179:82: note: passing argument to parameter 'source_scheme' here
  void SetCanonicalCookie(const net::CanonicalCookie& cookie, const std::string& source_scheme, bool modify_http_only, SetCanonicalCookieCallback callback) final;
                                                                                 ^
1 error generated.


Original change's description:
> Take scheme in CookieStore::SetCanonicalCookieAsync, not just whether it's secure.
> 
> This permits to check it against list of cookieable schemes (fixing #850044), and is
> a prerequisite for getting rid of SetCookieWithOptionsAsync in favor of everything
> using SetCanonicalCookieAsync.
> 
> Bug: 850044
> Change-Id: I890cf266767a124b116fc553932a74b5a97ed943
> Reviewed-on: https://chromium-review.googlesource.com/c/1450420
> Commit-Queue: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634646}

TBR=jam@chromium.org,caseq@chromium.org,tsepez@chromium.org,eugenebut@chromium.org,pwnall@chromium.org,mkwst@chromium.org,morlovich@chromium.org

Change-Id: I17b82ee596c4cdcebfc8774f06b7e155ead8c514
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850044
Reviewed-on: https://chromium-review.googlesource.com/c/1482460Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#634658}

https://chromium-review.googlesource.com/c/1460187 ("Fix gn build on 'Build
From Tarball' bot") together with
https://gn-review.googlesource.com/c/gn/+/4000 ("Pass -lpthread when linking
instead of -pthread") have caused the GN bootstrap process to fail when
--use-custom-libcxx is not used.

The reason is that -nodefaultlibs (passed to the compiler when linking with
--use-custom-libcxx) causes -pthread to be ignored. To work around that,
that GN CL started passing -lpthread so that it was added back to the
command-line. However, if we are _not_ using --use-custom-libcxx, the whole
process fails because -lpthread is specified at the wrong position in the
command-line and the symbols are not resolved correctly.

In this CL, make the --use-custom-libcxx build explicitly pass -lpthread to
the linker so that we can later go back to passing -pthread in the GN build,
as the compiler then knows where to put the right flags in the command line.

Bug: 934793
Change-Id: Id8bf242bf461fb5146e1ac28d187082c43fdafbb
Reviewed-on: https://chromium-review.googlesource.com/c/1482959
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634657}

The tests are flaky.

TBR=khmel@chromium.org

Bug: 934796
Change-Id: Ic526200eca2f906d4bbb035fa9d0fa1599b063af
Reviewed-on: https://chromium-review.googlesource.com/c/1483016Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634656}

None of these includes are needed (they can be forward declarations),
and eliminating them prevents the includes from transitively leaking.

TBR=droger@chromium.org

Change-Id: Ibc7aa3358897fd243a43c7dc5cdf5fc5860504a1
Reviewed-on: https://chromium-review.googlesource.com/c/1482956
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634655}