GitLab

This patch increase the kMaxKeyLength limit, and see how this can
improve cache uses by restoring the removed metrics.

Bug: 996861
Change-Id: I00be259603b69e5196e7a9729ef1cc509357baeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771367Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691041}

https://skia.googlesource.com/skia.git/+log/7be971fa3a4e..e36b85f34d27

git log 7be971fa3a4e..e36b85f34d27 --date=short --no-merges --format='%ad %ae %s'
2019-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 605f863173b6..cde4dd9601ce (9 commits)

Created with:
  gclient setdep -r src/third_party/skia@e36b85f34d27

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: chromium:None
Change-Id: I6ef6e90eb22e0ff4918184227c640afcdc8fc355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774252Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691040}

R=luoe@chromium.org

Change-Id: Ib6a5ad8ab65d44e7068645b455b786b948324a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768431
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691039}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1b2f2b335b20..b94afc0b88e6

git log 1b2f2b335b20..b94afc0b88e6 --date=short --no-merges --format='%ad %ae %s'
2019-08-28 vapier@chromium.org lint: fix trailing-comma-tuple warnings/errors
2019-08-28 vapier@chromium.org import configparser from six.moves
2019-08-28 zamorzaev@chromium.org cbuildbot: Fix a keyval bug

Created with:
  gclient setdep -r src/third_party/chromite@b94afc0b88e6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I7413caf928d599b43a0b1f768b189dd87d851bce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774250Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691038}

AppShimHost repeatedly queries AppShimHandler::Get to call out of
itself. In practice, these always go to the ExtensionAppShimHandler
that owns the AppShimHost.

Remove these functions from AppShimHandler and put them in the
AppShimHost::Client interface. Make the AppShimHost take a Client
at creation time (which is safe, now that AppShimHost is owned by
ExtensionAppShimHandler). Document that this is the interface between
AppShimHost and ExtensionAppShimHandler.

Bug: 982024
Change-Id: I954ce6f639596c4c930b701ed9770258852d0e58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772667
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691037}

This change adds stubs for integrating the native Password Checkup on
Android for the Leak Detection feature.

Bug: 986317
Change-Id: Idf57d8a812ee11e6d862dbd68ecb54ea58aff738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773221Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691036}

This change adds logic to record user interactions with the leak
detection dialog shown when the user submits a compromised credential.

Bug: 986317
Change-Id: I49bc3e9fd5d9d63ed3c00775b0d8d24b52d1acb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768330Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691035}

This change fixes a bug in ScopedWakeLock that didn't actually make the
call to acquire a wake lock when constructed. Also adds a test to catch
this case.

BUG=924762
TEST=Unit tests.

Change-Id: Ife26d3b9ae88f399adc21cd8cb62ba628929094b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757461
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691034}

Using wpt-import in Chromium 13462f0b.
With Chromium commits locally applied on WPT:
1194775a "Add ability to block same-origin access via document-access feature policy"
5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport."
d3b97055 "Update simulateUserActivation to match webxr-test-api spec"
2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest"
90789f54 "Implement fallback to element anchor"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
domenic@chromium.org, ricea@chromium.org:
  external/wpt/streams

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id36b11ba715266061ab84c9a9e286f077605d6e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774116Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691033}

This CL reduces estimated pre-processed size of node.h from 2.89MB
to 2.17 MB.

Bug: 242216
Change-Id: I28936b13071364293b86b7692efc2bfca202911e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772778
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691032}

This CL adds a histogram for downloads initiated from a page with a
Safety Tip. (This is based on the downloads metrics for the EV study
from
https://chromium-review.googlesource.com/c/chromium/src/+/935369/). It
will let us determine whether users are less likely to download files
from pages that have Safety Tips.

To record this metric, I had to tweak the meaning of
VisibleSecurityState::safety_tip_status, such that is set even when
the Finch feature is disabled. UI code is now responsible for checking
the feature status to decide whether or not to show the UI. This way,
the downloads code can record the safety tip status regardless of
whether the UI was actually enabled, so that we can compare user
behavior with and without the UI.

This change also revealed a bug that the safety tip status of the page
was being incorrectly reset when a navigation started, even if the
navigation didn't commit. I've changed that behavior to reset when a
navigation finishes rather than starts, and we now cache the
navigation entry ID along with the safety tip status so that we can
avoid using the safety tip status if there is a navigation in
progress.

Bug: 987754
Change-Id: I72fe92c4931897e67d0182953b5dcdd5fdfc3bae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773589
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691031}

Adding closure compilation for:
viewer-zoom-toolbar
viewer-pdf-toolbar
viewer-toolbar-dropdown

Deleting viewer-bookmarks-content, since this appears to be just a
wrapper around dom-repeat.

Some cleanup/addition of annotations in viewer-bookmark.js

Bug: 721073
Change-Id: I88b593c99da3b25deda7e0fe1c6e5d3b3bfa0e33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762814
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691030}

We add a flag to allow disabling of waiting for Service Worker
to be registered during installation of default installed windows apps.

Bug: 905898
Change-Id: I9649515240ca86023b94b135973a476c046ea38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771640
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691029}

TBR=karandeepb@chromium.org

Bug: 998369
Change-Id: Ic8136719b0b72533ab1f75ff70c48f420dbea0d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772209Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691028}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea78a142b81f..8a8dc5068079


Created with:
  gclient setdep -r src-internal@8a8dc5068079

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I8b054f0c7d3177e6cfefab18e4d46b8d87a8049f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774142Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691027}

https://dawn.googlesource.com/dawn.git/+log/b9b088f57e3d..f0b17d00b98d

git log b9b088f57e3d..f0b17d00b98d --date=short --no-merges --format='%ad %ae %s'
2019-08-27 kainino@chromium.org Use TextureFormat::None for RenderBundleEncoder and AttachmentState
2019-08-27 enga@chromium.org Rename SetErrorCallback to SetUncapturedErrorCallback
2019-08-27 enga@chromium.org Rename DeviceErrorCallback to ErrorCallback and add ErrorType arg
2019-08-27 enga@chromium.org Rename ContextLost to DeviceLost
2019-08-27 kainino@chromium.org Remove Texture::createDefaultView

Created with:
  gclient setdep -r src/third_party/dawn@f0b17d00b98d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
TBR=cwallez@chromium.org

Change-Id: I415cce5f3e1e5210ed61ff77c69c044bebfd0b58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772492
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691026}

Adds CooperativeScheduling runtime feature flag and makes it available in chrome://flags

Bug: 804661
Change-Id: Id0174dc30557822a6d9d34c924e7daa05e3a0523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743231Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691025}

It is possible for the caching system to believe that atomic-inlines
would have been impacted by floats.

As a result we threw away a (perfectly good) cached layout result.

This ignores line-boxes in this calculation.

Change-Id: Icc6dbe948ba88d54b252ceb06b2d50aecc558296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772387
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691024}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/2002bac5500d..1b2f2b335b20

git log 2002bac5500d..1b2f2b335b20 --date=short --no-merges --format='%ad %ae %s'
2019-08-28 vapier@chromium.org lint: fix up consider-merging-isinstance warnings

Created with:
  gclient setdep -r src/third_party/chromite@1b2f2b335b20

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ibaf41bfb54ccf8731908b9ac4b30601511d35ac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774144Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691023}

This change increments the network wait timeout from 1 minute to 5
minutes. This is done because after manual testing it was found that it
could take up to just over a minute for shill to notify Chrome of a
network change. 5 minutes is used as the absolute worst case.

BUG=924762
TEST=Unit tests.

Change-Id: I60a412930f379fd7639d01e9c856c0443e8ef14a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757460
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691022}

Looking at code and the crash stacks, it looks like we're synchronously
closing a WebViewImpl while it's handling an input event.

This CL adds some debugging to crash earlier so we can get a stack
showing where the Close call is coming from.

Bug: 992315
Change-Id: I16b17cbbec6dfdafadfc334028a31227ae61ccae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769348
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691021}

They were to handle cases that layer tree and transform tree had
different hierarchy. We can remove them because the cases no longer
exist in layer tree mode (for ui compositor only).

Bug: 993937
Change-Id: If496b5fc821fb786f281093be8ef2efed86e7bce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770510
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691020}

This change moves a function that semantically belongs in ResetState.

BUG=924762
TEST=Unit tests.

Change-Id: I8a8d0c446cda8e8a828857d80031b97e28206fc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757459
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691019}

https://skia.googlesource.com/skia.git/+log/fd849a537a4b..7be971fa3a4e

git log fd849a537a4b..7be971fa3a4e --date=short --no-merges --format='%ad %ae %s'
2019-08-28 michaelludwig@google.com Fix flutter roll

Created with:
  gclient setdep -r src/third_party/skia@7be971fa3a4e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@google.com

Bug: None
Change-Id: Ie547ba81d094effe2fdf505ff64c34c69f97f609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774139Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691018}

Test:
* Manually test by clicking system tray > bluetooth section > gear
  which opens bluetooth device page directly.  The banner will not
  be present.
* Manually go to settings page and notice banner.  Then, navigate
  into a subpage and notice that the banner is not present.


Bug: 997844
Change-Id: Iefe52c0e0111f15adf6c88147a77e4e2210fd0d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773204
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691017}

This test passes now after crrev.com/c/1769082, but we've noticed some
flake that isn't reproducing.  This CL re-enables it separately so it
can be easily reverted if necessary.

Bug: 989550
Change-Id: If84c590547a57403ad0bd36079550fe98fc53b1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769354
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691016}

Adds:
* kNtpZeroSuggest feature
* both kNtpRealbox and kNtpZeroSuggest to about:flags
* IsNtpRealboxEnabled() accessor, as zero suggest forces on realbox

R=mahmadi@chromium.org

Bug: 243926, 778489, 996516
Change-Id: Ifa91141c6459376a0e677b5c6ea527c13c5b59d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769595
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691015}

TestSelectNetwork
TestSelectConnectedNetwork
TestDeviceRequisition

TBR=antrim@chromium.org

Bug: 997685
Change-Id: I07fbc27aa47f430981d4581b6d51a9db2a7b305f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773998Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691014}

This CL breaks-out two additional special-cases out of the old
kIncorrectLock category:

- kExcludedScheme will be used for chrome-extension, since
  non-allowlisted extensions will use an incompatible request_initiator
  until https://crbug.com/940068 is fixed.

- kExcludedUniversalAccessPlugin will be used for requests from
  renderers which are embedding a universal-access plugin
  (like Flash) - the renderer is proxying requests on behalf of the
  (potentially cross-origin = request_initiator-incompatible) plugin.

The CL adds or modifies tests, so that if we started to treat an
incorrect lock as a bad message, then the tests would fail without the
additional exceptions outlined above.

Bug: 920634
Change-Id: I93f14a43d6569c010898a662c250d2bda0613fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762677
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691013}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=benmason@chromium.org

Change-Id: I1e5be8fb11b79811e1349fcec148ea06c78ec199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773659Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#691012}

TBR=pfeldman@chromium.org

Bug: 997911
Change-Id: I66aa9d4e1bd8e3167d1fd28113a67c145fb2adc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773265Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691011}

- Alert on overview enter that users can use Tab to navigate.
- Give a tip when either a window or a desk mini_view are
  highlighted that Ctrl+W can be used to close.
- Announce that a mini_view is of the active desk when it is so.
- Alert that a window is closed in overview mode.

TBR=dtseng@chromium.org for minor change in `spoken_feedback_browsertest.cc`.
BUG=997007
TEST=Manually on device.

Change-Id: I2f10ad14b6e3d77560b0cb7dc485c3867c099fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773725
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691010}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: Ibbe13c85a5e5842db9d5a0909009a9e1b42dcff0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700961
Auto-Submit: Eric Foo <efoo@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691009}

We will introduce a "batched writes" API in next CLs.
Current access to the apps that are owned by WebAppRegistrar (the LevelDb)
should be read-only.

Next CL: Make WebAppRegistrar::AllApps API read only (const).

Bug: 891172
Change-Id: Id3fb57f341683ead6ce83359d9f8d2147603b73b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772932Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691008}

Here's the set of classes/changes:

weblayer_private.BrowserControllerClient: this is a singleton that is supplied
when creating BrowserControllerImpl. It will duplicate the C++ BrowserObserver
interface along with any other server->client calls we want.

BrowserController: supplies an implementation (as an inner class) of
BrowserControllerClient to BrowserControllerImpl. BrowserController's inner
class forwards calls to BrowserObservers.

BrowserObserverProxy: there is a C++ and Java class with this name. The two
are tightly coupled. The C++ side implements BrowserObserver and forwards to the
java side. The java side forwards to BrowserControllerClient.

BUG=none
TEST=none

Change-Id: I2817149224f4ac2045769c4ce0c3f81040dc7507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772501
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691007}

Bug: 990561
Change-Id: I0df8d84b450a644d979c1f9c8764f9d2de4c1d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755283
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691006}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: Ia891d4988299e76925beb57bc69c22e19187eaa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700872Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691005}

TBR=shuchen@chromium.org

Bug: 997888
Change-Id: Ic7dfb8088ec76028c2c1daabdcd582c210c7560b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772931Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691004}

This is CL is generated by a script. Data is pulled from
review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4
for context.

Bug: 977050
Change-Id: I0037f36b9da556a802e14d452be1b582b7357179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700844
Commit-Queue: Eric Foo <efoo@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Auto-Submit: Eric Foo <efoo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691003}

In iOS13, the minimum duration for the long press gesture recognizer
was increased to 0.75s in order to mitigate interactions between this
feature and iOS's built in drag-and-drop functionality.  However,
web::WebViewLongPressElementForContextMenu() was still using 0.7 as the
action's press duration, which caused our context menu tests to fail.

This CL updates the duration for this helper to 0.75s and re-enables
disabled tests.

Bug: 989550
Change-Id: I02cb1208ba0b27d9d70722f1da381f57c0aa1e54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769082Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691002}