- 18 Jun, 2018 39 commits
-
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: Id57db819996d8502fc58510aa6508ea2fc5e5bfb Reviewed-on: https://chromium-review.googlesource.com/1102473Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#567957}
-
Marc Treib authored
TBR=imcheng@chromium.org NOTRY=true Bug: 853114 Change-Id: I1155d8f2c59bd5a55bc99c334ea78e7689b07a7d Reviewed-on: https://chromium-review.googlesource.com/1104137 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567956}
-
Dominic Mazzoni authored
They were accidentally mixed up in both the IDL and the tests. (I used a macro to generate the tests from the IDL, so the same bug crept into both.) Bug: 844540 Change-Id: I04023b609402e2b795a69a785c7f04af3c9459f7 Reviewed-on: https://chromium-review.googlesource.com/1103447Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#567955}
-
Koji Ishii authored
This patch changes a test to non-quirks mode, that hits not-defined, non-interoperable line-height quirks. When all characters on a line is above baseline or below baseline, by applying e.g., 'vertical-align: 1em' or 'line-height: 0': * Blink/WebKit assumes the baseline is part of line-height, except for atomic inlines. * Gecko does not include baseline to line-height. * Edge always include baseline to line-height. * This problem appears only in line-height quirks mode, because otherwise we have a strut that includes baseline. It's not hard to fix this, but does not seem to worth. We can revisit if webcompat proves this is necessary. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I46fa04beae3f216a9293d029520cff69e8e63656 Reviewed-on: https://chromium-review.googlesource.com/1065751 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#567954}
-
David 'Digit' Turner authored
The fetch_all.sh script which was used to download Chromium dependencies from Google Maven no longer works since the move to CIPD-managed packages. This CL introduces a new script (fetch_all.py) to fix the situation. Major differences between these script: * 'fetch_all.py' doesn't modify the workspace by default. Instead it uses a temporary build directory and parses the build.gradle file from there. This allows checking that all changes to this file are valid, and that all new dependencies can be properly downloaded. It then compares the build directory to the current workspace and list any detected differences (i.e. new/updated/deleted packages). * 'fetch_all.py --update-all' can then be used to modify the current workspace as well. This updates DEPS, BUILD.gn, and the content of third_party/android_deps/repository/, as well as prints to stdout a list of commands to upload new and updated packages through cipd. After the CIPD uploads are performed, one can create a new CL and upload it for review. * 'fetch_all.py --reset-workspace' can be used to reset the workspace to a sane state (including cipd-related links), in case the result of --update-all isn't satisfying. This simply removes ../.cipd followed by 'gclient sync --reset --nohooks -r src@HEAD' while trying to preserve your local build.gradle! + This script calls build/android/gyp/aar.py directly to regenerate all AAR .info files. This is simpler than relying on GN mode with 'update_android_aar_prebuilts=true', which no longer works because it tries to write over read-only cipd-controlled .info files. Maybe this mode should be removed, and instructions on how to add an .info file for AAR prebuilts updated to simply call 'aar.py --list <aar_path>' instead? BUG=845405 R=agrieve@chromium.org, jduborick@chromium.org, dgn@chromium.org Change-Id: Id3b14943a0b7094c1a8c1186bff311eaf283b6e3 Reviewed-on: https://chromium-review.googlesource.com/1102319 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#567953}
-
Arthur Sonzogni authored
This CL update the blink layout test: fast/eventsource/eventsource-constructor.html Depending on timing, the third EventSource: ~~~ new EventSource("http://disallowed.example.com/"); ~~~ may start before the test finishes. It results in a new console error message displayed. This CL prevent the console error message to be displayed. Note: I am working on https://crbug.com/831155. It causes the frame to commit a navigation slightly faster. As a result, some tests that are relying on how things are scheduled in blink are failing. Bug: 831155 Change-Id: I8a6bf0c1f1203be1e529b7eb6e3192849f7c518d Reviewed-on: https://chromium-review.googlesource.com/1102324Reviewed-by:Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#567952}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 47a732b0. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 1db32e09 "OffscreenCanvas Text rendering tests" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19893 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kozyatinskiy@chromium.org: external/wpt/console TBR=robertma No-Export: true Change-Id: I04cdd981325ffb30bd4cce958c6b18d0e77674fe Reviewed-on: https://chromium-review.googlesource.com/1103941 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#567951}
-
Takayoshi Kochi authored
The entry pointed to a meta-bug of wpt shadow-dom test issues, but the only remaining one has its own dedicated bug 392771. Bug: 392771, 505364 Change-Id: Ie32ec84d3accbdeabaac79a8c59f9f3d560c48ec Reviewed-on: https://chromium-review.googlesource.com/1103977Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567950}
-
Hiroki Nakagawa authored
This CL introduces the base URL in FetchClientSettingsObject to avoid a dependency on ExecutionContext from ModulatorImplBase. The dependency was not correct because the base URL must be provided by "fetch client settings object", not by "module map settings object". ModulatorImplBase corresponds to "module map settings object". Bug: 845285 Change-Id: I7986e16e3f160e145fa11357fe4a77cdff8113b7 Reviewed-on: https://chromium-review.googlesource.com/1102443 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#567949}
-
Giovanni Ortuño Urquidi authored
This reverts commit d6870941. Reason for revert: The original CL wasn't the cause of the mac bots failing. Original change's description: > Revert "Simplify in-process URLRequestContext creation with the NetworkService." > > This reverts commit f34bba7c. > > Reason for revert: A lot of tests are failing on Mac10.10 and Mac10.12. > Looking at both blame[1][2] lists when the tests started failing, this > seems like the most likely culprit. > > [1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33158 > [2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13801 > > Original change's description: > > Simplify in-process URLRequestContext creation with the NetworkService. > > > > The old code hooked up things to the URLRequestContext that hadn't been > > ported over to work with the NetworkService yet, when the NetworkService > > was enabled. This CL just does the minimum setup that's needed to not > > crash. It also makes requests made with the in-process URLRequestContext > > fail when the network service is enabled. These changes will help > > identify code that still depends on the legacy path, and allow for some > > cleanup of URLRequestContextBuilderMojo and NetworkContext. > > > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > > Change-Id: I4c3f40e6dc3c235844846bff7d1d43d0b1c986d0 > > Bug: 825242 > > Reviewed-on: https://chromium-review.googlesource.com/1096075 > > Commit-Queue: Matt Menke <mmenke@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#567879} > > TBR=jam@chromium.org,mmenke@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 825242 > Change-Id: I36da9fb06fa89296e031c88d7c75c16e63f3b725 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/1103818 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567932} TBR=jam@chromium.org,mmenke@chromium.org,ortuno@chromium.org Change-Id: I4f379142535672553027802c10d0a678a5734aad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825242 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1103858Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#567948}
-
Giovanni Ortuño Urquidi authored
TBR=robertma@chromium.org BUG=853360 NOTRY=true Change-Id: I61d13bce4af0cc83d2630b60d67963ef87b1ae20 Reviewed-on: https://chromium-review.googlesource.com/1104059Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit e7652b9e. Reason for revert: SandboxV2Test.SandboxProfileTest is failing on mac The test has been failing since this CL landed. There doesn't seem to be any other culprit. A lot of tests have been failing on mac for a while, so apologies in advance if this revert is incorrect. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33158 [ RUN ] SandboxV2Test.SandboxProfileTest [29390:779:0615/235812.468905:11042865975282:WARNING:test_suite.cc(240)] Test launcher output path /var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.u2ydbY/test_results.xml exists. Not adding test launcher result printer. [29390:779:0615/235812.562300:11042959366455:FATAL:sandbox_mac_v2_unittest.mm(113)] Check failed: result. line 123: unbound variable: prefix 0 content_unittests 0x000000010a96c29c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 content_unittests 0x000000010a8f3171 logging::LogMessage::~LogMessage() + 225 2 content_unittests 0x0000000108751c4b content::SandboxProfileProcess() + 3499 3 content_unittests 0x000000010a128248 base::TestSuite::Run() + 104 4 content_unittests 0x000000010a13ba1c base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) + 284 5 content_unittests 0x000000010a13b8d0 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) + 160 6 content_unittests 0x000000010874fbf6 main + 198 7 libdyld.dylib 0x00007fff993895c9 start + 1 ../../content/renderer/sandbox_mac_v2_unittest.mm:182: Failure Expected equality of these values: exit_code Which is: 1 0 Stack trace: 0 content_unittests 0x000000010e5750cb testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 content_unittests 0x000000010e574a89 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 content_unittests 0x000000010df21a94 content::SandboxV2Test_SandboxProfileTest_Test::TestBody() + 804 [ FAILED ] SandboxV2Test.SandboxProfileTest (273 ms) Original change's description: > [Mac] Fix form control rendering on 10.14 Mojave. > > The renderers need to talk to the CVMS server (OpenCL compiler), which > then outputs codesigned blobs that can be loaded in to the process. This > is required for drawing the form controls. > > In addition, another Metal bundle location (in /Library) is permitted. > > Bug: 850021, 847518 > Change-Id: I67106972baf5fc55fccd8f7deff3f47cbea076b5 > Reviewed-on: https://chromium-review.googlesource.com/1103127 > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567877} TBR=kerrnel@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 850021, 847518 Change-Id: Ife268e2d49abc98ad3708545223667e0fb12190c Reviewed-on: https://chromium-review.googlesource.com/1104037Reviewed-by:
-
Oscar Johansson authored
When building with Jumbo, kDialog in webui/signin/signin_email_confirmation_dialog.cc and views/webshare/webshare_target_picker_view.cc conflict. This commits solves the issue by renaming the constant to something more file specific. Bug: 773275 Change-Id: Iea327ab1948297fac97d3e7aaab9cb27a3631a30 Reviewed-on: https://chromium-review.googlesource.com/1102474 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#567945}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e61d72b37c64..00c71836144b git log e61d72b37c64..00c71836144b --date=short --no-merges --format='%ad %ae %s' 2018-06-16 danilchap@webrtc.org Replace rtc::Optional with absl::optional in media, ortc, p2p 2018-06-15 titovartem@webrtc.org Add base64 webrtc owned third_party dep 2018-06-15 phoglund@webrtc.org Make instructions for checkin_chrome_dep a bit clearer. 2018-06-15 srte@webrtc.org Adds trial to ignore video pacing for audio packets. 2018-06-15 jonasolsson@webrtc.org Refactor checks to use a copy of the new logging backend. 2018-06-15 yinwa@webrtc.org Fix a downstream test failure. 2018-06-15 srte@webrtc.org Adds trial to always send padding packets when not sending video. 2018-06-15 jonasolsson@webrtc.org Remove stringstreams from modules/video_coding/ 2018-06-15 srte@webrtc.org Makes BBR congestion window more similar to QUIC. 2018-06-15 srte@webrtc.org Improves buffer time calculation in network control tester. 2018-06-15 danilchap@webrtc.org Replace rtc::Optional with absl::optional in audio, call and video Created with: gclient setdep -r src/third_party/webrtc@00c71836144b The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:850493 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6ffa1cac7dd2e705ed84e9dee4649f7b3f9d6c54 Reviewed-on: https://chromium-review.googlesource.com/1103737Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567944}
-
Tetsui Ohkubo authored
This CL adds rotation animation to the arrow icon of UnifiedSystemTray's collapse icon. TEST=manual BUG=850441 Change-Id: Ib385803754daa0d19dc2b976ec075d55f775f1cc Reviewed-on: https://chromium-review.googlesource.com/1098748Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#567943}
-
yusukes authored
BUG=b:77887527 Change-Id: I4eb464522eb729a51f4fe032a3a280acd679f6a1 Reviewed-on: https://chromium-review.googlesource.com/1081653 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#567942}
-
Yuichiro Hanada authored
This CL adds a new method, |SwitchImeTo()|, to ArcInputMethodManagerService. ArcInputMethodManagerService observes the change of the active IME in Chrome OS and send the change to Arc container to synchronize the state between Chrome OS's InputMethodManager and Arc's InputMethodManager. Bug: 845079 Test: unit_tests Change-Id: Ib76795c9c768504a50ec3c4683c5ace6801aaf1d Reviewed-on: https://chromium-review.googlesource.com/1102230Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#567941}
-
Oscar Johansson authored
The function ProfileForWebContents is defined in both extension_install_prompt_show_params.cc and extension_install_prompt.cc. In Jumbo build this causes a conflict. The function is replaced by a inline statement. Bug: 850484 Change-Id: I6e8da38fa7c90bc6b53d7c3f770daa3e158d16c2 Reviewed-on: https://chromium-review.googlesource.com/1100462Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#567940}
-
Patti authored
r565205 introduced a crash when deleting a site's used storage. Fix. Bug: 852676 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8246cc478943dcfa47379ab6e9dfc61c14cae044 Reviewed-on: https://chromium-review.googlesource.com/1100673 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#567939}
-
Trent Apted authored
The touch menu is a regular popup bubble; using BubbleDialogDelegateView to get the desired look with minimal effort. However, that engages its CreateBubbleWidget(), which invokes widget->StackAbove(context). That causes the bubble to stack _immediately_ above |context|; below any already-existing bubbles. That doesn't make sense for a menu-like Widget, so put it back on top. This only really affects ChromeOS. Windows also uses this touch menu, but the call to Widget::Show() already causes the Widget to stack on top again. Bug: 848327 Change-Id: Icf115c69b0d0ca0e4a5af4ac6ce0f2b0c54c1678 Reviewed-on: https://chromium-review.googlesource.com/1100668Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#567938}
-
Hiroki Nakagawa authored
Before this CL, referrer for top-level module script is set in BaseFetchContext::AddAdditionalRequestHeaders() using ExecutionContext::GetOutgoingReferrer(). This works for documents, but doesn't for workers because this execution context is corresponding to "module map settings object", not "fetch client settings object". To fix this, this CL sets the referrer for top-level module script using "fetch client settings object" in ModuleScriptLoader as the spec defines. Change-Id: I0878b13febdae4ee2dc56c998e7f2c100e9c1ba7 Bug: 842553 Reviewed-on: https://chromium-review.googlesource.com/1102236Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit 1582e398. Reason for revert: Broke chromeos_unittests https://findit-for-me.appspot.com/waterfall/failure?redirect=1&url=https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27937 https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27937 Original change's description: > [CrOS MultiDevice] Add BleConnectionManager. > > Creates connections to remote devices over Bluetooth, using either the > listener role (BLE scans only) or the initiator role (a combination of BLE > advertising and scanning). > > When a connection is attempted, it remains active until either an > AuthenticatedChannel is returned successfully or until the request is > explicitly removed via one of the Cancel*() functions. > > Bug: 824568, 752273 > Change-Id: Icda1cde32e3d4455742c1570df15b82979cd0ace > Reviewed-on: https://chromium-review.googlesource.com/1100133 > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Ryan Hansberry <hansberry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567796} TBR=khorimoto@chromium.org,hansberry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 824568, 752273 Change-Id: Ie665ff0cc4390132955e4599eb3dab7caedd8746 Reviewed-on: https://chromium-review.googlesource.com/1103917Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit b0278053. Reason for revert: UserAddingScreenTest.ScreenVisibility has been flaky since this landed: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=UserAddingScreenTest.ScreenVisibility [28936:28936:0617/213745.316026:FATAL:accelerator_manager.cc(32)] Check failed: !base::ContainsValue(targets, target). Registering the same target multiple times #0 0x000004980f5c base::debug::StackTrace::StackTrace() #1 0x000004902b4b logging::LogMessage::~LogMessage() #2 0x000005857d49 ui::AcceleratorManager::Register() #3 0x000001ca3442 chromeos::WebUILoginView::WebUILoginView() #4 0x000001c9a51c chromeos::LoginDisplayHostWebUI::InitLoginWindowAndView() #5 0x000001c98cc5 chromeos::LoginDisplayHostWebUI::OnStartUserAdding() #6 0x000001ca20c7 chromeos::(anonymous namespace)::UserAddingScreenImpl::Start() #7 0x0000015dfd1c chromeos::UserAddingScreenTest_ScreenVisibility_Test::RunTestOnMainThread() #8 0x000004f449b7 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() Original change's description: > Support feedback keyboard shortcut in views login screen. > > This CL supports alt+shift+i to open the feedback dialog in views login > screen. > > Bug: 852242 > Change-Id: I9a285c6929fd2302d22f90fbefbb32bcd814359d > Reviewed-on: https://chromium-review.googlesource.com/1102035 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567829} TBR=xiyuan@chromium.org,tsepez@chromium.org,jdufault@chromium.org,xiaoyinh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 852242, 853445 Change-Id: I21afadf31af3c9ae8e04a30f6021b928efde43f8 Reviewed-on: https://chromium-review.googlesource.com/1103957 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
François Beaufort authored
This make sures requestPictureInPicture is resolved with existing Picture-in-Picture window when video is already pictureInPictureElement. Bug: 806249 Change-Id: I16e3fc2e8e19c2b623e8d2518fe4672a2a16b756 Reviewed-on: https://chromium-review.googlesource.com/1101686 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#567934}
-
Dirk Pranke authored
This sets the gpu=none flag explicitly to get the browser_tests to run on the VMs in the Chrome-quarantine pool on Mac10.12, to avoid any confusion with the default gpu values for the other test suites. This also temporarily turns off the browser_tests on 10.10, since it looks like we're probably too low on capacity there to handle this easily. We'll add more tomorrow and try again. TBR=jbudorick@chromium.org BUG=828031 NOTRY=true Change-Id: Ib948ba17c2bb3b4fb56912a9c612e72fa5e08f11 Reviewed-on: https://chromium-review.googlesource.com/1103938 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567933}
-
Giovanni Ortuño Urquidi authored
This reverts commit f34bba7c. Reason for revert: A lot of tests are failing on Mac10.10 and Mac10.12. Looking at both blame[1][2] lists when the tests started failing, this seems like the most likely culprit. [1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33158 [2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13801 Original change's description: > Simplify in-process URLRequestContext creation with the NetworkService. > > The old code hooked up things to the URLRequestContext that hadn't been > ported over to work with the NetworkService yet, when the NetworkService > was enabled. This CL just does the minimum setup that's needed to not > crash. It also makes requests made with the in-process URLRequestContext > fail when the network service is enabled. These changes will help > identify code that still depends on the legacy path, and allow for some > cleanup of URLRequestContextBuilderMojo and NetworkContext. > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I4c3f40e6dc3c235844846bff7d1d43d0b1c986d0 > Bug: 825242 > Reviewed-on: https://chromium-review.googlesource.com/1096075 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567879} TBR=jam@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 825242 Change-Id: I36da9fb06fa89296e031c88d7c75c16e63f3b725 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1103818 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Joel Hockey authored
* Defer call of setupCrostini_ until after |setupAndWaitUntilReady| to ensure UI has been created. * Stopped sending 'onDirectoryChanged' events for downloads and drive after adding new items and instead click Downloads entry to select it, or click Refresh button if downloads is already selected to ensure new items are refreshed and shown. Bug: 853594 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I47a7e062f8d9cbce44b68ee5203f545c9635a195 Reviewed-on: https://chromium-review.googlesource.com/1103428Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#567931}
-
Koji Ishii authored
Following bot results are included. 6871 6875 6881 6883 6884 6885 6888 6890 6895 6896 6897 6898 6901 6902 6903 6904 6905 6 lines were removed and 3 lines were deflaked by consecutive results since 6885. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I83cd32b138ea61591a8a853ce2040d6f1c5bab97 Reviewed-on: https://chromium-review.googlesource.com/1102220 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567930}
-
Julie Jeongeun Kim authored
Each Ozone platform creates its own NativeDisplayDelegate to get display information. Otherwise, 'display::FakeDisplayDelegate' is used for NativeDisplayDelegate. Per bug, ozone headless is crashing because it uses FakeDisplayDelegate and it doesn't invoke OnConfigurationChanged before initialization completes so ScreenBase can't add the display. Once NativeDisplayDelegate is initialized, DesktopScreenOzone requires DisplayMode from DisplaySnapshot but FakeDisplayDelegate has FakeDisplaySnapshot and it doesn't have DisplayMode. This CL creates HeadlessNativeDisplayDelegate which owns DisplaySnapshot and DisplayMode for ozone/headless. DesktopScreenOzone keeps it in delegate_ and communicates with it. To try this, compile with the following gn args use_ozone = true ozone_platform_headless = true TEST=./out/Debug/chrome --ozone-platform=headless Bug: 851375 Change-Id: Ib0d6dc66e6d9c538db38e1c6f04c35b149f9b6e6 Reviewed-on: https://chromium-review.googlesource.com/1094851Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#567929}
-
Yingbing Wu authored
[VK] Expose enable-virtual-keyboard-md-ui flag value to the keyboard configuration of API "chrome.virtualKeyboardPrivate.getConfig". Change-Id: I7c8832c8d7a259774a2377eab60227f93b291c0a Reviewed-on: https://chromium-review.googlesource.com/1103421Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yingbing Wu <wuyingbing@chromium.org> Cr-Commit-Position: refs/heads/master@{#567928}
-
Tsuyoshi Horo authored
Bug: 803774 Change-Id: Ibc55a90da18855ef34dae046823f83c6992ce41d Reviewed-on: https://chromium-review.googlesource.com/1102281Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#567927}
-
Christopher Cameron authored
Running a full nested NSRunLoop appears to cause problems wherein CATransactions are created from within a CATransaction's commit handlers. Bug: 853438 Change-Id: I37e9d3f92025c8b45201e23109a87e02afd6085c Reviewed-on: https://chromium-review.googlesource.com/1100239 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#567926}
-
Tetsui Ohkubo authored
ash_view_ids.h will be used frequently in browser tests under chrome/browser, so it should be in ash/public/cpp. TEST=trybots pass BUG=none Change-Id: I1df387234969908e6659c1596583b6d46ad01185 Reviewed-on: https://chromium-review.googlesource.com/1102278 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#567925}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ife202f3a80590b2c2538c5edf6ef8bf0a4e9dedc Reviewed-on: https://chromium-review.googlesource.com/1103774Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#567924}
-
Blake O'Hare authored
If you adjust the volume while the virtual keyboard is loaded, the slider will be hidden underneath the keyboard. Bug: 836155 Change-Id: Ia4f4c116906f80058772decc8420c8021f463aa6 Reviewed-on: https://chromium-review.googlesource.com/1096585Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
-
Dirk Pranke authored
This re-enables just the browser_tests suite on the chromium.mac bots and the matching trybots. The tests on Mac10.13 Tests are still marked as experimental, so failures there won't block the CQ. The re-enabled tests will run in the 'Chrome-quarantine' pool, which means that if the tests kill the machines, it should only affect the machines in that pool, and not the machines in the main 'Chrome' pool. The tests are still disabled on chromium.clang, chromium.fyi, and chromium.memory, and viz_browser_tests and surface_sync_browser_tests are still disabled everywhere. If it looks like this approach is working, we can reenable those as well as long as they go into the quarantine pool. R=jbudorick@chromium.org BUG=828031 NOTRY=true Change-Id: I2e914b68584fd4d718aba246906f38b0724a08f1 Reviewed-on: https://chromium-review.googlesource.com/1103796 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#567922}
-
Dirk Pranke authored
With the creation of the new 'Chrome-quarantine' pool we accidentally left the 10.12 'Chrome' pool with no 'gpu: none' machines (i.e., no VMs) to run tasks. This CL shifts all of the tests to physical machines where we should have capacity. TBR=jbudorick@chromium.org BUG=828031 NOTRY=true Change-Id: I1624d86887e65913330bc11b0cb1b05ddc05e1f9 Reviewed-on: https://chromium-review.googlesource.com/1103846 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Penny MacNeil authored
This does not "turn on" full blocking. The new hook will be in place, ready to block, but behavior will be determined by chrome/browser/conflicts/* in future CLs. The hook will default allow load. Tests: chrome_elf_unittests.exe, ThirdParty* Bug: 769590 Change-Id: I97b1f1d368a160e0f9856dfb55a0242af350328d Reviewed-on: https://chromium-review.googlesource.com/1076972Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#567920}
-
Ben Wagner authored
The Skia change has landed, so remove this compile flag and rebaseline. BUG=chromium:698492 Change-Id: I9446021ae0ccd908abee40226e81bf6c99819af8 Reviewed-on: https://chromium-review.googlesource.com/1102730Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#567919}
-
- 17 Jun, 2018 1 commit
-
-
Darren Shen authored
Some classes listen to ShellObserver::OnVirtualKeyboardStateChanged in order to add/remove KeyboardController observer when the keyboard is enabled/disabled. However, with the simplified KeyboardController lifetimes, we can add/remove observers whenever. So we just add an observer in the constructor and remove it in the destructor. After this change, there will be no more observers of OnVirtualKeyboardStateChanged. Bug: 731537 Change-Id: I7274484229ff5f64ac973806e565f178a271094f Reviewed-on: https://chromium-review.googlesource.com/1101598Reviewed-by:
-
