- 05 Aug, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596635955-2b1d31dacdbaf52cf854414e21cd977f1d32db43.profdata to chrome-win32-master-1596643173-1c5e3b62f80a4dd3f16924cb334ea677bc923f5e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I13d20081550abb91d26374dded504b023ff97b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339541Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795176}
-
Noah Rose Ledesma authored
In order for the global media controls dialog to display the currently used audio device in the UI the renderer needs to report what device is in use. Currently, MediaWebContentsObserver will receive messages when the output device is switched. However, the device id reported by the renderer is hashed so that it may be only used on one origin. This change has the MediaWebContentsObserver translate the device ID before passing it off to the MediaSessionControllersManager. Bug: 1111432 Change-Id: I11d161ff5f89525b4c465f01a779bdd30e31c823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331330 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#795175}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fa9a15cb008b..fe8e758b920c 2020-08-05 thestig@chromium.org Rewrite OS_LINUX define. 2020-08-05 thestig@chromium.org Rewrite is_linux GN flag. 2020-08-05 tsepez@chromium.org Rename CXFA_NodeHelper to CFXJSE_NodeHelper and move to fxjs/ 2020-08-05 thestig@chromium.org Roll tools/clang/ 6cbea33c9..1078c4141 (10 commits) 2020-08-04 thestig@chromium.org Use |kAA| instead of "AA" string. 2020-08-04 thestig@chromium.org Remove some dead CPDF_FormControl code. 2020-08-04 thestig@chromium.org Roll third_party/zlib/ f87c8e288..7492de9a5 (3 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110266 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I857a1b9d415c8bd425194f933c82e65081afe49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338923Reviewed-by:
-
Jun Kokatsu authored
This change makes Trusted Type policy enforcement to Perfect types (i.e. `require-trusted-types-for 'script'; trusted-types;`) by default for WebUI (while still keeping report-only). This means WebUI will not be able to use unsafe APIs by default (e.g. innerHTML, document.write, etc). However, I have removed Trusted Types CSP from a pages where it does not support Trusted Types yet (e.g. Polymer 3). This change will not make any observable changes, as report-only CSP would only log console error when it detects Trusted Types violation. Bug: 41905 Change-Id: Ib9d6eae53b600123c1837d2cdc56269c14a8d00f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234238 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#795173}
-
Noah Rose Ledesma authored
The current implemnetation of GetMediaDeviceIDFroHMAC accepts a blink::mojom::MediaStreamType to distinguish between audio and video devices. However, it is not able to distinguish between audio input and output. Currently, this method will assume input. In order to allow this method to work with audio output devices this change introduces an overload that accepts a blink::MediaDeviceType instead of a stream type. Bug: 1111585 Change-Id: Ie7111665f8cd3d24a360bff28d2da56c7ddfaacb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330741 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#795172}
-
Dan Harrington authored
Bug: 1113284 Change-Id: I63092930726af55e45b1878850de540a09d9ad69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339700 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#795171}
-
Dana Fried authored
See attached bug for rationale and example screenshots. We went from only making the change on Windows to making it on all platforms because the difference isn't jarring but makes a positive change in readability in almost all cases while maintaining the correct font height for the badge. Bug: 1111648 Change-Id: Ife6f126238489f11ead564ddf8f123de100a9d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331296Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#795170}
-
Daniel Rubery authored
This CL introduces a new Finch flag, SafeBrowsingRemoveCookies, which controls whether certain communications with Safe Browsing to attach cookies. This was previously being shared with the SafeBrowsingSeparateNetworkContexts Finch flag, which was misleading. Bug: 1049833 Change-Id: If5f375fb146a1afe5669fc22f5b863bcfdd096c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337253Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#795169}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I8cac684b50d2ed3d2ba61cbc75ca2e67c0f3ea2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339938Reviewed-by:
-
Mugdha Lakhani authored
This is so WebLayer can use it to support NoStatePrefetch. Bug: 1096088 Change-Id: If0986e4e2eb43960bd19c4d43b1272c1803dfd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336082Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#795167}
-
Fred Mello authored
https://docs.google.com/document/d/1SWAM_6e1Tk4UexJ1QuZJUtfXCQEqRfAQT_mfkSqBJqM Bug: 1112872 Change-Id: I387fb3f0f7d96b0dc92cd5494668b29735d870e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339925 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#795166}
-
Stephen Martinis authored
These will not actually be executed, but should be isolated, which is useful for the testing team. Bug: 1106083 Change-Id: Ie9094bf7eaa70dd0a130ccb747c7f64d8f5bdffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339921 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#795165}
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: I972509c2ce8e28dcd6542b0b9531d1c0a961dd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244971 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#795164}
-
Omer Katz authored
This reverts commit 77cd5d73. Reason for revert: pinpoint shows only regressions. Original change's description: > heap: Minor marking tweaks > > 1) Traces show that it can take a relatively long time before Oilpan > starts flushing v8 references (e.g. ~10 steps spent just on the > bailout worklist). This CL moves v8 references flushing before > processing of the bailout worklist. > 2) Traces also show that a shorter duration for the first marking step > can suffice. > > Bug: 986235 > Change-Id: If7bad026e91f1fdf1899035bda049834e7bffab5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339356 > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Auto-Submit: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795059} TBR=bikineev@chromium.org,omerkatz@chromium.org Change-Id: I36bbadafcfe91a4f725537975ec06b1a9ac10e0a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340040Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#795163}
-
William Lin authored
Currently, the identity internals debugging page does not display the account ID that the token belongs to. This information may be useful to list for debugging cases where multiple accounts are involved. This CL adds the account ID for each cached token to the Identity Internals page. Bug: None Change-Id: I704748f2521cb34c96ed7ccade0fdac6e99d01dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333545 Commit-Queue: William Lin <williamlin@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#795162}
-
Brian Sheedy authored
Targets the new driver and Windows versions for the GPU Windows 10 Quadro P400 machines in preparation for an upcoming upgrade. Bug: 1085489 Change-Id: I4dffa9fe085fa96dc3ad3e73bb981314195f98e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340000 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#795161}
-
Siyu An authored
Design doc go/chrome-sync-merchant-offers. Start with implementing only the protobuf changes since they are in kind of a finalized state and this CL can unblock impl on GMSCore. Bug: 1112095 Change-Id: I27705f467424d614c80b4dd03ae5207e112e4c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333870 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#795160}
-
Devlin authored
This reverts commit 4856b612. Reason for revert: New test is failing on windows asan. https://ci.chromium.org/p/chromium/builders/ci/win-asan/13719 [ RUN ] All/DumpAccessibilityEventsTest.AccessibilityEventsAriaHiddenDescendantsAlreadyIgnored/win DevTools listening on ws://127.0.0.1:56078/devtools/browser/cb8ef55e-fd6c-40c9-9bb9-69a6e2f10a39 [3056:12476:0805/095807.582:ERROR:browser_test_utils.cc(712)] No committed entry. [3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged [3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kLayoutComplete [3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kLoadComplete [3056:12476:0805/095810.693:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged [3056:12476:0805/095810.694:ERROR:dump_accessibility_events_browsertest.cc(103)] === IsRecordingComplete#1 run_until size=0 [3056:12476:0805/095810.703:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged [3056:12476:0805/095810.856:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged [3056:12476:0805/095810.857:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kEndOfTest [3056:12476:0805/095810.866:INFO:dump_accessibility_test_helper.cc(93)] Testing: C:/b/s/w/ir/content/test/data/accessibility/event/aria-hidden-descendants-already-ignored.html [3056:12476:0805/095810.867:INFO:dump_accessibility_test_helper.cc(95)] Expected output: C:/b/s/w/ir/content/test/data/accessibility/event/aria-hidden-descendants-already-ignored-expected-win.txt [3056:12476:0805/095810.867:ERROR:dump_accessibility_test_helper.cc(127)] Diff: * Line Expected - ---- -------- 1 EVENT_OBJECT_HIDE on <div#heading-root.a> role=ROLE_SYSTEM_GROUPING name="Heading" INVISIBLE level=2 2 EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL * 3 IA2_EVENT_TEXT_INSERTED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL new_text={'<obj>' start=0 end=1} * 4 IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1} Actual ------ EVENT_OBJECT_HIDE on <div#heading-root.a> role=ROLE_SYSTEM_GROUPING name="Heading" INVISIBLE level=2 EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL IA2_EVENT_TEXT_INSERTED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL new_text={'<obj>' start=0 end=1} IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1} IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1} <-- End-of-file --> Original change's description: > Fire WIN HIDE event only on ignored ancestor > > Google drive expand/collapse state is not being announced due to > excessive HIDE/SHOW/REORDER events flooding NVDA, and NVDA end up > discarding most events. > > For example, if aria-hidden="true" is set on an ancestor node, which > would cause that node many of its descendants to be set to IGNORED > state which triggering too many EVENT_OBJECT_HIDE and causes NVDA > to drop the events. In reality, we only want EVENT_OBJECT_HIDE to be > generated on the ancestor node where aria-hidden="true" is set, so > not to flood and confuse NVDA with excessive events. > > This change fixes the above issue by firing EVENT_OBJECT_HIDE on the > root should the entire subtree changes to IGNORED state. > > Suppressing excessive SHOW/REORDER events will be addressed in follow up > patches. > > AX-RelNotes: NVDA can now announce Google drive "My Drive" expand/ > collapse state. > > Bug: 1019420 > Change-Id: I4fdabd6740630a149c1b22cdb3180d2f75807b10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309450 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#795017} TBR=dmazzoni@chromium.org,aleventhal@chromium.org,Adam.Ettenberger@microsoft.com,vicfei@microsoft.com Change-Id: I4354e1effb7b3fe4a01caef00f696513ecaacbbc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339828Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795159}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1e0d126c..10ee7644 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie2ff859c44254929e07512ccd23568fbf659e4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339794Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795158}
-
Thomas Tellier authored
Bug: 1015746 Change-Id: I5862995d37ae067664304f57562460c46d51c811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339518Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#795157}
-
Noah Rose Ledesma authored
The media session controller will now notify the media session of audio device switching. Upon receiving this message, the media session will update the MediaSessionInfo to include the device id and notify its observers. Because it is possible for a media session's players to be using different audio devices, a device is only added to the info object if all of the sessions players are using the same device. Bug: 1096251 Change-Id: I280387991b333eff60141e38e119eff7444aebb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324406 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
Introduces new metric recording outcome of every Omnibox focus event. Logged result will allow us to monitor for increase in abandoned interactions as we introduce new suggestion types. Bug: 1105156 Change-Id: I0b12e8cfa748e6a33f1d44e96ade77bf0b39cdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329878 Commit-Queue: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Reviewed-by:Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
liberato@chromium.org authored
AndroidBatteryMetrics required an application state change before switching from UNKNOWN to the current state, which prevents it from recording metrics on browser startup immediately. This CL changes the behavior to check the application state on startup, so that recording can begin immediately. Change-Id: Iaec5a175ea3f367b30d1fd95414dcc5e67573315 Bug: 1113311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333090 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#795154}
-
Ken Rockot authored
Bug: 1059389 Change-Id: Ifcd3c119d779503d4a2f8a9bd8046b6ce7272951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339205Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#795153}
-
Koji Ishii authored
r793989 crrev.com/c/2332083 caused a test in `virtual/ layout_ng_block_frag` to hit DCHECK failure in |NGInlineCursor|, and probably caused two flakes in crbug.com/1112237 and crbug.com/1112289. r795011 crrev.com/c/2313736 supports block fragmentation in |NGInlineCursor|. This patch removes these DCHECK failiure expectations. Bug: 829028, 1112237, 1112289 Change-Id: I637ad65e2143d7506a570c8edf91edb36e26ad47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339697 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
This CL is fixing a crash related to cursor movement (line) when a single-line RenderText has newline. The unittest added is crashing without the fix. The problem is the following: 1) In single-line, newline codepoints are rewritten 2) The whole text will be in the same run (same Line). 3) The cursor movement function are looking at the original text to detect a newline. SEE: RenderText::GetAdjacentSelectionModel(...) is calling |-> LineSelectionModel(GetLineContainingCaret(current), direction); But it has an incorrect line number, since: RenderTextHarfBuzz::GetLineContainingCaret(...) |-> LineIndexForNewline The function is looking at the original text! R=msw@chromium.org Bug: 1108254 Change-Id: I656cd8a4b0a5d5d77e074249425c5821860d3e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339385Reviewed-by:Michael Wasserman <msw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795151}
-
Nate Fischer authored
This adds a search bar to filter flags. To match the apparent behavior of chrome://flags, this accepts any flag which contains the query as a case insensitive substring of either the flag name or description. If the user has any (non-empty) query, this will also filter out the warning message, since this is just getting in the user's way. This imports the material search icon (magnifier glass). Bug: 1052345 Test: Manual - verify the search bar works as expected Test: run_webview_instrumentation_test_apk -f DeveloperUiTest.* Change-Id: I80db4b7325d9c931f622f9f37d969350865115b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330310 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#795150}
-
Andy Lu authored
Implementing a pref so that printing a web page can be disabled. The print option will not show up in the "share" action sheet if the policy is disabled.Also will disable any other entry point such as Javascript window.print(). Also added the unit tests associated with the new pref. Bug: 1066482 Change-Id: I3167f941bc2f192600d359a75a8bd844ffc2fc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337715Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Andy Lu <andyhylu@google.com> Cr-Commit-Position: refs/heads/master@{#795149}
-
Dominic Mazzoni authored
Original patch: http://crrev.com/c/2319411 Revert: http://crrev.com/c/2326560 See diff between first and last patchsets. The revert was due to the new DCHECK added in render_accessibility_impl.cc. I carefully debugged all of the failures and there was only one real failure (slider thumbs) which are now fixed with a few lines of code to explicitly invalidate them. The other failures were all false positives - in every case, the bounds of a LayoutObject had changed but the paint invalidation simply hadn't come yet - but it eventually came and all bounding boxes became correct. So I'm just removing the DCHECK. The performance win is great, and we're not seeing any cases where bounds aren't invalidated where they should be. We can revisit if we see failures in the wild. Original description: Previously, any time there was a layout, the accessibility serialization code would scan every AXObject to see if any needed to update their bounding box. Instead, replace this with a mechanism that uses PaintInvalidator to mark AXObjects that might have dirty bounding boxes. Existing tests already provide some coverage; if you comment out the code in paint_invalidator.cc, a handful of browser tests fail. To provide even more coverage, a debug-only check walks the entire tree and ensures that no nodes have incorrect bounding boxes. If you try commenting out the code in paint_invalidator.cc now, hundreds of browser tests fail. This provides some good confidence that it's working correctly. Finally, add a new blink perf test demonstrating a simple scenario where this results in a dramatic speedup, just by focusing links in a document with a few thousand nodes. Bug: 1109081 Change-Id: Ia6bdbbac243c816a613d7b44807c91534b33221e AX-Relnotes: makes accessibility less sluggish on very large web pages Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333573Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#795148}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08a9885983f1..3b1b0980710f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com,rdcronin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1085419,chromium:1105096,chromium:1112335,chromium:1113252 Tbr: rogerta@google.com,rdcronin@google.com Change-Id: Ie646c5535cbda49368215d574d8b692598a32c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338817Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795147}
-
Aaron Leventhal authored
Active descendant information should be exposed on the focused object. In the case of the Omnibox, this is the textfield, not the listbox. This is the same source as active descendant changed events. The active descendant information is not currently used by any AT to enable the omnibox, but it could be, so it should be corrected. Bug: None Change-Id: I1adda17e3065d884b20ab2307f5c89b3c7c0c7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339379 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2de6d657dde3..695e1de8318d 2020-08-05 johnkslang@users.noreply.github.com Merge pull request #2365 from KhronosGroup/update-gtests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I4d14295b6deda9e26a5af572635524e71b5555a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339725Reviewed-by:
-
David Tseng authored
Bug: 1112348 AX-Relnotes: n/a Change-Id: I05deaeaf61f1390feb700c322799d9afd05a75e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322736 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#795144}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/011b0075cd53..a4a8199cf1a3 2020-08-05 t-olfly@microsoft.com Source order viewer toggle persistence 2020-08-05 jobay@google.com Eliminate initial timeout in waitForFunction If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112692 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8210522fb914799218b17f3f348a9b95fec877ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339537Reviewed-by:
-
Jihwan Marc Kim authored
A 'once' listener should be unregistered when it is invoked, and stopImmediatePropagation() should not invoke other event listeners. We had a bug that stopImmediatePropagation() unregistered uninvoked 'once' listeners. Bug: 993109 Change-Id: Iaabb03141ee7cf2de88dc6c8726f5a474efd133b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336011 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#795142}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/486f1812ef65..bd6505349012 2020-08-05 saagarsanghavi@google.com ResultDB reporting for bot-triggered builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Iadaeb46832185a028295ce96aa8541d492fc29aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339726Reviewed-by:
-
Jimmy Gong authored
- When the print job app is enabled, print notifications will show a simplified progress notification and hide all buttons. Bug: 1103369 Change-Id: I17424d33fed72a1df6cf1ba3ec5dd129ebe5774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324411Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#795140}
-
Jimmy Gong authored
- Fixes a bug where the PRINTER_UNREACHABLE error was not captured by the print job history service. - This only occurred if the user were to attempt to print repeatedly to an offline printer. In those cases, the error was only captured in the OnPrintJobUpdated event. Bug: 1103429 Change-Id: I910fa3a173300e62ac151e58ff679c0e389497ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315797Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
This CL is adding unittests for testing fractional text position. The tests are fonts and platform-independant. The layout will be the same on every system. R=msw@chromium.org Bug: 1111044 Change-Id: I3db022838866516501fbd0405a059a6a4b5aa3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331332 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e4e2a847dab3..c547fda2a9c6 2020-08-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 74cc8ea2b8df to be7c55a2a8ce (2 revisions) 2020-08-05 syoussefi@chromium.org Add back glslang include check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I4efc5974a6b93014147619acf507fd3a680acac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339639Reviewed-by:
-
