- 10 Dec, 2015 40 commits
-
-
thakis authored
It was added for chrome frame testing, but chrome frame is no more. Nothing depends on this target nowadays. It doesn't build with clang/win, and the only reason we didn't notice is because the 'all' target doesn't include all targets in gyp. The gn build gets this right. Since this target doesn't build with clang/win and is unused, just delete it. BUG=82385 Review URL: https://codereview.chromium.org/1521443002 Cr-Commit-Position: refs/heads/master@{#364511}
-
tommycli authored
Patch does a few things: 1) Renames a bunch of inconsistently named Sync / Sign-in classes and Polymer pages to the consistent People. 2) Enables People section on ChromeOS, as it should be. BUG=563721,559481 Review URL: https://codereview.chromium.org/1503333003 Cr-Commit-Position: refs/heads/master@{#364510}
-
tapted authored
This currently generates a lot of log spam. Aura widgets do something for drag and drop here, but that's coming later. By continuing to emit the log when a mouse button is pressed, the log may still hint at the potential cause of an imminent problem. BUG=464581, 565979 Review URL: https://codereview.chromium.org/982193003 Cr-Commit-Position: refs/heads/master@{#364509}
-
brettw authored
In order to roll GN 7c3f6cc6..e33d0667 (r363049:r364398) and pick up the following changes: 936b61a1 No GN phony rules when it matches outputs. 22d5facb tools/gn: depend on allocator_extension.cc to keep bootstrap working 90cdb30c Reference configs variable from config help in GN dda6c278 Remove allocator_extension_thunks since this layer is not required 79adad4e Format all BUILD.gn with "gn format --in-place". 0cbfc07f tools/gn: update reference.md doc 910ac443 [GN] Add support to rebase_path to resolve paths above the source root. 7741ab49 tools/gn: forward declare some base types in trace.h TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Review URL: https://codereview.chromium.org/1517583004 Cr-Commit-Position: refs/heads/master@{#364508}
-
thakis authored
BUG=559766 TBR=rch Review URL: https://codereview.chromium.org/1510173006 Cr-Commit-Position: refs/heads/master@{#364507}
-
dpranke authored
This reverts #364362 and re-lands #364236, now that the underlying issue w/ webkit_unit_tests has been addressed. TBR=thakis@chromium.org BUG=432959 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_oilpan_rel Review URL: https://codereview.chromium.org/1506333004 Cr-Commit-Position: refs/heads/master@{#364506}
-
tommi authored
WebRTC 10903:10978 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/118aa04..090af54 Libjingle 10903:10977 Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/917ba7e..5a04232 TBR= BUG= Review URL: https://codereview.chromium.org/1515673005 Cr-Commit-Position: refs/heads/master@{#364505}
-
nick authored
It seems there's an obscure shutdown-time race where we wind up with a null GetURLRequestContext() after the grabbing the cookies. Speculative "it can't hurt" fix for the bug below. BUG=568716 Review URL: https://codereview.chromium.org/1516043002 Cr-Commit-Position: refs/heads/master@{#364504}
-
zmo authored
media/video-aspect-ratio.html media/video-colorspace-yuv420.html media/video-colorspace-yuv422.html media/video-controls-rendering.html media/video-controls-with-cast-rendering.html media/video-layer-crash.html media/video-overlay-cast-dark-rendering.html media/video-overlay-cast-light-rendering.html media/video-transformed.html svg/wicd/rightsizing-grid.xhtml svg/wicd/sizing-flakiness.html svg/wicd/test-rightsizing-a.xhtml svg/zoom/page/zoom-hixie-mixed-009.xml svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm svg/zoom/page/zoom-svg-through-object-with-auto-size.html svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml tables/mozilla/bugs/bug101674.html tables/mozilla/bugs/bug14929.html tables/mozilla/bugs/bug86708.html tables/mozilla_expected_failures/bugs/97619.html tables/mozilla_expected_failures/bugs/bug85016.html BUG=568778 TEST=XP blink bot TBR=dglazkov@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1513303004 Cr-Commit-Position: refs/heads/master@{#364503}
-
dbeam authored
This CL limits the number of downloads to 20 when: - first showing the download page - searching - undoing a "Clear all" It also ignores updates to items that aren't yet transmitted to the page and loads more when the user scrolls to the end of the list. R=asanka@chromium.org BUG=526577,526583 Review URL: https://codereview.chromium.org/1492273002 Cr-Commit-Position: refs/heads/master@{#364502}
-
scottmg authored
This was broken at https://codereview.chromium.org/1481703002/ in static_library builds. base/debug/crash_logging.cc silently ignores key setting if there's not a key setting function set to it. When crashpad moved to the exe, everything sort of seemed OK (and a few keys got set because they're set in crashpad.cc in the exe). But any set from the dlls went into their copy of base/debug/crash_logging.cc which didn't have logging set up in crashpad.cc because it only initialized the globals in the exe. The fix (resurrected from code removed in https://codereview.chromium.org/1479283002/) is to have the DLLs set their own function to call back into the exe. This doesn't occur in shared_library builds because there's only one 'base'. Example static_library: crash/7e66260061a696bb (noting that Fields include switches, extensions, etc.) Example shared_library: crash/708ab5c5f980e0df R=mark@chromium.org TBR=cpu@chromium.org BUG=568189, 546288 Review URL: https://codereview.chromium.org/1517503004 Cr-Commit-Position: refs/heads/master@{#364501}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3b13f76f..7b14b333 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1517693003 Cr-Commit-Position: refs/heads/master@{#364500}
-
tsergeant authored
The change to classify mixed content and SHA-1 certificates as insecure meant that a details link would not appear for these sites. BUG=568401 Review URL: https://codereview.chromium.org/1509193007 Cr-Commit-Position: refs/heads/master@{#364499}
-
thestig authored
Currently, the plugin's frame's url is chrome-extension://[pdf_extension_id]/index-material.html and that gets sanitized to nothing. Instead, just use the document's URL, like in r327641. BUG=563137 Review URL: https://codereview.chromium.org/1510993002 Cr-Commit-Position: refs/heads/master@{#364498}
-
shess authored
Unlock passed F_UNLCK as cmd to fcntl(). It's supposed to be in flock.type. As a result, the file is not actually unlocked. F_UNLCK is 2 (on OSX and Linux), cmd 2 is F_SETFD, which sets flags on the file descriptor, which is why the call succeeds. The only flag defined appears to be FD_CLOEXEC, which is the low-order bit of the third parameter. Since the parameter passed to fcntl is aligned at off_t or better, Unlock() will clear FD_CLOEXEC if set. As best I can tell cases with FD_CLOEXEC do not use base::File. [Addendum: File::Lock/Unlock was landed for leveldb, and at this time Chromium's only use is in third_party/leveldatabase/env_chromium.cc.] BUG=565787 Review URL: https://codereview.chromium.org/1491743009 Cr-Commit-Position: refs/heads/master@{#364497}
-
stevenjb authored
BUG=563744 Review URL: https://codereview.chromium.org/1520563002 Cr-Commit-Position: refs/heads/master@{#364496}
-
Stephen White authored
This will cause Skia to do more accurate allocations for offscreen buffers, reducing memory usage. Mark affected tests as needing rebaseline, or give new reference result. BUG=240827 R=fmalita@chromium.org Review URL: https://codereview.chromium.org/1513283003 . Cr-Commit-Position: refs/heads/master@{#364495}
-
wnwen authored
BUG=567299 Review URL: https://codereview.chromium.org/1508813002 Cr-Commit-Position: refs/heads/master@{#364494}
-
grunell authored
BUG=323185 Review URL: https://codereview.chromium.org/1513313002 Cr-Commit-Position: refs/heads/master@{#364493}
-
sky authored
No one uses this anymore. BUG=none TEST=none R=sadrul@chromium.org Review URL: https://codereview.chromium.org/1510413004 Cr-Commit-Position: refs/heads/master@{#364492}
-
ccameron authored
BUG=554541 Review URL: https://codereview.chromium.org/1503393005 Cr-Commit-Position: refs/heads/master@{#364491}
-
zmo authored
Probably it just needs to be rebaselined, but I am not a qualified judge on this. BUG=521124 TEST=XP blink bot TBR=dglazkov@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1511413006 Cr-Commit-Position: refs/heads/master@{#364490}
-
bcf authored
BUG= internal b/25566835 Review URL: https://codereview.chromium.org/1510973005 Cr-Commit-Position: refs/heads/master@{#364489}
-
mek authored
This reverts commit 772bb2e5. This CL still causes content_unittests failures. Please make sure they are fixed before relanding.... BUG=525142 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=kulshin@chromium.org Review URL: https://codereview.chromium.org/1514183002 Cr-Commit-Position: refs/heads/master@{#364488}
-
xlai authored
This CL adds a static variable in ImageBuffer that keeps track of global GPU memory usage, as well as a member variable for GPU memory usage in current ImageBuffer. These are useful metrics for accelerated canvases. By doing local experiments on Linux desktops and Android One, I put a conservative estimate on the maximum limit that this static variable can take before the UI responses on chrome becomes laggy. The estimate is equivalent to the allocated memory for 80 accelerated 2d canvases with 1000*500 size; the estimate for Android is a quarter of that. The GPU memory usage should be updated when ImageBuffer is created, destroyed or switching from accelerated mode to non- accelerated mode or vice versa. Unit Test CanvasRendering- Context2DTest.GPUMemoryUpdateForAcceleratedCanvas added. BUG=548209 Review URL: https://codereview.chromium.org/1482363004 Cr-Commit-Position: refs/heads/master@{#364487}
-
wangxianzhu authored
Review URL: https://codereview.chromium.org/1512803004 Cr-Commit-Position: refs/heads/master@{#364486}
-
zmo authored
BUG=568740 TEST=blink mac10.8/win7 bots TBR=dglazkov@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1516953002 Cr-Commit-Position: refs/heads/master@{#364485}
-
christiank authored
BUG=434699 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7d60ce9a132a88ead407a2a58c91edc431e68259 Cr-Commit-Position: refs/heads/master@{#364326} Review URL: https://codereview.chromium.org/1379783002 Cr-Commit-Position: refs/heads/master@{#364484}
-
mikecase authored
We use a hardcoded file to determine timeout scaling. Suppressing findbugs warning about using the hardcoded filename in the OnDeviceInstrumentationDriver class. BUG= TBR=nyquist@chromium.org Review URL: https://codereview.chromium.org/1510493013 Cr-Commit-Position: refs/heads/master@{#364483}
-
dtseng authored
This cl now makes a few more refinments: - explicitly sets the current range when significant tab events happen, but only if the tab (rootWebArea node) itself has focus. - checks to see that the aura view has focus before entering compat mode. TEST= 1. move to status tray (verify compat), press escape (verify classic) and that classic gets all key commands 2. open two tabs; switch between the two tabs and verify that classic commands still work. 3. switch to launcher (alt+shift+l); verify that compat commands work. Important because launcher sets only focused state (but not focusable state). 4. open a new window with multiple tabs and do the above steps. 5. open a new tab and verify you can type in the address bar and receive feedback. Important because this is an instance where we stay in compat but also receive a chrome.tabs event. The rootWebArea in thi caase has no focused state set. Review URL: https://codereview.chromium.org/1513933005 Cr-Commit-Position: refs/heads/master@{#364482}
-
maxbogue authored
Disabled via dashboard does not fall under CAN_START. BUG=555113 Review URL: https://codereview.chromium.org/1519593002 Cr-Commit-Position: refs/heads/master@{#364481}
-
jbroman authored
It has no uses (aside from its unit tests), and doesn't seem to have for several years. Review URL: https://codereview.chromium.org/1513833002 Cr-Commit-Position: refs/heads/master@{#364480}
-
lazyboy authored
Since the updated extension's SW doesn't call skipWaiting(), the old SW would control the updated extension page in the beginning. Once the extension page is closed, the new SW starts controlling subsequent pages. This follows the SW model: "the incumbent worker remains active until all pages controlled by it are closed." BUG=533065 Review URL: https://codereview.chromium.org/1510573003 Cr-Commit-Position: refs/heads/master@{#364479}
-
mmoroz authored
R=aizatsky@chromium.org, inferno@chromium.org, krasin@chromium.org BUG=566504 Review URL: https://codereview.chromium.org/1509163002 Cr-Commit-Position: refs/heads/master@{#364478}
-
prasadv authored
BUG=568661 Review URL: https://codereview.chromium.org/1509853007 Cr-Commit-Position: refs/heads/master@{#364477}
-
dgn authored
Some callbacks (from AsyncTasks, broadcasts reciever and other sources) are received on the Android UI thread but the code expects to run on the Chrome UI thread. BUG=568602 TBR=atwilson@chromium.org Review URL: https://codereview.chromium.org/1514903002 Cr-Commit-Position: refs/heads/master@{#364476}
-
dkrahn authored
The certificate format is now a PEM certificate chain. This code did not get updated and was still attempting to parse DER X.509. This change updates the code to parse PEM and auto-renewal of Enterprise Machine Certificates should work again. BUG=b:24618871 TEST=unit: now using fake expired certs in PEM format Review URL: https://codereview.chromium.org/1511793004 Cr-Commit-Position: refs/heads/master@{#364475}
-
maxbogue authored
GoogleAuthUtil has much better failure semantics, so this should clear up some of the runtime exceptions AccountManager.invalidateAuthToken() was producing. Since invalidateToken() now throws exceptions when things go wrong, this change isolates the network retry logic already existing in AccountManagerHelper and shares it between getToken and invalidateToken(). BUG=418809,535320 Review URL: https://codereview.chromium.org/1504283002 Cr-Commit-Position: refs/heads/master@{#364474}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/201efb5ae008..565901db954c $ git log 201efb5ae..565901db9 --date=short --no-merges --format='%ad %ae %s' 2015-12-10 scroggo Switch SkAutoMalloc to SkAutoTMalloc to avoid cast 2015-12-10 halcanary SkPixelSerializer: remove deprecated virtual 2015-12-10 joshualitt Move DistanceAdjustTable to its own file 2015-12-10 jvanverth Add Apple renderer strings to PowerVR detection 2015-12-10 halcanary SkDocument::setDCTEncoder() for old versions of webkit 2015-12-10 joshualitt Move appending of large glyphs into GrAtlasTextBlob 2015-12-10 scroggo Silence another PNG print statement CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=reed@google.com Review URL: https://codereview.chromium.org/1514153002 Cr-Commit-Position: refs/heads/master@{#364473}
-
slan authored
All device Chromecast builds should default to "cast" platform. Desktop builds will continue to use "headless" as default for now. BUG= Review URL: https://codereview.chromium.org/1519613002 Cr-Commit-Position: refs/heads/master@{#364472}
-