- 04 Jun, 2020 40 commits
-
-
Yi Gu authored
This test has been flaky since it was introduced. Probably due to the same issue as issue 1046784. TBR=yurys@chromium.org Bug: 1046784 Change-Id: I02b4e0c7c39c6123b1a6f0db70f1dacf6c7cbd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230913Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775229}
-
Fabian Sommer authored
Remove constness of the ExtensionHostObserver passed in OnExtensionHostDestroyed. This allows scoped observers to stop observing a host that is getting destroyed. Fixed: 1086475 Change-Id: I9abc696fe164f26b4927cd7366e1cd04570dbe43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216211Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#775228}
-
Clark DuVall authored
This implements popup blocking logic in WebLayer that matches chrome. To make this work, I needed to add a bit of functionality to open windows in other dispositions besides CURRENT_TAB. Bug: 1084013 Change-Id: I99df4b618a97f954347a1acdac844702053d1be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228365Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#775227}
-
Juanmi Huertas authored
There was a missing part of an if cause allowing passthrough to be tried as a Canvas Resource Provider. Re adding that check, and removing the expectation of the test to fail. This CL fixes as well https://buganizer.corp.google.com/issues/158138519 Bug: 1088023 Change-Id: Ic896d0d0b6cdbc72a0751daf0b2e629a0febdf18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230764Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#775226}
-
Peng Huang authored
Bug: None Change-Id: Ibb1568a17df7b7b2656f90888620c19a8e9e1ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231443Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#775225}
-
Eugene But authored
False is no longer supported configuration. Bug: 1017165 Change-Id: I67ec5b56afc2b2363c6013106bf4f4f0123e2114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228052Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#775224}
-
Sammie Quon authored
Early users were finding trying to align windows to the top of the display was sometimes difficult because maximize kept procing. Reduce the threshold to 8px. It's much smaller, but we anticipate people who want to use it will normally slam their mouses to the top of the screen. Test: manual Bug: 1091036 Change-Id: Id5c58f77d30fbc4b07d0cdba64e5fcbecbd3b0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229764Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#775223}
-
Jacques Newman authored
This implements the base class NGGridTrackCollectionBase and relevant tests. NGGridTrackCollectionBase provides an implementation for some shared functionality on track range collections, specifically binary search on the collection to get a range index given a track number. This change also adds NGGridTrackCollectionBase::RangeRepeatIterator, which iterates over ranges. There are 4 planned NGGridTrackCollections: 1. NGGridTrackRangeCollectionBase - Base class for shared functionality, layout-only, non-persistent. 2. NGGridElementTrackCollection - Defines the ranges needed due to specified tracks, layout-only, non-persistent. 3. NGGridAlgorithmTrackCollection - Used for sizing tracks in NGGridLayoutAlgorithm, layout-only, non-persistent. 4. Blink::Grid interface - Blink-wide interface used for accessing grid elements after layout, persistent. Link to Design Doc for LayoutNG CSS Grid: https://docs.google.com/document/d/1J2MunypRmbqPyHVLZjgN-xjNvYk77kPXyO3lhqj7OSI/edit?ts=5e949de9 There should be no behavioral changes associated with this CL. Bug: 1045599 Change-Id: Id9880fd2f1fb05e21e8642b0f4b766f9aaecad2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225835 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#775222}
-
Christopher Cameron authored
Change YouTube, GMail, and Google Drive (non-bookmark) apps to use RemoteCocoa. Do this just by inspecting their app id. These apps exist in a strange corner where they are not bookmark apps, but largely behave like bookmark apps. It's an open question if they should be multi-profile or not. In this patch I err on the side of caution and treat them as old-style non-multi-profile apps, because much of the multi-profile handling code is now PWA-only (post-BMO). In working on this, I found a bug wherein we assume when generating app shims, that any app that has a start URL is a bookmark or PWA app. This is not a valid assumption. Add a new field to web_app::ShortcutInfo to track if an app should be multi-profile, and populate it accordingly. There will be one bug here that I won't be able to fix without more effort and risk than it's worth. If someone created a multi-profile app shim for any non-PWA app that happened to have a valid URL, that shortcut will no longer "work" in that it will open the app in a new Chrome window instead of an app. Launching through chrome://apps will repair the situation. This is documented in crbug.com/1091318. R=dmurph TBR=rdevlin.cronin Bug: 1086824 Change-Id: Ibd829b07ed806c3e3c45b67075c5e25e368b9341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229663 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#775221}
-
phillis authored
The badging success/error windows metric looks stable and we can mark it as obsolete. Extend for MacOS to further investigate on no app shim host errors. Bug: 1089333, 1088645, 1088644 Change-Id: Ie5fe0bc219a9203079237124bc014056fd1b6721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229365Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
David Benjamin authored
Bug: 641225 Change-Id: Ifbe4f8c04e58ae4c9c6e9d357845740b735c2caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230906 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#775219}
-
Tommy Li authored
The has_selected_match_ member of OmniboxPopupModel seems redundant with the selection and the default match. This CL attempts to delete this extra bit of state. We want to do this, because I plan to do a lot of work on OmniboxPopupModel selection handling to support section headers properly, and it's easier if I clean this up first. There may be a slight behavior change but it's hard to quantify exactly: - With this CL, it seems that deleting the match often reduces the total number of suggestions. - Without this CL, we get more results from AutocompleteController to "fill in" and get to the maximum again. - But either of these things can occur, both WITH and WITHOUT the CL, it's not very consistent. It seems to sensitively depend on whether or not providers have "backup" matches that were outranked waiting on standby to be put in. - This CL makes the code call Stop() after deleting the match every time, where this didn't always happen before if the default match was selected. It's probably driving the change. - Overall the behavior change seems qualitatively to me to be slightly positive or neutral. But the code is a lot simpler this way. Bug: 1078183, 1052522 Change-Id: Icc6b0d95c31904125f8eeafc095e0bb1eca9accd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227169 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#775218}
-
Robbie McElrath authored
crrev.com/c/2171450 introduced a bug in Chrome's Site Settings UI that caused fallback favicons to not load. That CL used the iconUrl parameter of the onFaviconAvailable callback method to create the fallback favicon when a real one wasn't available, but that parameter actually stores the original url of the saved favicon, not the url of the page we're looking up a favicon for, so it was empty when one wasn't found. This CL makes the callback use the original url when generating the fallback favicon. Bug: 1077716 Change-Id: I5e9d047994f0ec71a83930e97d410636d9e3134e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226297Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#775217}
-
Etienne Pierre-doray authored
To let native unwinders add modules found from proc/maps. ModuleCache is able to find most modules on its own (thus StackSamplingProfilerTest can work without it), but this is necessary to support additional modules (e.g. compiled java). Bug: 1004855 Change-Id: I944cb094522169eef60906e1e5b3b9d77e689b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230775Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#775216}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/615880b58043..c461b6d69583 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yigu@google.com,tbansal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yigu@google.com,tbansal@google.com Change-Id: Ia953d4693e0a23ed799630652447650e8b7122c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231003Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775215}
-
Ken MacKay authored
Bug: internal b/156821522 Change-Id: I5f84f513eb299769800f98b8da313aad2ed26f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230183 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Auto-Submit: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775214}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/273da44ed986..7835859ea8de 2020-06-04 lalitm@google.com tp: rename SparseVector -> NullableVector 2020-06-04 fmayer@google.com Ingest heap graphs in a more streaming fashion. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:157210785 Tbr: perfetto-bugs@google.com Change-Id: I95b609d087ed896813533ffd64035d13dd467349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231025Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775213}
-
Omer Katz authored
Bug: 1079247 Change-Id: If021e8ff4ccf3f591794698396ef2bf636115ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231066 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#775212}
-
Matthias Körber authored
Change-Id: Ie055b7b2a4c09122cc6bae6caa778a8b4677f4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230489Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#775211}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591214254-6aa4e5b3c8cad7acd58b53b8c7cc7024959b4c99.profdata to chrome-mac-master-1591286362-102873a0b212b7d3d19b6bf651c7d4720fb0d502.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I566d73607dc716fd9e85ace8e2b75134606da856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231010Reviewed-by:
-
evliu authored
This CL adds a header that was missed in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2206918. Bug: 1091051 Change-Id: Ifa742b5197b4deba6873a0c90ac180478b91d9a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228061Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#775209}
-
Jonathan Backer authored
crbug.com/1061442 suggests that it is unwise to do a virtual context switch after the underlying context is lost. This CL prevents that. Bug: 1061442 Change-Id: I7143836d0591c2a7f0a291b66f60b4f46d84c5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231285Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#775208}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cabedcafaa77..0df92012a18e 2020-06-04 jmadill@chromium.org Rename Platform.h to PlatformMethods.h. 2020-06-04 nguyenmh@google.com Allow line formats to pass description body's line length check 2020-06-04 spang@chromium.org Re-enable ShouldClearOpaqueFdRGBA8 on Pixel2 Vulkan 2020-06-04 xiaoxuan.liu@arm.com Vulkan: Cleanup unused variable in submitFrame() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I70d277c0803c59555efdaca8956212483fa38fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231418Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/024d42fdd6bb..5a2a7b3096d0 2020-06-04 johnstiles@google.com Update GrClampFragmentProcessor to use a child FP. 2020-06-04 bungeman@google.com Regularize SkFontMgr for CoreText build. 2020-06-04 johnstiles@google.com Fix invalid code generation with @setData and 'in fragmentProcessor?'. 2020-06-04 herb@google.com Move addToAtlas to GrAtlasManager 2020-06-04 senorblanco@chromium.org Dawn: skip PromiseImageShutdownTest and TextureIdleProcTest. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I020be42684f35a4ed6a4f89d6f03c410fb088f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231024Reviewed-by:
-
Calder Kitagawa authored
This reverts commit 17ae1743. Reason for revert: MSAN failure https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878408074967908800/+/steps/components_unittests/0/logs/Deterministic_failure:PaintPreviewRecorderUtilsTest.TestSerializeAsSkPicture__status_CRASH/0 Original change's description: > [Paint Preview] Account for scroll offset in subframes > > Scroll position isn't accounted for in the clip rect for subframes. It > needs to be manually corrected via the tracker when serializing. > > Bug: 1090920 > Change-Id: I93e316016832132cbfdfec833249ed454c060b9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228577 > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775098} TBR=mahmoudi@chromium.org,ckitagawa@chromium.org Change-Id: I2b2e7f5ff847c95c0c329bea0a54dc11c3810310 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231262Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#775205}
-
gogerald authored
Screenshot: https://drive.google.com/file/d/11nP7UVbol-7HM50Pm0LBcP5Mlwt8qzRL/view?usp=sharing Bug: 1091041 Change-Id: I230f3e8be0fbb330dc23edc7782e61708ca74701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230766 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#775204}
-
Liquan (Max) Gu authored
This CL adds test coverage for the appearance of the Expandable Payment Handler UI and its user interaction. Changes: * Moved the original content of ExpandablePaymentHandlerTest.java into ExpandablePaymentHandlerCoordinatorTest.java (and change to small-test). * Added test cases in ExpandablePaymentHandlerTest.java. * Changed payment method from "/pay" to the "payment_method.json". This is because /pay was not pointing to a payment method manifest, so JIT installation was disabled. * merchant.html: given ids to the buttons so that the tests can simulate users' clicking on the buttons. Bug: 1042892, 1084705, 1084707, 1084708, 1084711, 1084721, 1068741 Change-Id: I4943932632cc446c75144bcdf7f9d9f9e06881be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227512Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#775203}
-
Ankit Kumar authored
This CL ensures that when focus is restored to PDF, we maintain the viewport and do not scroll even if the focused annotation is out of viewport. Bug: 1085614 Change-Id: Ifc4015b6d393dd1678d839a6636fbd4b335528ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224946Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#775202} -
Jonathan Ross authored
On Mac we are seeing FirstPaintAfterBackForwardCacheRestore flake. This disables the test on just Mac until the root cause can be addressed TBR=npm@chromium.org TEST=BackForwardCachePageLoadMetricsObserverBrowserTest.FirstPaintAfterBackForwardCacheRestore Bug: 1075936 Change-Id: Ia6ad11517e81edb9d3832468e8db4881eec7dd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231284Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#775201}
-
Swapnil authored
If the device is offline, we fail to download and install the extensions which are listed in ForceList policy. We only look in the cache if the manifest fetch was successful. If manifest fetch failed, then we report the failure. Here, we try to fetch the extension from cache in case we failed to fetch the manifest and try to install the extension. In case we received MANIFEST_FETCH_FAILED or MANIFEST_INVALID error, instead of reporting the failure, try fetching the extension from cache. For force installed extensions, In case of no internet connection: We don't retry fetching the manifest now, and try installing directly from the cache. If the extension is not present in the cache, we retry downloading with backoff delay. In other failures related to Manifest fetch like server shut down etc., we make retry attempts and then in case of failure try installing it from the cache. A new histogram is added: Extensions.ForceInstalledCacheStatus : It reports the cache status for force installed extensions whenever a CRX file is looked up in the cache. It reports the cache status irrespective of whether the extension failed to install or installed successfully. Bug: 1051870 Change-Id: Iab8d95a7ffbf144ae415686b6a80d501a19823e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054244 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
I forgot to remove the %m part in https://chromium-review.googlesource.com/c/chromium/src/+/2229010 Change-Id: Ica40d2f9787e400967155f55749cd2d5b789127c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231260 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#775199}
-
Devlin Cronin authored
Stop recording Extensions.UnpackFailureInstallSource and Extensions.UnpackSuccessInstallSource. Bug: 1072516 Change-Id: I47c3e62752187a228eeb09a4f0782b3ae075fd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229427 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#775198}
-
Dave Tapuska authored
With the future removal of the content::Widget mojom interface we need to ensure that the blink Widget/FrameWidget interfaces are correctly initialized for tests. BUG=1073560 Change-Id: Id960f8c450ff9485d36b81504a4d96da3f4f14b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230839Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#775197}
-
Kent Tamura authored
- If a ruby base box has only zero-width lines, we should not allow overhang. - If a ruby base box didn't provide baseline, the corresponding ruby text box should provide it. These behaviors are compatible with the legacy layout. This fixes five failing tests. Bug: 1069817 Change-Id: Ibe42f27cf2a60b07e39f6fb979f177e3d08cb6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230141Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#775196}
-
danakj authored
chrome.gpuBenchmarking.pointerActionSequence() has synchronization problems, as the hit testing is done against compositor submissions but the gpuBenchmarking methods do not cause or wait for compositing to occur. So tests must explicitly do this themselves to avoid flaky behaviour. The webaudio-autoplay-iframe-with-gesture.html test on its own works fine, somehow. But the compositing of the iframe fails to beat the gpuBenchmarking synthetic events if it runs after the document-user-activation-cross-origin-feature-policy-header.html test which also involves gpuBenchmarking synthetic events. This adds waits in the test's js code to make up for the gpuBenchmarking harness being flaky. R=yigu@chromium.org Bug: 872952, 1091299 Change-Id: I6c4cb1ffc51286584ef9c7079bfff8677da1e1a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230768 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
David Black authored
These methods are unused and were missed during earlier clean up. Bug: b:157237955 Change-Id: Ia3f45af1f206cf817544705af4500ebcf77cf74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226916 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#775194}
-
Behnood Momenzadeh authored
This CL will add a flag to enable suggesting navigations based on lookalikes. Lookalikes are currently used to detect spoofs, but it could be utilized to suggest navigations to users who might have typos in their navigation URL. Bug: 1076154 Change-Id: I4daf8061a3b52db970588f8a16b7fa9d19e38628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228985Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Cr-Commit-Position: refs/heads/master@{#775193}
-
Charlene Yan authored
Move from BrowserTabStripController into TabStripModel so it can be used by both BrowserTabStripController and TabStripModelOrderController. Update TabStripModelOrderController::DetermineInsertionIndex to take into account collapsed groups. Also rename variable from tabstrip_ to model_ inside order controller. Bug: 1018230 Change-Id: I26cf677bde4c68b91909f8f4d6f2e564e15bca92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219018 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#775192}
-
Juanmi Huertas authored
Fixing comments inside webgl::getImageData about the CPU fallback and about the usage of CopyRenderingResultsFromDrawingBuffer regarding that method not failing because the resource was always expected to be accelerated (GPU). Leaving a bug open (to track the issue with removing the CPU fallback) as some investigation may be needed whether it really makes sense to have that CPU fallback. Bug: 1090962, 1035589 Change-Id: Id50a18511e7966a860f46fa7d2e40a57e3269dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229156 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Auto-Submit: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#775191}
-
Zach Trudo authored
StorageModule and EncryptionModule are needed in the reporting client interface. TestStorageModule and TestEncryptionModule are needed in the reporting client tests. Bug: chromium:1078512 Change-Id: Ic96ce4b9a85724f7dee20f4576e54383d6bc3330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228984 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
-
