GitLab

BUG=408986

Review URL: https://codereview.chromium.org/554043002

Cr-Commit-Position: refs/heads/master@{#293831}

BUG=410931
TEST=testSmoothness passes

Review URL: https://codereview.chromium.org/547423002

Cr-Commit-Position: refs/heads/master@{#293830}

BUG=none

Review URL: https://codereview.chromium.org/551783003

Cr-Commit-Position: refs/heads/master@{#293829}

This CL removes most of guava, except a few classes and annotations.

Also updates the rest of Chrome to ensure only those classes are in use.

Thirdly, it adds an OWNERS file to third_party/guava.

BUG=163393
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/546973003

Cr-Commit-Position: refs/heads/master@{#293828}

BUG=397741

Review URL: https://codereview.chromium.org/542363002

Cr-Commit-Position: refs/heads/master@{#293827}

BUG=none
TBR=rjkroege

Review URL: https://codereview.chromium.org/549383002

Cr-Commit-Position: refs/heads/master@{#293826}

Revert of [GCM] Adding GCMAccountMapper tests (patchset #2 id:20001 of https://codereview.chromium.org/544363002/)

Reason for revert:
GCMAccountMapperTest.MultipleAccountMappings is failing on Win7 Debug.

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/30987

Original issue's description:
> [GCM] Adding GCMAccountMapper tests
>
> 1) When the status is ADDING (adding message is sent), the token is refreshed.
> 2) When the status is REMOVING (removing message is sent), the token is added
> again.
> 3) updating multiple account mappings
>
> BUG=374969
> R=jianli@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/a15249de25304c0d2173029bc22b2f136adac537

TBR=jianli@chromium.org,fgorski@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=374969

Review URL: https://codereview.chromium.org/554153003

Cr-Commit-Position: refs/heads/master@{#293825}

We were trying to unregister the HistoryDeleteDirective DTC at shutdown, but
the DTC shutdown happens as part of the ProfileSyncService shutdown, and is
destroyed after the observers_ object is destroyed. As such, there's no need
to remove the observer.

This patch also unreverts 6513171d
Original codereview at https://codereview.chromium.org/534733002

BUG=409965 368834

Review URL: https://codereview.chromium.org/535683002

Cr-Commit-Position: refs/heads/master@{#293824}

BUG=

Review URL: https://codereview.chromium.org/551903002

Cr-Commit-Position: refs/heads/master@{#293823}

under certain circumstances, when resuming a request.

BUG=411228

Review URL: https://codereview.chromium.org/545353002

Cr-Commit-Position: refs/heads/master@{#293822}

The tests ensures extensions do not access filesystem:file:///* URL.

BUG=367027
TEST=the new tests

Review URL: https://codereview.chromium.org/544483003

Cr-Commit-Position: refs/heads/master@{#293821}

BUG=374321
NOTRY=true

Review URL: https://codereview.chromium.org/552703002

Cr-Commit-Position: refs/heads/master@{#293820}

Main message and sub message direction of the validation message can differ. Pass direction of the subMsg to allow text display accordingly.

BUG=91638
R=jam, jamesr

Review URL: https://codereview.chromium.org/391923006

Cr-Commit-Position: refs/heads/master@{#293819}

Added an extra "effective extension" property to ScriptContext for this to still work correctly in about:blank iframes inside extension pages.

BUG=395376

Review URL: https://codereview.chromium.org/498513002

Cr-Commit-Position: refs/heads/master@{#293818}

Disable TwoClientBookmarksSyncTest.SC_MovingBMsFromBMBarToBMFolder and TwoClientBookmarksSyncTest.SC_MovingBMsFromBMFoldToBMBar since they flake on Windows.

BUG=412169
TBR=rsimha@chromium.org

Review URL: https://codereview.chromium.org/552093003

Cr-Commit-Position: refs/heads/master@{#293817}

This CL does the following:
* Eliminates auto connect glue code
* Elim SetManaged* helpers
* Converts StaticIPConfig, SavedIPConfig, and WebProxyAutoDiscoveryUrl
  properties from Shill to ONC
* Uses ManagedNetworkConfigurationHandler::GetManagedProperties in
  internet_options_handler.cc to get (almost) all properites. The
  remaining properties will require additional translation and/or design

BUG=279351

Review URL: https://codereview.chromium.org/509643003

Cr-Commit-Position: refs/heads/master@{#293816}

It was an experimental feature that is no longer being actively developed.

BUG=NONE

Review URL: https://codereview.chromium.org/523233002

Cr-Commit-Position: refs/heads/master@{#293815}

BUG=358271
TEST=EME browser tests pass

Review URL: https://codereview.chromium.org/550933003

Cr-Commit-Position: refs/heads/master@{#293814}

This saves about 6 idle wakeups on the top_10 idle energy benchmark. It can save up to 1/second in the general case.

BUG=411488

Review URL: https://codereview.chromium.org/542353002

Cr-Commit-Position: refs/heads/master@{#293813}

cespy.dll is a LSP and preventing it from loading in Chrome prevents
users from accessing the internet.

BUG=399968

Review URL: https://codereview.chromium.org/545003006

Cr-Commit-Position: refs/heads/master@{#293812}

BUG=397741

Review URL: https://codereview.chromium.org/535073005

Cr-Commit-Position: refs/heads/master@{#293811}

Change the divider between the popup header and the options page content
from a box-shadow to a bottom-border, as suggested in UI review.

BUG=411995

Review URL: https://codereview.chromium.org/546033002

Cr-Commit-Position: refs/heads/master@{#293810}

This makes templates behave like values when merging and duplicates are found.
If the values are the same, allow them to collide. This happens when importing
if multiple files import the same .gni file.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/547063004

Cr-Commit-Position: refs/heads/master@{#293809}

This updates the targets that depend on these to also be test-only.

BUG=http://crbug.com/412064
R=jamesr@chromium.org, tfarina@chromium.org

Review URL: https://codereview.chromium.org/551933002

Cr-Commit-Position: refs/heads/master@{#293808}

The bounding boxes of show press and tap gesture are the same right now,
which are based on the touch start location and the largest radius seen
before the show press gesture is sent.

BUG=403747

Review URL: https://codereview.chromium.org/538653002

Cr-Commit-Position: refs/heads/master@{#293807}

libjingle: Removes all references to talk/sound. The current reference comes from cl 153321 where it was added under the flag enabled_libjingle_device_manager which is by default set to 0. The comment in that cl says it is to enable using this gyp file in the standalone build. This means that the code was never intended to be built for Chromium.

Since that cl was committed the approach has changed. We are now creating new gyp files in the standalone build, containing parts of libjingle and phasing out libjingle.gyp one piece at a time.

The files removed in this cl are part of (../webrtc's) sound.gyp which is not (and will not be) built in Chromium. The reason it is in webrtc is that libjingle and webrtc are being merged into one project.

BUG=https://code.google.com/p/webrtc/issues/detail?id=3379

Review URL: https://codereview.chromium.org/532293002

Cr-Commit-Position: refs/heads/master@{#293806}

so that the same implementation can be used with Aura+Ozone on Linux.

Review URL: https://codereview.chromium.org/490693003

Cr-Commit-Position: refs/heads/master@{#293805}

If there's a single user in chrome://settings, you can navigate to
chrome://settings/manageProfile to edit it (even though the UI doesn't
always let you). In this case, however, we shouldn't display the add/remove
desktop shortcut button in the manageProfile overlay (since the shortcut for
single users is a non-profile generic Chrome shortcut)

BUG=409735
TEST=Start Chrome. Ensure you only have one profile.
Go to chrome://settings/manageProfile. There shouldn't be an add/remove
shortcut button.

Review URL: https://codereview.chromium.org/542843002

Cr-Commit-Position: refs/heads/master@{#293804}

BUG=none

Review URL: https://codereview.chromium.org/545303002

Cr-Commit-Position: refs/heads/master@{#293803}

App Store rules appear to be moving toward enforcing the format of
CFBundleVerison on iOS, so this allows setting a custom plist key to
store the full Chrome version instead.

BUG=411302

Review URL: https://codereview.chromium.org/542223002

Cr-Commit-Position: refs/heads/master@{#293802}

Also moved some generic TypeConverters to a separate file.

BUG=403930

Review URL: https://codereview.chromium.org/540683002

Cr-Commit-Position: refs/heads/master@{#293801}

Currently, destroying a PDFiumPage triggers an Unload() which can result
in an access to other PDFiumPages. But these other pages may already have
been destroyed as a previous element via STLDeleteElements(&pages_).

Instead, unload all pages first, then destroy them all afterwards so that
no access to other pages will be attempted after the destruction of the
first one has begun.

Move the STLDeleteElements() call to the bottom, to make it more closely
mimic the ordering that might occur should pages_ someday be switched
from vector to ScopedPtrVector or similar.

BUG=384365

Review URL: https://codereview.chromium.org/544873002

Cr-Commit-Position: refs/heads/master@{#293800}

BUG=411360

Review URL: https://codereview.chromium.org/550503002

Cr-Commit-Position: refs/heads/master@{#293799}

This should address issues we are seeing with flickering content.

BUG=408849

Review URL: https://codereview.chromium.org/547823003

Cr-Commit-Position: refs/heads/master@{#293798}

In RootView::DispatchGestureEvent(), use Event::Clone()
to copy gesture events prior to processing and perform
coordinate conversion of the events during targeting but
before dispatch (so the location of the gesture event
is in the coordinate space of the target).

In preparation for removing
RootView::DispatchGestureEvent(), also make the
corresponding changes to
EventProcessor::OnEventFromSource(). These changes
are necessary to ensure that located events will
be dispatched with their locations in the correct
coordinate space in all situations (in particular,
when an event is bubbling during an invocation of
nested event-processing).

BUG=411487
TEST=WidgetTest.GestureEventLocationWhileBubbling,
     ViewTargeterTest.GestureEventCoordinateConversion,
     modified ViewTargeterTest.ViewTargeterForGestureEvents

Review URL: https://codereview.chromium.org/542323002

Cr-Commit-Position: refs/heads/master@{#293797}

BUG=396645

Review URL: https://codereview.chromium.org/557433002

Cr-Commit-Position: refs/heads/master@{#293796}

https://chromium.googlesource.com/chromium/blink/+log/86ce4af33b763b24cf2365d8cd19a2ebade676c3..09bd97099a92cf983363f8db6c6c2178b0cd7c6a
TBR=arv@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/557443002

Cr-Commit-Position: refs/heads/master@{#293795}

BUG=412086
TBR=lfg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/552013002

Cr-Commit-Position: refs/heads/master@{#293794}

This CL introduces util_unittest.cc, which acts as a place for current and
future functions in util.h.

BUG=411108

Review URL: https://codereview.chromium.org/552433002

Cr-Commit-Position: refs/heads/master@{#293793}

Speculative, to see if it helps with

==12563== WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7f834414fd2c in views::DesktopWindowTreeHostX11::InitX11Window(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1164
    #1 0x7f834414dc6e in views::DesktopWindowTreeHostX11::Init(aura::Window*, views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:259
    #2 0x7f83441408e9 in views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&) ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:420
    #3 0x7f834411722f in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:358
    #4 0x7f834473bc8b in ChromeNativeAppWindowViews::InitializeDefaultWindow(extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:231
    #5 0x7f834473f52d in ChromeNativeAppWindowViews::InitializeWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:672
    #6 0x7f834c3d8bbe in apps::NativeAppWindowViews::Init(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) apps/ui/views/native_app_window_views.cc:46
    #7 0x7f834460443c in ChromeAppsClient::CreateNativeAppWindowImpl(extensions::AppWindow*, extensions::AppWindow::CreateParams const&) chrome/browser/ui/views/apps/chrome_apps_client_views.cc:14
    #8 0x7f834be98433 in extensions::AppWindow::Init(GURL const&, extensions::AppWindowContents*, extensions::AppWindow::CreateParams const&) extensions/browser/app_window/app_window.cc:281
    #9 0x7f834bd6bbfb in extensions::AppWindowCreateFunction::RunAsync() extensions/browser/api/app_window/app_window_api.cc:296 #10 0x7f834bee4510 in AsyncExtensionFunction::Run() extensions/browser/extension_function.cc:452
    #11 0x7f834bee9771 in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*, content::RenderFrameHost*, base::Callback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) extensions/browser/extension_function_dispatcher.cc:392
    #12 0x7f834bee86b6 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderViewHost*) extensions/browser/extension_function_dispatcher.cc:309
    #13 0x7f834bedac91 in OnRequest extensions/browser/extension_host.cc:342
    #14 0x7f8345add9d2 in content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) content/browser/web_contents/web_contents_impl.cc:526
    #15 0x7f83459847fe in content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_view_host_impl.cc:894

Started happening here
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/98
(see stdio for symbols), and this looks like the only change in that
build.

This reverts commit c76ef732.

BUG=384644
TBR=jackhou@chromium.org

Review URL: https://codereview.chromium.org/550413002

Cr-Commit-Position: refs/heads/master@{#293792}