- 29 Nov, 2018 40 commits
-
-
Matthew Jones authored
This patch adds the plumbing and integration for using the feature highlight api to show in product help for duet instead of the previous pointer bubble. The new IPH follows the same triggering rules and brings focus to the search accelerator. Tapping outside the highlight or on the search accelerator will dismiss the IPH, otherwise it will dismiss after 6 seconds. A complementary internal patch will add the actual feature highlight functionality. Bug: 907617 Change-Id: I8e12f87954aae146b592618333620c1eb76995b0 Reviewed-on: https://chromium-review.googlesource.com/c/1347569Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#612286}
-
Dan Harrington authored
Previously, if an article was already in the prefetch database, its priority was left unchanged when a new list of suggestions is received. Now its priority is updated to conform to the list order given by the suggestion source. Bug: 841516 Change-Id: I38ed8ae9f5024095af14496e7274afa09c2ceff1 Reviewed-on: https://chromium-review.googlesource.com/c/1345238 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#612285}
-
Chris Mumford authored
Just a few spelling mistakes and incorrect parameter names. TBR=xiyuan@chromium.org Bug: none Change-Id: Iee5c1170aa96626ebc46d75c224f024479eee7b2 Reviewed-on: https://chromium-review.googlesource.com/c/1355428Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#612284}
-
sebsg authored
Tbr: sdefresne@chromium.org Bug: 910216 Change-Id: I6cdfe95d6c9202d14fc681fecded9ff2ce2bbdb2 Reviewed-on: https://chromium-review.googlesource.com/c/1355599Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612283}
-
erikchen authored
The script now passes the argument through to the test suite. This allows the default value of 3 to be overridden. Bug: 910027 Change-Id: If9bd23756262a84443c097aeafa011e05e84f876 Reviewed-on: https://chromium-review.googlesource.com/c/1354274 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#612282}
-
Jonathan Metzman authored
We want to eventually switch most libFuzzer builds to component builds in order to save the space. The Chrome OS one is a good build to test component builds with since it isn't running already. Bug: 701825 Change-Id: I43bf889e20ef54c51a5bbce1e9976ff1636fe3fb Reviewed-on: https://chromium-review.googlesource.com/c/1355329Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612281}
-
Javier Ernesto Flores Robles authored
Makes explicit when the custom keyboard views are paused. Nils last suggestions on reset. Removes the accessory view from non web urls. Organizes code in the the form activity handler. Stops using |lastSuggestions| to gate view controller updates, |[pause / continue]CustomViewController| is used instead. Bug: 845472 Change-Id: I751015f9bd2b7b085c15a10fd41fd949dc1fa672 Reviewed-on: https://chromium-review.googlesource.com/c/1355179Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#612280}
-
Eugene But authored
Use enumeration statistic type and no index fields. Bug: 1182320 Change-Id: If45573cd4572fd9ed634710a026ac898e001a0cf Reviewed-on: https://chromium-review.googlesource.com/c/1354329Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612279}
-
Yusuke Sato authored
BUG=b:118408409 TEST=try Change-Id: Id4eab57052f4221d5150e68294f54a22821f22df Reviewed-on: https://chromium-review.googlesource.com/c/1354400Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#612278}
-
Becky Zhou authored
Bug: 907282 Change-Id: I239dfb4ed667e6584bd598f7221003271ee7185b Reviewed-on: https://chromium-review.googlesource.com/c/1347270Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#612277}
-
Mounir Lamouri authored
This reverts commit 4fd1b68c. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Sheriff] Disable document-user-activation.html on Linux. > > It's flaky. > > Tbr: tkent@chromium.org > Bug: 910211 > Change-Id: I66a8cf70781d906fd97fda1a22f9d5050b273613 > Reviewed-on: https://chromium-review.googlesource.com/c/1355487 > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612255} TBR=sebsg@chromium.org Change-Id: I9f41384c2a4b9dce100eecf1603f33a9f7ca6bbf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910211 Reviewed-on: https://chromium-review.googlesource.com/c/1355431Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#612276}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/813bfbd06112..df72914a60d5 git log 813bfbd06112..df72914a60d5 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 cwallez@chromium.org Result: Add default template for Result<T, E> Created with: gclient setdep -r src/third_party/dawn@df72914a60d5 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I5f9f01249f952b88c7cb97f491920306183d7a21 Reviewed-on: https://chromium-review.googlesource.com/c/1355361Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612275}
-
Wei Li authored
AddFirstRunTab, WelcomePages, and WelcomePagesWithPolicy are disabled due to they failed constantly on Mac. After repeated tests, they seem working fine so re-enable them now. BUG=691707 Change-Id: I34e5a191094a488111151a0bccf949b30f26fad7 Reviewed-on: https://chromium-review.googlesource.com/c/1353989Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#612274}
-
sebsg authored
It's flaky there are well. Disabled the test altogether for now. Tbr: jonross@chromium.org Bug: 910213 Change-Id: Ifbd34680ae3896a5cd9ff99a4791ccc2f8e12289 Reviewed-on: https://chromium-review.googlesource.com/c/1355494Reviewed-by:
-
Mounir Lamouri authored
Bug: 910211 Change-Id: I32512c338b59e5474a89b32172e2089f96467598 TBR: sebsg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1355491Reviewed-by:
-
Eric Roman authored
Bug: 903948 Change-Id: Ida8e955b212f26c9938a43cb196d9f90aac3404b Reviewed-on: https://chromium-review.googlesource.com/c/1351098 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#612271}
-
Dmitry Gozman authored
This patch makes CommitFailedNavigation not use LoadNavigationErrorPage, which is left for loading renderer-initiated error pages. That allows us to simplify LoadNavigationErrorPage and unify all three renderer-initiated calls. Bug: 855189 Change-Id: Ic56fe7b63376e0c4d92d4fb38b87e9d20aae85a5 Reviewed-on: https://chromium-review.googlesource.com/c/1338919Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612270}
-
Becca Hughes authored
This is a reland of 93ee1837 This includes a fix to //ash:ash_unittests which was throwing a linker error which resulted in the original being reverted. Original change's description: > [Media Session] [1/4] Move MediaMetadata to service > > This CL moves the MediaMetadata and MediaImage mojo types > from Blink to the Media Session service along with their > mapped types in content. > > This is the first of four parts. > > BUG=875004 > > Change-Id: Ie862229bbeb474a60ccc4d2f82d8c4e1f8017b74 > Reviewed-on: https://chromium-review.googlesource.com/c/1227401 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605481} Bug: 875004 Change-Id: Id04143a89594a523f323ac16a54d93f1f2447367 Reviewed-on: https://chromium-review.googlesource.com/c/1318802Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#612269}
-
khmel@chromium.org authored
This prevents removing runtime apps on package change event. This fixes the issue when running Andorod Instant apps are closed on package update. They appear in ARC as runtime app. TEST=Manually, unit_test BUG=b/119671931 Change-Id: Ife214bafb11a7b86c2b8fa86eea9824f1bc6e6d6 Reviewed-on: https://chromium-review.googlesource.com/c/1354686 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612268}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I984e218d26ca92c1f531fbec9267a0de56ea0c57 Reviewed-on: https://chromium-review.googlesource.com/c/1352422Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#612267}
-
Tatiana Buldina authored
Bug: chromedriver:1997 Change-Id: Ic231f01e68cc141877d501b5aee6926bc48ac1ee Reviewed-on: https://chromium-review.googlesource.com/c/1355172Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#612266}
-
Oleh Prypin authored
Otherwise they're hitting an old Mac version and can't find xcode Change-Id: Ie959d5fa958001822cace2160fb6c45516b8f602 Reviewed-on: https://chromium-review.googlesource.com/c/1355131Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612265}
-
Stephane Zermatten authored
This change replaces base::Unretained with a weak ptr everywhere where there's possible a doubt that something could go wrong. In particular, it uses weak ptrs for the try_done and all_done callbacks of batch element checkers, since they can be called after the checker has been deleted, even if it's unlikely. This change also moves the script tracker in the Controller to make it the last owned type to be deleted, as the script tracker will access everything that exists in the controller, through actions. It's best to delete it first. Finally, this change adds null checks for ui_delegate_ in android_ui_controller.cc, as the controller can delete itself separate from any UI decisions. In this case, it sets ui_delegate_ to null. Bug: 806868 Change-Id: Ie2e11ea54a1bdf80c4bc80d79a158a1658bc0d1b Reviewed-on: https://chromium-review.googlesource.com/c/1353942 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#612264}
-
Yi Su authored
This CL adds a validity check for FaviconDriver::GetActiveURL(). GetActiveURL() depends on GetLastCommittedItem, and can be nil at various times -- such as during session restore on startup. Bug: 908240 Change-Id: I32bcf8e93b862fd87ae22bce6c59cbb9c4ba2f5d Reviewed-on: https://chromium-review.googlesource.com/c/1350873Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612263}
-
Andrew Grieve authored
I've made this mistake a couple of times :( Without a check, it writes single-letter files to the depfile. Change-Id: I0cf315573d2ed92b6b23fcf095e7396980d8d03d Reviewed-on: https://chromium-review.googlesource.com/c/1355324Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612262}
-
Lucas Furukawa Gadani authored
Bug: 908139 Change-Id: I678dc64c18e78392493c2fc3acba974b3b6a28f8 Reviewed-on: https://chromium-review.googlesource.com/c/1349466Reviewed-by:
-
Jonathan Metzman authored
Bug: 904877 Change-Id: I303d40cd19cc0dcfbdf3606bcaa357adb4793edd Reviewed-on: https://chromium-review.googlesource.com/c/1347579 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#612260}
-
Boris Sazonov authored
This CL removes unused Context field from SigninTestUtil, fixes usages and also replaces a couple of anonymous classes with lambdas. Bug: 738533 Change-Id: Ia47262016a7aa7d5bc7a682a949518613760cf8a Reviewed-on: https://chromium-review.googlesource.com/c/1352319Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:2909 BUG=angleproject:2901 BUG=angleproject:2913 BUG=angleproject:2918 BUG=angleproject:2708 BUG=angleproject:2987 TBR=kbr@chromium.org Change-Id: I4ac05d075a420f5a011c5b7ea056477a25a4c95c Reviewed-on: https://chromium-review.googlesource.com/c/1351602Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612258}
-
Clemens Arbesser authored
Bug: 806868 Change-Id: Iba3d0a38f1d215880b3479a5c1baa2d3d4d97b24 Reviewed-on: https://chromium-review.googlesource.com/c/1355164Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#612257}
-
Becca Hughes authored
This test was marked as flaky, but it has not failed in a while so we should try and re-enable it. BUG=874500 Change-Id: I7564d54a82af721a72fb4e1b2fb836415edd5c07 Reviewed-on: https://chromium-review.googlesource.com/c/1354620Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#612256}
-
sebsg authored
It's flaky. Tbr: tkent@chromium.org Bug: 910211 Change-Id: I66a8cf70781d906fd97fda1a22f9d5050b273613 Reviewed-on: https://chromium-review.googlesource.com/c/1355487Reviewed-by:
-
Uladzimir Miniailau authored
Bug: 898109 Change-Id: If15a8ea69c7fd77e084b5766ea23afb6a4f1224e Reviewed-on: https://chromium-review.googlesource.com/c/1354921 Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#612254}
-
danakj authored
This is a reland of eacb6ed3 The flaky test has been disabled. TBR=piman Original change's description: > Reland "Start gpu channel and compositor mojo pipe collection eagerly" > > This is a reland of 66794d00 > > In this reland we revert changes to RenderThreadImpl and mus to make > LayerTreeFrameSink creation asynchronous again. > > Then in RenderWidget we must remember that a warmup is underway, we do > so with a bool and a WeakPtrFactory. If it is aborted, we reset the bool > and invalidate the WeakPtrFactory. > > If a request for a frame sink beats the warmup completing, we save > the callback and run that instead of saving the frame sink on > RenderWidget when the warmup completes. > > This ignores some weird weird corner cases like where warmup is > aborted then we start another warmup or unfreeze the widget or something > and will just make redundant requests. Since these are so rare they > are not worth adding complexity for. > > Original change's description: > > Start gpu channel and compositor mojo pipe collection eagerly > > > > When a RenderWidget is frozen, its compositor is stopped. However when > > the main frame is being navigated, we want to start requesting mojo > > pipes for the gpu and display compositor immediately so that it can > > happen in parallel with the navigation loading. > > > > Previously, we just always did this when creating a RenderWidget, and > > left them active when freezing the RenderWidget. After 678f025f > > however, we don't, and this causes time-to-first-pixels regressions > > on navigation. > > > > So we add a WarmupCompositor() method to RenderWidget, and call this > > from RenderFrameImpl::CreateFrame() when it makes the provisional > > frame, and the WebFrameWidget, since we expect to make use of the > > main frame RenderWidget shortly. > > > > Then, if RenderFrameImpl::FrameDetached() occurs, due to the > > navigation failing, we will AbortWarmupCompositor() to drop the > > mojo pipes instead of holding onto them indefinitely. > > > > This recovers the loading regressions introduced, while also not > > allocating mojo channels for frozen RenderWidgets indefinitely. > > > > In order to do this reasonably, we drop the "callback" from the > > request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that > > it always returns something immediately. This way RenderWidget > > does not need to worry about having a task run to collect the > > new frame sink, and ordering with tasks from the compositor to > > collect it. > > > > R=piman@chromium.org > > > > Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0 > > Bug: 905191 > > Reviewed-on: https://chromium-review.googlesource.com/c/1341073 > > Commit-Queue: danakj <danakj@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#610909} > > Bug: 905191 > Change-Id: I6cb65e08a832a969156b96bece0f2e12eccd5b60 > Reviewed-on: https://chromium-review.googlesource.com/c/1351938 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611838} Bug: 905191 Change-Id: I0320c8604d50d5d83157c058c230b471c0898b26 Reviewed-on: https://chromium-review.googlesource.com/c/1355321Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#612253}
-
Brian Osman authored
This disables an "optimization" in Skia that appears to actually cause a performance regression. After looking, that optimization is probably unnecessary, and will probably be removed. To facilitate that, this CL switches it off so we can rebaseline the affected layout tests. Effectively reverts: https://chromium-review.googlesource.com/c/chromium/src/+/1334230 Bug: chromium:908566 Change-Id: I634814dabaed09b7f93390f7f4d5fba499317185 Reviewed-on: https://chromium-review.googlesource.com/c/1351761Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#612252}
-
Sebastien Seguin-Gagnon authored
This reverts commit eabc228b. Reason for revert: May have caused a compile error that closed the tree: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/2197 Original change's description: > Fix DownloadManagerTestCase flakiness. > > On iOS 12 URLSession:dataTask:didReceiveData: delegate method can be > called when task is in NSURLSessionTaskStateCompleted state. This > resulted in extra URLFetcherResponseWriter::Finish call (one from > didReceiveData: and one from didCompleteWithError:). > URLFetcherResponseWriter::Finish DCHECKs if Finish is called twice, so > the test was flaky. > > This CL changes DownloadTaskImpl to only call > URLFetcherResponseWriter::Finish from didCompleteWithError:. > > Bug: 873204 > Change-Id: Ie6b8757e2c5c5d35da088fd108d92ee3ed13244d > Reviewed-on: https://chromium-review.googlesource.com/c/1354233 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612249} TBR=sdefresne@chromium.org,eugenebut@chromium.org Change-Id: I1f7e7620911c73ce1f497fb6ae7b09ed16a2547f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873204 Reviewed-on: https://chromium-review.googlesource.com/c/1355600Reviewed-by:
-
Benoît Lizé authored
v8::string::ExternalStringResourceBase -> StringResource{8,16} cast is undefined behavior, as there is now ParkableStringResource{8,16} and StringResource{8,16}. Add a common ancestor to these two classes, and cast to it to avoid UB. Bug: 909796 Change-Id: I94c65e03f283ca3c9fee344743e3f607686d2846 Reviewed-on: https://chromium-review.googlesource.com/c/1355046 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612250}
-
Eugene But authored
On iOS 12 URLSession:dataTask:didReceiveData: delegate method can be called when task is in NSURLSessionTaskStateCompleted state. This resulted in extra URLFetcherResponseWriter::Finish call (one from didReceiveData: and one from didCompleteWithError:). URLFetcherResponseWriter::Finish DCHECKs if Finish is called twice, so the test was flaky. This CL changes DownloadTaskImpl to only call URLFetcherResponseWriter::Finish from didCompleteWithError:. Bug: 873204 Change-Id: Ie6b8757e2c5c5d35da088fd108d92ee3ed13244d Reviewed-on: https://chromium-review.googlesource.com/c/1354233Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612249}
-
Jonathan Metzman authored
TBR=inferno@chromium.org Change-Id: I2bc6f5c7e165bba9bb4a0e02ca6535128cb59766 Reviewed-on: https://chromium-review.googlesource.com/c/1355481Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612248}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73b3bde2659f..f38fffb7aa2f Created with: gclient setdep -r src-internal@f38fffb7aa2f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:906654 TBR=mmoss@chromium.org Change-Id: I781599f8fc3ee65a6151606e25b935421aaeb03f Reviewed-on: https://chromium-review.googlesource.com/c/1355360Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612247}
-
