- 30 Mar, 2018 13 commits
-
-
Stephen Martinis authored
This won't block CQ, but will let us see if a potential fix works. Bug: 826735 Change-Id: I23c8e9a7b1df04206313df3fdbec58d733d17f7f Reviewed-on: https://chromium-review.googlesource.com/986947Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#547042}
-
Hiroki Nakagawa authored
As a preparation for enabling to establish WebSocket connections off the main thread, this CL reduces dependencies on Document in DocumentWebSocketChannel for making it thread-safe. This CL depends on: https://chromium-review.googlesource.com/c/chromium/src/+/984754 Bug: 825740 Change-Id: I023bb8343415adbf45e99e74218ef70d9b35bf6a Reviewed-on: https://chromium-review.googlesource.com/985812 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#547041}
-
Weidong Guo authored
Background: The app list goes back when it loses focus or VKEY_BROWSER_BACK is received. Tapping on the back button on shelf will triggers back actions twice. Change: Prevent handling in AppListPresenterDelegate when the back button is clicked. BUG=819668 Change-Id: I8e11e479cbcbe8bf917006cdf8f4ebacda94ace5 Reviewed-on: https://chromium-review.googlesource.com/985417 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#547040}
-
Sergey Ulanov authored
WebRunner will be used on Fuchsia to run web applications. Bug: 822474 Change-Id: I56b2fd4bf653bb2c77a013b3134f6dba8065289a Reviewed-on: https://chromium-review.googlesource.com/965255Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Ben Goodger <ben@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#547039}
-
Dave Schuyler authored
This CL adds a keyword_separator_view_. The suggestion view and keyword view were using the same separator (a hyphen character). The text was small and jumping between the views isn't seen per se, but I'm looking to simplify/detangle the code; and not sharing ui elements helps disconnect them. Bug: None Change-Id: I507f0e6475866722106d8dd85386ff7be6a76d68 Reviewed-on: https://chromium-review.googlesource.com/987053Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#547038}
-
Leonard Grey authored
This matches Cocoa behavior. Bug: 826838 Change-Id: I85e1325ecf1c025fe05c5967d00845cd2f56dea2 Reviewed-on: https://chromium-review.googlesource.com/986852 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547037}
-
Peter Mayo authored
Bug: 827209 Change-Id: I732d3fefd4096008a33604281a66e7fa846f702f Reviewed-on: https://chromium-review.googlesource.com/987013Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#547036}
-
David Bokan authored
Insets are used to resize the visual viewport of a renderer when the virtual keyboard appears, without resizing the widget geometry. For a <webview>, this plumbing was missing. This led to the virtual keyboard not allowing overscroll or scrolling focused input fields into view when the content is in a <webview>. Bug: 740223 Change-Id: I62837fb09ae7b3590c198643259daf407028d8b6 Reviewed-on: https://chromium-review.googlesource.com/985020 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#547035}
-
Michael Giuffrida authored
Some instructions I've used to build years-old versions of Chromium. Bug: None Change-Id: Id8951de8f6dcad1100ed34ee7f71e094b629333b Reviewed-on: https://chromium-review.googlesource.com/966978 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#547034}
-
Hiroki Nakagawa authored
As a preparation for enabling to establish WebSocket connections off the main thread, this CL reduces dependencies on Document in DocumentWebSocketChannel for making it thread-safe. Specifically, this replaces GetDocument() calls for the traces and the inspector with GetExecutionContext(). Bug: 825740 Change-Id: If2f4afd30c30453388de5e4e50ec7169025e8b4b Reviewed-on: https://chromium-review.googlesource.com/984754 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547033}
-
Illia Martyniuk authored
We can use more verbose page title instead of "DelegatedFrameHost" to pass to the SurfaceManager for debugging purposes. It is easier to track what FrameSink is associated with what Debug Label if these labels are page titles. Bug: 816802 Change-Id: If5aa98fc7e9225d2798f85ca21d6ab221c02514b Reviewed-on: https://chromium-review.googlesource.com/984172 Commit-Queue: Illia Martyniuk <illiam@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#547032}
-
Eugene But authored
Previously Download Manager used infobar background shadow and white view for the background. Now the background is image view with resizable image. The image is different for regular and compact user interface size. Bug: 823510 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idfd7528cdbe2c9903e3cf23428da27b655dc80ff Reviewed-on: https://chromium-review.googlesource.com/986720Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#547031}
-
Michael Thiessen authored
This CL fixes two issues that could cause a backgrounded webVR page to receive the displayactivate event and start webVR presentation while not visible. The first is an issue where the ContentViewCore could be focused while paused if the view hierarchy changes, switching Android view focus while the Activity is paused. The second is an issue where we the stored state to handle displayactivate on headset insertion wasn't getting cleared when launched by an intent rather than headset insertion. Bug: 826983 Change-Id: Ic3426f36261b3dcdd44ce7162dff4a9b00fbef39 Reviewed-on: https://chromium-review.googlesource.com/986465Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#547030}
-
- 29 Mar, 2018 27 commits
-
-
Peter K. Lee authored
Due to some other issues with properly getting SSOService object to pass to FeedbackKit, this CL adds a feature flag to use FeedbackKit V2 but disable passing of SSOService object. This will cause feedback reports to be filed as anonymous. Bug: 814587 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaa603b5c4344ce0d97596309b368d8cd410ad381 Reviewed-on: https://chromium-review.googlesource.com/986941 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#547029}
-
Kenichi Ishibashi authored
When getting a controller service worker, clients expect that the controller is running. This CL makes sure the controller is running when a client queries ControllerServiceWorker via ControllerServiceWorkerConnector. Note that there is another path to get ControllerServiceWorker, i.e., ServiceWorkerProviderHost::GetControllerServiceWorkerPtr(). This CL doesn't update it yet because we need to change it as an async method. A follow-up CL will update it. Bug: 797222 Change-Id: I9b3df8e87d4c184266083041de6a3e888efd9413 Reviewed-on: https://chromium-review.googlesource.com/981842 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#547028}
-
Zhenyao Mo authored
This is to unblock certain NVidia driver's glReadPixels calls in the sandboxed GPU process. Note that the needed file /dev/nvidiactl is already in the list for read/write. BUG=817400 TEST=manual R=tsepez@chromium.org Change-Id: I9074a8335a9c4df1487f5a288d5e284bbedf67c3 Reviewed-on: https://chromium-review.googlesource.com/965462Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#547027}
-
Mostyn Bramley-Moore authored
This is needed for icecc builds with the plugin, but should also work in non-icecc builds and be (slightly?) faster since we don't need to look at the filesystem. Bug: 583454 Change-Id: I2cd7db325a21ba2f61e20e0ff2d963cc36974c11 Reviewed-on: https://chromium-review.googlesource.com/970424Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#547026}
-
Nico Weber authored
In particular, if it runs on the main waterfall, it should also run on the tot bots. Adds app_shell_unittests, aura_unittests, chrome_elf_import_unittests, compositor_unittests, install_static_unittests, mini_installer_tests, wm_unittests. Don't run mini_installer_tests on the cross bot due to next_version_mini_installer.exe not yet working there. Bug: 827075,827082,799827 Change-Id: Iffe1cf0be5a95892988aab93feefecf2c5b48cbd Reviewed-on: https://chromium-review.googlesource.com/986679Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#547025}
-
danakj authored
This adds an interface SharedBitmapIdRegistrar which is implemented by TextureLayer, and given to the TextureLayerClient directly in PrepareTransferableResource(). The SharedBitmapIdRegistrar is given mappings from viz::SharedBitmapId to base::SharedMemory objects. This mapping is kept valid as the TextureLayer moves between trees, or if the LayerTreeFrameSink changes, until the returned SharedBitmapIdRegistration is destroyed/assigned to. In order to maintain the mapping, the base::SharedMemory ownership must be at least partly held inside the TextureLayer, so this introduces a lightweight thread-safe ref-counted wrapper around the base::SharedMemory called CrossThreadSharedBitmap, that is used to give ownership to the TextureLayer, as well as to keep ownership in the client until it is no longer using the SharedMemory and any pending ReleaseCallbacks have fired. This plumbs the new SharedBitmapIdRegistrar to all clients of TextureLayer, but most don't touch it, still using the SharedBitmapManager to create/map their SharedMemory+SharedBitmapIds. The one client this does convert is WebGL, in the DrawingBuffer class. The class now holds a cc::CrossThreadSharedBitmap and cc::SharedBitmapIdRegistration instead of the viz::SharedBitmap it held previously. R=kylechar@chromium.org Bug: 730660 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I25e2bc6b819fcab043faa3fc4949a89f5e078307 Reviewed-on: https://chromium-review.googlesource.com/976694 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547024}
-
mrefaat authored
Open Storekit when users visit itunes http urls. Bug: 623016 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I054144c712631c30ca0acecbcfa97ededd7950b2 Reviewed-on: https://chromium-review.googlesource.com/987116Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#547023}
-
Zhenyao Mo authored
Several ES3 commands do not handle that workaround at the moment. BUG=826509 TEST=gl_tests R=piman@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2d4e53fbf8c0d548b6de414073d5afa9ac58fd26 Reviewed-on: https://chromium-review.googlesource.com/985119 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547022}
-
Filip Gorski authored
Updates the build file to include resources for hostimpl. Feed sizing: Monochrome.apk_Dex +2 entries fields +5 entries methods +1 entries types +1 entries strings Monochrome.apk_Breakdown (+1,650 bytes) -227 bytes Zip Overhead +35 bytes Non-compiled Android resources size +29 bytes Package metadata size +233 bytes Java code size +1,580 bytes Compiled Android resources size Monochrome.apk_TransferSize +939 bytes Transfer size (deflate) Monochrome.apk_Specifics +2,042 bytes normalized apk size +392 bytes main dex size Monochrome.apk_InstallSize +1,650 bytes APK size +3,233.68000001 bytes Estimated installed size Monochrome.apk_Uncompressed (+392 bytes) +392 bytes Java code size Monochrome.apk_DexCache +36 bytes DexCache Monochrome.apk_InstallBreakdown (+3,460.68 bytes) +35 bytes Non-compiled Android resources size +29 bytes Package metadata size +1,816.68 bytes Java code size +1,580 bytes Compiled Android resources size Change-Id: I59eeaf0f0f8100b90cbdd1ddb6f57ccba77a577c Reviewed-on: https://chromium-review.googlesource.com/985971Reviewed-by:Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#547021}
-
Edward Lesmes authored
It should be luci.chromium.try, not master.tryserver.chromium.linux. R=nodir@chromium.org, iannucci@chromium.org, jbudorick@chromium.org Bug: 643346 Change-Id: I55ad4fad5238e1c2f1f6047cdc9b22131c7080e7 Reviewed-on: https://chromium-review.googlesource.com/986627Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#547020}
-
Christopher Cameron authored
Cut-and-paste methods for sending blink::WebMouseEvent and blink::WebMouseWheelEvent to the renderer, cut out of RWHVCocoa, and added to RWHVMac via the RWHNSViewClient interface. Bug: 821651 Change-Id: I659c9ae59d0c2e617e6bc0f895f938091dc13f5e Reviewed-on: https://chromium-review.googlesource.com/982943 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547019}
-
Joel Einbinder authored
When autocompleting css variables, sometimes the suggestbox would be hidden after typing a few characters. This patch simplifies the logic around when the suggest box should be shown. It changes applySuggestion to be called when the suggestion should be discarded. Change-Id: Iabbdcdcaec8f495220bae568fa51f2b4ad239e78 Reviewed-on: https://chromium-review.googlesource.com/981197 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#547018}
-
Klaus Weidner authored
In legacy ClientWait mode, we seem to get overlapping frames during presentation that unexpectedly trigger the "reuse acquired frame" path. This isn't compatible with the stricter sanity check from crrev.com/c/984714. Revert to the old behavior while investigating what's going on. Change-Id: Ic9ed38155291451fc0fb599dfcf3beea36830ad4 Reviewed-on: https://chromium-review.googlesource.com/986630Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#547017}
-
Veranika Liaukevich authored
Bug: 770749 Change-Id: Ia34fd204174a9ec61e232a7e967c46cd0e0c57ef Reviewed-on: https://chromium-review.googlesource.com/966894 Commit-Queue: Veranika Liaukevich <veranika@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#547016}
-
Esmael El-Moslimany authored
Bug: 820456 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I91afc303b1e5b5c03e12b7ccaef7a2d8fd49ef61 Reviewed-on: https://chromium-review.googlesource.com/982159 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#547015}
-
Chris Harrelson authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0c31205048b61fa3150761751b36d06130021a3b Reviewed-on: https://chromium-review.googlesource.com/986934 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547014}
-
Mohammad Refaat authored
This reverts commit d43b9609. Reason for revert: Re-enable the WKHTTPSystemCookieStore for M67 Original change's description: > Disable WKHTTPSystemCookieStore usage. > > This will be merged to M66 to disable it in release > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I333fcb47eda7c0c56cd1f01ba2a69f91d2650b25 > Reviewed-on: https://chromium-review.googlesource.com/986460 > Reviewed-by: Peter Lee <pkl@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546888} TBR=eugenebut@chromium.org,pkl@chromium.org,mrefaat@chromium.org Change-Id: I7fc647c062b9c0e2c7df3b02ce568d2634d9be81 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/986617Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#547013}
-
Mike Wittman authored
In some unwinds seen on recent OS X beta versions unw_init_local attempts to access memory past the end of the mapped libraries. This region appears to be protected or unmapped, resulting in crashes. Getting a fix for libunwind into an OS X release may take 18 months (if accepted at all). This workaround will avoid the crashes in the mean time. 57% of the Mac profiler crashes seen over the last five months were due to this bug. Bug: 774682 Change-Id: I260b03adea433f93871c7628eb38886aa877e549 Reviewed-on: https://chromium-review.googlesource.com/969830 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#547012}
-
Alex Newcomer authored
Let ShelfButton handle all ink drop manipulations instead of special casing for the Application Menu. TBD: Handle ink drop scaling up with the app icon. Bug: 823908 Change-Id: Ic80ca273fa331edf98c1078363ea5497a2845c1a Reviewed-on: https://chromium-review.googlesource.com/978855 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#547011}
-
bsheedy authored
Adds another invocation of chrome_public_test_vr_apk to the VR FYI bot, but with VrCore set to use the O2 render path. This only works on O MR1+ and has the potential to be less stable, so we only want it on the FYI bot for now. Change-Id: I4b528a240eb62d979b586511b223fcac79e66d7c Reviewed-on: https://chromium-review.googlesource.com/982528Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547010}
-
Koji Ishii authored
Following bot results are included. 4414 4419 4422 4423 4426 4427 4429 4435 4442 4444 4446 4450 4452 1 lines were removed and 12 lines were deflaked by consecutive results since 4375. 1 rebaseline is included by reviewing the failures in 4452. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I2f83d41a3f9b527c4ada84b442faa66ae96181c0 Reviewed-on: https://chromium-review.googlesource.com/983082 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547009}
-
David Bokan authored
Tickmarks are calculated based on Document-relative rects but turning on RLS made these rect Frame-relative since they're "absolute". This patch explicitly converts them to document coordinates. Bug: 826219 Change-Id: Id39f1b337f2bebe34587d79398879778ddb864cc Reviewed-on: https://chromium-review.googlesource.com/986715Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#547008}
-
Vladimir Levin authored
This patch ensures that we don't try to initiate a capture dump when the main window has been discarded. Specifically, we would enter a test_phase_ = CLEAN_UP in this case, and we should only be reporting results if we're in DURING_TEST phase. Bug: 826649, 826634 Change-Id: Id0a4892a29b1e9b6bf4adb4ca6196c86da8cd071 Reviewed-on: https://chromium-review.googlesource.com/986944Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547007}
-
Toni Barzic authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c873de4b9021..6eff8cb7641c $ git log c873de4b9..6eff8cb76 --date=short --no-merges --format='%ad %ae %s' 2018-03-27 darekm Add constants for CEC D-Bus service. 2018-02-22 claudiomagni Add learning example mojom for the ML Service. 2018-03-26 smbarber vm_concierge: generate go protos 2018-03-26 tbarzic Add EmitAshInitialized method to dbus constants 2018-03-07 derat system_api: Add CRAS output-active constants. 2018-03-26 jkardatzke Added D-Bus call to concierge for launching an application Created with: roll-dep src/third_party/cros_system_api Change-Id: Ie4e548441a01b33e46cc56bc7a3b28968ef6e0e5 Reviewed-on: https://chromium-review.googlesource.com/986879Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#547006}
-
Joshua Peraza authored
7bd613e55835 linux: prefix args with crashpad and build tools on android 246ecc6686f3 linux: disable libcurl when in chromium Bug: crashpad:30 Change-Id: I573b784b39f48d40ebbf70ac8efbc978ee86637b Reviewed-on: https://chromium-review.googlesource.com/984332 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#547005}
-
Kim Paulhamus authored
This change registers the Java implementation of authenticator.mojom behind a feature flag. The implementation currently returns "Not implemented" errors for both get() and create() calls. Bug: 678885 Change-Id: Ieebff9c70b1c227695b90ed0d045f96af1adf23d Reviewed-on: https://chromium-review.googlesource.com/927722 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#547004}
-
François Doray authored
This reverts commit b1d6f80a. Reason for revert: https://crbug.com/827392 Original change's description: > Add DevTools check to CrashKeys for crbug.com/824774. > > Record whether DevTools is currently active in CrashKeys. > > Bug: 824774 > Change-Id: I697bf892037c63216890d9d5f7ccc67e037f3b19 > Reviewed-on: https://chromium-review.googlesource.com/986453 > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546929} TBR=kenrb@chromium.org,wjmaclean@chromium.org Change-Id: Id3f8c9b4810facf9cb0b7f15ad6699c691f2042c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824774, 827392 Reviewed-on: https://chromium-review.googlesource.com/987172Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#547003}
-