- 17 May, 2019 40 commits
-
-
Jordan Bayles authored
This patch rolls openscreen to the latest HEAD. Change-Id: I9890293e3b2ed62a702bd0aa08a0615cf26798a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618022Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#661020}
-
Chris Hamilton authored
A further CL will decouple the existing observer implementations to use these directly, but there will be some small breaking logic changes to ShouldObserve/OnNodeAdded/OnBeforeNodeRemoved to handle on a case by case basis. BUG=910288 Change-Id: I3ac75aac01dd2b961926df46b2e0ba8b73c3f141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610987 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#661019}
-
James Lissiak authored
This is a follow up to bug discussion 960409: https://bugs.chromium.org/p/chromium/issues/detail?id=960409#c8 The patch adds the 'devtools://' url scheme to the list of internal schemes and adds a check to ensure that navigations to that scheme don't bounce out to external apps. Change-Id: Ibe9ab69a2bebc20e7636e65943dc67b426f0fea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615605Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: James Lissiak <jalissia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#661018}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/62ad1eeb0e6b..036cc9ae1244 git log 62ad1eeb0e6b..036cc9ae1244 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 sugoi@google.com Unnormalized texture coordinates Created with: gclient setdep -r src/third_party/swiftshader@036cc9ae1244 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I916448feebc044c8970d3eaee6c8999d6f53e2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661017}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6ea34ccba4c6..662a859f9bb3 git log 6ea34ccba4c6..662a859f9bb3 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 perezju@chromium.org [Telemetry] Close devtools client backend as best effort Created with: gclient setdep -r src/third_party/catapult@662a859f9bb3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:958778 TBR=simonhatch@google.com Change-Id: I1973aefcf13450280c03dd676c4af90f967804fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617399Reviewed-by:
-
Matthew Jones authored
This patch disables the location selection dialog and always shows the duplicate download infobar. Bug: 958473 Change-Id: Id1ace68e1636728097e7865e270f08a57fb8ab3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618009Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#661015}
-
David Benjamin authored
Bug: 699562 Change-Id: I9c818a0c0c490b2d32929a9867d5d3bebf6e8ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618016 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#661014}
-
Theresa authored
Introduce ChromeSupplier and use it to provide OverviewModeBehavior to the app menu and SystemUiCoordinator/NavigationBarColorController. The ChromeSupplier allows classes to register a callback to be notified when the wrapped dependency is available. BUG=956260, 960129 Change-Id: If1e363be247a237b45931b1727cb76f2a6ee694b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610205 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#661013}
-
Rouslan Solomakhin authored
Before this patch, Payment Request would always return false for canMakePayment() and hasEnrolledInstrument() and reject show() with NotSupportedError for websites with invalid certificates, even if the --ignore-certificate-errors flag was passed on the command line. This flag is used by web platform tests, which was unable to run some Payment Request tests. This patch checks for --ignore-certificate-errors flag the SSL validity checker for Payment Request. After this patch, web platform tests are able to run more of the Payment Request tests. Bug: 964472 Change-Id: I94be74cbaa973a37b5effc0d3925e18ca5a50f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618121Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661012}
-
Andrew Xu authored
In KeyboardController::NotifyKeyboardBoundsChanging, when keyboard window is null or invisible, |visual_bounds_in_root_| is reset and it changes the return value of GetWorkspaceOccludedBoundsInScreen. However we still use the old value returned by GetWorkspaceOccluded- BoundsInScreen before condition block as parameter. This CL fixes this issue. Bug: 960174 Change-Id: Iee95babce7a01328d90a1065b2da8f171ff7d844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618181 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661011}
-
Brian White authored
This reverts commit 3cf15f91. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak 08:51:48.392 3538 worker/2 external/wpt/wasm/webapi/body.any.html leaked 08:51:48.397 3431 [5197/7478] external/wpt/wasm/webapi/body.any.html failed unexpectedly (leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,22],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,3]})) 08:51:48.393 3538 worker/2 external/wpt/wasm/webapi/body.any.html failed: 08:51:48.393 3538 worker/2 leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,22],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,3]}) Since it appears WASM related and the V8 roll is in a pretty small set, this seems the most likely culprit. https://chromium.googlesource.com/chromium/src.git/+log/2b9db0045e4d669a0615c40215de3cfb95e729ea..0daa25d5051667136a263f627aa0a61703f26dd4 Original change's description: > Update V8 to version 7.6.206. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/c9178292..92b8322b > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Iac0d4b87103b6c56b70aad5f27f8a66405e62130 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617067 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#660835} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6ef39c00255ca2a86f9cddacc5ea4c5ec4122f8b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618163 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#661010}
-
Staphany Park authored
Change-Id: Ibc6258557227b34a56dc3a1b5e3239a375a86584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616947 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#661009}
-
Mehran Mahmoudi authored
This fixes an issue with key functions In-Product Help which caused it to show the incurrect view on quick changes in cursor visibility. Bug: 962683 Change-Id: Ibc86a91a877e42ceab69bbf133db07b8ff0f78d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617718Reviewed-by:
-
danakj authored
The use of Bind() is deprecated, replace with BindRepeating because this callback is called more than once, and make the type explicit as well in the receiver. This was discussed in "Should AuthCallback be a OnceCallback?" on blink-network-dev@chromium.org. R=mmenke@chromium.org Bug: 953861 Change-Id: Iaa4a155e767da077688a4a107d2f0d7bf37d6a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615835Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#661007}
-
Bruce Long authored
Fix for: Issue 963392: Regression:'Drop and Install' Message is seen when a bookmarked item is dragged in chrome://extension page. On initiating a bookmark drag, the UniformResourceLocatorW clipboard format is added to the data object, as well as a "virtual" .url file using CFSTR_FILEDESCRIPTORW/CFSTR_FILECONTENTS formats, which represents an internet shortcut intended to be dropped on the desktop. Before my introduction of virtual file support: https://chromium.googlesource.com/chromium/src/+/e524176b0fb387f1c3e509364cde09af045b8a91 a Chromium drop target ignored the virtual file content, but now it is recognized on drag enter and drop. The chrome:://extensions page "sees" the presence of file data and assumes the intent is to install an extension and thus displays the Drop to Install feedback--you see the same thing without my fix when dragging an arbitrary file in from the desktop into the extensions page. The least risky fix is to ignore virtual files if there is also url data present. Note you can't just check if the "chromium/x-bookmark-entries" custom format is present, since this bug also repros dragging the favicon or site info icon out of the address bar, and in that scenario "chromium/x-bookmark-entries" is not added. In my experimentation dragging items out of Outlook.exe, no url data is added to the data object, so this fix won't break the primary scenario addressed by my original change. Bug: 963392 Change-Id: I902cecedca49e1fc6f39cbf9a62de8895dfd0d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615962 Commit-Queue: Bruce Long <brlong@microsoft.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#661006}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fdbb15913346..e6f19dda56ee git log fdbb15913346..e6f19dda56ee --date=short --no-merges --format='%ad %ae %s' 2019-05-17 akeshet@chromium.org skylab: delete suite_id argument from AbortSkylabHWTests 2019-05-17 saklein@chromium.org PrepareBinhostUploads: Write the package index file with sudo Created with: gclient setdep -r src/third_party/chromite@e6f19dda56ee The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I4726ceb812f9b1e3338b98495f8cea9ab17ef642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617398Reviewed-by:
-
Lucas Furukawa Gadani authored
Bug: 962500 Change-Id: Ib5e275a7f31be3a7e24dfc7bf976b6e2866624fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614703 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#661004}
-
Ben Mason authored
Bug: 964451 Change-Id: I27f4a28ade2cee226c5a65b366d9aaeda503d0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618013Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#661003}
-
Mehran Mahmoudi authored
This addresses some comments from UX review on settings for touchless devices. More information on the bug. Bug: 962562,963515,961904 Change-Id: I6146f1dbddbb580748074ad201c82f267e5306ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613709 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#661002}
-
Tobias Sargeant authored
Fixes: 963456 Bug: 939312,963456 Change-Id: Ia3d040d396cfaffe1d8ca68fd51cda42beed7e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613985 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Anna Malova <amalova@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#661001}
-
rbpotter authored
This CL changes PrintPreviewHandler to obtain the sign in state from the identity service, and send this with initial settings. This will eventually allow Print Preview to set the initial cloudPrintState without querying the cloud print server. Bug: 961359 Change-Id: I4382801b7e9a474e3664966d1794e4f4d6b0a7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616329 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#661000}
-
Sky Malice authored
Bug: 956737 Change-Id: I0283330437fb75a973b92281c4237ba14b3a44ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614077Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#660999}
-
Xianzhu Wang authored
This uses the same mechanism used in https://chromium-review.googlesource.com/c/chromium/src/+/1612358 for LayoutInline. The new code favors LayoutNG for performance, to avoid back-and-forth flipping in some cases for LayoutNG and allow that for Legacy. Also fix an issue of unnecessary flipping for SVG text. Change-Id: I70dc61807d2284a3cdda1fd4733b7ab2bfdd00e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615680 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#660998}
-
Yutaka Hirano authored
It is used only once, so let's inline it. This change also removes std::function use which is currently banned. Bug: 963306 Change-Id: I532ceb3707196c0c21a3aed8ae8c154467cd5fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614648 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#660997}
-
Xiyuan Xia authored
Get rid of the following code path: AppListMenuModelAdapter::Delegate -> AppListControllerImpl (AppListViewDelegate) -> AppListClient -> ChromeAppListModelUpdater/ChromeSearchResult -> AppContextMenu (SimpleMenuModel::Delegate) It is no longer needed because SimpleMenuModel is passed directly to app list code and has AppContextMenu as its delegate to handle the menu. Bug: 958134 Change-Id: Ieee6ee26869ec6b14dc7ebced45c84064d60ac3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617907Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660996}
-
Mirko Bonadei authored
ABSL is trying to be -Wundef clean and sending a patch for these macros seems overkill. They are used inside a __APPLE__ block with this pattern: #if defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE #endif Bug: None Change-Id: I863d099dcc3a2588388afab24a61be89884b392b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612913Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#660995}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbaaf61f1d99..85e6c29b6f88 Created with: gclient setdep -r src-internal@85e6c29b6f88 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I607f49869d9f97495f4d330705a8ec0f54999d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618061Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660994}
-
Andrew Grieve authored
This allows it to be brotli-compressed, saving 560kb for both SystemWebview.apk and TrichromeWebview.apk. The Monochrome Webview Stub APK continues to use licenses as an asset. Moves WebViewApplication from glue/ -> apk/ and renames it to "WebViewApkApplication" in order to not conflict with not-yet-updated downstream glue/ code. Bug: 734846 Change-Id: Icb0655057eae4ef80117f59cb060c1f596abf646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612660Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#660993}
-
Denis Kuznetsov authored
BUG=b:129924393 Change-Id: I0f7cf9a05d2bd4e5e8cb01e467ccecb3d28d7e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614182 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#660992}
-
Chandani Shrestha authored
This change provides fixes for these issues: Problem: The content title was heading role Fix: Added heading role of level 1 Problem: Aria-label was missing in drop-downs Fix: Added aria-label in drop-downs Tested keyboard navigation - navigate up/down drop-down items using arrow keys - Checkbox is checked/unchecked using space bar - Tab into/out (no tab traps) Tested screen reader - reads checkbox label - reads items selected from the drop down list Bug: 963183 Change-Id: Iaab2dd37323427215f765b3d7bbef885861c210f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605506 Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d7e41546c030..1ca7ce3f76a5 git log d7e41546c030..1ca7ce3f76a5 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1ca7ce3f76a5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I641f6ef5b83c2c02f9a202af63ffa43326f66e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616958Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b45ee83cc7c0..f3fa60010e45 git log b45ee83cc7c0..f3fa60010e45 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 brianosman@google.com Implement postfix ++/--, and use the correct 1 for floats Created with: gclient setdep -r src/third_party/skia@f3fa60010e45 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Ic69b16d58ede72b1e013cffc4ff7aa9679e5a8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617396Reviewed-by:
-
John Delaney authored
Add a UKM event with metadata for each ad frame observed on a page load. Records overall performance statistics (bytes/cpu), as well as metadata such as whether the ad is cross origin, it's size, etc. This will greatly simplify the number of metrics we are recording as we will not need to split out all UMA by visible/non-visible/etc. These metrics will prevent the need for new UMA to address the impact of ad interventions. As a lot of this UKM duplicates existing UMA, so we will reuse the existing tests. Once these metrics are landed, duplicate UMA metrics can be removed on a case by case basis depending on usefulness/simplicity. Bug: 951480 Change-Id: I19c2a63f496fd84250e0318491da1753ca9d2771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562619Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Jacques Newman authored
This re-lands this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1535171 Which was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1610026 Original Change's description: > Refactor to handle ignored nodes that pass into the browser AX tree > > * Introduces the concept of "in the tree" vs "ignored" in Blink without > changing the actual behavior. No ignored nodes are sent to the browser > accessibility tree. > * Adds new function IsIgnoredPassThrough, for use when an object is > ignored, but should be passed through to the browser-side anyways. > This will be used to allow different types of ignored nodes to pass > through, instead of all at once. > * Refactors browser-side code to walk only the unignored tree. > > Bug: 651614 > > Change-Id: Idbd85949a8505f8a03a08e3e002bb893619d6757 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535171 > Commit-Queue: Jacques Newman <janewman@microsoft.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#659089} Change additional to original change: The original change caused a crash because GetUnignoredChildCount was called on a parent with dangling pointers in its children vector. This was previously acceptable as child_count only relied on the length of the vector, not its contents. This issue has been mitigated by caching the unignored child count, similar to how the unignored index in parent is cached. Bug: 651614 Change-Id: I90b09237862d17848113fb084b9b08b60e12999f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609590Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660987}
-
Brian White authored
This reverts commit 81046e57. Reason for revert: Mac ASAN tests are failing: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29?limit=200 This seems the most likely culprit between the last good and when the (very frequent) failures began. https://chromium.googlesource.com/chromium/src.git/+log/17f09d5d92fc142fae6863b6c0d8bae17355ab95..8dde0a59b1362fc7a19186ca686cd5c6960003f5 [33545:775:0516/215851.235197:ERROR:vt_video_encode_accelerator_mac.cc(517)] VTCompressionSessionCreate failed: -12908 [90mtracing_service_impl.cc:[0m [39mConfigured tracing, #sources:2, duration:0 ms, #buffers:1, total buffer size:12 KB, total sessions:1[0m [90mshared_memory_arbiter_im[0m [31mShared memory buffer overrun! Stalling[0m ... Original change's description: > Migrate blink::MediaStreamVideoSource to WTF::Bind > > This CL is the 3rd out of n CLs to convert modules/mediastream/ > away from base::Bind{Once,Repeating} to their respective Blink/WTF > counterparts. > > In this particular CL, a weak reference of MediaStreamVideoSource is > passed to VideoTrackAdapter ctor to avoid double-bind methods with > CrossThreadBind -> ConvertToBaseCallback -> CrossThreadBind. > > R=dgozman@chromium.org, guidou@chromium.org > CC=blink-reviews-vendor@chromium.org > > BUG=923394 > > Change-Id: Ibd75c5fef80bef1a4328c4abb007fb07efbcc095 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594114 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660725} TBR=haraken@chromium.org,hiroshige@chromium.org,guidou@chromium.org,tonikitoo@igalia.com,tzik@chromium.org Change-Id: I082573534da71adbb7b56a70d3b34ccd15272ba2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616857Reviewed-by:
-
Robert Sesek authored
Bug: 958976 Change-Id: I7fc2bcdb8f2fadeab82a88a8c9b5a66c5b1aca25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618041Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
-
Gayane Petrosyan authored
This reverts commit 1843462f. Reason for revert: Color calculation is too long and freezes the browser for 1-2sec. Original change's description: > [NTP] Calc and store custom background color V2. > > When user selects new custom background, use thumbnail from image > collections to fetche and calculate calculate the most frequent color on > the image. The calculated color is then stored in prefs with the rest of > the background info. > > Bug: 874325 > Change-Id: I5905b583f22174a491749543e922512e6b47caf0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612235 > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660899} TBR=gayane@chromium.org,kmilka@chromium.org,nicolaso@chromium.org Change-Id: Id7ce0fd7255fcacd7322777e32d914defd8003d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616855Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#660984}
-
Mehran Mahmoudi authored
This shows the progressbar that includes the current URL when the activity is resumed. Bug: 961404 Change-Id: I61bbc4ac02006c39b3e32d8615489bcc785719ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617646Reviewed-by:
-
James MacLean authored
This reverts commit fb42e13e. Reason for revert: MSAN test failing. Original change's description: > Refactor to remove RenderWidget::PageScaleFactorChanged(). > > This refactor moves the logic in RenderWidget::PageScaleFactorChanged() > to RenderWidget::SetPageScaleStateAndLimits(). This removes the need for > RenderViewImpl::PageScaleFactorChanged() to call GetWidget(). > > This is a re-land of > https://chromium-review.googlesource.com/c/chromium/src/+/1614080. > > TBR=dcheng@chromium.org > TBR=collinbaker@chromium.org > > Bug: 924336 > Change-Id: Id076ddc805c62069984181914f3722d4d081a3b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617064 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660834} TBR=dcheng@chromium.org,wjmaclean@chromium.org,collinbaker@chromium.org Change-Id: Ied08b30c3363b2cee0d3e01994b06e50835bb27d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616739Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#660982}
-
Yutaka Hirano authored
No one inherits it, so replace protected with private. Also make it a final class. Bug: None Change-Id: Icc7d927c711514f9a64d29290826ae3f824f33bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616876 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
-
