GitLab

BUG=451654

Review URL: https://codereview.chromium.org/873403004

Cr-Commit-Position: refs/heads/master@{#313186}

This separates out all the service worker specific code from the generic
connection handling. As well as exposing some API in content/public so
code outside of content/ can handle connections.

This is the first step in making it possible to have chrome extensions,
or other code outside of content/ be the endpoint of a connection.

This doesn't change any functionality, it just moves code around.

BUG=426458

Review URL: https://codereview.chromium.org/861373002

Cr-Commit-Position: refs/heads/master@{#313185}

As we addressed certain amount of the performance problem,
it's time to give it another try.

R=viettrungluu@chromium.org
BUG=377980

Review URL: https://codereview.chromium.org/857483004

Cr-Commit-Position: refs/heads/master@{#313184}

Fix a TODO I added a while back.  Instead of calling SetMinContentsScale
and SetTileGridSize directly, pass these as parameters to constructor of the
PicturePile.

Committed: https://crrev.com/6d1f2981f3204852a9189d0b6e7ad0b18659d68d
Cr-Commit-Position: refs/heads/master@{#309867}

Review URL: https://codereview.chromium.org/811953005

Cr-Commit-Position: refs/heads/master@{#313183}

Cherry-pick potential divide-by-zero fix
https://codereview.chromium.org/877783004

This includes remnants of an attempt to turn on AVX2. That failed and the
critical parts have been reverted. However, the attempt revealed some necessary
changes which have been kept for the next attempt. These constitute a no-op for
this particular roll.

Enable AVX2:
https://codereview.chromium.org/863143002

Fix GN build:
https://codereview.chromium.org/865893004
https://codereview.chromium.org/817293008
https://codereview.chromium.org/866273003

Fix cpu detection:
https://codereview.chromium.org/864393002

Disable AVX2:
https://codereview.chromium.org/880513003

R=tomfinegan@chromium.org
R=yaowu@chromium.org
BUG=396572

Review URL: https://codereview.chromium.org/883503002

Cr-Commit-Position: refs/heads/master@{#313182}

Gnubby was added a a Capbility in https://codereview.chromium.org/787033003,
but since it is not negotiated between host and client, that's not the right
way to make it configurable.

BUG=448131

Review URL: https://codereview.chromium.org/878573006

Cr-Commit-Position: refs/heads/master@{#313181}

The flags were disabled to suppress a build error in ffmpeg.
The error should be fixed now:
https://crrev.com/a458f95e5718918a70506be2a33ea3be55e59024

BUG=450771, 371125
TEST=emerge-mipsel-o32-generic chromeos-chrome
cbuildbot --remote mipsel-o32-generic-tot-chromium-pfq-informational

Review URL: https://codereview.chromium.org/878603005

Cr-Commit-Position: refs/heads/master@{#313180}

The idea of this change is to fire Win AX events
based on the AX tree changing, rather than based
on Blink firing the right event and mapping it to a
Win event.

Store the Win-specific AX attributes (ia role,
ia state, name, value, etc.) in a struct, and when a
node is updated, compare the old value of each attribute
to the new value and fire an appropriate event for each
one (name changed, state changed, etc.).

Handle hypertext_ similarly, and properly diff the old and new hypertext in get_oldText and get_newText.

This enables all of the "event" tests that were
previously added to pass now, and it makes live regions
work correctly in NVDA and JAWS.

BUG=447962

Committed: https://crrev.com/eb691a960bef3c2aefa38627baa7cbdde480b81e
Cr-Commit-Position: refs/heads/master@{#313052}

Review URL: https://codereview.chromium.org/848653002

Cr-Commit-Position: refs/heads/master@{#313179}

Also removes some now unreachable code following the BoringSSL roll.

Review URL: https://codereview.chromium.org/877783005

Cr-Commit-Position: refs/heads/master@{#313178}

For in-process gpu, the CommandLine of the current process is a shared
resource and cannot be safely manipulated on the IO thread.

This moves inserting the gpu command line switches to the UI thread, and
slightly start up. Although still need additional fixes to start up code
to ensure it's safe to manipulate it on UI thread.

This also fixes the bug of inserting gpu switches when GpuProcessHost is
not used, for example in android webview.

BUG=450396

Review URL: https://codereview.chromium.org/865063002

Cr-Commit-Position: refs/heads/master@{#313177}

Python 2.7.9 adds an additional parameter to the HTTPSHandler.do_open function.
This function is overriden in fancy_urllib and called externally. This causes
the SDK updater to fail with a Python traceback. This CL fixes the calling
signature of the overriden do_open function.

BUG=452137
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/874393004

Cr-Commit-Position: refs/heads/master@{#313176}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9994197..02cd199

TBR=pilgrim@chromium.org,timloh@chromium.org

Review URL: https://codereview.chromium.org/877553004

Cr-Commit-Position: refs/heads/master@{#313175}

Avoid JNI string translation for each histogrom update routed through
RecordHistogram by caching the histogram lookup. Use the Java string
handle as the key.

BUG=442300

Review URL: https://codereview.chromium.org/867063006

Cr-Commit-Position: refs/heads/master@{#313174}

Some tests are failing on Snow because cryptohome doesn't unmount in time.
Attempting to increase this timeout to alleviate the issue.
We can revert this patch if it doesn't help.

BUG=449746
TEST=various telemetry-based autotests on Snow

Review URL: https://codereview.chromium.org/871923007

Cr-Commit-Position: refs/heads/master@{#313173}

BUG=

Review URL: https://codereview.chromium.org/865203004

Cr-Commit-Position: refs/heads/master@{#313172}

Revert of Fix for the font files being maped multiple times (Fontconfig). (patchset #4 id:60001 of https://codereview.chromium.org/697383002/)

BUG=452227

Reason for revert:
Suspected for breaking security_OpenFDs on cros (http://crbug.com/452227):

01/26 13:31:23.658 ERROR|security_O:0147| Found unexpected fds in chrome type=renderer: set(['0500 /usr/share/fonts/croscore/Tinos-Regular.ttf', '0500 /usr/share/fonts/noto/NotoSans-Regular.ttc', '0500 /usr/share/fonts/noto/NotoSans-Bold.ttc'])
01/26 13:31:23.658 DEBUG|security_O:0138| Found pid 8280 for chrome
01/26 13:31:23.660 ERROR|security_O:0147| Found unexpected fds in chrome type=renderer: set(['0500 /usr/share/fonts/noto/NotoSans-Regular.ttc'])

Original issue's description:
> Fix for font files being mmaped multiple times (Fontconfig).
>
> Before this change, when there were a lot of font fallbacks happening on
> the web site, the fallback font was mmaped multiple times, reaching up to
> 200 times in the TC url: http://jsfiddle.net/p5pe81vs/, leading to OOMs
> and crashes for renderer process.
>
> This happens after the change introduced in
> https://codereview.chromium.org/307243002
>
> This CL keeps track of the mmaps for each font ID to avoid any further
> unnecessary IPC requests and mmaps for future requests of the same font
> ID that would result in new FD.
>
> BUG=430021
>
> NOPRESUBMIT=true
> brettw indicates this use of ScopedAllowIO is acceptable.
> Previous code eluded IO checks, this change makes the IO use find-able.
>
> Committed: https://crrev.com/78db5e535ef48c596223fe272572e5679fbb44fd
> Cr-Commit-Position: refs/heads/master@{#313102}

TBR=behdad@google.com,brettw@chromium.org,bungeman@chromium.org,derat@chromium.org,dominik.rottsches@intel.com,eae@chromium.org,jln@chromium.org,reed@chromium.org,jam@chromium.org,jochen@chromium.org,kolczyk@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=430021

Review URL: https://codereview.chromium.org/873213003

Cr-Commit-Position: refs/heads/master@{#313171}

Additional suppression for http://crrev.com/776673002.

BUG=452219
TBR=senorblanco@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/876183002

Cr-Commit-Position: refs/heads/master@{#313170}

BUG=405270

Review URL: https://codereview.chromium.org/816353011

Cr-Commit-Position: refs/heads/master@{#313169}

Revert of Instrumenting opening password database to find jank (patchset #1 id:1 of https://codereview.chromium.org/807263003/)

Reason for revert:
Undoing profiler instrumentations since the jank is fixed.

Original issue's description:
> Instrumenting opening password database to find jank.
>
> This database opening happens in UI thread. Checking what jankiness this causes.
>
> Background: one of jankiness investigations (crbug.com/426272) came to a conclusion that the jank is actually caused by this issue. Instrumenting to get the numbers.
>
> BUG=138903
>
> Committed: https://crrev.com/42466460ec1a5c0f2953d13e57d0d290cb38ca21
> Cr-Commit-Position: refs/heads/master@{#308702}

TBR=isherman@chromium.org
BUG=138903

Review URL: https://codereview.chromium.org/878763002

Cr-Commit-Position: refs/heads/master@{#313168}

The existing code would render the separate surface render pass in source
space, rather than in target space, which means it would render small,
apply the filter, then scale up to target space, which caused scaling
artifacts.

I've updated the surface transforms to respect combined_transform_scales,
which are the x and y axis lengths of combined_transform.

I've also written a test that demonstrates the issue, and is fixed by
this cl.

BUG=411079

Review URL: https://codereview.chromium.org/846453005

Cr-Commit-Position: refs/heads/master@{#313167}

R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/875983006

Cr-Commit-Position: refs/heads/master@{#313166}

Depends on https://codereview.chromium.org/869003003/

BUG=451286
TBR=sgurun@chromium.org

Review URL: https://codereview.chromium.org/873583007

Cr-Commit-Position: refs/heads/master@{#313165}

The option is now 'open as window', before it was 'open as tab'.

The default has also been changed so by default the checkbox is unchecked (and the bookmark app will open as a tab).

BUG=450102

Review URL: https://codereview.chromium.org/869483003

Cr-Commit-Position: refs/heads/master@{#313164}

- Makes components_browsertests swarmable.
- Adds components_browsertests to the main waterfall for linux, mac and
  win bots.
- Updates the chromium tryserver to run components_browsertests as
  swarmable.
- Add content_shell as a dependency for components_browsertests for
  Mac, which is needed for the Content Shell helper on that platform.

The original CL did not add content_shell as a dependency for
components_browsertests, which made the build step for the isolate flaky
dependent upon whether content_shell happened to have already been built.

BUG=311270

Original CL:
Review: https://codereview.chromium.org/863023003/
Committed: https://crrev.com/7a3df3b7171fa87f556d22803fdc02a67e975865
Cr-Commit-Position: refs/heads/master@{#312886}

Revert CL:
https://codereview.chromium.org/856323003/
Committed: https://crrev.com/27ac8082963904942aaebcbf85620ae6e27ad5c9
Cr-Commit-Position: refs/heads/master@{#312976}

Review URL: https://codereview.chromium.org/874843002

Cr-Commit-Position: refs/heads/master@{#313163}

Invert the logic now that unprefixed EME APIs are enabled by default.

BUG=394918
TEST=Encrypted Media browser tests pass.

Review URL: https://codereview.chromium.org/865793003

Cr-Commit-Position: refs/heads/master@{#313162}

Currently, unrecoverable exception raised during a user story run does not
create a failure value for that user story. This leads to confusing log output
by gtest_progress_reporter.

This patch fixes this by catching unrecoverable exception and add failure value
to the currently user story value. This patch also improve unittest in
user_story_runner_unittest to make sure that the stdout output captures the
raise exceptions.

BUG=448827

Review URL: https://codereview.chromium.org/875993002

Cr-Commit-Position: refs/heads/master@{#313161}

BUG=None

Review URL: https://codereview.chromium.org/876863002

Cr-Commit-Position: refs/heads/master@{#313160}

Split FullscreenController to MouseController (and leave fullscreen related parts in original class). ExclusiveAccessManager is responsible for coordinating the different exclusive access controllers.

BUG=166928
TEST=Requires MANUAL testing of fullscreen and pointer/mouse lock is required as tests are disabled for being flaky

Review URL: https://codereview.chromium.org/836933005

Cr-Commit-Position: refs/heads/master@{#313159}

It's accessed concurrently on the render thread and the media thread internally and externally.

BUG=452093
TEST=none

Review URL: https://codereview.chromium.org/879483004

Cr-Commit-Position: refs/heads/master@{#313158}

This is another preparation for crbug.com/448190.
This change encapsulates a platform file as a MessageAttachment
abstract class and its subclass called PlatformFileAttachment.
This abstraction allows MessageAttachmentSet to contain not only
platform files, but also a mojo MessagePipes, which will be
encapsulated by another MessageAttachment subclass.

BUG=448190
R=agl@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/856443003

Cr-Commit-Position: refs/heads/master@{#313157}

BUG=450703
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/866403006

Cr-Commit-Position: refs/heads/master@{#313156}

Currently they don't get displayed at all!

BUG=450232
TBR=sammc@chromium.org

Review URL: https://codereview.chromium.org/867123002

Cr-Commit-Position: refs/heads/master@{#313155}

Rebaselined in Blink.

BUG=449873
TBR=reed@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/872183003

Cr-Commit-Position: refs/heads/master@{#313154}

The bypass smoke test uses an existing browser session, where the favicon requewst has already been made and completed through the data saver proxy.  When the favicon is requested again during the bypass test, it will still appear to come through the proxy causing the case to fail.  If instead we use a fresh browser session, bypass works as expected for the favicon.

In general, it's good practice to make tests as atomic as possible, so this should be better design for the smoke tests (although it adds ~12 seconds to the total execution time).

BUG=452161

Review URL: https://codereview.chromium.org/862803004

Cr-Commit-Position: refs/heads/master@{#313153}

BUG=450337

Review URL: https://codereview.chromium.org/877763003

Cr-Commit-Position: refs/heads/master@{#313152}

BUG=chromium:268984
TEST=All tests pass in SessionRestoreBrowserTest and
BetterSessionRestoreBrowserTest
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/871013006

Cr-Commit-Position: refs/heads/master@{#313151}

DeviceDescription::id is set from "gcd_id" value.
DeviceDescription::type is set from "class" value.

Removed some unused values.

BUG=449864

Review URL: https://codereview.chromium.org/861523002

Cr-Commit-Position: refs/heads/master@{#313150}

BUG=452219
TBR=senorblanco@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/875203002

Cr-Commit-Position: refs/heads/master@{#313149}

Review URL: https://codereview.chromium.org/845693004

Cr-Commit-Position: refs/heads/master@{#313148}

net: add a number of .gov HSTS entries.
Cr-Commit-Position: refs/heads/master@{#313147}